mirrors/flexisip-account-manager
1
0
Fork 0
mirror of https://gitlab.linphone.org/BC/public/flexisip-account-manager.git synced 2026-01-17 01:58:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix FLEXIAPI-268 Allow pn-param in Apple format for the push notifications endpoints

Browse source
This commit is contained in:
Timothée Jaussoin 2025-02-13 10:18:03 +01:00
parent 63c1c404a6
commit 2bf8db6bd1
3 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -17,6 +17,7 @@ v1.7
- Fix FLEXIAPI-262 Bypass the JWT auth if we have an API Key
- Fix FLEXIAPI-264 Add -k|api_key_ip parameter to accounts:create-admin-account to set/clear the related API Key restriction
- Fix FLEXIAPI-256 Publish an empty string while deleting a device on Redis to force the refresh on the other clients
- Fix FLEXIAPI-268 Allow pn-param in Apple format for the push notifications endpoints
v1.6
----

4
flexiapi/app/Rules/PnParam.php
View file

@ -9,11 +9,11 @@ class PnParam implements Rule
{
public function passes($attribute, $value)
{
return $value == null || Validator::regex('/^\w+$/')->validate($value);
return $value == null || Validator::regex('/^[\w\.]+$/')->validate($value);
}
public function message()
{
return 'The :attribute should be null or contain only alphanumeric and underscore characters';
return 'The :attribute should be null or contain only alphanumeric, dots and underscore characters';
}
}

18
flexiapi/tests/Feature/ApiPushNotificationTest.php
View file

@ -67,5 +67,23 @@ class ApiPushNotificationTest extends TestCase
'type' => $this->type,
'call_id' => 'call_id-123'
])->assertStatus(503);
$this->keyAuthenticated($account)
->json($this->method, $this->tokenRoute, [
'pn_provider' => $this->pnProvider,
'pn_param' => 'ABCD1234.org.linphone.phone.voip',
'pn_prid' => $this->pnPrid,
'type' => $this->type,
'call_id' => 'call_id-123'
])->assertStatus(503);
$this->keyAuthenticated($account)
->json($this->method, $this->tokenRoute, [
'pn_provider' => $this->pnProvider,
'pn_param' => '@blabla@',
'pn_prid' => $this->pnPrid,
'type' => $this->type,
'call_id' => 'call_id-123'
])->assertJsonValidationErrors(['pn_param']);
}
}