Fix FLEXIAPI-174 Check if the phone is valid before trying to recover it (deprecated endpoint)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 v1.5
 ----
+- Fix FLEXIAPI-174 Check if the phone is valid before trying to recover it (deprecated endpoint)
 - Fix FLEXIAPI-173 Wrong route in validateEmail (deprecated)
 - Fix FLEXIAPI-171 Fix README documentation for CreateAdminAccount
 - Fix FLEXIAPI-170 Fix undefined variable apiKey in CreateAdminAccount

flexiapi/app/Http/Controllers/Api/Account/AccountController.php

@@ -187,7 +187,7 @@ class AccountController extends Controller
 
         $request->validate([
             'phone' => [
-                'required', new WithoutSpaces, 'starts_with:+'
+                'required', new WithoutSpaces, 'starts_with:+', 'exists:accounts,phone'
             ],
             'account_creation_token' => [
                 'required',

flexiapi/tests/Feature/ApiAccountTest.php

@@ -746,6 +746,12 @@ class ApiAccountTest extends TestCase
 
         $token = AccountCreationToken::factory()->create();
 
+        // Wrong phone
+        $this->json($this->method, $this->route . '/recover-by-phone', [
+            'phone' => '+331234', // wrong phone number
+            'account_creation_token' => $token->token
+        ])->assertJsonValidationErrors(['phone']);
+
         $this->json($this->method, $this->route . '/recover-by-phone', [
             'phone' => $phone,
             'account_creation_token' => $token->token