Fix FLEXIAPI-242 Add stricter validation for the AccountCreationToken Push Notification endpoint

.gitlab-ci-files/deploy.yml

@@ -1,7 +1,7 @@
 rocky8-deploy:
   extends: .deploy
   script:
-    - ./deploy_packages.sh rockylinux 8
+    - ./deploy_packages.sh rockylinux
   needs:
     - rocky8-package
     - rocky8-test
@@ -9,18 +9,18 @@ rocky8-deploy:
 rocky9-deploy:
   extends: .deploy
   script:
-    - ./deploy_packages.sh rockylinux 9
+    - ./deploy_packages.sh rockylinux
   needs:
     - rocky9-package
     - rocky9-test
 
-rocky10-deploy:
-  extends: .deploy
-  script:
-    - ./deploy_packages.sh rockylinux 10
-  needs:
-    - rocky10-package
-    - rocky10-test
+#debian11-deploy:
+#  extends: .deploy
+#  script:
+#    - ./deploy_packages.sh debian bullseye
+#  needs:
+#    - debian11-package
+#    - debian11-test
 
 debian12-deploy:
   extends: .deploy
@@ -30,30 +30,20 @@ debian12-deploy:
     - debian12-package
     - debian12-test
 
-debian13-deploy:
-  extends: .deploy
-  script:
-    - ./deploy_packages.sh debian trixie
-  needs:
-    - debian13-package
-    - debian13-test
-
 remi-rocky8-deploy:
   extends: .deploy
-  #rules:
-    #- changes:
-    #  - .gitlab-ci.yml
   script:
-    - ./deploy_packages.sh rockylinux 8
+    - ./deploy_packages.sh rockylinux
   needs:
     - remi-rocky8-package
+    - remi-rocky8-test
 
 .deploy:
   stage: deploy
   tags: ["docker"]
-  rules:
-    - if: $CI_COMMIT_REF_NAME == "master"
-    - if: $CI_COMMIT_REF_NAME =~ /^release/
+  only:
+    - master
+    - /^release/.*$/
 
   before_script:
     - rm -f $CI_PROJECT_DIR/build/*devel*.rpm # Remove devel packages

.gitlab-ci-files/package.yml

@@ -1,84 +1,62 @@
 rocky8-package:
-  needs:
-    - prepare-package
   extends: .package
   image: gitlab.linphone.org:4567/bc/public/docker/rocky8-php:$ROCKY_8_IMAGE_VERSION
   script:
-    - make package-el8
+    # We install this dependency only for the pipeline
+    - dnf -y install https://rpms.remirepo.net/enterprise/remi-release-8.rpm
+    - dnf -y module reset php
+    - dnf -y module enable php:remi-8.0
+    - dnf -y update php\*
+    - dnf -y install php-sodium
+    - make rpm-el8
 
 rocky9-package:
-  needs:
-    - prepare-package
   extends: .package
   image: gitlab.linphone.org:4567/bc/public/docker/rocky9-php:$ROCKY_9_IMAGE_VERSION
   script:
-    - make package-el9
+    - make rpm-el9
 
-rocky10-package:
-  needs:
-    - prepare-package
-  extends: .package
-  image: gitlab.linphone.org:4567/bc/public/docker/rocky10-php:$ROCKY_10_IMAGE_VERSION
-  script:
-    - make package-el10
+#debian11-package:
+#  extends: .debian_package
+#  image: gitlab.linphone.org:4567/bc/public/docker/debian11-php:$DEBIAN_11_IMAGE_VERSION
 
 debian12-package:
-  needs:
-    - prepare-package
   extends: .debian_package
   image: gitlab.linphone.org:4567/bc/public/docker/debian12-php:$DEBIAN_12_IMAGE_VERSION
 
-debian13-package:
-  needs:
-    - prepare-package
-  extends: .debian_package
-  image: gitlab.linphone.org:4567/bc/public/docker/debian13-php:$DEBIAN_13_IMAGE_VERSION
-
 .debian_package:
   extends: .package
   script:
-    - make package-deb
+    - make deb
 
 remi-rocky8-package:
   image: gitlab.linphone.org:4567/bc/public/docker/rocky8-php:$ROCKY_8_IMAGE_VERSION
-  extends: .remi-rocky-package
-  variables:
-    ROCKY_RELEASE: 8
-  before_script:
-    - dnf -y module reset redis
-    - dnf -y install @redis:6
-
-.remi-rocky-package:
   extends: .package
-  rules:
-    - if: $CI_COMMIT_REF_NAME =~ /^release/ || $CI_COMMIT_REF_NAME == "master"
-    #- changes:
-    #  - .gitlab-ci.yml
   script:
-    # Remi
     - mkdir -p $CI_PROJECT_DIR/build
-    - dnf -y install https://rpms.remirepo.net/enterprise/remi-release-$ROCKY_RELEASE.rpm
+    - dnf -y install https://rpms.remirepo.net/enterprise/remi-release-8.rpm
     - yum -y install wget php-devel gcc liblzf php-pear lz4-devel liblzf-devel libzstd-devel php-pecl-apcu-devel
     # igbinary
     - wget https://rpms.remirepo.net/SRPMS/$PHP_IGBINARY_REMI_VERSION.remi.src.rpm
     - rpmbuild --rebuild $PHP_IGBINARY_REMI_VERSION.remi.src.rpm
     - rm /root/rpmbuild/RPMS/*/*debug*.rpm
-    - mv /root/rpmbuild/RPMS/*/*devel*.rpm $CI_PROJECT_DIR/build/$PHP_IGBINARY_REMI_VERSION-devel.el$ROCKY_RELEASE.x86_64.rpm || true # Rename to fit our naming format
-    - mv /root/rpmbuild/RPMS/*/*.rpm $CI_PROJECT_DIR/build/$PHP_IGBINARY_REMI_VERSION.el$ROCKY_RELEASE.x86_64.rpm # Rename to fit our naming format
+    - mv /root/rpmbuild/RPMS/*/*devel*.rpm $CI_PROJECT_DIR/build/$PHP_IGBINARY_REMI_VERSION-devel.el8.x86_64.rpm || true # Rename to fit our naming format
+    - mv /root/rpmbuild/RPMS/*/*.rpm $CI_PROJECT_DIR/build/$PHP_IGBINARY_REMI_VERSION.el8.x86_64.rpm # Rename to fit our naming format
     # msgpack
     - wget https://rpms.remirepo.net/SRPMS/$PHP_MSGPACK_REMI_VERSION.remi.src.rpm
     - rpmbuild --rebuild $PHP_MSGPACK_REMI_VERSION.remi.src.rpm
     - rm /root/rpmbuild/RPMS/*/*debug*.rpm
-    - mv /root/rpmbuild/RPMS/*/*devel*.rpm $CI_PROJECT_DIR/build/$PHP_MSGPACK_REMI_VERSION-devel.el$ROCKY_RELEASE.x86_64.rpm || true
-    - mv /root/rpmbuild/RPMS/*/*.rpm $CI_PROJECT_DIR/build/$PHP_MSGPACK_REMI_VERSION.el$ROCKY_RELEASE.x86_64.rpm
+    - mv /root/rpmbuild/RPMS/*/*devel*.rpm $CI_PROJECT_DIR/build/$PHP_MSGPACK_REMI_VERSION-devel.el8.x86_64.rpm || true
+    - mv /root/rpmbuild/RPMS/*/*.rpm $CI_PROJECT_DIR/build/$PHP_MSGPACK_REMI_VERSION.el8.x86_64.rpm
     # install and cleanup the dependencies
     - yum -y localinstall build/*.rpm
+    - rm build/*.rpm
     # phpredis
     - wget https://rpms.remirepo.net/SRPMS/$PHP_REDIS_REMI_VERSION.remi.src.rpm
     - rpmbuild --rebuild $PHP_REDIS_REMI_VERSION.remi.src.rpm
     - rm /root/rpmbuild/RPMS/*/*debug*.rpm
-    - mv /root/rpmbuild/RPMS/*/*devel*.rpm $CI_PROJECT_DIR/build/$PHP_REDIS_REMI_VERSION-devel.el$ROCKY_RELEASE.x86_64.rpm || true
-    - mv /root/rpmbuild/RPMS/*/*.rpm $CI_PROJECT_DIR/build/$PHP_REDIS_REMI_VERSION.el$ROCKY_RELEASE.x86_64.rpm
+    - mv /root/rpmbuild/RPMS/*/*devel*.rpm $CI_PROJECT_DIR/build/$PHP_REDIS_REMI_VERSION-devel.el8.x86_64.rpm || true
+    - mv /root/rpmbuild/RPMS/*/*.rpm $CI_PROJECT_DIR/build/$PHP_REDIS_REMI_VERSION.el8.x86_64.rpm
 
     - rm -r /root/rpmbuild # Cleanup
 
@@ -91,13 +69,7 @@ remi-rocky8-package:
       - build/*
     when: always
     expire_in: 1 day
-
-  variables:
-    COMPOSER_CACHE_DIR: $CI_PROJECT_DIR/.composer/cache
-    COMPOSER_ALLOW_SUPERUSER: 1
-
   cache:
     key: ${CI_COMMIT_REF_SLUG}
     paths:
       - flexiapi/vendor/
-      - .composer/cache

.gitlab-ci-files/prepare-package.yml

@@ -1,11 +0,0 @@
-prepare-package:
-  tags: ["docker"]
-  stage: prepare-package
-  image: gitlab.linphone.org:4567/bc/public/docker/debian12-php:$DEBIAN_12_IMAGE_VERSION
-  script:
-    - make prepare-common
-  artifacts:
-    paths:
-      - rpmbuild/*
-    when: always
-    expire_in: 1 day

.gitlab-ci-files/test.yml

@@ -10,47 +10,49 @@ rocky9-test:
   needs:
     - rocky9-package
 
-rocky10-test:
-  extends: .rocky-test
-  image: gitlab.linphone.org:4567/bc/public/docker/rocky10-php:$ROCKY_10_IMAGE_VERSION
-  needs:
-    - rocky10-package
-
 .rocky-test:
   extends: .test
   script:
     - yum -y localinstall build/*.rpm
     - cd /opt/belledonne-communications/share/flexisip-account-manager/flexiapi
-    - composer install --ignore-platform-req=ext-sodium # Rocky 8 and 9 use the external library
+    - composer install --ignore-platform-req=ext-sodium # Rocky 8 use the external library
     - vendor/bin/phpcs
     - vendor/bin/phpmd . ansi phpmd.xml
     - php artisan key:generate
     - vendor/bin/phpunit --log-junit $CI_PROJECT_DIR/flexiapi_phpunit.log
 
+#debian11-test:
+#  extends: .debian-test
+#  image: gitlab.linphone.org:4567/bc/public/docker/debian11-php:$DEBIAN_11_IMAGE_VERSION
+#  needs:
+#    - debian11-package
+
 debian12-test:
   extends: .debian-test
   image: gitlab.linphone.org:4567/bc/public/docker/debian12-php:$DEBIAN_12_IMAGE_VERSION
   needs:
     - debian12-package
 
-debian13-test:
-  extends: .debian-test
-  image: gitlab.linphone.org:4567/bc/public/docker/debian13-php:$DEBIAN_13_IMAGE_VERSION
-  needs:
-    - debian13-package
-
 .debian-test:
   extends: .test
   script:
-    #- apt update
+    - apt update
     - apt install -y ./build/*.deb
     - cd /opt/belledonne-communications/share/flexisip-account-manager/flexiapi
-    - composer install
+    - composer install --dev
     - vendor/bin/phpcs
     - vendor/bin/phpmd . ansi phpmd.xml
     - php artisan key:generate
     - vendor/bin/phpunit --log-junit $CI_PROJECT_DIR/flexiapi_phpunit.log
 
+remi-rocky8-test:
+  extends: .test
+  image: gitlab.linphone.org:4567/bc/public/docker/rocky8-php:$ROCKY_8_IMAGE_VERSION
+  needs:
+    - remi-rocky8-package
+  script:
+    - yum -y localinstall build/*.rpm
+
 mysql-latest-test:
   extends: .test
   image: gitlab.linphone.org:4567/bc/public/docker/debian12-php:$DEBIAN_12_IMAGE_VERSION

.gitlab-ci.yml

@@ -1,21 +1,18 @@
 variables:
-  ROCKY_8_IMAGE_VERSION: 20250702_171834_update_rocky8_dockerhub
-  ROCKY_9_IMAGE_VERSION: 20250702_171314_update_rocky9_dockerhub
-  ROCKY_10_IMAGE_VERSION: 20250908_164454_rocky10_first
-  DEBIAN_12_IMAGE_VERSION: 20250908_154742_refresh_dependencies
-  DEBIAN_13_IMAGE_VERSION: 20251204_115628_update_packages
-  PHP_REDIS_REMI_VERSION: php-pecl-redis6-6.1.0-1
-  PHP_IGBINARY_REMI_VERSION: php-pecl-igbinary-3.2.16-2
-  PHP_MSGPACK_REMI_VERSION: php-pecl-msgpack-2.2.0-3
+  ROCKY_8_IMAGE_VERSION: 20230330_163028_remove_remi
+  ROCKY_9_IMAGE_VERSION: 20240314_163316_add_php_sodium
+  DEBIAN_11_IMAGE_VERSION: 20240221_140459_package_upgrade_02_24
+  DEBIAN_12_IMAGE_VERSION: 20230925_143235_enable_debian12_packaging
+  PHP_REDIS_REMI_VERSION: php-pecl-redis5-5.3.6-1
+  PHP_IGBINARY_REMI_VERSION: php-pecl-igbinary-3.2.14-1
+  PHP_MSGPACK_REMI_VERSION: php-pecl-msgpack-2.2.0-1
 
 include:
-  - '.gitlab-ci-files/prepare-package.yml'
   - '.gitlab-ci-files/package.yml'
   - '.gitlab-ci-files/test.yml'
   - '.gitlab-ci-files/deploy.yml'
 
 stages:
-  - prepare-package
   - package
   - test
   - deploy

CHANGELOG.md

@@ -1,157 +1,147 @@
-# Releases
+# Flexisip Account Manager Changelog
 
-All notable changes to this project will be documented in this file.
+v1.5
+---
+- Fix FLEXIAPI-202 Add account parameter to the redirection in the destroy admin route
+- Fix FLEXIAPI-195 Fix LiblinphoneTesterAccoutSeeder to fit with the latest Account related changes
+- Fix FLEXIAPI-193 Typo
+- Fix FLEXIAPI-192 Clear and upgrade properly the account dictionary entries if the entries are already existing
+- Fix FLEXIAPI-191 Add quotes for the pn-prid parameter in FlexisipPusherConnector
+- Fix FLEXIAPI-186 Ensure that empty objects are serialized in JSON as objects and not empty arrays
+- Fix FLEXIAPI-185 Return null if the account dictionary is empty in the API
+- Fix FLEXIAPI-184 Append phone_change_code and email_change_code to the admin /accounts/<id> endpoint if they are available
+- Fix FLEXIAPI-183 Complete the account hooks on the dictionnary actions
+- Fix FLEXIAPI-182 Replace APP_SUPER_ADMINS_SIP_DOMAINS with a proper sip_domains table, API endpoints, UI panels, console command, tests and documentation
+- Fix FLEXIAPI-181 Replace APP_ADMINS_MANAGE_MULTI_DOMAINS with APP_SUPER_ADMINS_SIP_DOMAINS
+- Fix FLEXIAPI-180 Fix the token and activation flow for the provisioning with token endpoint when the header is missing
+- Fix FLEXIAPI-179 Add Localization support as a Middleware that handles Accept-Language HTTP header
+- Fix FLEXIAPI-178 Show the unused code in the Activity tab of the accounts in the admin panel
+- Fix FLEXIAPI-177 Complete vcards-storage and devices related endpoints with their User/Admin ones
+- Fix FLEXIAPI-176 Improve logs for the deprecated endpoints and AccountCreationToken related serialization
+- Fix FLEXIAPI-175 and FLEXISIP-231 Rewrite the Redis contacts parser to handle properly SIP uris (thanks @thibault.lemaire !)
+- Fix FLEXIAPI-174 Check if the phone is valid before trying to recover it (deprecated endpoint)
+- Fix FLEXIAPI-173 Wrong route in validateEmail (deprecated)
+- Fix FLEXIAPI-171 Fix README documentation for CreateAdminAccount
+- Fix FLEXIAPI-170 Fix undefined variable apiKey in CreateAdminAccount
+- Fix FLEXIAPI-168 Add POST /accounts/me/email to confirm the email change
+- Fix FLEXIAPI-167 Add the handling of a custom identifier for the JWT tokens on top of the email one
+- Fix FLEXIAPI-166 Reimplement the deprecated email validation URL
+- Fix FLEXIAPI-165 Remove for now text/vcard header constraint
+- Fix FLEXIAPI-164 Add vcards-storage endpoints
+- Fix FLEXIAPI-163 Complete AccountService hooks
+- Fix FLEXIAPI-162 Drop the aliases table and migrate the data to the phone column
+- Fix FLEXIAPI-161 Complete the Dictionary tests to cover the collection accessor
+- Fix FLEXIAPI-159 Add the account_creation_tokens/consume endpoint
+- Fix FLEXIAPI-158 Restrict the phone number change API endpoint to return 403 if the account doesn't have a validated Account Creation Token
+- Fix FLEXIAPI-156 Disable the Phone change web form when PHONE_AUTHENTICATION is disabled
+- Fix FLEXIAPI-155 Add a new accountServiceAccountUpdatedHook and accountServiceAccountDeletedHook
+- Fix FLEXIAPI-153 Add phone and email to be changed in the Activity panel
+- Fix FLEXIAPI-152 API Key usage clarification
+- Fix FLEXIAPI-151 Migrate to hCaptcha
+- Fix FLEXIAPI-150 Use the same account_id parameter for both API and Web routes
+- Fix FLEXIAPI-149 Add a toggle to disable phone check on username for admin endpoints and forms
+- Fix FLEXIAPI-148 Reuse AccountService in the POST /api/accounts admin endpoint
+- FIX FLEXIAPI-146 Allow users to manage their own devices
+- Fix FLEXIAPI-145 Put back the 'code' parameter as an alias for the 'confirmation_key' for the activateEmail and activatePhone endpoints
+- Fix FLEXIAPI-144 Introduce APP_FLEXISIP_PUSHER_FIREBASE_KEYSMAP as a replacement for APP_FLEXISIP_PUSHER_FIREBASE_KEY
+- Fix FLEXIAPI-143 JWT Authentication layer on the API
+- Fix FLEXIAPI-142 PUT /accounts endpoint doesn't allow overiding values anymore
+- Fix FLEXIAPI-140 Fix the display_name attribute in the Vcard4 render
+- Fix FLEXIAPI-139 Refactor the email and phone API documentation
+- Fix FLEXIAPI-138 Add ip and user_agent columns to all the tokens and code tables, fill the values when required and display them in the admin
+- Fix FLEXIAPI-136 Refactor the Web Panel toggle mechanism and move it to a proper Middleware
+- Fix FLEXIAPI-135 Merge the admins table in the accounts table
+- Fix FLEXIAPI-134 Add a system to detect and block abusive accounts
+- Fix FLEXIAPI-133 Use the correct breadcrumb on create and fix a password
+- Fix FLEXIAPI-132 Refactor the Provisioning to remove proxy_default_values
+- Fix #143 Ensure that the ProvisioningToken model behave likes all the other Consommable
+- Fix #141 Add a new hook system for the Account Service
+- Fix #138 Add a dictionary attached to the accounts
+- Fix #137 Migrate the icons from Material Icons to Material Symbols
+- Fix #135 Refactor the password algorithms code
+- Fix #134 Create an Activity view in the Admin > Accounts panel
+- Fix #133 Make the MySQL connection unstrict
+- Fix #132 Move the provisioning_tokens and recovery_codes to dedicated table
+- Fix #130 Drop the group column in the Accounts table
+- Fix FLEXIAPI-242 Add stricter validation for the AccountCreationToken Push Notification endpoint
 
-The format is based on [Keep a Changelog](https://keepachangelog.com/).
+v1.4.9
+------
+- Complete the missing changelog
 
-## [2.1]
+v1.4.8
+------
+- Fix FLEXIAPI-166 Reimplement the deprecated email validation URL
+- Fix FLEXIAPI-140 Select the display_name attribute from the database to inject...
 
-### Added
+v1.4.7
+------
+- Fix FLEXIAPI-175 and FLEXISIP-231 Rewrite the Redis contacts parser to handle properly SIP uris (thanks @thibault.lemaire !)
 
-- **Add CardDav servers** They can be configured in the administration panels and the API.
-- **Rockylinux 10 support** Packages are now available in the official repository
-- **Artisan cleanup script for statistics** Add an artisan console script to clear statistics after n days `app:clear-statistics {days} {--apply}`
-- **Add Voicemail features and related API endpoints** to integrate with `flexisip-voicemail`
+v1.4.6
+------
+- Fix FLEXIAPI-142 PUT /accounts endpoint doesn't allow overiding values anymore
+- Fix typos and dependencies
 
-### Changed
+v1.4.5
+------
+- Fix FLEXIAPI-132 Refactor the Provisioning to remove proxy_default_values
 
-- **Contacts Lists** The Contacts Lists are now handled per Space. During the migration, if there is only one Space present, existing Contacts Lists are automatically attached to it, otherwise the first Super Space available is used. If they are then attached to the wrong Space you'll have to change directly their `space_id` value in the `contacts_lists` database table.
-- **PHP 8.2 minimum** Laravel and its dependencies were upgraded to version 11 as well.
-- **Logout the user when the password is correctly changed**
+v1.4.4
+------
+- Fix FLEXIAPI-136 Refactor the Web Panel toggle mechanism and move it to a proper Middleware
 
-## [2.0]
+v1.4.3
+------
+- Fix FLEXIAPI-133 Use the correct breadcrumb on create and fix a password update related issue on update
 
-### Added
+v1.4.2
+------
+- Fix #135 Refactor the password algorithms code
 
-- **Spaces:** A new way to manage your SIP domains and hosts. A Space is defined by a unique SIP Domain and Host pair.
-    - **New mandatory DotEnv variable** `APP_ROOT_HOST`, replaces `APP_URL` and `APP_SIP_DOMAIN` that are now configured using the new dedicated Artisan script. It defines the root hostname where all the Spaces will be configured. All the Spaces will be as subdomains of `APP_ROOT_HOST` except one that can be equal to `APP_ROOT_HOST`. Example: if `APP_ROOT_HOST=myhost.com` the Spaces hosts will be `myhost.com`, `alpha.myhost.com` , `beta.myhost.com`...
-    - **New DotEnv variable:** `APP_ACCOUNT_RECOVERY_TOKEN_EXPIRATION_MINUTES=0` Number of minutes before expiring the recovery tokens
-    - **New Artisan script** `php artisan spaces:create-update {sip_domain} {host} {name} {--super}`, replaces `php artisan sip_domains:create-update {sip_domain} {--super}`. Can create a Space or update a Space Host base on its Space SIP Domain.
-- **Push Notification endpoint** Add a /push-notification endpoint to send custom push notifications to the Flexisip Pusher
-- **Add internationalisation support in the app** The web panels are now available in French and English
-- **Add External Accounts** In the API and web panels, allowing users to setup an external account that can be used in another service like the B2BUA
-- **Add configurable admin API Keys** Allowing admins to setup non-expiring services API Keys
-- **Add provisioning email** A user can now receive a custom generated email with all the provisioning related information
-- **Add API endpoints to send the password reset and provisioning emails**
-- **Add an app setup wizard page** Static web page inviting the users to download the app if it is not installed yet
+v1.4.1
+------
+- Fix #133 Make the MySQL connection unstrict
 
-### Changed
+v1.4
+----
+- Redesign and refactoring of the main UI and panel flows
+- Complete the statistics and add a specific API to get usage statistics from FlexiAPI
+- Removal of XMLRPC
+- Add RockyLinux 9 support
+- Add Debian 12 to CI
+- Fix #122 Add a new console command CreateFirstAdmin
+- Fix #121 Only apply throttling to redeemed tokens
+- Fix #123 Define a proper documentation for the provisioning flow
+- Fix #124 Return 404 when the account is already provisioned or the provisioning_token not valid
+- Fix #125 Remove the External Accounts feature
+- Fix #19 Set all the ERROR confirmation_key to null in the accounts table
 
-- **Complete and reorganize the Markdown documentation**
-- **Refactor the emails templates** All the emails were modernized and are now generated in HTML
+v1.3
+----
+- Fix #90 Deploy packages from release branches as well
+- Fix #58 Fix the packaging process to use git describe as a reference
+- Fix #58 Move the generated packages in the build directory, and fix the release and version format in the .spec
+- Fix #58 Refactor and cleanup the .gitlab-ci file
+- Move the minimum PHP version to 8.0
+- Fix #47 Move the docker to an external repository
+- Fix #83 Add php-redis-remi package
+- Fix #85 Also package php-pecl-igbinary and php-pecl-msgpack from remi
+- Fix #84 Remove CentOS7 from the pipeline
+- Fix #80 Inject provisioning link and QRCode in the default email with a password_reset parameter
+- Fix #79 Add a refresh_password parameter to the provisioning URLs
+- Fix #78 Add a APP_ACCOUNTS_EMAIL_UNIQUE environnement setting
+- Fix #30 Remove APP_EVERYONE_IS_ADMIN
 
-### Removed
+v1.2
+----
 
-- **Remove the deprecated endpoints** The endpoints inherited from XMLRPC are now completely removed, the following variable can be removed:
-    - APP_DANGEROUS_ENDPOINTS
-    - APP_PROJECT_URL
-- **Removing and moving DotEnv instance environnement variables to the Spaces** The following DotEnv variables were removed. You can now configure them directly in the designated spaces after the migration.
-    - INSTANCE_COPYRIGHT
-    - INSTANCE_INTRO_REGISTRATION
-    - INSTANCE_CONFIRMED_REGISTRATION_TEXT
-    - INSTANCE_CUSTOM_THEME
-    - WEB_PANEL
-    - PUBLIC_REGISTRATION
-    - PHONE_AUTHENTICATION
-    - DEVICES_MANAGEMENT
-    - INTERCOM_FEATURES
-    - NEWSLETTER_REGISTRATION_ADDRESS
-    - ACCOUNT_PROXY_REGISTRAR_ADDRESS
-    - ACCOUNT_TRANSPORT_PROTOCOL_TEXT
-    - ACCOUNT_REALM
-    - ACCOUNT_PROVISIONING_RC_FILE
-    - ACCOUNT_PROVISIONING_OVERWRITE_ALL
-    - ACCOUNT_PROVISIONING_USE_X_LINPHONE_PROVISIONING_HEADER
-- **Enforce the session and cache in the configuration** The following variables can be removed from your DotEnv file as well:
-    - SESSION_DRIVER
-    - CACHE_DRIVER
-
-### Migrate from [1.6]
-
-1. Deploy the new version and migrate the database.
-
-```
-php artisan migrate
-```
-
-2. Set `APP_ROOT_HOST` in `.env` or as an environnement variable. And remove `APP_URL` and `APP_SIP_DOMAIN`
-
-```
-APP_ROOT_HOST=myhost.com
-```
-
-3. The migration script will automatically copy the `sip_domain` into `host` in the `spaces` table. You then have to "fix" the hosts and set them to equal or be subdomains of `APP_ROOT_HOST`.
-
-```
-php artisan spaces:create-update my.sip myhost.com "My Super Space" --super # You can set some Spaces as SuperSpaces, the admin will be able to manage the other spaces
-php artisan spaces:create-update alpha.sip alpha.myhost.com "Alpha Space"
-php artisan spaces:create-update beta.sip beta.myhost.com "Beta Space"
-...
-```
-
-4. Configure your web server to point the `APP_ROOT_HOST` and subdomains to the app. See the related documentation in [`INSTALL.md` file](INSTALL.md#31-mandatory-app_root_host-variable).
-
-5. Configure your Spaces.
-
-6. (Optional) Import the old instance DotEnv environnement variables into a space.
-
-7. Remove the instance based environnement variables (see **Changed** above) and configure them directly in the spaces using the API or Web Panel.
-
-⚠️ Be careful, during this import only the project DotEnv file variables will be imported, other environnement (eg. set in Apache, nginx or Docker) will be ignored.
-
-⚠️ The content of the `ACCOUNT_PROVISIONING_RC_FILE` will not be imported. You will have to extract the sections and lines that you want to use manually using the dedicated form or the API.
-
-```
-php artisan spaces:import-configuration-from-dot-env {sip_domain}
-```
-
-You can find more details regarding those steps in the [`INSTALL.md`](INSTALL.md) and [`README.md`](README.md) files.
-
-
-## [1.6] - 2024-12-30
-
-### Added
-
-- **Allow the expiration of tokens and codes in the DotEnv configuration**
-    - **New DotEnv variables:** check all the new `*_EXPIRATION_MINUTES` for each token and code in `.env.example`
-- **Phone validation system by country code:** all the provided phone numbers are now properly validated and some countries can be forbidden
-- **SIP Domain management:** the account domains are now managed in a set of panels and API endpoints, this is the base of the upcoming space administration system
-- **JSON validation in the API:** the provised JSON is now validated and returns an error if an issue is detected
-- **CoTURN credentials support:** TURN credentials can now be generated and return through the provisioning feature
-- **RFC 8898 Support**
-
-## Changed
-
-- **Replace Material Icons with Phosphor**
-
-## Deprecated
-
-- **Last major version supporting the deprecated endpoints of the API**
-
-### Migrate from [1.5]
-
-Nothing specific to do
-
-## [1.5] - 2024-08-29
-
-### Added
-
-- **Account activity view:** new panel, available behind the Activity tab, will allow any admin to follow the activity of the accounts they manage.
-- **Detect and block abusive accounts:** This activity tracking is coming with a related tool that is measuring the accounts activity and automatically block them if it detects some unusual behaviors on the service. An account can also directly be blocked and unblocked from the setting panel. Two new setting variables will allow you to fine tune those behaviors triggers.
-    - **New DotEnv variable:** `BLOCKING_TIME_PERIOD_CHECK=30` Time span on which the blocking service will proceed, in minutes
-    - **New DotEnv variable:** `BLOCKING_AMOUNT_EVENTS_AUTHORIZED_DURING_PERIOD=5` Amount of account events authorized during this period
-- **OAuth JWT Authentication:** OAuth support with the handling of JWE tokens issues by a third party service such as Keycloack.
-    - **New DotEnv variable:** `JWT_RSA_PUBLIC_KEY_PEM=`
-    - **New DotEnv variable:** `JWT_SIP_IDENTIFIER=sip_identifier`
-- **Super-domains and super-admins support:** Introduce SIP domains management. The app accounts are now divided by their domains with their own respective administrators that can only see and manage their own domain accounts and settings. On top of that it is possible to configure a SIP domain as a "super-domain" and then allow its admins to become "super-admins". Those super-admins will then be able to manage all the accounts handled by the instance and create/edit/delete the other SIP domains. Add new endpoints and a new super-admin role in the API to manage the SIP domains. SIP domains can also be created and updated directly from the console using a new artisan script (documented in the README);
-    - **New Artisan script:** `php artisan sip_domains:create-update {domain} {--super}`
-- **Account Dictionary:** Each account can now handle a specific dictionary, configurable by the API or directly the web panel. This dictionary allows developers to store arbitrary `key -> value pairs` on each accounts.
-- **Vcard storage:** Attach custom vCards on a dedicated account using new endpoints in the API. The published vCard are validated before being stored.
-
-### Changed
-
-- **User management of their own devices:** Allowing users will be able to manage its own devices. Specific API endpoints were also added to manage them directly from the clients.
-- **Migration to hCaptcha:** Migrate from Google Recaptcha to hCaptcha in this release.
-    - **New DotEnv variable:** HCAPTCHA_SECRET=secret-key
-    - **New DotEnv variable:** HCAPTCHA_SITEKEY=site-key
-- **Localization support:** The API is now accepting the `Accept-Language` header and adapt its internal localization to the client/browser one. For the moment only French and English are supported but more languages could be added in the future.
+- Introduce FlexiAPI built on Laravel to replace XMLRPC
+- Deprecates XMLRPC (will be removed in the 2.0 release)
+- Create a REST API to manage the accounts, related features and provisioning
+- Create a user web panel for their account management, currently in testing phase (unstable)
+- Create an admin web panel to manage accounts and related features
+- Allow accounts to be exported as ExternalAccounts and imported in another Flexisip Account Manager instance
+- Add various artisan console commands to maintain the data (cleaning up, importing, exporting, seeding)
+- Add unit tests for the FlexiAIP REST API
+- Rebuild the existing database using the Laravel migration scripts

INSTALL.md

@@ -1,160 +0,0 @@
-# DotEnv configuration
-
-FlexiAPI relies on [DotEnv](https://github.com/vlucas/phpdotenv) to be configured. This configuration can be accessed using the existing `.env` file that can be itself overwritten by an environnement variables.
-
-Those variables can then be set using Docker-Compose, a bash script or a web-server.
-
-If you're installing FlexiAPI from the RedHat or Debian package you can find the configuration file at `/etc/flexisip-account-manager/flexiapi.env`.
-
-Check also the [RELEASE.md](RELEASE.md) to check if you don't have specific migrations to do between releases.
-
-# 1.a Manual setup
-
-Clone the repository, install the dependencies and generate a key.
-
-    composer install --no-dev
-    php artisan key:generate
-
-# 1.b Packages setup
-
-FlexiAPI is packaged for Debian and RedHat, you can setup those repositories using the Flexisip documentation https://wiki.linphone.org/xwiki/wiki/public/view/Flexisip/1.%20Installation/#HInstallationfromourrepositories
-
-    yum install bc-flexisip-account-manager # For RedHat distributions
-    apt install bc-flexisip-account-manager # For Debian distributions
-
-The `artisan` script is in the root directory of where the application is setup, with packages its often `/opt/belledonne-communications/share/flexisip-account-manager/flexiapi/`.
-
-⚠️ If you want to enable JWT authentication the php-sodium dependency is required, on Rockylinux it is only available in the Remi repository in some cases. You can install it with the following steps:
-
-    dnf -y install https://rpms.remirepo.net/enterprise/remi-release-{rockylinux-release}.rpm
-    dnf -y module reset php
-    dnf -y module enable php:remi-{php-version}
-    dnf -y update php\*
-    dnf -y install php-sodium
-
-# 2. Web server configuration
-
-The package will deploy a `flexisip-account-manager.conf` file in the apache2 configuration directory.
-This file can be loaded and configured in your specific VirtualHost configuration.
-
-To know more about the web server configuration part, you can directly [visit the official Laravel installation documentation](https://laravel.com/docs/).
-
-⚠️ The Account Manager is handling files upload, please ensure that you raised `upload_max_filesize` and `post_max_size` to a reasonable number in your `php.ini` file to prevent file upload errors.
-
-# 3. .env file configuration
-
-Complete all the variables in the `.env` file (from the `.env.example` one if you setup the instance manually) or by overwriting them in your Docker or web-server configuration.
-
-## 3.1. Mandatory `APP_ROOT_HOST` variable
-
-`APP_ROOT_HOST` contains the HTTP host where your FlexiAPI is hosted (eg. `flexiapi.domain.tld` or directly `flexiapi-domain.tld`).
-
-This is the host that you'll define in the Apache or webserver VirtualHost:
-
-    ServerName flexiapi-domain.tld
-    ServerAlias *.flexiapi-domain.tld
-
-If you are planning to manage several Spaces (see Spaces bellow) a wildcard `ServerAlias` as above is required.
-
-## 3.2. Database migration
-
-Then configure the database connection parameters and migrate the tables. The first migration *MUST* be run on an empty database.
-
-    php artisan migrate
-
-# 4. Spaces
-
-Since the 1.6 FlexiAPI can manage different SIP Domains on separate HTTP subdomains.
-
-A Space is defined as a specific HTTP subdomain of `APP_ROOT_HOST` and is linked to a specific SIP Domain. It is also possible to host one (and only one) specific Space directly under `APP_ROOT_HOST`.
-
-By default administrator accounts in Spaces will only see the accounts of their own Space (that have the same SIP Domain).
-However it is possible to define a Space as a "SuperSpace" allowing the admins to see all the other Spaces and accounts and create/edit/delete the other Spaces.
-
-## 4.1. Setup the first Space
-
-You will need to create the first Space manually, generally as a SuperSpace, after that the other Spaces can directly be created in your browser through the Web Panels.
-
-    php artisan spaces:create-update {sip_domain} {host} {name} {--super}
-
-For example:
-
-    php artisan spaces:create-update company-sip-domain.tld flexiapi-domain.tld "My Super Space" --super
-    php artisan spaces:create-update other-sip-domain.tld other.flexiapi-domain.tld "My Other Space"
-
-## 5. Create a first administrator and finish the setup
-
-Create a first administrator account:
-
-    php artisan accounts:create-admin-account {-u|username=} {-p|password=} {-d|domain=}
-
-For example:
-
-    php artisan accounts:create-admin-account -u admin -p strong_password -d company-sip-domain.tld
-
-You can now try to authenticate on the web panel and continue the setup using your admin account.
-
-# Other custom configurations
-
-## Multiple virtualhosts option
-
-In your web server configuration create several VirtualHosts that are pointing to the same FlexiAPI instance.
-Using the environnement variables you can then configure FlexiAPI per instance.
-
-With Apache, use the [mod_env](https://httpd.apache.org/docs/2.4/mod/mod_env.html) module.
-
-    SetEnv APP_ENV "production"
-
-On nginx use `fastcgi_param` to pass the parameter directly to PHP.
-
-    location ~ [^/]\.php(/|$) {
-        …
-        include /etc/nginx/fastcgi_params;
-        fastcgi_param  APP_ENV     "staging";
-    }
-
-> **Warning** Do not create a cache of your configuration (using `artisan config:cache`) if you have a multi-environnement setup.
-> The cache is always having the priority on the variables set in the configuration files.
-
-## Custom Theme
-
-If you enable the Custom CSS Theme option to true in the Space administration panel, FlexiAPI will try to load a CSS file located in `public/css/$space_host.style.css`. If the file doesn't exists it will fallback to `public/css/style.css`.
-
-You can find an example CSS file at `public/css/custom.style.css`.
-
-## Flexisip Push notifications pusher
-
-The API endpoint `POST /account_creation_tokens/send-by-push` uses the `flexisip_pusher` binary delivered by the [Flexisip](https://gitlab.linphone.org/BC/public/flexisip) project (and related package). You must configure the `APP_FLEXISIP_PUSHER_PATH` and `APP_FLEXISIP_PUSHER_FIREBASE_KEYSMAP` environnement variables to point to the correct binary.
-
-    APP_FLEXISIP_PUSHER_PATH=/opt/belledonne-communications/bin/flexisip_pusher
-
-This binary will be executed under "web user" privileges. Ensure that all the related files required by `flexisip_pusher` can be accessed using this user account.
-
-    /var/opt/belledonne-communications/log/flexisip/flexisip-pusher.log // Write permissions
-    /etc/flexisip/apn/*pem // Read permissions
-
-## SELinux restrictions
-
-If you are running on a RedHat machine, please ensure that SELinux is correctly configured.
-
-Allow the webserver user to write in the `storage/` directory:
-
-    chcon -R -t httpd_sys_rw_content_t storage/
-
-Don't forget to make this change persistent if the directory may be relabeled :
-
-    semanage fcontext -a -t httpd_sys_rw_content_t storage/
-
-You can use the restorecon command to verify that this is working :
-
-    restorecon storage/
-
-If your database is located on a remote machine, you should also allow your webserver user to connect to remote hosts:
-
-    semanage port -a -t http_port_t -p tcp 3306 // Open remote connections on the MySQL port for example
-    setsebool -P httpd_can_network_connect 1 // Allow remote network connected
-    setsebool -P httpd_can_network_connect_db 1 // Allow remote database connection
-
-If you are planning to send emails using your account manager:
-
-    setsebool -P httpd_can_sendmail 1 // Allow email to be sent

Makefile

@@ -20,7 +20,7 @@ else
 endif
 
 cleanup-package-semvers:
-	rm -f flexisip-account-manager.spec.run
+	rm flexisip-account-manager.spec.run
 
 prepare:
 	cd flexiapi && php composer.phar install --ignore-platform-req=ext-redis --no-dev
@@ -38,7 +38,6 @@ package-common:
 	cp -R --parents flexiapi/**/* $(OUTPUT_DIR)/flexisip-account-manager/
 	cp flexiapi/composer* $(OUTPUT_DIR)/flexisip-account-manager/flexiapi/
 	cp README.md $(OUTPUT_DIR)/flexisip-account-manager/
-	cp INSTALL.md $(OUTPUT_DIR)/flexisip-account-manager/
 	cp flexiapi/.env.example $(OUTPUT_DIR)/flexisip-account-manager/flexiapi/.env.example
 	cp flexiapi/artisan $(OUTPUT_DIR)/flexisip-account-manager/flexiapi/
 	cp flexiapi/phpunit.xml $(OUTPUT_DIR)/flexisip-account-manager/flexiapi/
@@ -50,7 +49,7 @@ package-common:
 	cp -R cron/ $(OUTPUT_DIR)/flexisip-account-manager/
 	cp flexisip-account-manager.spec.run $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
 
-	tar cf flexisip-account-manager.tar.gz -C $(OUTPUT_DIR) flexisip-account-manager
+	tar cvf flexisip-account-manager.tar.gz -C $(OUTPUT_DIR) flexisip-account-manager
 	mv flexisip-account-manager.tar.gz $(OUTPUT_DIR)/rpmbuild/SOURCES/flexisip-account-manager.tar.gz
 
 package-end-common:
@@ -58,34 +57,25 @@ package-end-common:
 	rm -rf $(OUTPUT_DIR)/rpmbuild/SPECS $(OUTPUT_DIR)/rpmbuild/SOURCES $(OUTPUT_DIR)/rpmbuild/SRPMS $(OUTPUT_DIR)/rpmbuild/BUILD $(OUTPUT_DIR)/rpmbuild/BUILDROOT
 
 rpm-el8-only:
-	mkdir -p build
-	sed -i 's/Requires:.*/Requires: php >= 8.2, php-gd, php-pdo, php-redis, php-mysqlnd, php-mbstring/g' $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
-	rpmbuild --quiet -bb --define 'dist .el8' --define '_topdir $(OUTPUT_DIR)/rpmbuild' --define "_rpmdir $(OUTPUT_DIR)/rpmbuild" $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
+	sed -i 's/Requires:.*/Requires:       php >= 8.0, php-gd, php-pdo, php-redis, php-mysqlnd, php-mbstring/g' $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
+	rpmbuild -v -bb --define 'dist .el8' --define '_topdir $(OUTPUT_DIR)/rpmbuild' --define "_rpmdir $(OUTPUT_DIR)/rpmbuild" $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
 	@echo "📦✅ RPM el8 Package Created"
 
 rpm-el9-only:
-	mkdir -p build
-	rpmbuild --quiet -bb --define 'dist .el9' --define '_topdir $(OUTPUT_DIR)/rpmbuild' --define "_rpmdir $(OUTPUT_DIR)/rpmbuild" $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
+	rpmbuild -v -bb --define 'dist .el9' --define '_topdir $(OUTPUT_DIR)/rpmbuild' --define "_rpmdir $(OUTPUT_DIR)/rpmbuild" $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
 	@echo "📦✅ RPM el9 Package Created"
 
-rpm-el10-only:
-	mkdir -p build
-	rpmbuild --quiet -bb --define 'dist .el10' --define '_topdir $(OUTPUT_DIR)/rpmbuild' --define "_rpmdir $(OUTPUT_DIR)/rpmbuild" $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
-	@echo "📦✅ RPM el10 Package Created"
-
 rpm-cleanup:
 	@echo "🧹 Cleanup"
 	mv rpmbuild/*/*.rpm build/.
 	rm -r rpmbuild
 
 deb-only:
-	mkdir -p build
-	sed -i 's/posttrans/post/g' $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
-	rpmbuild --quiet -bb --with deb --define '_topdir $(OUTPUT_DIR)/rpmbuild' --define "_rpmfilename tmp.rpm" --define "_rpmdir $(OUTPUT_DIR)/rpmbuild" $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
+	rpmbuild -v -bb --with deb --define '_topdir $(OUTPUT_DIR)/rpmbuild' --define "_rpmfilename tmp.rpm" --define "_rpmdir $(OUTPUT_DIR)/rpmbuild" $(OUTPUT_DIR)/rpmbuild/SPECS/flexisip-account-manager.spec
 	fakeroot alien -g -k --scripts $(OUTPUT_DIR)/rpmbuild/tmp.rpm
 	rm -r $(OUTPUT_DIR)/rpmbuild
 	rm -rf $(OUTPUT_DIR)/*.orig
-	sed -i 's/Depends:.*/Depends: $${shlibs:Depends}, php (>= 8.2), php-xml, php-pdo, php-gd, php-redis, php-mysql, php-mbstring, php-sqlite3/g' $(OUTPUT_DIR)/bc-flexisip-account-manager*/debian/control
+	sed -i 's/Depends:.*/Depends: $${shlibs:Depends}, php (>= 8.0), php-xml, php-pdo, php-gd, php-redis, php-mysql, php-mbstring, php-sqlite3/g' $(OUTPUT_DIR)/bc-flexisip-account-manager*/debian/control
 
 	cd `ls -rt $(OUTPUT_DIR) | tail -1` && dpkg-buildpackage --no-sign
 	@echo "📦✅ DEB Package Created"
@@ -96,22 +86,11 @@ deb-only:
 
 	mv *.deb build/.
 
-prepare-common: prepare package-semvers package-common
-
-package-el8: rpm-el8-only rpm-cleanup cleanup-package-semvers package-end-common
-rpm-el8: prepare-common package-el8
-rpm-el8-dev: prepare-dev package-semvers package-common package-el8
-
-package-el9: rpm-el9-only rpm-cleanup cleanup-package-semvers package-end-common
-rpm-el9: prepare-common package-el9
-rpm-el9-dev: prepare-dev package-semvers package-common package-el9
-
-package-el10: rpm-el10-only rpm-cleanup cleanup-package-semvers package-end-common
-rpm-el10: prepare-common package-el10
-rpm-el10-dev: prepare-dev package-semvers package-common package-el10
-
-package-deb: deb-only cleanup-package-semvers package-end-common
-deb: prepare-common package-deb
-deb-dev: prepare-dev package-semvers package-common package-deb
+rpm-el8: prepare package-semvers package-common rpm-el8-only rpm-cleanup cleanup-package-semvers package-end-common
+rpm-el8-dev: prepare-dev package-semvers package-common rpm-el8-only rpm-cleanup cleanup-package-semvers package-end-common
+rpm-el9: prepare package-semvers package-common rpm-el9-only rpm-cleanup cleanup-package-semvers package-end-common
+rpm-el9-dev: prepare-dev package-semvers package-common rpm-el9-only rpm-cleanup cleanup-package-semvers package-end-common
+deb: prepare package-semvers package-common deb-only cleanup-package-semvers package-end-common
+deb-dev: prepare-dev package-semvers package-common deb-only cleanup-package-semvers package-end-common
 
 .PHONY: rpm

README.md

@@ -17,14 +17,130 @@ Flexisip is dual licensed, and can be licensed and distributed:
 
 # Documentation
 
-Once deployed you can have access to the global and API documentation on the `/api` and `/provisioning/documentation` pages.
+Once deployed you can have access to the global and API documentation on the `/api` and `/documentation` pages.
 
 # Setup
 
-Check the [INSTALL.md](INSTALL.md) and [CHANGELOG.md](CHANGELOG.md) files.
+## DotEnv configuration
+
+FlexiAPI relies on [DotEnv](https://github.com/vlucas/phpdotenv) to be configured. This configuration can be accessed using the existing `.env` file that can be itself overwritten by an environnement variables.
+
+Thoses variables can then be set using Docker-Compose, a bash script or a web-server for example.
+
+If you're installing FlexiAPI from the RPM package you can find the configuration file at `/etc/flexisip-account-manager/flexiapi.env`.
+
+## Manual setup
+
+Clone the repository, install the dependencies and generate a key.
+
+    composer install --no-dev
+    php artisan key:generate
+
+Then configure the database connection in the `.env` file (from the `.env.example` one). And migrate the tables. The migration *MUST* be run on an empty database. The `.env` file will be available at the root of the project or often located in `/etc/flexisip-account-manager` in packaged versions.
+
+    php artisan migrate
+
+You can also run the test suit using `phpunit`.
+
+To know more about the web server configuration part, you can directly [visit the official Laravel installation documentation](https://laravel.com/docs/8.x).
+
+### Apache2 server configuration
+
+The package will deploy a `flexisip-account-manager.conf` file in the apache2 configuration directory.
+This file can be loaded and configured in your specific VirtualHost configuration.
+
+### Configure the .env file
+
+Complete all the other variables in the `.env` file or by overwritting them in your Docker or web-server configuration:
+- The OVH SMS connector
+- SMTP configuration
+- App name, SIP domain…
+
+### Multi instances environement
+
+FlexiAPI can also handle multi domains setup.
+
+#### Multiple virtualhosts option
+
+In your web server configuration create several virtualhosts that are pointing to the same FlexiAPI instance.
+Using the environnement variables you can then configure FlexiAPI per instance.
+
+With Apache, use the [mod_env](https://httpd.apache.org/docs/2.4/mod/mod_env.html) module.
+
+    SetEnv APP_NAME "VirtualHost One"
+
+On nginx use `fastcgi_param` to pass the parameter directly to PHP.
+
+    location ~ [^/]\.php(/|$) {
+        …
+        include /etc/nginx/fastcgi_params;
+        fastcgi_param  APP_NAME     "VirtualHost Two";
+    }
+
+> **Warning** Do not create a cache of your configuration (using `artisan config:cache`) if you have a multi-environnement setup.
+> The cache is always having the priority on the variables set in the configuration files.
+
+#### Multiple .env option
+
+To do so, configure several web servers virtualhosts and set a specific `APP_ENV` environnement variable in each of them.
+
+Note that if `APP_ENV` is not set FlexiAPI will directly use the default `.env` file.
+
+FlexiAPI will then try to load a custom configuration file with the following name `.env.$APP_ENV`. So for the previous example `.env.foobar`.
+
+You can then configure your instances with specific values.
+
+    INSTANCE_COPYRIGHT="FooBar - Since 1997"
+    INSTANCE_INTRO_REGISTRATION="Welcome on the FooBar Server"
+    INSTANCE_CUSTOM_THEME=true
+    …
+
+#### Custom theme
+
+If you set `INSTANCE_CUSTOM_THEME` to true, FlexiAPI will try to load a CSS file located in `public/css/$APP_ENV.style.css`. If the file doesn't exists it will fallback to `public/css/style.css`.
+
+You can find an example CSS file at `public/css/custom.style.css`.
+
+#### Flexisip Push notifications pusher
+
+The API endpoint `POST /account_creation_tokens/send-by-push` uses the `flexisip_pusher` binary delivered by the [Flexisip](https://gitlab.linphone.org/BC/public/flexisip) project (and related package). You must configure the `APP_FLEXISIP_PUSHER_PATH` and `APP_FLEXISIP_PUSHER_FIREBASE_KEYSMAP` environnement variables to point to the correct binary.
+
+    APP_FLEXISIP_PUSHER_PATH=/opt/belledonne-communications/bin/flexisip_pusher
+
+This binary will be executed under "web user" privileges. Ensure that all the related files required by `flexisip_pusher` can be accessed using this user account.
+
+    /var/opt/belledonne-communications/log/flexisip/flexisip-pusher.log // Write permissions
+    /etc/flexisip/apn/*pem // Read permissions
+
+### SELinux restrictions
+
+If you are running on a CentOS/RedHat machine, please ensure that SELinux is correctly configured.
+
+Allow the webserver user to write in the `storage/` directory:
+
+    chcon -R -t httpd_sys_rw_content_t storage/
+
+Don't forget to make this change persistent if the directory may be relabeled :
+
+    semanage fcontext -a -t httpd_sys_rw_content_t storage/
+
+You can use the restorecon command to verify that this is working :
+
+    restorecon storage/
+
+If your database is located on a remote machine, you should also allow your webserver user to connect to remote hosts:
+
+    semanage port -a -t http_port_t -p tcp 3306 // Open remote connections on the MySQL port for example
+    setsebool -P httpd_can_network_connect 1 // Allow remote network connected
+    setsebool -P httpd_can_network_connect_db 1 // Allow remote database connection
+
+If you are planning to send emails using your account manager:
+
+    setsebool -P httpd_can_sendmail 1 // Allow email to be sent
 
 ## Usage
 
+For the web panel, a general documentation is available under the `/documentation` page.
 For the REST API, the `/api` page contains all the required documentation to authenticate and request the API.
 FlexiAPI is also providing endpoints to provision Liblinphone powered devices. You can find more documentation about it on the `/provisioning/documentation` documentation page.
 
@@ -32,29 +148,19 @@ FlexiAPI is also providing endpoints to provision Liblinphone powered devices. Y
 
 FlexiAPI is shipped with several console commands that you can launch using the `artisan` executable available at the root of this project.
 
-### Create or update a Space
+### Create or update a SIP Domain
 
-Create or update a Space, required to then create accounts afterward. The `super` option enable/disable the domain as a super domain.
+Create or update a SIP Domain, required to then create accounts afterward. The `super` option enable/disable the domain as a super domain.
 
-    php artisan spaces:create-update {sip_domain} {host} {name} {--super}
-
-### Import the old DotEnv instance configuration into a Space
-
-Since 2.0 some environnement instance configuration variables were moved into the Space configuration, you can import them using this command.
-
-    php artisan spaces:import-configuration-from-dot-env {sip_domain}
-
-⚠️ Be careful, during this import only the project DotEnv file variables will be imported, other environnement (eg. set in Apache, nginx or Docker) will be ignored.
-
-⚠️ The content of the `ACCOUNT_PROVISIONING_RC_FILE` will not be imported. You will have to extract the sections and lines that you want to use manually using the dedicated form or the API.
+    php artisan sip_domains:create-update {domain} {--super}
 
 ### Create an admin account
 
-Create an admin account, an API Key will also be generated along the way, it might expire after a while (regarding the API Key expiration policy). An empty `api_key_ip` will remove the IP restriction on the key.
+Create an admin account, an API Key will also be generated along the way, it might expire after a while.
 
 If no parameters are put, a default admin account will be created.
 
-    php artisan accounts:create-admin-account {-u|username=} {-p|password=} {-d|domain=} {-k|api_key_ip=}
+    php artisan accounts:create-admin-account {-u|username=} {-p|password=} {-d|domain=}
 
 ### Clear the expired API Keys
 
@@ -94,19 +200,20 @@ Once one account is declared as administrator, you can directly configure the ot
 
 ### Seed liblinphone test accounts
 
-You can also seed the tables with test accounts for the liblinphone test suite with the following command (check LiblinphoneTesterAccountSeeder for the JSON syntax):
+You can also seed the tables with test accounts for the liblinphone test suite with the following command (check LiblinphoneTesterAccoutSeeder for the JSON syntax):
 
     php artisan accounts:seed /path/to/accounts.json
 
 ## SMS templates
 
-To send SMS to the USA some providers need to validate their templates before transferring them, see [Sending SMS messages to the USA - OVH](https://help.ovhcloud.com/csm/en-ie-sms-sending-sms-to-usa?id=kb_article_view&sysparm_article=KB0051359).
+To send SMS to the USA some providers need to validate their templates before transfering them, see [Sending SMS messages to the USA - OVH](https://help.ovhcloud.com/csm/en-ie-sms-sending-sms-to-usa?id=kb_article_view&sysparm_article=KB0051359).
 
 Here are the currently used SMS templates in the app to declare in your provider panel:
-- Validation code: `Your #APP_NAME# validation code is #CODE#`. Sent to validate the phone change by SMS.
-- Validation code with expiration: `Your #APP_NAME# validation code is #CODE#. The code is available for #CODE_MINUTES# minutes`. Sent to validate the phone change by SMS, include an expiration time.
 
-## Custom email templates
+- Creation code: `Your #APP_NAME# creation code is #CODE#`. Sent to confirm the creation of the account by SMS.
+- Recovery code: `Your #APP_NAME# recovery code is #CODE#`. Sent to recover the account by SMS.
+
+## Custom email templaces
 
 Some email templates can be customized.
 
@@ -137,7 +244,7 @@ The `POST /api/messages` endpoint allows you to send messages on the SIP network
 
     APP_LINPHONE_DAEMON_UNIX_PATH=/tmp/ld
 
-If you have issues connecting to that socket check the [`systemd restrictions`](INSTALL.md#systemd-restrictions) part of this document.
+If you have issues connecting to that socket check the [`systemd restrictions`](#systemd-restrictions) part of this document.
 
 The socket is located in the `/tmp` directory.
 

RELEASE.md

@@ -0,0 +1,35 @@
+# Releases
+
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/).
+
+## [1.5] - 2024-08-29
+
+### Added
+
+- **Account activity view:** new panel, available behind the Activity tab, will allow any admin to follow the activity of the accounts they manage.
+- **Detect and block abusive accounts:** This activity tracking is coming with a related tool that is measuring the accounts activity and automatically block them if it detects some unusual behaviors on the service. An account can also directly be blocked and unblocked from the setting panel. Two new setting variables will allow you to fine tune those behaviors triggers.
+    - **New DotEnv variable:** `BLOCKING_TIME_PERIOD_CHECK=30` # Time span on which the blocking service will proceed, in minutes
+    - **New DotEnv variable:** `BLOCKING_AMOUNT_EVENTS_AUTHORIZED_DURING_PERIOD=5` # Amount of account events authorized during this period
+- **OAuth JWT Authentication:** OAuth support with the handling of JWE tokens issues by a third party service such as Keycloack.
+    - **New DotEnv variable:** `JWT_RSA_PUBLIC_KEY_PEM=`
+    - **New DotEnv variable:** `JWT_SIP_IDENTIFIER=sip_identifier`
+- **Super-domains and super-admins support:** Introduce SIP domains management. The app accounts are now divided by their domains with their own respective administrators that can only see and manage their own domain accounts and settings. On top of that it is possible to configure a SIP domain as a "super-domain" and then allow its admins to become "super-admins". Those super-admins will then be able to manage all the accounts handled by the instance and create/edit/delete the other SIP domains. Add new endpoints and a new super-admin role in the API to manage the SIP domains. SIP domains can also be created and updated directly from the console using a new artisan script (documented in the README);
+    - **New Artisan script:** `php artisan sip_domains:create-update {domain} {--super}`
+- **Account Dictionary:** Each account can now handle a specific dictionary, configurable by the API or directly the web panel. This dictionary allows developers to store arbitrary `key -> value pairs` on each accounts.
+- **Vcard storage:** Attach custom vCards on a dedicated account using new endpoints in the API. The published vCard are validated before being stored.
+
+### Changed
+
+- **User management of their own devices:** Allowing users will be able to manage its own devices. Specific API endpoints were also added to manage them directly from the clients.
+- **Migration to hCaptcha:** Migrate from Google Recaptcha to hCaptcha in this release.
+    - **New DotEnv variable:** HCAPTCHA_SECRET=secret-key
+    - **New DotEnv variable:** HCAPTCHA_SITEKEY=site-key
+- **Localization support:** The API is now accepting the `Accept-Language` header and adapt its internal localization to the client/browser one. For the moment only French and English are supported but more languages could be added in the future.
+
+### Deprecated
+
+- **Last major version supporting the deprecated endpoints of the API**
+

cron/flexiapi.cron

@@ -1 +0,0 @@
-* * * * * apache /opt/belledonne-communications/share/flexisip-account-manager/flexiapi/artisan schedule:run >> /dev/null 2>&1

cron/flexiapi.debian

@@ -1,10 +1,7 @@
 #!/bin/sh
 
 cd /opt/belledonne-communications/share/flexisip-account-manager/flexiapi/
-sudo -su www-data && php artisan accounts:clear-accounts-tombstones 7 --apply
-sudo -su www-data && php artisan accounts:clear-api-keys 60
-sudo -su www-data && php artisan accounts:clear-files 30 --apply
-sudo -su www-data && php artisan accounts:clear-unconfirmed 30 --apply
-sudo -su www-data && php artisan app:clear-statistics 30 --apply
 sudo -su www-data && php artisan digest:clear-nonces 60
-sudo -su www-data && php artisan spaces:expiration-emails
+sudo -su www-data && php artisan accounts:clear-api-keys 60
+sudo -su www-data && php artisan accounts:clear-accounts-tombstones 7 --apply
+sudo -su www-data && php artisan accounts:clear-unconfirmed 30 --apply

cron/flexiapi.redhat

@@ -1,10 +1,7 @@
 #!/bin/sh
 
 cd /opt/belledonne-communications/share/flexisip-account-manager/flexiapi/
-php artisan accounts:clear-accounts-tombstones 7 --apply
-php artisan accounts:clear-api-keys 60
-php artisan accounts:clear-files 30 --apply
-php artisan accounts:clear-unconfirmed 30 --apply
-php artisan app:clear-statistics 30 --apply
 php artisan digest:clear-nonces 60
-php artisan spaces:expiration-emails
+php artisan accounts:clear-api-keys 60
+php artisan accounts:clear-accounts-tombstones 7 --apply
+php artisan accounts:clear-unconfirmed 30 --apply

flexiapi/.env.example

@@ -1,39 +1,61 @@
+APP_NAME=FlexiAPI
 APP_ENV=local
 APP_KEY=
 APP_DEBUG=false
-APP_ROOT_HOST=
+APP_URL=http://localhost
+APP_SIP_DOMAIN=sip.example.com
 
 APP_LINPHONE_DAEMON_UNIX_PATH=
 APP_FLEXISIP_PUSHER_PATH=
 APP_FLEXISIP_PUSHER_FIREBASE_KEYSMAP= # Each pair is separated using a space and defined as a key:value
 
+APP_API_KEY_EXPIRATION_MINUTES=60 # Number of minutes the generated API Keys are valid
+APP_API_ACCOUNT_CREATION_TOKEN_RETRY_MINUTES=60 # Number of minutes between two consecutive account_creation_token creation
+
 APP_ALLOW_PHONE_NUMBER_USERNAME_ADMIN_API=false # Allow phone numbers to be set as username in admin account creation endpoints
 
+# Risky toggles
+APP_DANGEROUS_ENDPOINTS=false # Enable some dangerous endpoints used for XMLRPC like fallback usage
+
+# SIP server parameters
+ACCOUNT_PROXY_REGISTRAR_ADDRESS=sip.example.com # Proxy registrar address, can be different than the SIP domain
+ACCOUNT_TRANSPORT_PROTOCOL_TEXT="TLS (recommended), TCP or UDP" # Simple text, to explain how the SIP server can be reached
+ACCOUNT_REALM=null # Default realm for the accounts, fallback to the domain if not set, enforce null by default
+
+# Account creation
+ACCOUNT_EMAIL_UNIQUE=false # Emails are unique between all the accounts
+ACCOUNT_CONSUME_EXTERNAL_ACCOUNT_ON_CREATE=false
+ACCOUNT_BLACKLISTED_USERNAMES=
+ACCOUNT_USERNAME_REGEX="^[a-z0-9+_.-]*$"
+ACCOUNT_DEFAULT_PASSWORD_ALGORITHM=SHA-256 # Can ONLY be MD5 or SHA-256 in capital, default to SHA-256
+
+# Account provisioning
+ACCOUNT_PROVISIONING_RC_FILE=
+ACCOUNT_PROVISIONING_OVERWRITE_ALL=
+ACCOUNT_PROVISIONING_USE_X_LINPHONE_PROVISIONING_HEADER=true
+
+# Blocking service
+BLOCKING_TIME_PERIOD_CHECK=30 # Time span on which the blocking service will proceed, in minutes
+BLOCKING_AMOUNT_EVENTS_AUTHORIZED_DURING_PERIOD=5 # Amount of account events authorized during this period
+
+# Instance specific parameters
+INSTANCE_COPYRIGHT= # Simple text displayed in the page footer
+INSTANCE_INTRO_REGISTRATION= # Markdown text displayed in the home page
+INSTANCE_CUSTOM_THEME=false
+INSTANCE_CONFIRMED_REGISTRATION_TEXT= # Markdown text displayed when an account is confirmed
+
+WEB_PANEL=true # Fully enable/disable the web panels
+NEWSLETTER_REGISTRATION_ADDRESS= # Address to contact when a user wants to register to the newsletter
+PUBLIC_REGISTRATION=true # Toggle to enable/disable the public registration forms
+PHONE_AUTHENTICATION=true # Toggle to enable/disable the SMS support, requires public registration
+DEVICES_MANAGEMENT=false # Toggle to enable/disable the devices management supporttrue
+INTERCOM_FEATURES=false # Toggle to enable/disable the intercom related features
+
 TERMS_OF_USE_URL= # A URL pointing to the Terms of Use
 PRIVACY_POLICY_URL= # A URL pointing to the Privacy Policy
 APP_PROJECT_URL= # A URL pointing to the project information page
 
-# Expiration time for tokens and code, in minutes, 0 means no expiration
-APP_API_ACCOUNT_CREATION_TOKEN_RETRY_MINUTES=60 # Number of minutes between two consecutive account_creation_token creation
-APP_ACCOUNT_CREATION_TOKEN_EXPIRATION_MINUTES=0
-APP_ACCOUNT_RECOVERY_TOKEN_EXPIRATION_MINUTES=0
-APP_EMAIL_CHANGE_CODE_EXPIRATION_MINUTES=10
-APP_PHONE_CHANGE_CODE_EXPIRATION_MINUTES=10
-APP_RECOVERY_CODE_EXPIRATION_MINUTES=10
-APP_PROVISIONING_TOKEN_EXPIRATION_MINUTES=0
-APP_API_KEY_EXPIRATION_MINUTES=60 # Number of minutes the unused API Keys are valid
-APP_RESET_PASSWORD_EMAIL_TOKEN_EXPIRATION_MINUTES=1440 # 24h
-
-# Account creation and authentication
-ACCOUNT_EMAIL_UNIQUE=false # Emails are unique between all the accounts
-ACCOUNT_BLACKLISTED_USERNAMES=
-ACCOUNT_USERNAME_REGEX="^[a-z0-9+_.-]*$"
-ACCOUNT_DEFAULT_PASSWORD_ALGORITHM=SHA-256 # Can ONLY be MD5 or SHA-256 in capital, default to SHA-256
-ACCOUNT_AUTHENTICATION_BEARER= # Bearer value (WWW-Authenticate: Bearer <value>) of the external service that can provide a trusted (eg. JWT token) for the authentication, takes priority and disable the DIGEST auth if set, see https://www.rfc-editor.org/rfc/rfc8898
-
-# Blocking service
-BLOCKING_TIME_PERIOD_CHECK=30 # Time span on which the blocking service will proceed, in minutes
-BLOCKING_AMOUNT_EVENTS_AUTHORIZED_DURING_PERIOD=5 # Amount of account events authorized during this period
+LOG_CHANNEL=stack
 
 # FlexiSIP database
 # Ensure that you have the proper SELinux configuration to allow database connections, see the README
@@ -58,9 +80,10 @@ REDIS_DB=
 
 # Logs
 # Ensure that you have the proper SELinux configuration to write in the storage directory, see the README
-LOG_CHANNEL=stack
 BROADCAST_DRIVER=log
+CACHE_DRIVER=file
 QUEUE_CONNECTION=sync
+SESSION_DRIVER=cookie
 SESSION_LIFETIME=120
 
 # SMTP and emails
@@ -77,11 +100,6 @@ MAIL_VERIFY_PEER=true
 MAIL_VERIFY_PEER_NAME=true
 MAIL_SIGNATURE="The Example Team"
 
-# CoTURN
-COTURN_SERVER_HOST= # IP or domain name
-COTURN_SESSION_TTL_MINUTES=1440 # 60 * 24
-COTURN_STATIC_AUTH_SECRET= # static-auth-secret in the coturn configuration
-
 # OVH SMS API variables
 OVH_APP_KEY=
 OVH_APP_SECRET=
@@ -96,6 +114,3 @@ HCAPTCHA_SITEKEY=site-key
 # JWT
 JWT_RSA_PUBLIC_KEY_PEM=
 JWT_SIP_IDENTIFIER=
-
-# Temporary toggles
-APP_SHOW_LOGIN_COUNTER_TEMP= # default true

flexiapi/app/Account.php

@@ -23,8 +23,8 @@ use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Foundation\Auth\User as Authenticatable;
+use Illuminate\Http\Request;
 use Illuminate\Support\Str;
-use Illuminate\Database\Eloquent\Collection;
 use Carbon\Carbon;
 
 use Awobaz\Compoships\Compoships;
@@ -36,9 +36,9 @@ class Account extends Authenticatable
     use HasFactory;
     use Compoships;
 
-    protected $with = ['passwords', 'emailChangeCode', 'types', 'actions', 'dictionaryEntries', 'carddavServers'];
-    protected $hidden = ['expire_time', 'pivot', 'currentProvisioningToken', 'currentRecoveryCode', 'dictionaryEntries'];
-    protected $appends = ['realm', 'provisioning_token', 'provisioning_token_expire_at', 'dictionary'];
+    protected $with = ['passwords', 'activationExpiration', 'emailChangeCode', 'types', 'actions', 'dictionaryEntries'];
+    protected $hidden = ['expire_time', 'confirmation_key', 'pivot', 'currentProvisioningToken', 'currentRecoveryCode', 'dictionaryEntries'];
+    protected $appends = ['realm', 'confirmation_key_expires', 'provisioning_token', 'dictionary'];
     protected $casts = [
         'activated' => 'boolean',
     ];
@@ -73,10 +73,7 @@ class Account extends Authenticatable
                 return;
             }
 
-            /**
-             * config('app.sip_domain') is required for the Tests suit
-             */
-            $builder->where('domain', config('app.sip_domain') ?? space()->domain);
+            $builder->where('domain', config('app.sip_domain'));
         });
     }
 
@@ -114,19 +111,14 @@ class Account extends Authenticatable
         });
     }
 
+    public function activationExpiration()
+    {
+        return $this->hasOne(ActivationExpiration::class);
+    }
+
     public function apiKey()
     {
-        return $this->hasOne(ApiKey::class)->whereNull('expires_after_last_used_minutes');
-    }
-
-    public function adminApiKeys()
-    {
-        return $this->hasMany(ApiKey::class)->whereNotNull('expires_after_last_used_minutes');
-    }
-
-    public function external()
-    {
-        return $this->hasOne(ExternalAccount::class);
+        return $this->hasOne(ApiKey::class);
     }
 
     public function contacts()
@@ -134,23 +126,6 @@ class Account extends Authenticatable
         return $this->belongsToMany(Account::class, 'contacts', 'account_id', 'contact_id');
     }
 
-    public function files()
-    {
-        return $this->hasMany(AccountFile::class)->latest();
-    }
-
-    public function voicemails()
-    {
-        return $this->hasMany(AccountFile::class)
-            ->whereIn('content_type', AccountFile::VOICEMAIL_CONTENTTYPES)
-            ->latest();
-    }
-
-    public function uploadedVoicemails()
-    {
-        return $this->voicemails()->whereNotNull('name');
-    }
-
     public function vcardsStorage()
     {
         return $this->hasMany(VcardStorage::class);
@@ -166,12 +141,6 @@ class Account extends Authenticatable
         return $this->hasMany(AccountDictionaryEntry::class);
     }
 
-    public function carddavServers()
-    {
-        return $this->belongsToMany(SpaceCardDavServer::class, 'account_carddav_credentials', 'account_id', 'space_carddav_server_id')
-            ->withPivot('username', 'realm', 'algorithm', 'password');
-    }
-
     public function getDictionaryAttribute()
     {
         if ($this->dictionaryEntries->isEmpty()) return new stdClass;
@@ -209,11 +178,6 @@ class Account extends Authenticatable
         return $this->belongsToMany(AccountType::class);
     }
 
-    public function space()
-    {
-        return $this->hasOne(Space::class, 'domain', 'domain');
-    }
-
     public function statisticsFromCalls()
     {
         return $this->hasMany(StatisticsCall::class, ['from_username', 'from_domain'], ['username', 'domain']);
@@ -282,38 +246,11 @@ class Account extends Authenticatable
         return $this->hasOne(AccountCreationToken::class);
     }
 
-    public function accountRecoveryTokens()
-    {
-        return $this->hasMany(AccountRecoveryToken::class);
-    }
-
     public function authTokens()
     {
         return $this->hasMany(AuthToken::class);
     }
 
-    /**
-     * Reset password
-     */
-
-    public function getCurrentResetPasswordUrlAttribute(): string
-    {
-        return replaceHost(
-            route('account.reset_password_email.change', $this->currentResetPasswordEmailToken->token),
-            $this->space->host
-        );
-    }
-
-    public function currentResetPasswordEmailToken()
-    {
-        return $this->hasOne(ResetPasswordEmailToken::class)->where('used', false)->latestOfMany();
-    }
-
-    public function resetPasswordEmailTokens()
-    {
-        return $this->hasMany(ResetPasswordEmailToken::class)->latest();
-    }
-
     /**
      * Attributes
      */
@@ -335,24 +272,6 @@ class Account extends Authenticatable
         return null;
     }
 
-    public function getProvisioningTokenExpireAtAttribute(): ?string
-    {
-        if ($this->currentProvisioningToken) {
-            return $this->currentProvisioningToken->expire_at;
-        }
-
-        return null;
-    }
-
-    public function getRemainingCardDavCredentialsCreatableAttribute(): Collection
-    {
-        return $this->space->carddavServers()->whereNotIn('id', function ($query) {
-            $query->select('space_carddav_server_id')
-                  ->from('account_carddav_credentials')
-                  ->where('account_id', $this->id);
-        })->get();
-    }
-
     public function getIdentifierAttribute(): string
     {
         return $this->attributes['username'] . '@' . $this->attributes['domain'];
@@ -369,12 +288,12 @@ class Account extends Authenticatable
 
     public function getRealmAttribute()
     {
-        return $this->space->account_realm;
+        return config('app.realm');
     }
 
     public function getResolvedRealmAttribute()
     {
-        return $this->space->account_realm ?? $this->domain;
+        return config('app.realm') ?? $this->domain;
     }
 
     public function getConfirmationKeyExpiresAttribute()
@@ -386,6 +305,11 @@ class Account extends Authenticatable
         return null;
     }
 
+    public function getSha256PasswordAttribute()
+    {
+        return $this->passwords()->where('algorithm', 'SHA-256')->exists();
+    }
+
     public static function dtmfProtocolsRule()
     {
         return implode(',', array_keys(self::$dtmfProtocols));
@@ -398,42 +322,18 @@ class Account extends Authenticatable
 
     public function getSuperAdminAttribute(): bool
     {
-        return Space::where('domain', $this->domain)->where('super', true)->exists() && $this->admin;
-    }
-
-    /**
-     * Provisioning
-     */
-
-    public function getProvisioningUrlAttribute(): string
-    {
-        return replaceHost(
-            route('provisioning.provision', $this->getProvisioningTokenAttribute()),
-            $this->space->host
-        );
-    }
-
-    public function getProvisioningQrcodeUrlAttribute(): string
-    {
-        return replaceHost(
-            route('provisioning.qrcode', $this->getProvisioningTokenAttribute()),
-            $this->space->host
-        );
-    }
-
-    public function getProvisioningWizardUrlAttribute(): string
-    {
-        return replaceHost(
-            route('provisioning.wizard', $this->getProvisioningTokenAttribute()),
-            $this->space->host
-        );
+        return SipDomain::where('domain', $this->domain)->where('super', true)->exists() && $this->admin;
     }
 
     /**
      * Utils
      */
+    public function activationExpired(): bool
+    {
+        return ($this->activationExpiration && $this->activationExpiration->isExpired());
+    }
 
-    public function generateUserApiKey(?string $ip = null): ApiKey
+    public function generateApiKey(?Request $request = null): ApiKey
     {
         $this->apiKey()->delete();
 
@@ -441,7 +341,7 @@ class Account extends Authenticatable
         $apiKey->account_id = $this->id;
         $apiKey->last_used_at = Carbon::now();
         $apiKey->key = Str::random(40);
-        $apiKey->ip = $ip;
+        $apiKey->ip = $request ? $request->ip() : '127.0.0.1';
         $apiKey->save();
 
         return $apiKey;
@@ -465,12 +365,10 @@ class Account extends Authenticatable
         return $authToken;
     }
 
-    public function recover(?string $code = null, ?string $phone = null, ?string $email = null): string
+    public function recover(?string $code = null): string
     {
         $recoveryCode = new RecoveryCode;
         $recoveryCode->code = $code ?? generatePin();
-        $recoveryCode->phone = $phone;
-        $recoveryCode->email = $email;
         $recoveryCode->account_id = $this->id;
 
         if (request()) {

flexiapi/app/AccountCardDavCredentials.php

@@ -1,20 +0,0 @@
-<?php
-
-namespace App;
-
-use Illuminate\Database\Eloquent\Model;
-
-class AccountCardDavCredentials extends Model
-{
-    protected $table = 'account_carddav_credentials';
-
-    public function cardDavServer()
-    {
-        return $this->hasOne(SpaceCardDavServer::class, 'id', 'space_carddav_server_id');
-    }
-
-    public function getIdentifierAttribute()
-    {
-        return $this->username . '@' . $this->domain;
-    }
-}

flexiapi/app/AccountCreationToken.php

@@ -27,8 +27,6 @@ class AccountCreationToken extends Consommable
     use HasFactory;
 
     protected $hidden = ['id', 'updated_at', 'created_at'];
-    protected $appends = ['expire_at'];
-    protected ?string $configExpirationMinutesKey = 'account_creation_token_expiration_minutes';
 
     public function accountCreationRequestToken()
     {

flexiapi/app/AccountFile.php

@@ -1,74 +0,0 @@
-<?php
-
-namespace App;
-
-use Illuminate\Database\Eloquent\Model;
-use Illuminate\Database\Eloquent\Concerns\HasUuids;
-use Illuminate\Support\Facades\Storage;
-
-class AccountFile extends Model
-{
-    use HasUuids;
-
-    public const VOICEMAIL_CONTENTTYPES = ['audio/opus', 'audio/wav'];
-    public const FILES_PATH = 'files';
-    protected $hidden = ['account_id', 'updated_at', 'sending_by_mail_at', 'sent_by_mail_at', 'sending_by_mail_tryouts'];
-    protected $appends = ['download_url'];
-    protected $casts = [
-        'uploaded_at' => 'datetime',
-    ];
-
-    protected static function booted()
-    {
-        static::deleting(function (AccountFile $accountFile) {
-            Storage::delete($accountFile->getPathAttribute());
-        });
-    }
-
-    public function account()
-    {
-        return $this->belongsTo(Account::class)->withoutGlobalScopes();
-    }
-
-    public function getMaxUploadSizeAttribute(): ?int
-    {
-        return maxUploadSize();
-    }
-
-    public function getUploadUrlAttribute(): ?string
-    {
-        return route('file.upload', $this->attributes['id']);
-    }
-
-    public function getPathAttribute(): string
-    {
-        return self::FILES_PATH . '/' . $this->attributes['name'];
-    }
-
-    public function getUrlAttribute(): ?string
-    {
-        return !empty($this->attributes['name'])
-            && !empty($this->attributes['id'])
-            ? replaceHost(
-                route('file.show', ['uuid' => $this->attributes['id'], 'name' => $this->attributes['name']]),
-                $this->account->space->host
-            )
-            : null;
-    }
-
-    public function getDownloadUrlAttribute(): ?string
-    {
-        return !empty($this->attributes['name'])
-            && !empty($this->attributes['id'])
-            ? replaceHost(route(
-                'file.download',
-                ['uuid' => $this->attributes['id'], 'name' => $this->attributes['name']]
-            ), $this->account->space->host)
-            : null;
-    }
-
-    public function isVoicemailAudio(): bool
-    {
-        return in_array($this->attributes['content_type'], self::VOICEMAIL_CONTENTTYPES);
-    }
-}

flexiapi/app/AccountRecoveryToken.php

@@ -1,42 +0,0 @@
-<?php
-
-namespace App;
-
-use Illuminate\Database\Eloquent\Factories\HasFactory;
-
-class AccountRecoveryToken extends Consommable
-{
-    use HasFactory;
-
-    protected $hidden = ['id', 'updated_at', 'created_at'];
-    protected $appends = ['expire_at'];
-    protected ?string $configExpirationMinutesKey = 'account_recovery_token_expiration_minutes';
-
-    public function account()
-    {
-        return $this->belongsTo(Account::class);
-    }
-
-    public function consume()
-    {
-        $this->used = true;
-        $this->save();
-    }
-
-    public function consumed(): bool
-    {
-        return $this->used == true;
-    }
-
-    public function toLog()
-    {
-        return [
-            'token' => $this->token,
-            'pn_param' => $this->pn_param,
-            'used' => $this->used,
-            'account_id' => $this->account_id,
-            'ip' => $this->ip,
-            'user_agent' => $this->user_agent,
-        ];
-    }
-}

flexiapi/app/ActivationExpiration.php

@@ -16,24 +16,29 @@
     You should have received a copy of the GNU Affero General Public License
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
+
 namespace App;
 
+use Carbon\Carbon;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 
-class ExternalAccount extends Model
+class ActivationExpiration extends Model
 {
     use HasFactory;
 
-    public const PROTOCOLS = ['UDP', 'TCP','TLS'];
+    protected $casts = [
+        'expires' => 'datetime:Y-m-d H:i:s',
+    ];
 
     public function account()
     {
         return $this->belongsTo(Account::class);
     }
 
-    public function getIdentifierAttribute(): string
+    public function isExpired()
     {
-        return $this->attributes['username'] . '@' . $this->attributes['domain'];
+        $now = Carbon::now();
+        return $this->expires->lessThan($now);
     }
 }

flexiapi/app/ApiKey.php

@@ -28,12 +28,8 @@ class ApiKey extends Model
 
     protected $table = 'api_keys';
 
-    protected $casts = [
-        'last_used_at' => 'datetime',
-    ];
-
     public function account()
     {
-        return $this->belongsTo(Account::class)->withoutGlobalScopes();
+        return $this->belongsTo(Account::class);
     }
 }

flexiapi/app/Console/Commands/Accounts/ClearApiKeys.php

@@ -1,68 +0,0 @@
-<?php
-/*
-    Flexisip Account Manager is a set of tools to manage SIP accounts.
-    Copyright (C) 2020 Belledonne Communications SARL, All rights reserved.
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Affero General Public License as
-    published by the Free Software Foundation, either version 3 of the
-    License, or (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU Affero General Public License for more details.
-
-    You should have received a copy of the GNU Affero General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-namespace App\Console\Commands\Accounts;
-
-use Illuminate\Console\Command;
-use Carbon\Carbon;
-
-use App\ApiKey;
-
-class ClearApiKeys extends Command
-{
-    protected $signature = 'accounts:clear-api-keys {minutes?}';
-    protected $description = 'Clear the expired user API Keys after n minutes and clear the other expired admin keys';
-
-    public function handle()
-    {
-        // User API Keys
-        $minutes = $this->argument('minutes') ?? config('app.api_key_expiration_minutes');
-
-        if ($minutes == 0) {
-            $this->info('Expiration time is set to 0, nothing to clear');
-            return Command::SUCCESS;
-        }
-
-        $this->info('Deleting user API Keys unused after ' . $minutes . ' minutes');
-
-        $count = ApiKey::whereNull('expires_after_last_used_minutes')
-            ->where('last_used_at', '<', Carbon::now()->subMinutes($minutes)->toDateTimeString())
-            ->delete();
-
-        $this->info($count . ' user API Keys deleted');
-
-        // Admin API Keys
-        $keys = ApiKey::whereNotNull('expires_after_last_used_minutes')
-            ->where('expires_after_last_used_minutes', '>', 0)
-            ->with('account')
-            ->get();
-
-        $count = 0;
-
-        foreach ($keys as $key) {
-            if ($key->last_used_at->addMinutes($key->expires_after_last_used_minutes)->isPast()) {
-                $this->info('Deleting ' . $key->account->identifier . ' admin API Key expired after ' . $key->expires_after_last_used_minutes .'min');
-                $key->delete();
-                $count++;
-            }
-        }
-
-        $this->info($count . ' admin API Keys deleted');
-    }
-}

flexiapi/app/Console/Commands/Accounts/ClearFiles.php

@@ -1,35 +0,0 @@
-<?php
-
-namespace App\Console\Commands\Accounts;
-
-use App\AccountFile;
-use Carbon\Carbon;
-use Illuminate\Console\Command;
-
-class ClearFiles extends Command
-{
-    protected $signature = 'accounts:clear-files {days} {--apply}';
-    protected $description = 'Remove the uploaded files after n days';
-
-    public function handle(): int
-    {
-        $files = AccountFile::where(
-            'created_at',
-            '<',
-            Carbon::now()->subDays($this->argument('days'))->toDateTimeString()
-        );
-
-        $count = $files->count();
-
-        if ($this->option('apply')) {
-            $this->info($count . ' files in deletion…');
-            $files->delete();
-            $this->info($count . ' files deleted');
-
-            return Command::SUCCESS;
-        }
-
-        $this->info($count . ' files to delete');
-        return Command::SUCCESS;
-    }
-}

flexiapi/app/Console/Commands/Accounts/SendVoicemailsEmails.php

@@ -1,40 +0,0 @@
-<?php
-
-namespace App\Console\Commands\Accounts;
-
-use App\AccountFile;
-use App\Mail\Voicemail;
-use Carbon\Carbon;
-use Illuminate\Console\Command;
-use Illuminate\Support\Facades\Mail;
-
-class SendVoicemailsEmails extends Command
-{
-    protected $signature = 'accounts:send-voicemails-emails {--tryout}';
-    protected $description = 'Send the voicemail emails';
-
-    public function handle()
-    {
-        $voicemails = AccountFile::whereNotNull('uploaded_at')
-            ->whereNull('sent_by_mail_at')
-            ->where('sending_by_mail_tryouts', '<', is_int($this->option('tryout'))
-                ? $this->option('tryout')
-                : 3)
-            ->get();
-
-        foreach ($voicemails as $voicemail) {
-            $voicemail->sending_by_mail_at = Carbon::now();
-            $voicemail->save();
-
-            if (Mail::to(users: $voicemail->account)->send(new Voicemail($voicemail))) {
-                $voicemail->sent_by_mail_at = Carbon::now();
-                $this->info('Voicemail sent to ' . $voicemail->account->identifier);
-            } else {
-                $voicemail->sending_by_mail_tryouts++;
-                $this->info('Error sending voicemail to ' . $voicemail->account->identifier);
-            }
-
-            $voicemail->save();
-        }
-    }
-}

flexiapi/app/Console/Commands/ClearApiKeys.php

@@ -0,0 +1,51 @@
+<?php
+/*
+    Flexisip Account Manager is a set of tools to manage SIP accounts.
+    Copyright (C) 2020 Belledonne Communications SARL, All rights reserved.
+
+    This program is free software: you can redistribute it and/or modify
+    it under the terms of the GNU Affero General Public License as
+    published by the Free Software Foundation, either version 3 of the
+    License, or (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU Affero General Public License for more details.
+
+    You should have received a copy of the GNU Affero General Public License
+    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+namespace App\Console\Commands;
+
+use Illuminate\Console\Command;
+use Carbon\Carbon;
+
+use App\ApiKey;
+
+class ClearApiKeys extends Command
+{
+    protected $signature = 'accounts:clear-api-keys {minutes?}';
+    protected $description = 'Clear the expired API Keys after n minutes';
+
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
+    public function handle()
+    {
+        $minutes = $this->argument('minutes') ?? config('app.api_key_expiration_minutes');
+
+        $this->info('Deleting api keys unused after ' . $minutes . ' minutes');
+
+        $count = ApiKey::where(
+            'last_used_at',
+            '<',
+            Carbon::now()->subMinutes($minutes)->toDateTimeString()
+        )->delete();
+
+        $this->info($count . ' api keys deleted');
+    }
+}

flexiapi/app/Console/Commands/ClearNonces.php

@@ -17,7 +17,7 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Console\Commands\Digest;
+namespace App\Console\Commands;
 
 use Illuminate\Console\Command;
 use Carbon\Carbon;

flexiapi/app/Console/Commands/ClearOldAccountsTombstones.php

@@ -17,18 +17,23 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Console\Commands\Accounts;
+namespace App\Console\Commands;
 
 use Illuminate\Console\Command;
 use Carbon\Carbon;
 
 use App\AccountTombstone;
 
-class ClearAccountsTombstones extends Command
+class ClearOldAccountsTombstones extends Command
 {
     protected $signature = 'accounts:clear-accounts-tombstones {days} {--apply}';
     protected $description = 'Clear deleted accounts tombstones after n days';
 
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
     public function handle()
     {
         $tombstones = AccountTombstone::where(
@@ -41,10 +46,10 @@ class ClearAccountsTombstones extends Command
             $this->info($tombstones->count() . ' tombstones deleted');
             $tombstones->delete();
 
-            return Command::SUCCESS;
+            return 0;
         }
 
         $this->info($tombstones->count() . ' tombstones to delete');
-        return Command::SUCCESS;
+        return 0;
     }
 }

flexiapi/app/Console/Commands/ClearStatistics.php

@@ -1,47 +0,0 @@
-<?php
-
-namespace App\Console\Commands;
-
-use App\StatisticsCall;
-use App\StatisticsMessage;
-use Carbon\Carbon;
-use Illuminate\Console\Command;
-
-class ClearStatistics extends Command
-{
-    protected $signature = 'app:clear-statistics {days} {--apply}';
-    protected $description = 'Command description';
-
-    public function handle()
-    {
-        $calls = StatisticsCall::where(
-            'created_at',
-            '<',
-            Carbon::now()->subDays($this->argument('days'))->toDateTimeString()
-        );
-        $messages = StatisticsMessage::where(
-            'created_at',
-            '<',
-            Carbon::now()->subDays($this->argument('days'))->toDateTimeString()
-        );
-
-        $callsCount = $calls->count();
-        $messagesCount = $messages->count();
-
-        if ($this->option('apply')) {
-            $this->info($callsCount . ' calls statistics in deletion…');
-            $calls->delete();
-            $this->info($callsCount . ' calls statistics deleted');
-
-            $this->info($messagesCount . ' messages statistics in deletion…');
-            $messages->delete();
-            $this->info($messagesCount . ' messages statistics deleted');
-
-            return Command::SUCCESS;
-        }
-
-        $this->info($callsCount . ' calls statistics to delete');
-        $this->info($messagesCount . ' messages statistics to delete');
-        return Command::SUCCESS;
-    }
-}

flexiapi/app/Console/Commands/CreateAdminAccount.php

@@ -17,18 +17,18 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Console\Commands\Accounts;
+namespace App\Console\Commands;
 
 use Illuminate\Console\Command;
 use Carbon\Carbon;
 
 use App\Account;
-use App\Space;
+use App\SipDomain;
 
 class CreateAdminAccount extends Command
 {
-    protected $signature = 'accounts:create-admin-account {--u|username=} {--p|password=} {--d|domain=} {--k|api_key_ip=}';
-    protected $description = 'Create an admin account and generate an API Key';
+    protected $signature = 'accounts:create-admin-account {--u|username=} {--p|password=} {--d|domain=}';
+    protected $description = 'Create an admin account';
 
     public function __construct()
     {
@@ -37,9 +37,9 @@ class CreateAdminAccount extends Command
 
     public function handle()
     {
-        $spaces = Space::all('domain')->pluck('domain');
+        $sipDomains = SipDomain::all('domain')->pluck('domain');
 
-        $this->info('Your creating a new admin account in the database, existing accounts with the same credentials will be overwritten');
+        $this->info('Your will create a new admin account in the database, existing accounts with the same credentials will be overwritten');
 
         $username = $this->option('username');
         $domain = $this->option('domain');
@@ -50,7 +50,7 @@ class CreateAdminAccount extends Command
         }
 
         if (!$this->option('domain')) {
-            $domain = $this->ask('What will be the admin domain? Default: ' . $spaces->first());
+            $domain = $this->ask('What will be the admin domain? Default: ' . $sipDomains->first());
         }
 
         if (!$this->option('password')) {
@@ -58,11 +58,11 @@ class CreateAdminAccount extends Command
         }
 
         $username = $username ?? 'admin';
-        $domain = $domain ?? $spaces->first();
+        $domain = $domain ?? $sipDomains->first();
         $password = $password ?? 'change_me';
 
-        if (!$spaces->contains($domain)) {
-            $this->error('The domain must be one of the following ones: ' . $spaces->implode(', '));
+        if (!$sipDomains->contains($domain)) {
+            $this->error('The domain must be one of the following ones: ' . $sipDomains->implode(', '));
             $this->comment('You can create an extra domain using the dedicated console command');
             return Command::FAILURE;
         }
@@ -80,6 +80,7 @@ class CreateAdminAccount extends Command
         $account = new Account;
         $account->username = $username;
         $account->domain = $domain;
+        $account->email = 'admin_test@sip.example.org';
         $account->activated = true;
         $account->user_agent = 'Test';
         $account->ip_address = '0.0.0.0';
@@ -89,11 +90,11 @@ class CreateAdminAccount extends Command
         $account->created_at = Carbon::now()->subYears(3);
         $account->save();
 
-        $account->generateUserApiKey(ip: $this->option('api_key_ip') ?? null);
+        $account->generateApiKey();
         $account->updatePassword($password);
 
-        $this->info('Admin test account created: "' . $username . '@' . $domain . '" | Password: "' . $password . '" | API Key: "' . $account->apiKey->key . '" (valid on ' . ($account->apiKey->ip ?? 'any') . ' ip)');
+        $this->info('Admin test account created: "' . $username . '@' . $domain . '" | Password: "' . $password . '" | API Key: "' . $account->apiKey->key . '"');
 
-        return Command::SUCCESS;
+        return 0;
     }
 }

flexiapi/app/Console/Commands/CreateAdminAccountTest.php

@@ -17,28 +17,32 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Console\Commands\Accounts;
+namespace App\Console\Commands;
 
 use Illuminate\Console\Command;
 use Carbon\Carbon;
 
 use App\Account;
 use App\ApiKey;
+use App\SipDomain;
 
-class CreateAdminTest extends Command
+class CreateAdminAccountTest extends Command
 {
     protected $signature = 'accounts:create-admin-test';
     protected $description = 'Create a test admin account, only for tests purpose';
 
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
     public function handle()
     {
         $username = 'admin_test';
         $domain = 'sip.example.org';
 
-        $this->call('spaces:create-update', [
-            'sip_domain' => $domain,
-            'host' => $domain,
-            'name' => $domain,
+        $this->call('sip_domains:create-update', [
+            'domain' => $domain,
             '--super' => 'true'
         ]);
 
@@ -65,6 +69,6 @@ class CreateAdminTest extends Command
 
         $this->info('API Key updated to: ' . $secret);
 
-        return Command::SUCCESS;
+        return 0;
     }
 }

flexiapi/app/Console/Commands/CreateSipDomain.php

@@ -0,0 +1,50 @@
+<?php
+/*
+    Flexisip Account Manager is a set of tools to manage SIP accounts.
+    Copyright (C) 2020 Belledonne Communications SARL, All rights reserved.
+
+    This program is free software: you can redistribute it and/or modify
+    it under the terms of the GNU Affero General Public License as
+    published by the Free Software Foundation, either version 3 of the
+    License, or (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU Affero General Public License for more details.
+
+    You should have received a copy of the GNU Affero General Public License
+    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+namespace App\Console\Commands;
+
+use App\SipDomain;
+use Illuminate\Console\Command;
+
+class CreateSipDomain extends Command
+{
+    protected $signature = 'sip_domains:create-update {domain} {--super}';
+    protected $description = 'Create a SIP Domain';
+
+    public function handle()
+    {
+        $this->info('Your will create or update a SIP Domain in the database');
+
+        $sipDomain = SipDomain::where('domain', $this->argument('domain'))->firstOrNew();
+        $sipDomain->domain = $this->argument('domain');
+
+        $sipDomain->exists
+            ? $this->info('The domain already exists, updating it')
+            : $this->info('A new domain will be created');
+
+        $sipDomain->super = (bool)$this->option('super');
+        $sipDomain->super
+            ? $this->info('Set as a super domain')
+            : $this->info('Set as a normal domain');
+
+        $sipDomain->save();
+
+        return Command::SUCCESS;
+    }
+}

flexiapi/app/Console/Commands/RemoveUnconfirmedAccounts.php

@@ -17,18 +17,23 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Console\Commands\Accounts;
+namespace App\Console\Commands;
 
 use Illuminate\Console\Command;
 use Carbon\Carbon;
 
 use App\Account;
 
-class ClearUnconfirmed extends Command
+class RemoveUnconfirmedAccounts extends Command
 {
     protected $signature = 'accounts:clear-unconfirmed {days} {--apply} {--and-confirmed}';
     protected $description = 'Clear unconfirmed accounts after n days';
 
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
     public function handle()
     {
         $accounts = Account::where(
@@ -48,10 +53,10 @@ class ClearUnconfirmed extends Command
             $accounts->delete();
             $this->info($count . ' accounts deleted');
 
-            return Command::SUCCESS;
+            return 0;
         }
 
         $this->info($count . ' accounts to delete');
-        return Command::SUCCESS;
+        return 0;
     }
 }

flexiapi/app/Console/Commands/RunAccountSeeder.php

@@ -17,17 +17,22 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Console\Commands\Accounts;
+namespace App\Console\Commands;
 
 use Database\Seeders\LiblinphoneTesterAccoutSeeder;
 use Illuminate\Console\Command;
 use Illuminate\Support\Facades\App;
 
-class Seed extends Command
+class RunAccountSeeder extends Command
 {
     protected $signature = 'accounts:seed {json-file-path}';
     protected $description = 'Seed some accounts from a JSON file';
 
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
     public function handle()
     {
         $file = $this->argument('json-file-path');

flexiapi/app/Console/Commands/SetAccountAdmin.php

@@ -17,29 +17,34 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Console\Commands\Accounts;
+namespace App\Console\Commands;
 
 use Illuminate\Console\Command;
 
 use App\Account;
 
-class SetAdmin extends Command
+class SetAccountAdmin extends Command
 {
     protected $signature = 'accounts:set-admin {id}';
     protected $description = 'Give the admin role to an account';
 
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
     public function handle()
     {
         $account = Account::withoutGlobalScopes()->where('id', $this->argument('id'))->first();
 
         if (!$account) {
             $this->error('Account not found, please use an existing account id');
-            return Command::FAILURE;
+            return 1;
         }
 
         if ($account->admin) {
             $this->error('The account is already having the admin role');
-            return Command::FAILURE;
+            return 1;
         }
 
         $account->admin = true;
@@ -47,6 +52,6 @@ class SetAdmin extends Command
 
         $this->info('Account '.$account->identifier.' is now admin');
 
-        return Command::SUCCESS;
+        return 0;
     }
 }

flexiapi/app/Console/Commands/Spaces/CreateUpdate.php

@@ -1,67 +0,0 @@
-<?php
-/*
-    Flexisip Account Manager is a set of tools to manage SIP accounts.
-    Copyright (C) 2020 Belledonne Communications SARL, All rights reserved.
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Affero General Public License as
-    published by the Free Software Foundation, either version 3 of the
-    License, or (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU Affero General Public License for more details.
-
-    You should have received a copy of the GNU Affero General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-namespace App\Console\Commands\Spaces;
-
-use App\Space;
-use Illuminate\Console\Command;
-
-class CreateUpdate extends Command
-{
-    protected $signature = 'spaces:create-update {sip_domain} {host} {name} {--super}';
-    protected $description = 'Create a Space';
-
-    public function handle()
-    {
-        $this->info('Your are creating or updating a Space in the database');
-
-        if (empty(config('app.root_host'))) {
-            $this->error('The environnement variable APP_ROOT_HOST doesn\'t seems to be set');
-        }
-
-        if (!str_ends_with($this->argument('host'), config('app.root_host'))) {
-            $this->error('The provided host doesn\'t seems to ends with ' . config('app.root_host'));
-        }
-
-        $space = Space::where('domain', $this->argument('sip_domain'))->firstOrNew();
-        $space->host = $this->argument('host');
-        $space->domain = $this->argument('sip_domain');
-        $space->name = $this->argument('name');
-
-        if ($hostSpace = Space::where('host', $this->argument('host'))->first()) {
-            if (!$space->exists && $hostSpace->domain != $space->domain) {
-                $this->error('A Space with this host and a different sip_domain already exists in the database');
-                return Command::FAILURE;
-            }
-        }
-
-        $space->exists
-            ? $this->info('The space already exists, updating it')
-            : $this->info('A new Space will be created');
-
-        $space->super = (bool)$this->option('super');
-        $space->super
-            ? $this->info('Set as a super Space')
-            : $this->info('Set as a normal Space');
-
-        $space->save();
-
-        return Command::SUCCESS;
-    }
-}

flexiapi/app/Console/Commands/Spaces/ExpirationEmails.php

@@ -1,57 +0,0 @@
-<?php
-
-namespace App\Console\Commands\Spaces;
-
-use Illuminate\Console\Command;
-use Illuminate\Support\Facades\Mail;
-use Carbon\Carbon;
-
-use App\Mail\ExpiringSpace;
-use App\Space;
-
-class ExpirationEmails extends Command
-{
-    protected $signature = 'spaces:expiration-emails {days?}';
-    protected $description = 'Send an expiration email on the designated configured days before expiration. Days must be ordered descending and comma separated (eg. 7,3,1)';
-
-    public function handle()
-    {
-        $days = ['7','3','1'];
-
-        if ($this->argument('days')) {
-            preg_match_all('/\d++/', $this->argument('days'), $matches);
-
-            if (!empty($matches[0])) {
-                $i = 0;
-
-                while ($i + 1 < count($matches[0]) && (int)$matches[0][$i] > (int)$matches[0][$i + 1]) {
-                    $i++;
-                }
-
-                if ($i != count($matches[0]) - 1) {
-                    $this->error('The days must be integer, ordered descending and comma separated');
-
-                    return Command::FAILURE;
-                }
-
-                $days = $matches[0];
-            }
-        }
-
-        $expiringSpaces = Space::whereNotNull('expire_at')->whereDate('expire_at', '>=', Carbon::now())->get();
-
-        foreach ($expiringSpaces as $expiringSpace) {
-            if (in_array($expiringSpace->daysLeft, $days)) {
-                $this->info($expiringSpace->name . ' (' . $expiringSpace->host . ') is expiring in ' . $expiringSpace->daysLeft . ' days');
-
-                $admins = $expiringSpace->admins()->withoutGlobalScopes()->whereNotNull('email')->get();
-
-                $this->info('Sending an email to the admins ' . $admins->implode('email', ','));
-
-                foreach ($admins as $admin) {
-                    Mail::to($admin->email)->send(new ExpiringSpace($expiringSpace));
-                }
-            }
-        }
-    }
-}

flexiapi/app/Console/Commands/Spaces/ImportConfigurationFromDotEnv.php

@@ -1,54 +0,0 @@
-<?php
-
-namespace App\Console\Commands\Spaces;
-
-use Illuminate\Console\Command;
-use App\Space;
-
-class ImportConfigurationFromDotEnv extends Command
-{
-    protected $signature = 'spaces:import-configuration-from-dot-env {sip_domain}';
-    protected $description = 'Import the deprecated space DotEnv configuration in a Space';
-
-    public function handle()
-    {
-        $space = Space::where('domain', $this->argument('sip_domain'))->first();
-
-        if (!$space) {
-            $this->error('The space cannot be found');
-            return Command::SUCCESS;
-        }
-
-        $this->info('The following configuration will be imported in the space ' . $space->domain);
-        $this->info('The existing settings will be overwritten:');
-
-        $space->name = env('APP_NAME', null);
-
-        $space->custom_theme = env('INSTANCE_CUSTOM_THEME', false);
-        $space->web_panel = env('WEB_PANEL', true);
-
-        $space->copyright_text = env('INSTANCE_COPYRIGHT', null);
-        $space->intro_registration_text = env('INSTANCE_INTRO_REGISTRATION', null);
-        $space->newsletter_registration_address = env('NEWSLETTER_REGISTRATION_ADDRESS', null);
-        $space->account_proxy_registrar_address = env('ACCOUNT_PROXY_REGISTRAR_ADDRESS', 'sip.domain.com');
-        $space->account_realm = env('ACCOUNT_REALM', null);
-        $space->custom_provisioning_overwrite_all = env('ACCOUNT_PROVISIONING_OVERWRITE_ALL', false);
-        $space->provisioning_use_linphone_provisioning_header = env('ACCOUNT_PROVISIONING_USE_X_LINPHONE_PROVISIONING_HEADER', true);
-
-        $space->public_registration = env('PUBLIC_REGISTRATION', true);
-        $space->phone_registration = env('PHONE_AUTHENTICATION', true);
-        $space->intercom_features = env('INTERCOM_FEATURES', false);
-
-        foreach ($space->getDirty() as $key => $value) {
-            $show = '    - ' . $key . ' => ';
-            $show .= ($value == null) ? 'null' : $value;
-
-            $this->info($show);
-        }
-
-        if ($this->confirm('Do you want to update ' . $space->domain . '?', false)) {
-            $space->save();
-            $this->info('Space updated');
-        }
-    }
-}

flexiapi/app/Console/Commands/UpdatePhoneCountries.php

@@ -1,33 +0,0 @@
-<?php
-
-namespace App\Console\Commands;
-
-use App\PhoneCountry;
-use Illuminate\Console\Command;
-use libphonenumber\PhoneNumberUtil;
-
-class UpdatePhoneCountries extends Command
-{
-    protected $signature = 'app:update-phone-countries';
-    protected $description = 'Update the phone_countries table from the getCountryCodes() function';
-
-    public function handle()
-    {
-        $phoneNumberUtils = PhoneNumberUtil::getInstance();
-        $countryCodes = getCountryCodes();
-
-        foreach (array_diff(
-            array_keys($countryCodes),
-            PhoneCountry::pluck('code')->toArray()
-        ) as $code) {
-            if ($resolvedMetadata = $phoneNumberUtils->getMetadataForRegion($code)) {
-                $phoneCountry = new PhoneCountry();
-                $phoneCountry->code = $code;
-                $phoneCountry->country_code = $resolvedMetadata->getCountryCode();
-                $phoneCountry->save();
-
-                $this->info($code . ' - ' . $countryCodes[$code] . '  inserted');
-            }
-        }
-    }
-}

flexiapi/app/Consommable.php

@@ -2,18 +2,12 @@
 
 namespace App;
 
-use Carbon\Carbon;
-use DateTime;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Http\Request;
 
 abstract class Consommable extends Model
 {
     protected string $consommableAttribute = 'code';
-    protected ?string $configExpirationMinutesKey = null;
-    protected $casts = [
-        'expire_at' => 'datetime'
-    ];
 
     public function consume()
     {
@@ -27,35 +21,8 @@ abstract class Consommable extends Model
         $this->user_agent = $request->userAgent();
     }
 
-    public function offed(): bool
-    {
-        return $this->consumed() || $this->expired();
-    }
-
     public function consumed(): bool
     {
         return $this->{$this->consommableAttribute} == null;
     }
-
-    public function getExpireAtAttribute(): ?string
-    {
-        if ($this->isExpirable()) {
-            return $this->created_at->addMinutes((int)config('app.' . $this->configExpirationMinutesKey))->toJSON();
-        }
-
-        return null;
-    }
-
-    public function expired(): bool
-    {
-        return ($this->isExpirable()
-            && Carbon::now()->subMinutes((int)config('app.' . $this->configExpirationMinutesKey))->isAfter($this->created_at));
-    }
-
-    private function isExpirable(): bool
-    {
-        return $this->configExpirationMinutesKey != null
-            && config('app.' . $this->configExpirationMinutesKey) != null
-            && (int)config('app.' . $this->configExpirationMinutesKey) > 0;
-    }
 }

flexiapi/app/ContactsList.php

@@ -15,9 +15,4 @@ class ContactsList extends Model
     {
         return $this->belongsToMany(Account::class, 'contacts_list_contact', 'contacts_list_id', 'contact_id');
     }
-
-    public function space()
-    {
-        return $this->belongsTo(Space::class);
-    }
 }

flexiapi/app/EmailChangeCode.php

@@ -25,7 +25,6 @@ class EmailChangeCode extends Consommable
 {
     use HasFactory;
 
-    protected ?string $configExpirationMinutesKey = 'email_change_code_expiration_minutes';
     protected $hidden = ['id', 'account_id', 'code'];
 
     public function account()

flexiapi/app/Helpers/Utils.php

@@ -17,11 +17,9 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-use Illuminate\Support\Facades\App;
 use Illuminate\Support\Str;
 
 use App\Account;
-use App\Space;
 use App\DigestNonce;
 use Illuminate\Http\Request;
 use League\CommonMark\CommonMarkConverter;
@@ -29,15 +27,10 @@ use League\CommonMark\Extension\HeadingPermalink\HeadingPermalinkExtension;
 use League\CommonMark\Extension\TableOfContents\TableOfContentsExtension;
 use Illuminate\Support\Facades\DB;
 
-function space(): ?Space
-{
-    return is_object(request()->space) ? request()->space : null;
-}
-
 function passwordAlgorithms(): array
 {
     return [
-        'MD5' => 'md5',
+        'MD5'     => 'md5',
         'SHA-256' => 'sha256',
     ];
 }
@@ -47,16 +40,9 @@ function generateNonce(): string
     return Str::random(32);
 }
 
-function getRequestBoolean(Request $request, string $key, bool $reversed = false): bool
-{
-    $bool = $request->has($key) ? $request->get($key) == "on" : false;
-
-    return $reversed ? !$bool : $bool;
-}
-
 function generateValidNonce(Account $account): string
 {
-    $nonce = new DigestNonce();
+    $nonce = new DigestNonce;
     $nonce->account_id = $account->id;
     $nonce->nonce = generateNonce();
     $nonce->save();
@@ -76,9 +62,7 @@ function generatePin(): int
 
 function percent($value, $max): float
 {
-    if ($max == 0) {
-        $max = 1;
-    }
+    if ($max == 0) $max = 1;
     return round(($value * 100) / $max, 2);
 }
 
@@ -97,40 +81,16 @@ function markdownDocumentationView(string $view): string
         ],
     ]);
 
-    $converter->getEnvironment()->addExtension(new HeadingPermalinkExtension());
-    $converter->getEnvironment()->addExtension(new TableOfContentsExtension());
+    $converter->getEnvironment()->addExtension(new HeadingPermalinkExtension);
+    $converter->getEnvironment()->addExtension(new TableOfContentsExtension);
 
     return (string) $converter->convert(
-        (string) view($view, [
-            'app_name' => space()->name
+        (string)view($view, [
+            'app_name' => config('app.name')
         ])->render()
     );
 }
 
-function hasCoTURNConfigured(): bool
-{
-    return config('app.coturn_session_ttl_minutes') > 0
-        && !empty(config('app.coturn_server_host'))
-        && !empty(config('app.coturn_static_auth_secret'));
-}
-
-function getCoTURNCredentials(): array
-{
-    $user = Str::random(8);
-    $secret = config('app.coturn_static_auth_secret');
-
-    $ttl = config('app.coturn_session_ttl_minutes') * 60;
-    $time = time() + $ttl;
-
-    $username = $time . ':' . Str::random(16);
-    $password = base64_encode(hash_hmac('sha1', $username, $secret, true));
-
-    return [
-        'username' => $username,
-        'password' => $password,
-    ];
-}
-
 function parseSIP(string $sipAdress): array
 {
     return explode('@', \substr($sipAdress, 4));
@@ -147,27 +107,13 @@ function isRegularExpression(string $string): bool
     return $isRegularExpression;
 }
 
-function replaceHost(string $url, string $host): string
-{
-    $components = parse_url($url);
-    return str_replace($components['host'], $host, $url);
-}
-
 function resolveDomain(Request $request): string
 {
     return $request->has('domain')
         && $request->user()
         && $request->user()->superAdmin
         ? $request->get('domain')
-        : $request->space->domain;
-}
-
-function maxUploadSize(): int
-{
-    return min(
-        ini_parse_quantity(ini_get('upload_max_filesize')),
-        ini_parse_quantity(ini_get('post_max_size'))
-    );
+        : config('app.sip_domain');
 }
 
 function captchaConfigured(): bool
@@ -179,7 +125,7 @@ function resolveUserContacts(Request $request)
 {
     $selected = ['id', 'username', 'domain', 'activated', 'dtmf_protocol', 'display_name'];
 
-    return Account::withoutGlobalScopes()->whereIn('id', function ($query) use ($request) {
+    return Account::whereIn('id', function ($query) use ($request) {
         $query->select('contact_id')
             ->from('contacts')
             ->where('account_id', $request->user()->id)
@@ -214,266 +160,5 @@ function validateIsoDate($attribute, $value, $parameters, $validator): bool
         // Regex from https://www.myintervals.com/blog/2009/05/20/iso-8601-date-validation-that-doesnt-suck/
         : '/^([\+-]?\d{4}(?!\d{2}\b))((-?)((0[1-9]|1[0-2])(\3([12]\d|0[1-9]|3[01]))?|W([0-4]\d|5[0-2])(-?[1-7])?|(00[1-9]|0[1-9]\d|[12]\d{2}|3([0-5]\d|6[1-6])))([T\s]((([01]\d|2[0-3])((:?)[0-5]\d)?|24\:?00)([\.,]\d+(?!:))?)?(\17[0-5]\d([\.,]\d+)?)?([zZ]|([\+-])([01]\d|2[0-3]):?([0-5]\d)?)?)?)?$/';
 
-    return (bool) preg_match($regex, $value);
-}
-
-/**
- * This list was got from the Internet
- *
- * @see https://gist.github.com/vxnick/380904
- * @return array
- */
-function getCountryCodes()
-{
-    return [
-        'AD' => 'Andorra',
-        'AE' => 'United Arab Emirates',
-        'AF' => 'Afghanistan',
-        'AG' => 'Antigua & Barbuda',
-        'AI' => 'Anguilla',
-        'AL' => 'Albania',
-        'AM' => 'Armenia',
-        'AO' => 'Angola',
-        'AQ' => 'Antarctica',
-        'AR' => 'Argentina',
-        'AS' => 'American Samoa',
-        'AT' => 'Austria',
-        'AU' => 'Australia',
-        'AW' => 'Aruba',
-        'AX' => 'Åland Islands',
-        'AZ' => 'Azerbaijan',
-        'BA' => 'Bosnia & Herzegovina',
-        'BB' => 'Barbados',
-        'BD' => 'Bangladesh',
-        'BE' => 'Belgium',
-        'BF' => 'Burkina Faso',
-        'BG' => 'Bulgaria',
-        'BH' => 'Bahrain',
-        'BI' => 'Burundi',
-        'BJ' => 'Benin',
-        'BL' => 'St. Barthélemy',
-        'BM' => 'Bermuda',
-        'BN' => 'Brunei',
-        'BO' => 'Bolivia',
-        'BQ' => 'Bonaire, Sint Eustatius & Saba',
-        'BR' => 'Brazil',
-        'BS' => 'Bahamas',
-        'BT' => 'Bhutan',
-        'BV' => 'Bouvet Island',
-        'BW' => 'Botswana',
-        'BY' => 'Belarus',
-        'BZ' => 'Belize',
-        'CA' => 'Canada',
-        'CC' => 'Cocos (Keeling) Islands',
-        'CD' => 'Congo - Kinshasa',
-        'CF' => 'Central African Republic',
-        'CG' => 'Congo - Brazzaville',
-        'CH' => 'Switzerland',
-        'CI' => "Côte d'Ivoire",
-        'CK' => 'Cook Islands',
-        'CL' => 'Chile',
-        'CM' => 'Cameroon',
-        'CN' => 'China',
-        'CO' => 'Colombia',
-        'CR' => 'Costa Rica',
-        'CU' => 'Cuba',
-        'CV' => 'Cabo Verde',
-        'CW' => 'Curaçao',
-        'CX' => 'Christmas Island',
-        'CY' => 'Cyprus',
-        'CZ' => 'Czechia',
-        'DE' => 'Germany',
-        'DJ' => 'Djibouti',
-        'DK' => 'Denmark',
-        'DM' => 'Dominica',
-        'DO' => 'Dominican Republic',
-        'DZ' => 'Algeria',
-        'EC' => 'Ecuador',
-        'EE' => 'Estonia',
-        'EG' => 'Egypt',
-        'EH' => 'Western Sahara',
-        'ER' => 'Eritrea',
-        'ES' => 'Spain',
-        'ET' => 'Ethiopia',
-        'FI' => 'Finland',
-        'FJ' => 'Fiji',
-        'FK' => 'Falkland Islands',
-        'FM' => 'Micronesia',
-        'FO' => 'Faroe Islands',
-        'FR' => 'France',
-        'GA' => 'Gabon',
-        'GB' => 'United Kingdom',
-        'GD' => 'Grenada',
-        'GE' => 'Georgia',
-        'GF' => 'French Guiana',
-        'GG' => 'Guernsey',
-        'GH' => 'Ghana',
-        'GI' => 'Gibraltar',
-        'GL' => 'Greenland',
-        'GM' => 'Gambia',
-        'GN' => 'Guinea',
-        'GP' => 'Guadeloupe',
-        'GQ' => 'Equatorial Guinea',
-        'GR' => 'Greece',
-        'GS' => 'South Georgia & South Sandwich Islands',
-        'GT' => 'Guatemala',
-        'GU' => 'Guam',
-        'GW' => 'Guinea-Bissau',
-        'GY' => 'Guyana',
-        'HK' => 'Hong Kong',
-        'HM' => 'Heard & McDonald Islands',
-        'HN' => 'Honduras',
-        'HR' => 'Croatia',
-        'HT' => 'Haiti',
-        'HU' => 'Hungary',
-        'ID' => 'Indonesia',
-        'IE' => 'Ireland',
-        'IL' => 'Israel',
-        'IM' => 'Isle of Man',
-        'IN' => 'India',
-        'IO' => 'British Indian Ocean Territory',
-        'IQ' => 'Iraq',
-        'IR' => 'Iran',
-        'IS' => 'Iceland',
-        'IT' => 'Italy',
-        'JE' => 'Jersey',
-        'JM' => 'Jamaica',
-        'JO' => 'Jordan',
-        'JP' => 'Japan',
-        'KE' => 'Kenya',
-        'KG' => 'Kyrgyzstan',
-        'KH' => 'Cambodia',
-        'KI' => 'Kiribati',
-        'KM' => 'Comoros',
-        'KN' => 'St. Kitts & Nevis',
-        'KP' => 'North Korea',
-        'KR' => 'South Korea',
-        'KW' => 'Kuwait',
-        'KY' => 'Cayman Islands',
-        'KZ' => 'Kazakhstan',
-        'LA' => 'Laos',
-        'LB' => 'Lebanon',
-        'LC' => 'St. Lucia',
-        'LI' => 'Liechtenstein',
-        'LK' => 'Sri Lanka',
-        'LR' => 'Liberia',
-        'LS' => 'Lesotho',
-        'LT' => 'Lithuania',
-        'LU' => 'Luxembourg',
-        'LV' => 'Latvia',
-        'LY' => 'Libya',
-        'MA' => 'Morocco',
-        'MC' => 'Monaco',
-        'MD' => 'Moldova',
-        'ME' => 'Montenegro',
-        'MF' => 'St. Martin',
-        'MG' => 'Madagascar',
-        'MH' => 'Marshall Islands',
-        'MK' => 'North Macedonia',
-        'ML' => 'Mali',
-        'MM' => 'Myanmar',
-        'MN' => 'Mongolia',
-        'MO' => 'Macao',
-        'MP' => 'Northern Mariana Islands',
-        'MQ' => 'Martinique',
-        'MR' => 'Mauritania',
-        'MS' => 'Montserrat',
-        'MT' => 'Malta',
-        'MU' => 'Mauritius',
-        'MV' => 'Maldives',
-        'MW' => 'Malawi',
-        'MX' => 'Mexico',
-        'MY' => 'Malaysia',
-        'MZ' => 'Mozambique',
-        'NA' => 'Namibia',
-        'NC' => 'New Caledonia',
-        'NE' => 'Niger',
-        'NF' => 'Norfolk Island',
-        'NG' => 'Nigeria',
-        'NI' => 'Nicaragua',
-        'NL' => 'Netherlands',
-        'NO' => 'Norway',
-        'NP' => 'Nepal',
-        'NR' => 'Nauru',
-        'NU' => 'Niue',
-        'NZ' => 'New Zealand',
-        'OM' => 'Oman',
-        'PA' => 'Panama',
-        'PE' => 'Peru',
-        'PF' => 'French Polynesia',
-        'PG' => 'Papua New Guinea',
-        'PH' => 'Philippines',
-        'PK' => 'Pakistan',
-        'PL' => 'Poland',
-        'PM' => 'St. Pierre & Miquelon',
-        'PN' => 'Pitcairn Islands',
-        'PR' => 'Puerto Rico',
-        'PS' => 'Palestine',
-        'PT' => 'Portugal',
-        'PW' => 'Palau',
-        'PY' => 'Paraguay',
-        'QA' => 'Qatar',
-        'RE' => 'Réunion',
-        'RO' => 'Romania',
-        'RS' => 'Serbia',
-        'RU' => 'Russia',
-        'RW' => 'Rwanda',
-        'SA' => 'Saudi Arabia',
-        'SB' => 'Solomon Islands',
-        'SC' => 'Seychelles',
-        'SD' => 'Sudan',
-        'SE' => 'Sweden',
-        'SG' => 'Singapore',
-        'SH' => 'St. Helena',
-        'SI' => 'Slovenia',
-        'SJ' => 'Svalbard & Jan Mayen',
-        'SK' => 'Slovakia',
-        'SL' => 'Sierra Leone',
-        'SM' => 'San Marino',
-        'SN' => 'Senegal',
-        'SO' => 'Somalia',
-        'SR' => 'Suriname',
-        'SS' => 'South Sudan',
-        'ST' => 'São Tomé & Príncipe',
-        'SV' => 'El Salvador',
-        'SX' => 'Sint Maarten',
-        'SY' => 'Syria',
-        'SZ' => 'Eswatini',
-        'TC' => 'Turks & Caicos Islands',
-        'TD' => 'Chad',
-        'TF' => 'French Southern Territories',
-        'TG' => 'Togo',
-        'TH' => 'Thailand',
-        'TJ' => 'Tajikistan',
-        'TK' => 'Tokelau',
-        'TL' => 'Timor-Leste',
-        'TM' => 'Turkmenistan',
-        'TN' => 'Tunisia',
-        'TO' => 'Tonga',
-        'TR' => 'Türkiye',
-        'TT' => 'Trinidad & Tobago',
-        'TV' => 'Tuvalu',
-        'TW' => 'Taiwan',
-        'TZ' => 'Tanzania',
-        'UA' => 'Ukraine',
-        'UG' => 'Uganda',
-        'UM' => 'U.S. Minor Outlying Islands',
-        'US' => 'United States',
-        'UY' => 'Uruguay',
-        'UZ' => 'Uzbekistan',
-        'VA' => 'Holy See (Vatican City)',
-        'VC' => 'St. Vincent & Grenadines',
-        'VE' => 'Venezuela',
-        'VG' => 'British Virgin Islands',
-        'VI' => 'U.S. Virgin Islands',
-        'VN' => 'Vietnam',
-        'VU' => 'Vanuatu',
-        'WF' => 'Wallis & Futuna',
-        'WS' => 'Samoa',
-        'YE' => 'Yemen',
-        'YT' => 'Mayotte',
-        'ZA' => 'South Africa',
-        'ZM' => 'Zambia',
-        'ZW' => 'Zimbabwe',
-    ];
+    return (bool)preg_match($regex, $value);
 }

flexiapi/app/Http/Controllers/Account/AccountController.php

@@ -28,6 +28,13 @@ use App\Services\AccountService;
 
 class AccountController extends Controller
 {
+    public function documentation(Request $request)
+    {
+        return view('account.documentation', [
+            'documentation' => markdownDocumentationView('account.documentation_markdown')
+        ]);
+    }
+
     public function blocked(Request $request)
     {
         return view('account.blocked');

flexiapi/app/Http/Controllers/Account/ApiKeyController.php

@@ -34,7 +34,7 @@ class ApiKeyController extends Controller
     public function update(Request $request)
     {
         $account = $request->user();
-        $account->generateUserApiKey($request->ip());
+        $account->generateApiKey($request);
 
         return redirect()->back();
     }

flexiapi/app/Http/Controllers/Account/AuthTokenController.php

@@ -25,7 +25,7 @@ use Illuminate\Http\Request;
 
 use Endroid\QrCode\Builder\Builder;
 use Endroid\QrCode\Encoding\Encoding;
-use Endroid\QrCode\ErrorCorrectionLevel;
+use Endroid\QrCode\ErrorCorrectionLevel\ErrorCorrectionLevelHigh;
 use Endroid\QrCode\Writer\PngWriter;
 
 use Illuminate\Support\Facades\Auth;
@@ -46,7 +46,7 @@ class AuthTokenController extends Controller
                 : route('account.auth_tokens.auth.external', ['token' => $authToken->token])
             )
             ->encoding(new Encoding('UTF-8'))
-            ->errorCorrectionLevel(ErrorCorrectionLevel::High)
+            ->errorCorrectionLevel(new ErrorCorrectionLevelHigh())
             ->size(300)
             ->margin(10)
             ->build();
@@ -72,7 +72,7 @@ class AuthTokenController extends Controller
 
         $authToken->delete();
 
-        return redirect()->route('account.home');
+        return redirect()->route('account.dashboard');
     }
 
     /**
@@ -87,6 +87,6 @@ class AuthTokenController extends Controller
             $authToken->save();
         }
 
-        return redirect()->route('account.home');
+        return redirect()->route('account.dashboard');
     }
 }

flexiapi/app/Http/Controllers/Account/AuthenticateController.php

@@ -33,19 +33,13 @@ class AuthenticateController extends Controller
 
     public function login(Request $request)
     {
-        if ($request->user()) {
-            if ($request->user()->superAdmin) {
-                return redirect()->route('admin.spaces.index');
-            } elseif ($request->user()->admin) {
-                return redirect()->route('admin.spaces.me');
-            }
-
+        if (Auth::user()) {
             return redirect()->route('account.dashboard');
         }
 
-        return view('account.login', config('app.show_login_counter_temp') ? [
+        return view('account.login', [
             'count' => Account::where('activated', true)->count()
-        ]: []);
+        ]);
     }
 
     public function authenticate(Request $request)
@@ -63,7 +57,7 @@ class AuthenticateController extends Controller
         }
 
         if (!$account) {
-            return redirect()->back()->withErrors(['authentication' => __('Incorrect username or password')]);
+            return redirect()->back()->withErrors(['authentication' => 'Wrong username or password']);
         }
 
         // Try out the passwords
@@ -73,11 +67,34 @@ class AuthenticateController extends Controller
                 bchash($account->username, $account->resolvedRealm, $request->get('password'), $password->algorithm)
             )) {
                 Auth::login($account);
-                return redirect()->route('account.home');
+                return redirect()->route('account.dashboard');
             }
         }
 
-        return redirect()->back()->withErrors(['authentication' => __('Incorrect username or password')]);
+        return redirect()->back()->withErrors(['authentication' => 'Wrong username or password']);
+    }
+
+    /**
+     * Deprecated
+     */
+    public function validateEmail(Request $request, string $code)
+    {
+        $request->merge(['code' => $code]);
+        $request->validate(['code' => 'required|size:' . self::$emailCodeSize]);
+
+        $account = Account::where('confirmation_key', $code)->first();
+
+        if (!$account) {
+            return redirect()->route('account.login');
+        }
+
+        $account->confirmation_key = null;
+        $account->activated = true;
+        $account->save();
+
+        Auth::login($account);
+
+        return redirect()->route('account.dashboard');
     }
 
     public function loginAuthToken(Request $request, ?string $token = null)
@@ -103,7 +120,7 @@ class AuthenticateController extends Controller
 
             $authToken->delete();
 
-            return redirect()->route('account.home');
+            return redirect()->route('account.dashboard');
         }
 
         return view('account.authenticate.auth_token', [

flexiapi/app/Http/Controllers/Account/DeviceController.php

@@ -21,13 +21,13 @@ namespace App\Http\Controllers\Account;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
-use App\Libraries\FlexisipRedisConnector;
+use App\Libraries\FlexisipConnector;
 
 class DeviceController extends Controller
 {
     public function index(Request $request)
     {
-        $connector = new FlexisipRedisConnector;
+        $connector = new FlexisipConnector;
 
         return view(
             'account.device.index',
@@ -40,7 +40,7 @@ class DeviceController extends Controller
 
     public function delete(Request $request, string $uuid)
     {
-        $connector = new FlexisipRedisConnector;
+        $connector = new FlexisipConnector;
 
         return view(
             'account.device.delete',
@@ -54,7 +54,7 @@ class DeviceController extends Controller
 
     public function destroy(Request $request)
     {
-        $connector = new FlexisipRedisConnector;
+        $connector = new FlexisipConnector;
         $connector->deleteDevice($request->user()->identifier, $request->get('uuid'));
 
         return redirect()->route('account.device.index');

flexiapi/app/Http/Controllers/Account/EmailController.php

@@ -60,7 +60,7 @@ class EmailController extends Controller
         }
 
         return redirect()->route('account.email.change')->withErrors([
-            'code' => __('The code is not valid')
+            'code' => 'The code entered was not valid'
         ]);
     }
 }

flexiapi/app/Http/Controllers/Account/FileController.php

@@ -1,32 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Account;
-
-use App\AccountFile;
-use App\Http\Controllers\Controller;
-use Illuminate\Support\Facades\Storage;
-
-class FileController extends Controller
-{
-    public function show(string $uuid, string $name)
-    {
-        $file = AccountFile::findOrFail($uuid);
-
-        if ($file->name != $name) {
-            abort(404);
-        }
-
-        return Storage::get($file->path);
-    }
-
-    public function download(string $uuid, string $name)
-    {
-        $file = AccountFile::findOrFail($uuid);
-
-        if ($file->name != $name) {
-            abort(404);
-        }
-
-        return Storage::download($file->path);
-    }
-}

flexiapi/app/Http/Controllers/Account/PasswordController.php

@@ -21,9 +21,11 @@ namespace App\Http\Controllers\Account;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Auth;
+use Illuminate\Support\Facades\Mail;
 use Illuminate\Support\Facades\Log;
 
+use App\Mail\ConfirmedRegistration;
+
 class PasswordController extends Controller
 {
     public function show(Request $request)
@@ -47,10 +49,16 @@ class PasswordController extends Controller
 
         if ($account->passwords()->count() > 0) {
             Log::channel('events')->info('Web: Password changed', ['id' => $account->identifier]);
-            return redirect()->route('account.logout');
+
+            return redirect()->route('account.dashboard');
         }
 
         Log::channel('events')->info('Web: Password set for the first time', ['id' => $account->identifier]);
-        return redirect()->route('account.logout');
+
+        if (!empty($account->email)) {
+            Mail::to($account)->send(new ConfirmedRegistration($account));
+        }
+
+        return redirect()->route('account.dashboard');
     }
 }

flexiapi/app/Http/Controllers/Account/PhoneController.php

@@ -60,7 +60,7 @@ class PhoneController extends Controller
         }
 
         return redirect()->route('account.phone.change')->withErrors([
-            'code' => __('The code is not valid')
+            'code' => 'The code entered was not valid'
         ]);
     }
 }

flexiapi/app/Http/Controllers/Account/ProvisioningController.php

@@ -27,7 +27,6 @@ use Illuminate\Support\Str;
 
 use Endroid\QrCode\Builder\Builder;
 use Endroid\QrCode\Encoding\Encoding;
-use Endroid\QrCode\ErrorCorrectionLevel;
 use Endroid\QrCode\ErrorCorrectionLevel\ErrorCorrectionLevelHigh;
 use Endroid\QrCode\Writer\PngWriter;
 
@@ -40,13 +39,6 @@ class ProvisioningController extends Controller
         ]);
     }
 
-    public function wizard(Request $request, string $provisioningToken)
-    {
-        return view('provisioning.wizard', [
-            'token' => $provisioningToken
-        ]);
-    }
-
     public function qrcode(Request $request, string $provisioningToken)
     {
         $account = Account::withoutGlobalScopes()
@@ -58,6 +50,8 @@ class ProvisioningController extends Controller
             })
             ->firstOrFail();
 
+        if ($account->activationExpired()) abort(404);
+
         $params = ['provisioning_token' => $provisioningToken];
 
         if ($request->has('reset_password')) {
@@ -70,7 +64,7 @@ class ProvisioningController extends Controller
             ->writer(new PngWriter())
             ->data($url)
             ->encoding(new Encoding('UTF-8'))
-            ->errorCorrectionLevel(ErrorCorrectionLevel::High)
+            ->errorCorrectionLevel(new ErrorCorrectionLevelHigh())
             ->size(300)
             ->margin(10)
             ->build();
@@ -133,12 +127,8 @@ class ProvisioningController extends Controller
             })
             ->firstOrFail();
 
-        if ($provisioningToken != $account->provisioning_token) {
-            return abort(404);
-        }
-
-        if ($account->currentProvisioningToken->expired()) {
-            return abort(410, 'Expired');
+        if ($account->activationExpired() || ($provisioningToken != $account->provisioning_token)) {
+            abort(404);
         }
 
         $account->activated = true;
@@ -151,7 +141,7 @@ class ProvisioningController extends Controller
     private function checkProvisioningHeader(Request $request)
     {
         if (!$request->hasHeader('x-linphone-provisioning')
-          && $request->space->provisioning_use_linphone_provisioning_header) {
+          && config('app.provisioning_use_x_linphone_provisioning_header')) {
             abort(400, 'x-linphone-provisioning header is missing');
         }
     }
@@ -172,8 +162,11 @@ class ProvisioningController extends Controller
 
         $dom->appendChild($config);
 
-        if ($request->space?->custom_provisioning_entries) {
-            $rc = parse_ini_string($request->space->custom_provisioning_entries, true);
+        // Default RC file handling
+        $rcFile = config('app.provisioning_rc_file');
+
+        if (file_exists($rcFile)) {
+            $rc = parse_ini_file($rcFile, true);
 
             foreach ($rc as $sectionName => $values) {
                 $section = $dom->createElement('section');
@@ -189,44 +182,6 @@ class ProvisioningController extends Controller
             }
         }
 
-        $remoteContactDirectoryCounter = 0;
-        $authInfoIndex = 0;
-
-        // CardDav servers
-
-        if ($request->space?->carddavServers) {
-            foreach ($request->space->carddavServers as $carddavServer) {
-                $carddavServer->getProvisioningSection($config, $remoteContactDirectoryCounter);
-                $remoteContactDirectoryCounter++;
-            }
-        }
-
-        if ($account) {
-            foreach ($account->carddavServers as $carddavServer) {
-                $section = $dom->createElement('section');
-                $section->setAttribute('name', 'auth_info_' . $authInfoIndex);
-                $config->appendChild($section);
-
-                $entry = $dom->createElement('entry', $carddavServer->pivot->username);
-                $entry->setAttribute('name', 'username');
-                $section->appendChild($entry);
-
-                $entry = $dom->createElement('entry', $carddavServer->pivot->realm);
-                $entry->setAttribute('name', 'realm');
-                $section->appendChild($entry);
-
-                $entry = $dom->createElement('entry', $carddavServer->pivot->password);
-                $entry->setAttribute('name', 'ha1');
-                $section->appendChild($entry);
-
-                $entry = $dom->createElement('entry', $carddavServer->pivot->algorithm);
-                $entry->setAttribute('name', 'algorithm');
-                $section->appendChild($entry);
-
-                $authInfoIndex++;
-            }
-        }
-
         // Password reset
         if ($account && $request->has('reset_password')) {
             $account->updatePassword(Str::random(10));
@@ -242,41 +197,11 @@ class ProvisioningController extends Controller
         $config->appendChild($section);
 
         if ($account) {
-            $ui = $xpath->query("//section[@name='ui']")->item(0);
-
-            if ($ui == null && $account->space) {
-                $section = $dom->createElement('section');
-                $section->setAttribute('name', 'ui');
-
-                foreach ([
-                    'super',
-                    'disable_chat_feature',
-                    'disable_meetings_feature',
-                    'disable_broadcast_feature',
-                    'hide_settings',
-                    'hide_account_settings',
-                    'disable_call_recordings_feature',
-                    'only_display_sip_uri_username',
-                    'assistant_hide_create_account',
-                    'assistant_disable_qr_code',
-                    'assistant_hide_third_party_account',
-                    'max_account',
-                ] as $key) {
-                    // Cast the booleans into integers
-                    $entry = $dom->createElement('entry', (int)$account->space->$key);
-                    $entry->setAttribute('name', $key);
-                    $section->appendChild($entry);
-                }
-
-                $config->appendChild($section);
-            }
-
             $section = $xpath->query("//section[@name='proxy_0']")->item(0);
 
             if ($section == null) {
                 $section = $dom->createElement('section');
                 $section->setAttribute('name', 'proxy_0');
-                $config->appendChild($section);
             }
 
             $entry = $dom->createElement('entry', $account->fullIdentifier);
@@ -288,7 +213,10 @@ class ProvisioningController extends Controller
                 provisioningProxyHook($section, $request, $account);
             }
 
+            $config->appendChild($section);
+
             $passwords = $account->passwords()->get();
+            $authInfoIndex = 0;
 
             foreach ($passwords as $password) {
                 $section = $xpath->query("//section[@name='auth_info_" . $authInfoIndex . "']")->item(0);
@@ -296,7 +224,6 @@ class ProvisioningController extends Controller
                 if ($section == null) {
                     $section = $dom->createElement('section');
                     $section->setAttribute('name', 'auth_info_' . $authInfoIndex);
-                    $config->appendChild($section);
                 }
 
                 $entry = $dom->createElement('entry', $account->username);
@@ -324,6 +251,8 @@ class ProvisioningController extends Controller
                     provisioningAuthHook($section, $request, $password);
                 }
 
+                $config->appendChild($section);
+
                 $authInfoIndex++;
             }
         }
@@ -334,7 +263,7 @@ class ProvisioningController extends Controller
         }
 
         // Overwrite all the entries
-        if ($request->space?->custom_provisioning_overwrite_all) {
+        if (config('app.provisioning_overwrite_all')) {
             $xpath = new \DOMXpath($dom);
             $entries = $xpath->query("//section/entry");
             if (!is_null($entries)) {

flexiapi/app/Http/Controllers/Account/RecoveryController.php

@@ -20,16 +20,12 @@
 namespace App\Http\Controllers\Account;
 
 use App\Account;
-use App\AccountRecoveryToken;
 use Illuminate\Http\Request;
 use App\Http\Controllers\Controller;
 use App\Services\AccountService;
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Crypt;
 
-use Illuminate\Support\Str;
-use App\Http\Controllers\Account\AuthenticateController as WebAuthenticateController;
-
 class RecoveryController extends Controller
 {
     public function showEmail(Request $request)
@@ -40,16 +36,10 @@ class RecoveryController extends Controller
         ]);
     }
 
-    public function showPhone(Request $request, string $accountRecoveryToken)
+    public function showPhone(Request $request)
     {
-        $accountRecoveryToken = AccountRecoveryToken::where('token', $accountRecoveryToken)
-            ->where('used', false)
-            ->firstOrFail();
-
         return view('account.recovery.show', [
             'method' => 'phone',
-            'account_recovery_token' => $accountRecoveryToken->token,
-            'phone' => $request->get('phone'),
             'domain' => resolveDomain($request)
         ]);
     }
@@ -59,8 +49,7 @@ class RecoveryController extends Controller
         $rules = [
             'email' => 'required_without:phone|email|exists:accounts,email',
             'phone' => 'required_without:email|starts_with:+',
-            'h-captcha-response'  => captchaConfigured() ? 'required_with:email|HCaptcha' : '',
-            'account_recovery_token' => 'required_with:phone',
+            'h-captcha-response'  => captchaConfigured() ? 'required|HCaptcha' : '',
         ];
 
         $account = null;
@@ -97,25 +86,17 @@ class RecoveryController extends Controller
         }
 
         if (!$account) {
-            return redirect()->back()->withErrors(['identifier' => __("The account doesn't exists")]);
+            return redirect()->back()->withErrors(['identifier' => 'The account doesn\'t exists']);
         }
 
         if ($account->failedRecentRecovery()) {
-            return redirect()->back()->withErrors(['code' => __('Account recovered recently, try again later')]);
+            return redirect()->back()->withErrors(['code' => 'Account recovered recently, try again later']);
         }
 
         if ($request->get('email')) {
-            $account = (new AccountService)->recoverByEmail($account, $request->get('email'));
+            $account = (new AccountService)->recoverByEmail($account);
         } elseif ($request->get('phone')) {
-            $accountRecoveryToken = AccountRecoveryToken::where('token', $request->get('account_recovery_token'))
-                ->where('used', false)
-                ->first();
-
-            if (!$accountRecoveryToken) {
-                abort(403, 'Wrong Account Recovery Token');
-            }
-
-            $account = (new AccountService)->recoverByPhone($account, $request->get('phone'), $accountRecoveryToken);
+            $account = (new AccountService)->recoverByPhone($account);
         }
 
         return view('account.recovery.confirm', [
@@ -139,19 +120,11 @@ class RecoveryController extends Controller
 
         $account = Account::where('id', Crypt::decryptString($request->get('account_id')))->firstOrFail();
 
-        if ($account->currentRecoveryCode->expired()) {
-            return redirect()->route($request->get('method') == 'phone'
-                ? 'account.recovery.show.phone'
-                : 'account.recovery.show.email')->withErrors([
-                'code' => __('The code has expired')
-            ]);
-        }
-
         if ($account->recovery_code != $code) {
             return redirect()->route($request->get('method') == 'phone'
                 ? 'account.recovery.show.phone'
                 : 'account.recovery.show.email')->withErrors([
-                'code' => 'The code is not valid'
+                'code' => 'The code entered was not valid, try again later'
             ]);
         }
 

flexiapi/app/Http/Controllers/Account/ResetPasswordEmailController.php

@@ -1,37 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Account;
-
-use App\ResetPasswordEmailToken;
-use App\Http\Controllers\Controller;
-use Illuminate\Http\Request;
-
-class ResetPasswordEmailController extends Controller
-{
-    public function change(string $token)
-    {
-        $token = ResetPasswordEmailToken::where('token', $token)->firstOrFail();
-
-        return view('account.password_reset', [
-            'token' => $token
-        ]);
-    }
-
-    public function reset(Request $request)
-    {
-        $request->validate([
-            'token' => 'required|size:16',
-            'password' => 'required|min:8|confirmed',
-            'h-captcha-response'  => captchaConfigured() ? 'required|HCaptcha' : ''
-        ]);
-
-        $token = ResetPasswordEmailToken::where('token', $request->get('token'))->firstOrFail();
-
-        if ($token->offed()) abort(403);
-
-        $token->account->updatePassword($request->get('password'));
-        $token->consume();
-
-        return view('account.password_changed');
-    }
-}

flexiapi/app/Http/Controllers/Admin/Account/CardDavCredentialsController.php

@@ -1,104 +0,0 @@
-<?php
-/*
-    Flexisip Account Manager is a set of tools to manage SIP accounts.
-    Copyright (C) 2023 Belledonne Communications SARL, All rights reserved.
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Affero General Public License as
-    published by the Free Software Foundation, either version 3 of the
-    License, or (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU Affero General Public License for more details.
-
-    You should have received a copy of the GNU Affero General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-namespace App\Http\Controllers\Admin\Account;
-
-use App\Account;
-use App\AccountCardDavCredentials;
-use App\Http\Controllers\Controller;
-use Illuminate\Database\Query\Builder;
-use Illuminate\Http\Request;
-use Illuminate\Validation\Rule;
-use App\Http\Requests\Account\CardDavCredentials;
-
-class CardDavCredentialsController extends Controller
-{
-    public function create(int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-        $this->checkFeatureEnabled($account);
-
-        return view('admin.account.carddav.create', [
-            'account' => $account,
-            'carddavServers' => $account->remainingCardDavCredentialsCreatable
-        ]);
-    }
-
-    public function store(CardDavCredentials $request, int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-        $this->checkFeatureEnabled($account);
-
-        $request->validate([
-            'carddav_id' => ['required', Rule::exists('space_carddav_servers', 'id')->where(function (Builder $query) use ($account) {
-                return $query->where('space_id', $account->space->id);
-            })]
-        ]);
-
-        $accountCarddavCredentials = new AccountCardDavCredentials;
-        $accountCarddavCredentials->space_carddav_server_id = $request->get('carddav_id');
-        $accountCarddavCredentials->account_id = $account->id;
-        $accountCarddavCredentials->username = $request->get('username');
-        $accountCarddavCredentials->realm = $request->get('realm');
-        $accountCarddavCredentials->password = bchash(
-            $request->get('username'),
-            $request->get('realm'),
-            $request->get('password'),
-            $request->get('algorithm')
-        );
-        $accountCarddavCredentials->algorithm = $request->get('algorithm');
-        $accountCarddavCredentials->save();
-
-        return redirect()->route('admin.account.show', $account);
-    }
-
-    public function delete(int $accountId, int $cardDavId)
-    {
-        $account = Account::findOrFail($accountId);
-        $this->checkFeatureEnabled($account);
-
-        $accountCarddavCredentials = AccountCardDavCredentials::where('space_carddav_server_id', $cardDavId)
-            ->where('account_id', $account->id)
-            ->firstOrFail();
-
-        return view('admin.account.carddav.delete', [
-            'account' => $account,
-            'carddavCredentials' => $accountCarddavCredentials,
-        ]);
-    }
-
-    public function destroy(Request $request, int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-        $this->checkFeatureEnabled($account);
-
-        $accountCarddavCredentials = AccountCardDavCredentials::where('space_carddav_server_id', $request->carddav_id)
-            ->where('account_id', $account->id)
-            ->delete();
-
-        return redirect()->route('admin.account.show', $account);
-    }
-
-    private function checkFeatureEnabled(Account $account)
-    {
-        if (!$account->space->carddav_user_credentials) {
-            abort(403, 'CardDav Credentials features disabled');
-        }
-    }
-}

flexiapi/app/Http/Controllers/Admin/Account/FileController.php

@@ -1,32 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Admin\Account;
-
-use App\Account;
-use App\Http\Controllers\Controller;
-use Illuminate\Http\Request;
-
-class FileController extends Controller
-{
-    public function delete(int $accountId, string $fileId)
-    {
-        $account = Account::findOrFail($accountId);
-        $file = $account->files()->where('id', $fileId)->firstOrFail();
-
-        return view('admin.account.file.delete', [
-            'account' => $account,
-            'file' => $file
-        ]);
-    }
-
-    public function destroy(Request $request, int $accountId, string $fileId)
-    {
-        $account = Account::findOrFail($accountId);
-        $accountFile = $account->files()
-                        ->where('id', $fileId)
-                        ->firstOrFail();
-        $accountFile->delete();
-
-        return redirect()->route('admin.account.show', $account)->withFragment('#files');
-    }
-}

flexiapi/app/Http/Controllers/Admin/Account/ImportController.php

@@ -1,388 +0,0 @@
-<?php
-/*
-    Flexisip Account Manager is a set of tools to manage SIP accounts.
-    Copyright (C) 2023 Belledonne Communications SARL, All rights reserved.
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Affero General Public License as
-    published by the Free Software Foundation, either version 3 of the
-    License, or (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU Affero General Public License for more details.
-
-    You should have received a copy of the GNU Affero General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-namespace App\Http\Controllers\Admin\Account;
-
-use App\Account;
-use App\ExternalAccount;
-use App\Password;
-use App\PhoneCountry;
-use App\Space;
-use App\Http\Controllers\Controller;
-use Carbon\Carbon;
-use Illuminate\Support\Collection;
-use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Storage;
-use Illuminate\Validation\Rules\File;
-use Propaganistas\LaravelPhone\PhoneNumber;
-
-class ImportController extends Controller
-{
-    private Collection $errors;
-    private string $importDirectory = 'imported_csv';
-
-    public function __construct()
-    {
-        $this->errors = collect();
-    }
-
-    public function create(Request $request)
-    {
-        return view('admin.account.import.create', [
-            'domains' => $request->user()->superAdmin
-                ? Space::pluck('domain')
-                : [$request->user()->domain]
-        ]);
-    }
-
-    public function store(Request $request)
-    {
-        $request->validate([
-            'csv' => ['required', File::types(['csv', 'txt'])],
-            'domain' => 'required|exists:spaces,domain'
-        ]);
-
-        $domain = $request->user()->superAdmin
-            ? $request->get('domain')
-            : $request->user()->domain;
-
-        /**
-         * General formating checking
-         */
-        $csv = fopen($request->file('csv'), 'r');
-        $line = fgets($csv);
-        fclose($csv);
-
-        $lines = collect();
-        $this->errors['Wrong file format'] = "The number of columns doesn't matches the reference file. The first MUST be the same as the reference file";
-
-        $firstLine = 'Username,Password,Role,Status,Phone,Email,External Username,External Domain,External Password,External Realm, External Registrar,External Outbound Proxy,External Protocol';
-
-        if (substr($line, 0, strlen($firstLine)) == $firstLine) {
-            $lines = $this->csvToCollection($request->file('csv'));
-            unset($this->errors['Wrong file format']);
-        }
-
-        /**
-         * Error checking
-         */
-
-        // Usernames
-
-        $existingUsernames = Account::where('domain', $domain)
-            ->whereIn('username', $lines->pluck('username')->all())
-            ->pluck('username');
-
-        if ($existingUsernames->isNotEmpty()) {
-            $this->errors['Those usernames already exists'] = $existingUsernames->join(', ', ' and ');
-        }
-
-        if ($duplicates = $lines->pluck('username')->duplicates()) {
-            if ($duplicates->isNotEmpty()) {
-                $this->errors['Those usernames are declared several times'] = $duplicates->join(', ', ' and ');
-            }
-        }
-
-        if ($lines->pluck('username')->contains(function ($value) {
-            return strlen($value) < 2;
-        })) {
-            $this->errors['Some usernames are shorter than expected'] = '';
-        }
-
-        // Passwords
-
-        if ($lines->pluck('password')->contains(function ($value) {
-            return strlen($value) < 6;
-        })) {
-            $this->errors['Some passwords are shorter than expected'] = '';
-        }
-
-        // Roles
-
-        if ($lines->pluck('role')->contains(function ($value) {
-            return !in_array($value, ['admin', 'user']);
-        })) {
-            $this->errors['Some roles are not correct'] = '';
-        }
-
-        // Status
-
-        if ($lines->pluck('status')->contains(function ($value) {
-            return !in_array($value, ['active', 'inactive']);
-        })) {
-            $this->errors['Some statuses are not correct'] = '';
-        }
-
-        // Phones
-
-        $phoneCountries = PhoneCountry::where('activated', true)->get();
-
-        if ($phones = $lines->pluck('phone')->filter(function ($value) {
-            return !empty($value);
-        })->filter(function ($value) use ($phoneCountries) {
-            return !$phoneCountries->firstWhere('code', (new PhoneNumber($value))->getCountry());
-        })) {
-            if ($phones->isNotEmpty()) {
-                $this->errors['Some phone numbers are not correct'] = $phones->join(', ', ' and ');
-            }
-        }
-
-        $existingPhones = Account::whereIn('phone', $lines->pluck('phone')->all())
-            ->pluck('phone');
-
-        if ($existingPhones->isNotEmpty()) {
-            $this->errors['Those phones numbers already exists'] = $existingPhones->join(', ', ' and ');
-        }
-
-        // Emails
-
-        if ($emails = $lines->pluck('email')->filter(function ($value) {
-            return $value != '' && !filter_var($value, FILTER_VALIDATE_EMAIL);
-        })) {
-            if ($emails->isNotEmpty()) {
-                $this->errors['Some emails are not correct'] = $emails->join(', ', ' and ');
-            }
-        }
-
-        $existingEmails = Account::whereIn('email', $lines->pluck('email')->all())
-            ->pluck('email');
-
-        if ($existingEmails->isNotEmpty()) {
-            $this->errors['Those emails numbers already exists'] = $existingEmails->join(', ', ' and ');
-        }
-
-        if ($emails = $lines->pluck('email')->filter(fn (string $value) => $value != '')->duplicates()) {
-            if ($emails->isNotEmpty()) {
-                $this->errors['Those emails are declared several times'] = $emails->join(', ', ' and ');
-            }
-        }
-
-        // External account
-
-        $checkExternalUsernameDomains = collect();
-
-        foreach ($lines as $line) {
-            if ($line->external_username != null && ($line->external_password == null || $line->external_domain == null)) {
-                $this->errors['Line ' . $line->line . ': The mandatory external account columns must be filled'] = '';
-            }
-
-            if ($line->external_username != null && $line->external_password != null && $line->external_domain != null) {
-                if ($line->external_domain == $line->external_realm
-                 || $line->external_domain == $line->external_registrar
-                 || $line->external_domain == $line->external_outbound_proxy) {
-                    $this->errors['Line ' . $line->line . ': External realm, registrar or outbound proxy must be different than domain'] = '';
-                }
-
-                if (!in_array($line->external_protocol, ExternalAccount::PROTOCOLS)) {
-                    $this->errors['Line ' . $line->line . ': External protocol must be UDP, TCP or TLS'] = '';
-                }
-            }
-
-            $checkExternalUsernameDomains->push($line->external_username . ',' . $line->external_domain);
-        }
-
-        foreach ($checkExternalUsernameDomains->duplicates() as $duplicate) {
-            $this->errors['The following external account is used several times: ' . $duplicate] = '';
-        }
-
-        $filePath = $this->errors->isEmpty()
-            ? Storage::putFile($this->importDirectory, $request->file('csv'))
-            : null;
-
-        if ($filePath == false) {
-            $this->errors['The CSV file was not imported properly on the server'] = '';
-        }
-
-        return view('admin.account.import.check', [
-            'linesCount' => $lines->count(),
-            'errors' => $this->errors,
-            'domain' => $domain,
-            'filePath' => $filePath
-        ]);
-    }
-
-    public function handle(Request $request)
-    {
-        $request->validate([
-            'file_path' => 'required',
-            'domain' => 'required|exists:spaces,domain'
-        ]);
-
-        $domain = $request->user()->superAdmin
-            ? $request->get('domain')
-            : $request->user()->domain;
-
-        $lines = $this->csvToCollection(storage_path('app/' . $request->get('file_path')));
-
-        $accounts = [];
-        $now = \Carbon\Carbon::now();
-
-        $admins = $phones = $passwords = $externals = [];
-
-        $externalAlgorithm = 'MD5';
-
-        foreach ($lines as $line) {
-            if ($line->role == 'admin') {
-                array_push($admins, $line->username);
-            }
-
-            if (!empty($line->phone)) {
-                $phones[$line->username] = $line->phone;
-            }
-
-            if (!empty($line->password)) {
-                $passwords[$line->username] = $line->password;
-            }
-
-            if (!empty($line->external_username)) {
-                $externals[$line->username] = [
-                    'username' => $line->external_username,
-                    'domain' => $line->external_domain,
-                    'realm' => $line->external_realm,
-                    'registrar' => $line->external_registrar,
-                    'outbound_proxy' => $line->external_outbound_proxy,
-                    'protocol' => $line->external_protocol,
-                    'password' => bchash(
-                        $line->external_username,
-                        $line->external_realm ?? $line->external_domain,
-                        $line->external_password,
-                        $externalAlgorithm
-                    ),
-                    'algorithm' => $externalAlgorithm,
-                    'created_at' => Carbon::now(),
-                ];
-            }
-
-            array_push($accounts, [
-                'username' => $line->username,
-                'domain' => $domain,
-                'email' => $line->email,
-                'activated' => $line->status == 'active',
-                'ip_address' => '127.0.0.1',
-                'user_agent' => 'CSV Import',
-                'created_at' => $now,
-                'updated_at' => $now,
-            ]);
-        }
-
-        Account::insert($accounts);
-
-        // Set admins accounts
-        foreach ($admins as $username) {
-            $account = Account::where('username', $username)
-                ->where('domain', $domain)
-                ->first();
-            $account->admin = true;
-            $account->save();
-        }
-
-        // Set passwords
-
-        $passwordsToInsert = [];
-
-        $passwordAccounts = Account::whereIn('username', array_keys($passwords))
-            ->where('domain', $domain)
-            ->get();
-
-        $algorithm = config('app.account_default_password_algorithm');
-
-        foreach ($passwordAccounts as $passwordAccount) {
-            array_push($passwordsToInsert, [
-                'account_id' => $passwordAccount->id,
-                'password' => bchash(
-                    $passwordAccount->username,
-                    $request->space?->account_realm ?? $domain,
-                    $passwords[$passwordAccount->username],
-                    $algorithm
-                ),
-                'algorithm' => $algorithm
-            ]);
-        }
-
-        Password::insert($passwordsToInsert);
-
-        // Set external account
-
-        $externalAccountsToInsert = [];
-
-        $externalAccounts = Account::whereIn('username', array_keys($externals))
-            ->where('domain', $domain)
-            ->get();
-
-        foreach ($externalAccounts as $externalAccount) {
-            array_push($externalAccountsToInsert, [
-                'account_id' => $externalAccount->id
-            ] + $externals[$externalAccount->username]);
-        }
-
-        ExternalAccount::insert($externalAccountsToInsert);
-
-        // Set phone accounts
-        foreach ($phones as $username => $phone) {
-            $account = Account::where('username', $username)
-                ->where('domain', $domain)
-                ->first();
-            $account->phone = $phone;
-        }
-
-        return redirect()->route('admin.account.index');
-    }
-
-    private function csvToCollection($file): Collection
-    {
-        $lines = collect();
-        $csv = fopen($file, 'r');
-
-        $i = 1;
-        while (!feof($csv)) {
-            if ($line = fgetcsv($csv, 1000, ',')) {
-                if (count($line) != 13) {
-                    $this->errors['Parsing error at line ' . $i] = 'The number of columns is incorrect';
-                    $i++;
-                    continue;
-                }
-
-                $lines->push((object)[
-                    'line' => $i,
-                    'username' => !empty($line[0]) ? $line[0] : null,
-                    'password' => !empty($line[1]) ? $line[1] : null,
-                    'role' => $line[2],
-                    'status' => $line[3],
-                    'phone' => !empty($line[4]) ? $line[4] : null,
-                    'email' => $line[5],
-                    'external_username' => !empty($line[6]) ? $line[6] : null,
-                    'external_domain' => !empty($line[7]) ? $line[7] : null,
-                    'external_password' => !empty($line[8]) ? $line[8] : null,
-                    'external_realm' => !empty($line[9]) ? $line[9] : null,
-                    'external_registrar' => !empty($line[10]) ? $line[10] : null,
-                    'external_outbound_proxy' => !empty($line[11]) ? $line[11] : null,
-                    'external_protocol' => $line[12],
-                ]);
-
-                $i++;
-            }
-        }
-
-        fclose($csv);
-
-        $lines->shift();
-
-        return $lines;
-    }
-}

flexiapi/app/Http/Controllers/Admin/AccountAccountTypeController.php

@@ -17,7 +17,7 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Account;
+namespace App\Http\Controllers\Admin;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
@@ -26,7 +26,7 @@ use Illuminate\Support\Facades\Log;
 use App\Account;
 use App\AccountType;
 
-class AccountTypeController extends Controller
+class AccountAccountTypeController extends Controller
 {
     public function create(int $id)
     {
@@ -55,7 +55,7 @@ class AccountTypeController extends Controller
 
         Log::channel('events')->info('Web Admin: Account type attached', ['id' => $account->identifier, 'type_id' => $request->get('account_type_id')]);
 
-        return redirect()->route('admin.account.show', $account)->withFragment('#types');
+        return redirect()->route('admin.account.edit', $account);
     }
 
     public function destroy(Request $request, int $id, int $typeId)
@@ -66,6 +66,6 @@ class AccountTypeController extends Controller
 
         Log::channel('events')->info('Web Admin: Account type detached', ['id' => $account->identifier, 'type_id' => $request->get('account_type_id')]);
 
-        return redirect()->route('admin.account.show', $account)->withFragment('#types');
+        return redirect()->route('admin.account.edit', $account);
     }
 }

flexiapi/app/Http/Controllers/Admin/AccountActionController.php

@@ -17,7 +17,7 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Account;
+namespace App\Http\Controllers\Admin;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
@@ -27,7 +27,7 @@ use App\Account;
 use App\AccountAction;
 use App\Rules\NoUppercase;
 
-class ActionController extends Controller
+class AccountActionController extends Controller
 {
     public function create(int $accountId)
     {
@@ -56,7 +56,7 @@ class ActionController extends Controller
 
         Log::channel('events')->info('Web Admin: Account action created', ['id' => $account->identifier, 'action' => $accountAction->key]);
 
-        return redirect()->route('admin.account.show', $accountAction->account)->withFragment('#actions');
+        return redirect()->route('admin.account.edit', $accountAction->account);
     }
 
     public function edit(int $accountId, int $actionId)
@@ -91,7 +91,7 @@ class ActionController extends Controller
 
         Log::channel('events')->info('Web Admin: Account action updated', ['id' => $account->identifier, 'action' => $accountAction->key]);
 
-        return redirect()->route('admin.account.show', $account)->withFragment('#actions');
+        return redirect()->route('admin.account.edit', $account);
     }
 
     public function delete(int $accountId, int $actionId)
@@ -99,7 +99,6 @@ class ActionController extends Controller
         $account = Account::findOrFail($accountId);
 
         return view('admin.account.action.delete', [
-            'account' => $account,
             'action' => $account->actions()
                                 ->where('id', $actionId)
                                 ->firstOrFail()
@@ -117,6 +116,6 @@ class ActionController extends Controller
 
         Log::channel('events')->info('Web Admin: Account action deleted', ['id' => $accountAction->account->identifier, 'action_id' => $accountAction->key]);
 
-        return redirect()->route('admin.account.show', $accountAction->account)->withFragment('#actions');
+        return redirect()->route('admin.account.edit', $accountAction->account);
     }
 }

flexiapi/app/Http/Controllers/Admin/AccountActivityController.php

@@ -17,13 +17,13 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Account;
+namespace App\Http\Controllers\Admin;
 
 use App\Http\Controllers\Controller;
 
 use App\Account;
 
-class ActivityController extends Controller
+class AccountActivityController extends Controller
 {
     public function index(int $accountId)
     {

flexiapi/app/Http/Controllers/Admin/AccountContactController.php

@@ -17,31 +17,16 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Account;
+namespace App\Http\Controllers\Admin;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Log;
 
 use App\Account;
-use App\ContactsList;
 
-class ContactController extends Controller
+class AccountContactController extends Controller
 {
-    public function index(int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-
-        return view('admin.account.contact.index', [
-            'account' => $account,
-            'contacts_lists' => ContactsList::whereNotIn('id', function ($query) use ($accountId) {
-                $query->select('contacts_list_id')
-                    ->from('account_contacts_list')
-                    ->where('account_id', $accountId);
-            })->withCount('contacts')->get()
-        ]);
-    }
-
     public function create(int $accountId)
     {
         $account = Account::findOrFail($accountId);
@@ -62,7 +47,7 @@ class ContactController extends Controller
 
         if (!$contact) {
             return redirect()->back()->withErrors([
-                'sip' => __("The contact doesn't exists")
+                'sip' => 'The contact SIP address doesn\'t exists'
             ]);
         }
 
@@ -71,7 +56,7 @@ class ContactController extends Controller
 
         Log::channel('events')->info('Web Admin: Account contact added', ['id' => $account->identifier, 'contact' => $contact->identifier]);
 
-        return redirect()->route('admin.account.contact.index', $account);
+        return redirect()->route('admin.account.edit', $account);
     }
 
     public function delete(int $accountId, int $contactId)
@@ -94,6 +79,6 @@ class ContactController extends Controller
 
         Log::channel('events')->info('Web Admin: Account contact removed', ['id' => $account->identifier, 'contact' => $contact->identifier]);
 
-        return redirect()->route('admin.account.contact.index', $account);
+        return redirect()->route('admin.account.edit', $account);
     }
 }

flexiapi/app/Http/Controllers/Admin/AccountController.php

@@ -27,9 +27,8 @@ use App\Account;
 use App\ContactsList;
 use App\Http\Requests\Account\Create\Web\AsAdminRequest;
 use App\Http\Requests\Account\Update\Web\AsAdminRequest as WebAsAdminRequest;
-use App\Libraries\FlexisipRedisConnector;
 use App\Services\AccountService;
-use App\Space;
+use App\SipDomain;
 
 class AccountController extends Controller
 {
@@ -40,7 +39,8 @@ class AccountController extends Controller
             'order_sort' => 'in:asc,desc',
         ]);
 
-        $accounts = Account::orderBy($request->get('order_by', 'updated_at'), $request->get('order_sort', 'desc'));
+        $accounts = Account::with('contactsLists')
+            ->orderBy($request->get('order_by', 'updated_at'), $request->get('order_sort', 'desc'));
 
         if ($request->has('search')) {
             $accounts = $accounts->where('username', 'like', '%' . $request->get('search') . '%');
@@ -61,9 +61,6 @@ class AccountController extends Controller
         }
 
         return view('admin.account.index', [
-            'space' => (!$request->user()->superAdmin)
-                ? $request->user()->space
-                : null,
             'domains' => Account::groupBy('domain')->pluck('domain'),
             'contacts_lists' => ContactsList::all()->pluck('title', 'id'),
             'accounts' => $accounts->paginate(20)->appends($request->query()),
@@ -75,33 +72,13 @@ class AccountController extends Controller
         return redirect()->route('admin.account.index', $request->except('_token', 'query'));
     }
 
-    public function show(Request $request, int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-
-        return view('admin.account.show', [
-            'account' => $account,
-            'devices' => (new FlexisipRedisConnector)->getDevices($account->identifier)
-        ]);
-    }
-
     public function create(Request $request)
     {
-        $account = new Account;
-
-        if ($request->has('admin')) {
-            $account->admin = true;
-        }
-
-        if ($request->has('domain')) {
-            $account->domain = $request->get('domain');
-        }
-
         return view('admin.account.create_edit', [
-            'account' => $account,
+            'account' => new Account,
             'domains' => $request->user()?->superAdmin
-                ? Space::notFull()->get()
-                : Space::where('domain', $request->user()->domain)->get(),
+                ? SipDomain::all()
+                : SipDomain::where('domain', $request->user()->domain)->get(),
             'protocols' => [null => 'None'] + Account::$dtmfProtocols
         ]);
     }
@@ -112,7 +89,7 @@ class AccountController extends Controller
 
         Log::channel('events')->info('Web Admin: Account created', ['id' => $account->identifier]);
 
-        return redirect()->route('admin.account.show', $account);
+        return redirect()->route('admin.account.edit', $account->id);
     }
 
     public function edit(Request $request, int $accountId)
@@ -121,10 +98,15 @@ class AccountController extends Controller
 
         return view('admin.account.create_edit', [
             'account' => $account,
-            'protocols' => [null => __('Empty')] + Account::$dtmfProtocols,
+            'protocols' => [null => 'None'] + Account::$dtmfProtocols,
             'domains' => $request->user()?->superAdmin
-                ? Space::all()
-                : Space::where('domain', $account->domain)->get(),
+                ? SipDomain::all()
+                : SipDomain::where('domain', $account->domain)->get(),
+            'contacts_lists' => ContactsList::whereNotIn('id', function ($query) use ($accountId) {
+                $query->select('contacts_list_id')
+                    ->from('account_contacts_list')
+                    ->where('account_id', $accountId);
+            })->get()
         ]);
     }
 
@@ -134,7 +116,7 @@ class AccountController extends Controller
 
         Log::channel('events')->info('Web Admin: Account updated', ['id' => $account->identifier]);
 
-        return redirect()->route('admin.account.show', $accountId);
+        return redirect()->route('admin.account.edit', $accountId);
     }
 
     public function provision(int $accountId)
@@ -178,7 +160,7 @@ class AccountController extends Controller
         $account->contactsLists()->detach([$request->get('contacts_list_id')]);
         $account->contactsLists()->attach([$request->get('contacts_list_id')]);
 
-        return redirect()->route('admin.account.contact.index', $accountId)->withFragment('#contacts_lists');
+        return redirect()->route('admin.account.edit', $accountId)->withFragment('#contacts_lists');
     }
 
     public function contactsListRemove(Request $request, int $accountId)
@@ -186,6 +168,6 @@ class AccountController extends Controller
         $account = Account::findOrFail($accountId);
         $account->contactsLists()->detach([$request->get('contacts_list_id')]);
 
-        return redirect()->route('admin.account.contact.index', $accountId)->withFragment('#contacts_lists');
+        return redirect()->route('admin.account.edit', $accountId)->withFragment('#contacts_lists');
     }
 }

flexiapi/app/Http/Controllers/Admin/AccountDeviceController.php

@@ -17,18 +17,18 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Account;
+namespace App\Http\Controllers\Admin;
 
 use App\Account;
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
-use App\Libraries\FlexisipRedisConnector;
+use App\Libraries\FlexisipConnector;
 
-class DeviceController extends Controller
+class AccountDeviceController extends Controller
 {
     public function index(int $accountId)
     {
-        $connector = new FlexisipRedisConnector;
+        $connector = new FlexisipConnector;
         $account = Account::findOrFail($accountId);
 
         return view(
@@ -42,14 +42,14 @@ class DeviceController extends Controller
 
     public function delete(int $accountId, string $uuid)
     {
-        $connector = new FlexisipRedisConnector;
+        $connector = new FlexisipConnector;
         $account = Account::findOrFail($accountId);
 
         return view(
             'admin.account.device.delete',
             [
                 'account' => $account,
-                'device' => $connector->getDevices($account->identifier)
+                'device' =>  $connector->getDevices($account->identifier)
                     ->where('uuid', $uuid)->first()
             ]
         );
@@ -57,11 +57,11 @@ class DeviceController extends Controller
 
     public function destroy(Request $request, int $accountId)
     {
-        $connector = new FlexisipRedisConnector;
+        $connector = new FlexisipConnector;
         $account = Account::findOrFail($accountId);
 
         $connector->deleteDevice($account->identifier, $request->get('uuid'));
 
-        return redirect()->route('admin.account.show', $account);
+        return redirect()->route('admin.account.device.index', $account);
     }
 }

flexiapi/app/Http/Controllers/Admin/AccountDictionaryController.php

@@ -17,7 +17,7 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Account;
+namespace App\Http\Controllers\Admin;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
@@ -25,8 +25,18 @@ use Illuminate\Http\Request;
 use App\Account;
 use App\AccountDictionaryEntry;
 
-class DictionaryController extends Controller
+class AccountDictionaryController extends Controller
 {
+    public function index(int $accountId)
+    {
+        return view(
+            'admin.account.dictionary.index',
+            [
+                'account' => Account::findOrFail($accountId)
+            ]
+        );
+    }
+
     public function create(int $accountId)
     {
         return view('admin.account.dictionary.create_edit', [
@@ -51,7 +61,7 @@ class DictionaryController extends Controller
             accountServiceAccountEditedHook($request, $account);
         }
 
-        return redirect()->route('admin.account.show', $account);
+        return redirect()->route('admin.account.dictionary.index', $account->id);
     }
 
     public function edit(int $accountId, string $key)
@@ -81,7 +91,7 @@ class DictionaryController extends Controller
             accountServiceAccountEditedHook($request, $account);
         }
 
-        return redirect()->route('admin.account.show', $account);
+        return redirect()->route('admin.account.dictionary.index', $account->id);
     }
 
     public function delete(int $accountId, string $key)
@@ -92,7 +102,7 @@ class DictionaryController extends Controller
             'admin.account.dictionary.delete',
             [
                 'account' => $account,
-                'entry' => $account->dictionaryEntries()->where('key', $key)->firstOrFail()
+                'entry' =>  $account->dictionaryEntries()->where('key', $key)->firstOrFail()
             ]
         );
     }
@@ -102,6 +112,6 @@ class DictionaryController extends Controller
         $account = Account::findOrFail($accountId);
         $account->dictionaryEntries()->where('key', $request->get('key'))->delete();
 
-        return redirect()->route('admin.account.show', $account);
+        return redirect()->route('admin.account.dictionary.index', $account);
     }
 }

flexiapi/app/Http/Controllers/Admin/AccountImportController.php

@@ -0,0 +1,241 @@
+<?php
+/*
+    Flexisip Account Manager is a set of tools to manage SIP accounts.
+    Copyright (C) 2023 Belledonne Communications SARL, All rights reserved.
+
+    This program is free software: you can redistribute it and/or modify
+    it under the terms of the GNU Affero General Public License as
+    published by the Free Software Foundation, either version 3 of the
+    License, or (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU Affero General Public License for more details.
+
+    You should have received a copy of the GNU Affero General Public License
+    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+namespace App\Http\Controllers\Admin;
+
+use App\Account;
+use App\Http\Controllers\Controller;
+use Illuminate\Support\Collection;
+use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Storage;
+use Illuminate\Validation\Rules\File;
+
+class AccountImportController extends Controller
+{
+    private Collection $errors;
+    private string $importDirectory = 'imported_csv';
+
+    public function __construct()
+    {
+        $this->errors = collect();
+    }
+
+    public function create(Request $request)
+    {
+        return view('admin.account.import.create', [
+            'domains' => Account::select('domain')->distinct()->get()->pluck('domain')
+        ]);
+    }
+
+    public function store(Request $request)
+    {
+        $request->validate([
+            'csv' => ['required', File::types(['csv', 'txt'])],
+            'domain' => 'required|exists:accounts'
+        ]);
+
+        $lines = $this->csvToCollection($request->file('csv'));
+
+        /**
+         * Error checking
+         */
+
+        // Usernames
+
+        $existingUsernames = Account::where('domain', $request->get('domain'))
+            ->whereIn('username', $lines->pluck('username')->all())
+            ->pluck('username');
+
+        if ($existingUsernames->isNotEmpty()) {
+            $this->errors['Those usernames already exists'] = $existingUsernames->join(', ', ' and ');
+        }
+
+        if ($duplicates = $lines->pluck('username')->duplicates()) {
+            if ($duplicates->isNotEmpty()) {
+                $this->errors['Those usernames are declared several times'] = $duplicates->join(', ', ' and ');
+            }
+        }
+
+        if ($lines->pluck('username')->contains(function ($value) {
+            return strlen($value) < 2;
+        })) {
+            $this->errors['Some usernames are shorter than expected'] = '';
+        }
+
+        // Passwords
+
+        if ($lines->pluck('password')->contains(function ($value) {
+            return strlen($value) < 6;
+        })) {
+            $this->errors['Some passwords are shorter than expected'] = '';
+        }
+
+        // Roles
+
+        if ($lines->pluck('role')->contains(function ($value) {
+            return !in_array($value, ['admin', 'user']);
+        })) {
+            $this->errors['Some roles are not correct'] = '';
+        }
+
+        // Status
+
+        if ($lines->pluck('status')->contains(function ($value) {
+            return !in_array($value, ['active', 'inactive']);
+        })) {
+            $this->errors['Some status are not correct'] = '';
+        }
+
+        // Phones
+
+        if ($phones = $lines->pluck('phone')->filter(function ($value) {
+            return strlen($value) > 2 && substr($value, 0, 1) != '+';
+        })) {
+            if ($phones->isNotEmpty()) {
+                $this->errors['Some phone numbers are not correct'] = $phones->join(', ', ' and ');
+            }
+        }
+
+        $existingPhones = Account::whereIn('phone', $lines->pluck('phone')->all())
+            ->pluck('phone');
+
+        if ($existingPhones->isNotEmpty()) {
+            $this->errors['Those phones numbers already exists'] = $existingPhones->join(', ', ' and ');
+        }
+
+        // Emails
+
+        if ($emails = $lines->pluck('email')->filter(function ($value) {
+            return !filter_var($value, FILTER_VALIDATE_EMAIL);
+        })) {
+            if ($emails->isNotEmpty()) {
+                $this->errors['Some emails are not correct'] = $emails->join(', ', ' and ');
+            }
+        }
+
+        $existingEmails = Account::whereIn('email', $lines->pluck('email')->all())
+            ->pluck('email');
+
+        if ($existingEmails->isNotEmpty()) {
+            $this->errors['Those emails numbers already exists'] = $existingEmails->join(', ', ' and ');
+        }
+
+        if ($emails = $lines->pluck('email')->duplicates()) {
+            if ($emails->isNotEmpty()) {
+                $this->errors['Those emails are declared several times'] = $emails->join(', ', ' and ');
+            }
+        }
+
+        $filePath = $this->errors->isEmpty()
+            ? Storage::putFile($this->importDirectory, $request->file('csv'))
+            : null;
+
+        return view('admin.account.import.check', [
+            'linesCount' => $lines->count(),
+            'errors' => $this->errors,
+            'domain' => $request->get('domain'),
+            'filePath' => $filePath
+        ]);
+    }
+
+    public function handle(Request $request)
+    {
+        $request->validate([
+            'file_path' => 'required',
+            'domain' => 'required|exists:accounts'
+        ]);
+
+        $lines = $this->csvToCollection(storage_path('app/' . $request->get('file_path')));
+
+        $accounts = [];
+        $now = \Carbon\Carbon::now();
+
+        $admins = $phones = [];
+
+        foreach ($lines as $line) {
+            if ($line->role == 'admin') {
+                array_push($admins, $line->username);
+            }
+
+            if (!empty($line->phone)) {
+                $phones[$line->username] = $line->phone;
+            }
+
+            array_push($accounts, [
+                'username' => $line->username,
+                'domain' => $request->get('domain'),
+                'email' => $line->email,
+                'activated' => $line->status == 'active',
+                'ip_address' => '127.0.0.1',
+                'user_agent' => 'CSV Import',
+                'created_at' => $now,
+                'updated_at' => $now,
+            ]);
+        }
+
+        Account::insert($accounts);
+
+        // Set admins accounts
+        foreach ($admins as $username) {
+            $account = Account::where('username', $username)
+                ->where('domain', $request->get('domain'))
+                ->first();
+            $account->admin = true;
+        }
+
+        // Set admins accounts
+        foreach ($phones as $username => $phone) {
+            $account = Account::where('username', $username)
+                ->where('domain', $request->get('domain'))
+                ->first();
+            $account->phone = $phone;
+        }
+
+        return redirect()->route('admin.account.index');
+    }
+
+    private function csvToCollection($file): Collection
+    {
+        $lines = collect();
+        $csv = fopen($file, 'r');
+
+        $i = 1;
+        while (!feof($csv)) {
+            if ($line = fgetcsv($csv, 1000, ',')) {
+                $lines->push((object)[
+                    'line' => $i,
+                    'username' => $line[0],
+                    'password' => $line[1],
+                    'role' => $line[2],
+                    'status' => $line[3],
+                    'phone' => $line[4],
+                    'email' => $line[5],
+                ]);
+
+                $i++;
+            }
+        }
+
+        fclose($csv);
+
+        $lines->shift();
+
+        return $lines;
+    }
+}

flexiapi/app/Http/Controllers/Admin/AccountStatisticsController.php

@@ -17,7 +17,7 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Account;
+namespace App\Http\Controllers\Admin;
 
 use App\Account;
 use App\Http\Controllers\Controller;
@@ -26,7 +26,7 @@ use App\StatisticsCall;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\DB;
 
-class StatisticsController extends Controller
+class AccountStatisticsController extends Controller
 {
     public function edit(Request $request, int $accountId)
     {

flexiapi/app/Http/Controllers/Admin/AccountTypeController.php

@@ -17,7 +17,7 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Account;
+namespace App\Http\Controllers\Admin;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
@@ -27,7 +27,7 @@ use Illuminate\Validation\Rule;
 use App\AccountType;
 use App\Rules\NoUppercase;
 
-class TypeController extends Controller
+class AccountTypeController extends Controller
 {
     public function index()
     {

flexiapi/app/Http/Controllers/Admin/ApiKeyController.php

@@ -1,95 +0,0 @@
-<?php
-/*
-    Flexisip Account Manager is a set of tools to manage SIP accounts.
-    Copyright (C) 2020 Belledonne Communications SARL, All rights reserved.
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Affero General Public License as
-    published by the Free Software Foundation, either version 3 of the
-    License, or (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU Affero General Public License for more details.
-
-    You should have received a copy of the GNU Affero General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-namespace App\Http\Controllers\Admin;
-
-use App\ApiKey;
-use App\Http\Controllers\Controller;
-
-use Illuminate\Http\Request;
-use Illuminate\Support\Str;
-use Carbon\Carbon;
-
-class ApiKeyController extends Controller
-{
-    public function index(Request $request)
-    {
-        return view('admin.api_key.index', [
-            'api_keys' => $this->getApiKeysQuery($request)->with('account')->get()
-        ]);
-    }
-
-    public function create(Request $request)
-    {
-        return view('admin.api_key.create', [
-            'account' => $request->user()
-        ]);
-    }
-
-    public function store(Request $request)
-    {
-        $request->validate([
-            'name' => 'required|min:3',
-            'expires_after_last_used_minutes' => 'integer|min:0'
-        ]);
-
-        $apiKey = new ApiKey;
-        $apiKey->account_id = $request->user()->id;
-        $apiKey->name = $request->get('name');
-        $apiKey->expires_after_last_used_minutes = $request->get('expires_after_last_used_minutes');
-        $apiKey->last_used_at = Carbon::now();
-        $apiKey->key = Str::random(40);
-        $apiKey->save();
-
-        return redirect()->route('admin.api_keys.index');
-    }
-
-    public function delete(Request $request, string $key)
-    {
-        return view('admin.api_key.delete', [
-            'api_key' => $this->getApiKeysQuery($request)->where('key', $key)->first()
-        ]);
-    }
-
-    public function destroy(Request $request)
-    {
-        $this->getApiKeysQuery($request)->where('key', $request->get('key'))->delete();
-
-        return redirect()->route('admin.api_keys.index');
-    }
-
-    private function getApiKeysQuery(Request $request)
-    {
-        $apiKeys = ApiKey::whereIn('account_id', function ($query) {
-            $query->select('id')
-                  ->from('accounts')
-                  ->where('admin', true);
-        })->whereNotNull('expires_after_last_used_minutes');
-
-        if (!$request->user()->superAdmin) {
-            $apiKeys->whereIn('account_id', function ($query) use ($request) {
-                $query->select('id')
-                      ->from('accounts')
-                      ->where('domain', $request->user()->domain);
-            });
-        }
-
-        return $apiKeys;
-    }
-}

flexiapi/app/Http/Controllers/Admin/ContactsListContactController.php

@@ -17,19 +17,18 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Space;
+namespace App\Http\Controllers\Admin;
 
 use App\Account;
 use App\ContactsList;
-use App\Space;
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
 
 class ContactsListContactController extends Controller
 {
-    public function add(Request $request, Space $space, int $contactsListId)
+    public function add(Request $request, int $contactsListId)
     {
-        $accounts = $space->accounts()->orderBy('updated_at', $request->get('updated_at_order', 'desc'));
+        $accounts = Account::orderBy('updated_at', $request->get('updated_at_order', 'desc'));
 
         if ($request->has('search')) {
             $accounts = $accounts->where('username', 'like', '%' . $request->get('search') . '%');
@@ -39,9 +38,9 @@ class ContactsListContactController extends Controller
             $accounts = $accounts->where('domain', $request->get('domain'));
         }
 
-        return view('admin.space.contacts_list.contacts.add', [
-            'space' => $space,
-            'contacts_list' => $space->contactsLists()->findOrFail($contactsListId),
+        return view('admin.contacts_list.contacts.add', [
+            'domains' => Account::groupBy('domain')->pluck('domain'),
+            'contacts_list' => ContactsList::findOrFail($contactsListId),
             'params' => [
                 'contacts_list_id' => $contactsListId
             ],
@@ -53,33 +52,33 @@ class ContactsListContactController extends Controller
         ]);
     }
 
-    public function search(Request $request, Space $space, int $contactsListId)
+    public function search(Request $request, int $contactsListId)
     {
-        return redirect()->route('admin.spaces.contacts_lists.contacts.add', ['contacts_list_id' => $contactsListId] + $request->except('_token'));
+        return redirect()->route('admin.contacts_lists.contacts.add', ['contacts_list_id' => $contactsListId] + $request->except('_token'));
     }
 
-    public function store(Request $request, Space $space, int $contactsListId)
+    public function store(Request $request, int $contactsListId)
     {
         $request->validate([
             'contacts_ids' => 'required|exists:accounts,id'
         ]);
 
-        $contactsList = $space->contactsLists()->findOrFail($contactsListId);
+        $contactsList = ContactsList::findOrFail($contactsListId);
         $contactsList->contacts()->detach($request->get('contacts_ids')); // Just in case
         $contactsList->contacts()->attach($request->get('contacts_ids'));
 
-        return redirect()->route('admin.spaces.contacts_lists.edit', [$space, $contactsList->id]);
+        return redirect()->route('admin.contacts_lists.edit', $contactsList->id);
     }
 
-    public function destroy(Request $request, Space $space, int $contactsListId)
+    public function destroy(Request $request, int $contactsListId)
     {
         $request->validate([
             'contacts_ids' => 'required|exists:accounts,id'
         ]);
 
-        $contactsList = $space->contactsLists()->findOrFail($contactsListId);
+        $contactsList = ContactsList::findOrFail($contactsListId);
         $contactsList->contacts()->detach($request->get('contacts_ids'));
 
-        return redirect()->route('admin.spaces.contacts_lists.edit', [$space, $contactsList->id]);
+        return redirect()->route('admin.contacts_lists.edit', $contactsList->id);
     }
 }

flexiapi/app/Http/Controllers/Admin/ContactsListController.php

@@ -17,67 +17,65 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Admin\Space;
+namespace App\Http\Controllers\Admin;
 
 use App\Account;
 use App\ContactsList;
-use App\Space;
 use App\Http\Controllers\Controller;
 use Illuminate\Validation\Rule;
 use Illuminate\Http\Request;
 
 class ContactsListController extends Controller
 {
-    public function index(Request $request, Space $space)
+    public function index(Request $request)
     {
         $request->validate([
             'order_by' => 'in:title,updated_at,contacts_count',
             'order_sort' => 'in:asc,desc',
         ]);
 
-        $contactsLists = $space->contactsLists()->orderBy($request->get('order_by', 'updated_at'), $request->get('order_sort', 'desc'));
+        $contactsLists = ContactsList::orderBy($request->get('order_by', 'updated_at'), $request->get('order_sort', 'desc'));
 
-        return view('admin.space.contacts_list.index', [
-            'space' => $space,
+        return view('admin.contacts_list.index', [
             'contacts_lists' => $contactsLists
                 ->paginate(20)
                 ->appends($request->query()),
         ]);
     }
 
-    public function create(Request $request, Space $space)
+    public function show(int $id)
     {
-        return view('admin.space.contacts_list.create_edit', [
-            'space' => $space,
+    }
+
+    public function create(Request $request)
+    {
+        return view('admin.contacts_list.create_edit', [
             'contacts_list' => new ContactsList,
         ]);
     }
 
-    public function store(Request $request, Space $space)
+    public function store(Request $request)
     {
         $request->validate([
             'title' => 'required|unique:contacts_lists'
         ]);
 
         $contactsList = new ContactsList;
-        $contactsList->space_id = $space->id;
         $contactsList->title = $request->get('title');
         $contactsList->description = $request->get('description');
         $contactsList->save();
 
-        return redirect()->route('admin.spaces.contacts_lists.edit', [$space, $contactsList->id]);
+        return redirect()->route('admin.contacts_lists.edit', $contactsList->id);
     }
 
-    public function search(Request $request, Space $space, int $contactsListId)
+    public function search(Request $request, int $contactsListId)
     {
-        return redirect()->route('admin.spaces.contacts_lists.edit', [
-            'space' => $space,
-            'contacts_list_id' => $contactsListId] + $request->except('_token'));
+        return redirect()->route('admin.contacts_lists.edit', ['contacts_list_id' => $contactsListId] + $request->except('_token'));
     }
 
-    public function edit(Request $request, Space $space, int $id)
+    public function edit(Request $request, int $id)
     {
-        $contacts = $space->contactsLists()->findOrFail($id)->contacts();
+        $contacts = ContactsList::findOrFail($id)->contacts();
 
         if ($request->has('search')) {
             $contacts = $contacts->where('username', 'like', '%' . $request->get('search') . '%');
@@ -89,15 +87,14 @@ class ContactsListController extends Controller
 
         $contacts = $contacts->get();
 
-        return view('admin.space.contacts_list.create_edit', [
-            'space' => $space,
+        return view('admin.contacts_list.create_edit', [
             'domains' => Account::groupBy('domain')->pluck('domain'),
-            'contacts_list' => $space->contactsLists()->findOrFail($id),
+            'contacts_list' => ContactsList::findOrFail($id),
             'contacts' => $contacts
         ]);
     }
 
-    public function update(Request $request, Space $space, int $id)
+    public function update(Request $request, int $id)
     {
         $request->validate([
             'title' => [
@@ -106,27 +103,26 @@ class ContactsListController extends Controller
             ],
         ]);
 
-        $contactsList = $space->contactsLists()->findOrFail($id);
+        $contactsList = ContactsList::findOrFail($id);
         $contactsList->title = $request->get('title');
         $contactsList->description = $request->get('description');
         $contactsList->save();
 
-        return redirect()->route('admin.spaces.contacts_lists.index', $space);
+        return redirect()->route('admin.contacts_lists.index');
     }
 
-    public function delete(Space $space, int $id)
+    public function delete(int $id)
     {
-        return view('admin.space.contacts_list.delete', [
-            'space' => $space,
-            'contacts_list' => $space->contactsLists()->findOrFail($id),
+        return view('admin.contacts_list.delete', [
+            'contacts_list' => ContactsList::findOrFail($id),
         ]);
     }
 
-    public function destroy(Request $request, Space $space)
+    public function destroy(Request $request)
     {
-        $contactsList = $space->contactsLists()->findOrFail($request->get('contacts_lists_id'));
+        $contactsList = ContactsList::findOrFail($request->get('contacts_lists_id'));
         $contactsList->delete();
 
-        return redirect()->route('admin.spaces.contacts_lists.index', $space);
+        return redirect()->route('admin.contacts_lists.index');
     }
 }

flexiapi/app/Http/Controllers/Admin/ExternalAccountController.php

@@ -1,64 +0,0 @@
-<?php
-/*
-    Flexisip Account Manager is a set of tools to manage SIP accounts.
-    Copyright (C) 2023 Belledonne Communications SARL, All rights reserved.
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Affero General Public License as
-    published by the Free Software Foundation, either version 3 of the
-    License, or (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU Affero General Public License for more details.
-
-    You should have received a copy of the GNU Affero General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-namespace App\Http\Controllers\Admin;
-
-use App\Http\Controllers\Controller;
-use App\Http\Requests\ExternalAccount\CreateUpdate;
-use App\Services\AccountService;
-use Illuminate\Http\Request;
-use Illuminate\Validation\Rule;
-
-use App\ExternalAccount;
-use App\Account;
-
-class ExternalAccountController extends Controller
-{
-    public function show(int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-
-        return view('admin.account.external.show', [
-            'account' => $account,
-            'externalAccount' => $account->external ?? new ExternalAccount,
-            'protocols' => ExternalAccount::PROTOCOLS
-        ]);
-    }
-
-    public function store(CreateUpdate $request, int $accountId)
-    {
-        (new AccountService)->storeExternalAccount($request, $accountId);
-
-        return redirect()->route('admin.account.show', $accountId);
-    }
-
-    public function delete(int $accountId)
-    {
-        return view('admin.account.external.delete', [
-            'account' => Account::findOrFail($accountId)
-        ]);
-    }
-
-    public function destroy(int $accountId)
-    {
-        (new AccountService)->deleteExternalAccount($accountId);
-
-        return redirect()->route('admin.account.show', $accountId);
-    }
-}

flexiapi/app/Http/Controllers/Admin/PhoneCountryController.php

@@ -1,50 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Admin;
-
-use App\Http\Controllers\Controller;
-use App\PhoneCountry;
-
-use Illuminate\Http\Request;
-
-class PhoneCountryController extends Controller
-{
-    public function index()
-    {
-        return view('admin.phone_country.index', [
-            'phone_countries' => PhoneCountry::all()
-        ]);
-    }
-
-    public function activateAll()
-    {
-        PhoneCountry::query()->update(['activated' => true]);
-
-        return redirect()->route('admin.phone_countries.index');
-    }
-
-    public function deactivateAll()
-    {
-        PhoneCountry::query()->update(['activated' => false]);
-
-        return redirect()->route('admin.phone_countries.index');
-    }
-
-    public function activate(string $code)
-    {
-        $phoneCountry = PhoneCountry::where('code', $code)->firstOrFail();
-
-        PhoneCountry::where('country_code', $phoneCountry->country_code)->update(['activated' => true]);
-
-        return redirect()->route('admin.phone_countries.index');
-    }
-
-    public function deactivate(string $code)
-    {
-        $phoneCountry = PhoneCountry::where('code', $code)->firstOrFail();
-
-        PhoneCountry::where('country_code', $phoneCountry->country_code)->update(['activated' => false]);
-
-        return redirect()->route('admin.phone_countries.index');
-    }
-}

flexiapi/app/Http/Controllers/Admin/ProvisioningEmailController.php

@@ -1,36 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Admin;
-
-use App\Account;
-use App\Http\Controllers\Controller;
-use App\Mail\Provisioning;
-
-use Illuminate\Support\Str;
-use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Mail;
-use Illuminate\Support\Facades\Log;
-
-class ProvisioningEmailController extends Controller
-{
-    public function create(int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-
-        return view('admin.account.provisioning_email.create', [
-            'account' => $account
-        ]);
-    }
-
-    public function send(int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-        $account->provision();
-
-        Mail::to($account)->send(new Provisioning($account));
-
-        Log::channel('events')->info('Web Admin: Sending provisioning email', ['id' => $account->identifier]);
-
-        return redirect()->route('admin.account.show', $account);
-    }
-}

flexiapi/app/Http/Controllers/Admin/ResetPasswordEmailController.php

@@ -1,39 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Admin;
-
-use App\Account;
-use App\ResetPasswordEmailToken;
-use App\Http\Controllers\Controller;
-use App\Mail\ResetPassword;
-
-use Illuminate\Support\Str;
-use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Mail;
-
-class ResetPasswordEmailController extends Controller
-{
-    public function create(int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-
-        return view('admin.account.reset_password_email.create', [
-            'account' => $account
-        ]);
-    }
-
-    public function send(int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-
-        $resetPasswordEmail = new ResetPasswordEmailToken;
-        $resetPasswordEmail->account_id = $account->id;
-        $resetPasswordEmail->token = Str::random(16);
-        $resetPasswordEmail->email = $account->email;
-        $resetPasswordEmail->save();
-
-        Mail::to($account)->send(new ResetPassword($account));
-
-        return redirect()->route('admin.account.activity.index', $account);
-    }
-}

flexiapi/app/Http/Controllers/Admin/SipDomainController.php

@@ -0,0 +1,94 @@
+<?php
+/*
+    Flexisip Account Manager is a set of tools to manage SIP accounts.
+    Copyright (C) 2023 Belledonne Communications SARL, All rights reserved.
+
+    This program is free software: you can redistribute it and/or modify
+    it under the terms of the GNU Affero General Public License as
+    published by the Free Software Foundation, either version 3 of the
+    License, or (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU Affero General Public License for more details.
+
+    You should have received a copy of the GNU Affero General Public License
+    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+namespace App\Http\Controllers\Admin;
+
+use Illuminate\Http\Request;
+
+use App\Http\Controllers\Controller;
+use App\SipDomain;
+use Illuminate\Validation\Rule;
+
+class SipDomainController extends Controller
+{
+    public function index()
+    {
+        return view('admin.sip_domain.index', ['sip_domains' => SipDomain::withCount('accounts')->get()]);
+    }
+
+    public function create()
+    {
+        return view('admin.sip_domain.create_edit', [
+            'sip_domain' => new SipDomain
+        ]);
+    }
+
+    public function store(Request $request)
+    {
+        $request->validate([
+            'domain' => 'required|unique:sip_domains',
+        ]);
+
+        $sipDomain = new SipDomain;
+        $sipDomain->domain = $request->get('domain');
+        $sipDomain->super = $request->has('super') ? (bool)$request->get('super') == "true" : false;
+        $sipDomain->save();
+
+        return redirect()->route('admin.sip_domains.index');
+    }
+
+    public function edit(int $id)
+    {
+        return view('admin.sip_domain.create_edit', [
+            'sip_domain' => SipDomain::findOrFail($id)
+        ]);
+    }
+
+    public function update(Request $request, int $id)
+    {
+        $sipDomain = SipDomain::findOrFail($id);
+        $sipDomain->super = $request->has('super') ? $request->get('super') == "true" : false;
+        $sipDomain->save();
+
+        return redirect()->route('admin.sip_domains.index');
+    }
+
+    public function delete(int $id)
+    {
+        return view('admin.sip_domain.delete', [
+            'sip_domain' => SipDomain::findOrFail($id)
+        ]);
+    }
+
+    public function destroy(Request $request, int $id)
+    {
+        $sipDomain = SipDomain::findOrFail($id);
+
+        $request->validate([
+            'domain' => [
+                'required',
+                Rule::in(['first-zone', $sipDomain->domain]),
+            ]
+        ]);
+
+        $sipDomain->delete();
+
+        return redirect()->route('admin.sip_domains.index');
+    }
+}

flexiapi/app/Http/Controllers/Admin/Space/CardDavServerController.php

@@ -1,68 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Admin\Space;
-
-use App\Http\Controllers\Controller;
-use App\Http\Requests\Space\CardDavServer;
-use Illuminate\Http\Request;
-
-use App\Space;
-use App\SpaceCardDavServer;
-
-class CardDavServerController extends Controller
-{
-    public function create(Space $space)
-    {
-        return view('admin.space.carddav_server.create_edit', [
-            'space' => $space,
-            'carddavServer' => new SpaceCardDavServer
-        ]);
-    }
-
-    public function store(CardDavServer $request, Space $space)
-    {
-        $carddavServer = new SpaceCardDavServer;
-        $carddavServer->space_id = $space->id;
-        $carddavServer->fill($request->validated());
-        $carddavServer->enabled = getRequestBoolean($request, 'enabled');
-        $carddavServer->use_exact_match_policy = getRequestBoolean($request, 'use_exact_match_policy');
-        $carddavServer->save();
-
-        return redirect()->route('admin.spaces.integration', $space);
-    }
-
-    public function edit(Space $space, int $carddavServerId)
-    {
-        return view('admin.space.carddav_server.create_edit', [
-            'space' => $space,
-            'carddavServer' => $space->carddavServers()->findOrFail($carddavServerId)
-        ]);
-    }
-
-    public function update(CardDavServer $request, Space $space, int $carddavServerId)
-    {
-        $carddavServer = $space->carddavServers()->findOrFail($carddavServerId);
-        $carddavServer->fill($request->validated());
-        $carddavServer->enabled = getRequestBoolean($request, 'enabled');
-        $carddavServer->use_exact_match_policy = getRequestBoolean($request, 'use_exact_match_policy');
-        $carddavServer->save();
-
-        return redirect()->route('admin.spaces.integration', $space);
-    }
-
-    public function delete(Space $space, int $carddavServerId)
-    {
-        return view('admin.space.carddav_server.delete', [
-            'space' => $space,
-            'carddavServer' => $space->carddavServers()->findOrFail($carddavServerId)
-        ]);
-    }
-
-    public function destroy(Space $space, int $carddavServerId)
-    {
-        $carddavServer = $space->carddavServers()->findOrFail($carddavServerId);
-        $carddavServer->delete();
-
-        return redirect()->route('admin.spaces.integration', $space->id);
-    }
-}

flexiapi/app/Http/Controllers/Admin/Space/EmailServerController.php

@@ -1,60 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Admin\Space;
-
-use App\Space;
-use App\SpaceEmailServer;
-
-use App\Http\Requests\EmailServer\CreateUpdate;
-
-use App\Http\Controllers\Controller;
-use Illuminate\Http\Request;
-
-class EmailServerController extends Controller
-{
-    public function show(int $spaceId)
-    {
-        $space = Space::findOrFail($spaceId);
-
-        return view('admin.space.email_server.show', [
-            'space' => $space,
-            'emailServer' => $space->emailServer ?? new SpaceEmailServer
-        ]);
-    }
-
-    public function store(CreateUpdate $request, int $spaceId)
-    {
-        $space = Space::findOrFail($spaceId);
-        $emailServer = $space->emailServer ?? new SpaceEmailServer;
-
-        $emailServer->space_id = $space->id;
-        $emailServer->host = $request->get('host');
-        $emailServer->port = $request->get('port');
-        $emailServer->username = $request->get('username');
-        $emailServer->password = $request->get('password');
-        $emailServer->from_address = $request->get('from_address') ?? null;
-        $emailServer->from_name = $request->get('from_name') ?? null;
-        $emailServer->signature = $request->get('signature') ?? null;
-
-        $emailServer->save();
-
-        return redirect()->route('admin.spaces.integration', $spaceId);
-    }
-
-    public function delete(int $spaceId)
-    {
-        $space = Space::findOrFail($spaceId);
-
-        return view('admin.space.email_server.delete', [
-            'space' => $space
-        ]);
-    }
-
-    public function destroy(int $spaceId)
-    {
-        $space = Space::findOrFail($spaceId);
-        $space->emailServer->delete();
-
-        return redirect()->route('admin.spaces.integration', $spaceId);
-    }
-}

flexiapi/app/Http/Controllers/Admin/SpaceController.php

@@ -1,226 +0,0 @@
-<?php
-/*
-    Flexisip Account Manager is a set of tools to manage SIP accounts.
-    Copyright (C) 2023 Belledonne Communications SARL, All rights reserved.
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Affero General Public License as
-    published by the Free Software Foundation, either version 3 of the
-    License, or (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU Affero General Public License for more details.
-
-    You should have received a copy of the GNU Affero General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-namespace App\Http\Controllers\Admin;
-
-use App\Http\Controllers\Controller;
-use App\Http\Requests\Space\Create;
-use App\Space;
-use App\Rules\Ini;
-use App\Rules\Domain;
-
-use Illuminate\Http\Request;
-use Illuminate\Validation\Rule;
-
-class SpaceController extends Controller
-{
-    public function index()
-    {
-        return view('admin.space.index', ['spaces' => Space::withCount('accounts')->orderBy('host')->get()]);
-    }
-
-    public function me(Request $request)
-    {
-        return view('admin.space.show', [
-            'space' => $request->user()->space
-        ]);
-    }
-
-    public function show(Space $space)
-    {
-        return view('admin.space.show', [
-            'space' => $space
-        ]);
-    }
-
-    public function create()
-    {
-        return view('admin.space.create', [
-            'space' => new Space()
-        ]);
-    }
-
-    public function store(Create $request)
-    {
-        $fullHost = empty($request->get('host'))
-            ? config('app.root_host')
-            : $request->get('host') . '.' . config('app.root_host');
-
-        $request->merge(['full_host' => $fullHost]);
-        $request->validate([
-            'host' => 'nullable|regex:/'. Space::HOST_REGEX . '/',
-            'full_host' => ['required', 'unique:spaces,host', new Domain()],
-        ]);
-
-        $space = new Space();
-        $space->name = $request->get('name');
-        $space->domain = $request->get('domain');
-        $space->host = $request->get('full_host');
-        $space->account_realm = $request->get('account_realm');
-        $space->save();
-
-        return redirect()->route('admin.spaces.index');
-    }
-
-    public function edit(Space $space)
-    {
-        return view('admin.space.edit', [
-            'space' => $space
-        ]);
-    }
-
-    public function update(Request $request, Space $space)
-    {
-        $request->validate([
-            'max_account' => 'required|integer',
-        ]);
-
-        $space = $this->setAppConfiguration($request, $space);
-        $space->save();
-
-        return redirect()->back();
-    }
-
-    public function configuration(Space $space)
-    {
-        return view('admin.space.configuration', [
-            'space' => $space
-        ]);
-    }
-
-    public function integration(Space $space)
-    {
-        return view('admin.space.integration', [
-            'space' => $space
-        ]);
-    }
-
-    public function configurationUpdate(Request $request, Space $space)
-    {
-        $space = $this->setConfiguration($request, $space);
-        $space->save();
-
-        return redirect()->route('admin.spaces.configuration', $space);
-    }
-
-    public function administration(Space $space)
-    {
-        return view('admin.space.administration', [
-            'space' => $space
-        ]);
-    }
-
-    public function administrationUpdate(Request $request, Space $space)
-    {
-        $request->validate([
-            'name' => ['required', Rule::unique('spaces')->ignore($space->id)],
-            'max_accounts' => 'required|integer|min:0',
-            'expire_at' => 'nullable|date|after_or_equal:today'
-        ]);
-
-        if ($request->get('max_accounts') > 0) {
-            $request->validate([
-                'max_accounts' => 'integer|min:' . $space->accounts()->count()
-            ]);
-        }
-
-        $space->name = $request->get('name');
-        $space->super = getRequestBoolean($request, 'super');
-        $space->max_accounts = $request->get('max_accounts');
-        $space->expire_at = $request->get('expire_at');
-        $space->custom_theme = getRequestBoolean($request, 'custom_theme');
-        $space->web_panel = getRequestBoolean($request, 'web_panel');
-        $space->carddav_user_credentials = getRequestBoolean($request, 'carddav_user_credentials');
-        $space->save();
-
-        return redirect()->route('admin.spaces.show', $space);
-    }
-
-    private function setConfiguration(Request $request, Space $space)
-    {
-        $request->validate([
-            'newsletter_registration_address' => 'nullable|email',
-            'custom_provisioning_entries' => ['nullable', new Ini(Space::FORBIDDEN_KEYS)]
-        ]);
-
-        $space->copyright_text = $request->get('copyright_text');
-        $space->intro_registration_text = $request->get('intro_registration_text');
-        $space->newsletter_registration_address = $request->get('newsletter_registration_address');
-        $space->account_proxy_registrar_address = $request->get('account_proxy_registrar_address');
-
-        if ($space->accounts()->count() == 0) {
-            $space->account_realm = $request->get('account_realm');
-        }
-
-        $space->custom_provisioning_entries = $request->get('custom_provisioning_entries');
-        $space->custom_provisioning_overwrite_all = getRequestBoolean($request, 'custom_provisioning_overwrite_all');
-        $space->provisioning_use_linphone_provisioning_header = getRequestBoolean($request, 'provisioning_use_linphone_provisioning_header');
-
-        $space->public_registration = getRequestBoolean($request, 'public_registration');
-        $space->phone_registration = getRequestBoolean($request, 'phone_registration');
-        $space->intercom_features = getRequestBoolean($request, 'intercom_features');
-
-        return $space;
-    }
-
-    private function setAppConfiguration(Request $request, Space $space)
-    {
-        $request->validate([
-            'max_account' => 'required|integer',
-        ]);
-
-        $space->disable_chat_feature = getRequestBoolean($request, 'disable_chat_feature', reversed: true);
-        $space->disable_meetings_feature = getRequestBoolean($request, 'disable_meetings_feature', reversed: true);
-        $space->disable_broadcast_feature = getRequestBoolean($request, 'disable_broadcast_feature', reversed: true);
-        $space->hide_settings = getRequestBoolean($request, 'hide_settings', reversed: true);
-        $space->max_account = $request->get('max_account', 0);
-        $space->hide_account_settings = getRequestBoolean($request, 'hide_account_settings', reversed: true);
-        $space->disable_call_recordings_feature = getRequestBoolean($request, 'disable_call_recordings_feature', reversed: true);
-        $space->only_display_sip_uri_username = getRequestBoolean($request, 'only_display_sip_uri_username');
-        $space->assistant_hide_create_account = getRequestBoolean($request, 'assistant_hide_create_account', reversed: true);
-        $space->assistant_disable_qr_code = getRequestBoolean($request, 'assistant_disable_qr_code', reversed: true);
-        $space->assistant_hide_third_party_account = getRequestBoolean($request, 'assistant_hide_third_party_account', reversed: true);
-
-        return $space;
-    }
-
-    public function delete(Request $request, int $id)
-    {
-        $space = Space::findOrFail($id);
-        return view('admin.space.delete', [
-            'space' => $space
-        ]);
-    }
-
-    public function destroy(Request $request, int $id)
-    {
-        $space = Space::findOrFail($id);
-
-        $request->validate([
-            'domain' => [
-                'required',
-                Rule::in(['first-zone', $space->domain]),
-            ]
-        ]);
-
-        $space->delete();
-
-        return redirect()->route('admin.spaces.index');
-    }
-}

flexiapi/app/Http/Controllers/Admin/StatisticsController.php

@@ -106,13 +106,9 @@ class StatisticsController extends Controller
         $fromQuery = StatisticsCall::query();
         $toQuery = StatisticsCall::query();
 
-        $domain = $request->user()->superAdmin
-            ? $request->get('domain')
-            : $request->space->domain;
-
-        if ($domain) {
-            $fromQuery->where('to_domain', $domain);
-            $toQuery->where('from_domain', $domain);
+        if ($request->get('domain')) {
+            $fromQuery->where('to_domain', $request->get('domain'));
+            $toQuery->where('from_domain', $request->get('domain'));
         }
 
         if ($request->get('to')) {

flexiapi/app/Http/Controllers/Api/Account/AccountController.php

@@ -20,13 +20,30 @@
 namespace App\Http\Controllers\Api\Account;
 
 use Illuminate\Http\Request;
+use Illuminate\Validation\Rule;
+use Illuminate\Support\Str;
 use Illuminate\Support\Facades\Log;
-
+use Illuminate\Support\Facades\Mail;
 use App\Http\Controllers\Controller;
-use App\Http\Requests\Account\Create\Api\Request as ApiRequest;
+use Carbon\Carbon;
 
 use App\Account;
+use App\AccountCreationToken;
+
+use App\Http\Controllers\Account\AuthenticateController as WebAuthenticateController;
+use App\Http\Requests\Account\Create\Api\Request as ApiRequest;
+use App\Libraries\OvhSMS;
+use App\Mail\RegisterConfirmation;
+
+use App\Rules\AccountCreationToken as RulesAccountCreationToken;
+use App\Rules\BlacklistedUsername;
+use App\Rules\NoUppercase;
+use App\Rules\SIPUsername;
+use App\Rules\WithoutSpaces;
+use App\Rules\PasswordAlgorithm;
+
 use App\Services\AccountService;
+use App\SipDomain;
 
 class AccountController extends Controller
 {
@@ -44,24 +61,187 @@ class AccountController extends Controller
     }
 
     /**
-     * Get services credentials
+     * /!\ Dangerous endpoint, disabled by default
      */
-    public function turnService(Request $request)
+    public function phoneInfo(Request $request, string $phone)
     {
-        if (hasCoturnConfigured()) {
-            list($username, $password) = array_values(getCoTURNCredentials());
+        if (!config('app.dangerous_endpoints')) return abort(404);
 
-            return [
-                'username' => $username,
-                'password' => $password,
-                'ttl' => config('app.coturn_session_ttl_minutes') * 60,
-                'uris' => [
-                    'turn:' . config('app.coturn_server_host'),
-                ]
-            ];
+        $request->merge(['phone' => $phone]);
+        $request->validate([
+            'phone' => ['required', new WithoutSpaces, 'starts_with:+']
+        ]);
+
+        $account = Account::where('domain', config('app.sip_domain'))
+            ->where(function ($query) use ($phone) {
+                $query->where('username', $phone)
+                    ->orWhere('phone', $phone);
+            })->firstOrFail();
+
+        return \response()->json([
+            'activated' => $account->activated,
+            'realm' => $account->realm,
+            'phone' => (bool)$account->phone
+        ]);
+    }
+
+    /**
+     * /!\ Dangerous endpoint, disabled by default
+     * Store directly the account and alias in the DB and send a SMS or email for the validation
+     */
+    public function storePublic(Request $request)
+    {
+        if (!config('app.dangerous_endpoints')) return abort(404);
+
+        $request->validate([
+            'username' => [
+                'required_without:phone',
+                new NoUppercase,
+                new BlacklistedUsername,
+                new SIPUsername,
+                Rule::unique('accounts', 'username')->where(function ($query) use ($request) {
+                    $query->where('domain', $request->has('domain') ? $request->get('domain') : config('app.sip_domain'));
+                }),
+                Rule::unique('accounts_tombstones', 'username')->where(function ($query) use ($request) {
+                    $query->where('domain', $request->has('domain') ? $request->get('domain') : config('app.sip_domain'));
+                }),
+                'filled',
+            ],
+            'algorithm' => ['required', new PasswordAlgorithm],
+            'password' => 'required|filled',
+            'domain' => 'min:3',
+            'email' => config('app.account_email_unique')
+                ? 'required_without:phone|email|unique:accounts,email'
+                : 'required_without:phone|email',
+            'phone' => [
+                'required_without:email',
+                'required_without:username',
+                'unique:accounts,phone',
+                'unique:accounts,username',
+                new WithoutSpaces, 'starts_with:+'
+            ],
+            'account_creation_token' => [
+                'required',
+                new RulesAccountCreationToken
+            ]
+        ]);
+
+        $account = new Account;
+        $account->username = !empty($request->get('username'))
+            ? $request->get('username')
+            : $request->get('phone');
+        $account->email = $request->get('email');
+        $account->activated = false;
+        $account->domain = $request->has('domain')
+            ? $request->get('domain')
+            : config('app.sip_domain');
+        $account->ip_address = $request->ip();
+        $account->created_at = Carbon::now();
+        $account->user_agent = $request->header('User-Agent') ?? config('app.name');
+        $account->save();
+
+        $account->updatePassword($request->get('password'), $request->get('algorithm'));
+
+        $token = AccountCreationToken::where('token', $request->get('account_creation_token'))->first();
+        $token->consume();
+        $token->account_id = $account->id;
+        $token->save();
+
+        Log::channel('events')->info('API deprecated - Store public: AccountCreationToken redeemed', ['account_creation_token' => $token->toLog()]);
+        Log::channel('events')->info('API deprecated - Store public: Account created', ['id' => $account->identifier]);
+
+        // Send validation by phone
+        if ($request->has('phone')) {
+            $account->phone = $request->get('phone');
+            $account->confirmation_key = generatePin();
+            $account->save();
+
+            Log::channel('events')->info('API deprecated: Account created using the public endpoint by phone', ['id' => $account->identifier]);
+
+            $ovhSMS = new OvhSMS;
+            $ovhSMS->send($request->get('phone'), 'Your ' . config('app.name') . ' creation code is ' . $account->confirmation_key);
+        } elseif ($request->has('email')) {
+            // Send validation by email
+            $account->confirmation_key = Str::random(WebAuthenticateController::$emailCodeSize);
+            $account->save();
+
+            Log::channel('events')->info('API deprecated - Store public: Account created using the public endpoint by email', ['id' => $account->identifier]);
+
+            try {
+                Mail::to($account)->send(new RegisterConfirmation($account));
+            } catch (\Exception $e) {
+                Log::channel('events')->info('API deprecated - Store public: Public Register Confirmation email not sent, check errors log', ['id' => $account->identifier]);
+                Log::error('Public Register Confirmation email not sent: ' . $e->getMessage());
+            }
         }
 
-        return abort(404, 'No TURN service configured');
+        // Full reload
+        return Account::withoutGlobalScopes()->find($account->id);
+    }
+
+    /**
+     * /!\ Dangerous endpoint, disabled by default
+     */
+    public function recoverByPhone(Request $request)
+    {
+        if (!config('app.dangerous_endpoints')) return abort(404);
+
+        $request->validate([
+            'phone' => [
+                'required', new WithoutSpaces, 'starts_with:+', 'exists:accounts,phone'
+            ],
+            'account_creation_token' => [
+                'required',
+                new RulesAccountCreationToken
+            ]
+        ]);
+
+        $account = Account::where('phone', $request->get('phone'))->first();
+        $account->confirmation_key = generatePin();
+        $account->save();
+
+        $token = AccountCreationToken::where('token', $request->get('account_creation_token'))->first();
+        $token->consume();
+        $token->account_id = $account->id;
+        $token->save();
+
+        Log::channel('events')->info('API deprecated - Account recovery: AccountCreationToken redeemed', ['account_creation_token' => $token->toLog()]);
+        Log::channel('events')->info('API deprecated - Account recovery: Account recovery by phone', ['id' => $account->identifier]);
+
+        $ovhSMS = new OvhSMS;
+        $ovhSMS->send($request->get('phone'), 'Your ' . config('app.name') . ' recovery code is ' . $account->confirmation_key);
+    }
+
+    /**
+     * /!\ Dangerous endpoint, disabled by default
+     */
+    public function recoverUsingKey(string $sip, string $recoveryKey)
+    {
+        if (!config('app.dangerous_endpoints')) return abort(404);
+
+        list($username, $domain) = explode('@', $sip);
+
+        $account = Account::where('domain', $domain)
+            ->where(function ($query) use ($username) {
+                $query->where('username', $username)
+                      ->orWhere('phone', $username);
+            })->firstOrFail();
+
+        $confirmationKey = $account->confirmation_key;
+        $account->confirmation_key = null;
+
+        if ($confirmationKey != $recoveryKey) abort(404);
+
+        if ($account->activationExpired()) abort(403, 'Activation expired');
+
+        $account->activated = true;
+        $account->save();
+
+        $account->passwords->each(function ($i, $k) {
+            $i->makeVisible(['password']);
+        });
+
+        return $account;
     }
 
     public function store(ApiRequest $request)
@@ -69,6 +249,64 @@ class AccountController extends Controller
         return (new AccountService)->store($request);
     }
 
+    /**
+     * Deprecated
+     */
+    public function activateEmail(Request $request, string $sip)
+    {
+        // For retro-compatibility
+        if ($request->has('code')) {
+            $request->merge(['confirmation_key' => $request->get('code')]);
+        }
+
+        $request->validate([
+            'confirmation_key' => 'required|size:' . WebAuthenticateController::$emailCodeSize
+        ]);
+
+        $account = Account::sip($sip)
+            ->where('confirmation_key', $request->get('confirmation_key'))
+            ->firstOrFail();
+
+        if ($account->activationExpired()) abort(403, 'Activation expired');
+
+        $account->activated = true;
+        $account->confirmation_key = null;
+        $account->save();
+
+        Log::channel('events')->info('API: Account activated by email', ['id' => $account->identifier]);
+
+        return $account;
+    }
+
+    /**
+     * Deprecated
+     */
+    public function activatePhone(Request $request, string $sip)
+    {
+        // For retro-compatibility
+        if ($request->has('code')) {
+            $request->merge(['confirmation_key' => $request->get('code')]);
+        }
+
+        $request->validate([
+            'confirmation_key' => 'required|digits:4'
+        ]);
+
+        $account = Account::sip($sip)
+            ->where('confirmation_key', $request->get('confirmation_key'))
+            ->firstOrFail();
+
+        if ($account->activationExpired()) abort(403, 'Activation expired');
+
+        $account->activated = true;
+        $account->confirmation_key = null;
+        $account->save();
+
+        Log::channel('events')->info('API: Account activated by phone', ['id' => $account->identifier]);
+
+        return $account;
+    }
+
     public function show(Request $request)
     {
         return Account::where('id', $request->user()->id)

flexiapi/app/Http/Controllers/Api/Account/ApiKeyController.php

@@ -29,7 +29,7 @@ class ApiKeyController extends Controller
     public function generate(Request $request)
     {
         $account = $request->user();
-        $account->generateUserApiKey($request->ip());
+        $account->generateApiKey($request);
 
         $account->refresh();
         Cookie::queue('x-api-key', $account->apiKey->key, config('app.api_key_expiration_minutes'));
@@ -42,7 +42,7 @@ class ApiKeyController extends Controller
         $authToken = AuthToken::where('token', $token)->valid()->firstOrFail();
 
         if ($authToken->account) {
-            $authToken->account->generateUserApiKey($request->ip());
+            $authToken->account->generateApiKey($request);
 
             $authToken->account->refresh();
             Cookie::queue('x-api-key', $authToken->account->apiKey->key, config('app.api_key_expiration_minutes'));

flexiapi/app/Http/Controllers/Api/Account/CreationTokenController.php

@@ -64,9 +64,10 @@ class CreationTokenController extends Controller
         $token->pn_prid = $request->get('pn_prid');
         $token->fillRequestInfo($request);
 
+        // Send the token to the device via Push Notification
         $fp = new FlexisipPusherConnector($token->pn_provider, $token->pn_param, $token->pn_prid);
         if ($fp->sendToken($token->token)) {
-            Log::channel('events')->info('API: Account Creation Token sent', ['token' => $token->token]);
+            Log::channel('events')->info('API: Token sent', ['token' => $token->token]);
 
             $token->save();
             return;

flexiapi/app/Http/Controllers/Api/Account/DeviceController.php

@@ -20,7 +20,7 @@
 namespace App\Http\Controllers\Api\Account;
 
 use App\Http\Controllers\Controller;
-use App\Libraries\FlexisipRedisConnector;
+use App\Libraries\FlexisipConnector;
 use Illuminate\Http\Request;
 use stdClass;
 
@@ -28,14 +28,14 @@ class DeviceController extends Controller
 {
     public function index(Request $request)
     {
-        $devices = (new FlexisipRedisConnector)->getDevices($request->user()->identifier);
+        $devices = (new FlexisipConnector)->getDevices($request->user()->identifier);
 
         return ($devices->isEmpty()) ? new stdClass : $devices;
     }
 
     public function destroy(Request $request, string $uuid)
     {
-        $connector = new FlexisipRedisConnector;
+        $connector = new FlexisipConnector;
 
         return $connector->deleteDevice($request->user()->identifier, $uuid);
     }

flexiapi/app/Http/Controllers/Api/Account/FileController.php

@@ -1,42 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Api\Account;
-
-use App\AccountFile;
-use App\Http\Controllers\Controller;
-use App\Rules\AudioMime;
-use Carbon\Carbon;
-use Illuminate\Http\Request;
-use Illuminate\Support\Str;
-
-class FileController extends Controller
-{
-    public function upload(Request $request, string $uuid)
-    {
-        $file = AccountFile::findOrFail($uuid);
-
-        if (!empty($file->name)) {
-            abort(404);
-        }
-
-        $request->validate(['file' => 'required|file']);
-
-        if ($file->isVoicemailAudio()) {
-            $request->validate(['file' => [new AudioMime($file)]]);
-        }
-
-        $uploadedFile = $request->file('file');
-        $name = Str::random(8) . '_' . $uploadedFile->getClientOriginalName();
-
-        if ($uploadedFile->storeAs(AccountFile::FILES_PATH, $name)) {
-            $file->name = $name;
-            $file->size = $uploadedFile->getSize();
-            $file->uploaded_at = Carbon::now();
-            $file->save();
-
-            return $file;
-        }
-
-        abort(503);
-    }
-}

flexiapi/app/Http/Controllers/Api/Account/PasswordController.php

@@ -20,11 +20,14 @@
 namespace App\Http\Controllers\Api\Account;
 
 use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Mail;
 use Illuminate\Support\Facades\Log;
 
 use App\Http\Controllers\Controller;
 use App\Rules\PasswordAlgorithm;
 
+use App\Mail\ConfirmedRegistration;
+
 class PasswordController extends Controller
 {
     public function update(Request $request)
@@ -60,5 +63,9 @@ class PasswordController extends Controller
         }
 
         $account->updatePassword($request->get('password'), $algorithm);
+
+        if (!empty($account->email)) {
+            Mail::to($account)->send(new ConfirmedRegistration($account));
+        }
     }
 }

flexiapi/app/Http/Controllers/Api/Account/PushNotificationController.php

@@ -1,39 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Api\Account;
-
-use App\Http\Controllers\Controller;
-use App\Libraries\FlexisipPusherConnector;
-use App\Rules\PnParam;
-use App\Rules\PnPrid;
-use App\Rules\PnProvider;
-use App\Rules\CallId;
-use Illuminate\Http\Request;
-use Illuminate\Validation\Rule;
-use Illuminate\Support\Facades\Log;
-
-class PushNotificationController extends Controller
-{
-    public function push(Request $request)
-    {
-        $request->validate([
-            'pn_provider' => ['required', new PnProvider],
-            'pn_param' => [new PnParam],
-            'pn_prid' => [new PnPrid],
-            'type' => ['required', Rule::in(array_keys(FlexisipPusherConnector::$apnsTypes))],
-            'call_id' => [new CallId],
-        ]);
-
-        $fp = new FlexisipPusherConnector($request->get('pn_provider'), $request->get('pn_param'), $request->get('pn_prid'));
-
-        if ($fp->send(callId: $request->get('call_id'), type: $request->get('type'))) {
-            Log::channel('events')->info('API: Push notification sent', [
-                'call_id' => $request->get('call_id'),
-                'type' => $request->get('type')
-            ]);
-            return;
-        }
-
-        abort(503, "Push notification not sent");
-    }
-}

flexiapi/app/Http/Controllers/Api/Account/RecoveryTokenController.php

@@ -1,75 +0,0 @@
-<?php
-/*
-    Flexisip Account Manager is a set of tools to manage SIP accounts.
-    Copyright (C) 2020 Belledonne Communications SARL, All rights reserved.
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Affero General Public License as
-    published by the Free Software Foundation, either version 3 of the
-    License, or (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU Affero General Public License for more details.
-
-    You should have received a copy of the GNU Affero General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-namespace App\Http\Controllers\Api\Account;
-
-use Illuminate\Http\Request;
-use Illuminate\Support\Str;
-use Illuminate\Support\Facades\Log;
-use Carbon\Carbon;
-
-use App\AccountRecoveryToken;
-use App\Rules\PnParam;
-use App\Rules\PnPrid;
-use App\Rules\PnProvider;
-use App\Http\Controllers\Controller;
-use App\Http\Controllers\Account\AuthenticateController as WebAuthenticateController;
-use App\Libraries\FlexisipPusherConnector;
-
-class RecoveryTokenController extends Controller
-{
-    public function sendByPush(Request $request)
-    {
-        $request->validate([
-            'pn_provider' => ['required', new PnProvider],
-            'pn_param' => [new PnParam],
-            'pn_prid' => [new PnPrid],
-        ]);
-
-        $last = AccountRecoveryToken::where('pn_provider', $request->get('pn_provider'))
-            ->where('pn_param', $request->get('pn_param'))
-            ->where('pn_prid', $request->get('pn_prid'))
-            ->where('created_at', '>=', Carbon::now()->subMinutes(config('app.account_recovery_token_retry_minutes'))->toDateTimeString())
-            ->where('used', true)
-            ->latest()
-            ->first();
-
-        if ($last) {
-            Log::channel('events')->info('API: Token throttled', ['token' => $last->token]);
-            abort(429, 'Last token requested too recently');
-        }
-
-        $token = new AccountRecoveryToken;
-        $token->token = Str::random(WebAuthenticateController::$emailCodeSize);
-        $token->pn_provider = $request->get('pn_provider');
-        $token->pn_param = $request->get('pn_param');
-        $token->pn_prid = $request->get('pn_prid');
-        $token->fillRequestInfo($request);
-
-        $fp = new FlexisipPusherConnector($token->pn_provider, $token->pn_param, $token->pn_prid);
-        if ($fp->sendToken($token->token)) {
-            Log::channel('events')->info('API: AccountRecoveryToken sent', ['token' => $token->token]);
-
-            $token->save();
-            return;
-        }
-
-        abort(503, "Token not sent");
-    }
-}

flexiapi/app/Http/Controllers/Api/Account/VcardsStorageController.php

@@ -10,12 +10,12 @@ class VcardsStorageController extends Controller
 {
     public function index(Request $request)
     {
-        return (new AdminVcardsStorageController)->index($request, $request->user()->id);
+        return (new AdminVcardsStorageController)->index($request->user()->id);
     }
 
     public function show(Request $request, string $uuid)
     {
-        return (new AdminVcardsStorageController)->show($request, $request->user()->id, $uuid);
+        return (new AdminVcardsStorageController)->show($request->user()->id, $uuid);
     }
 
     public function store(Request $request)
@@ -30,6 +30,6 @@ class VcardsStorageController extends Controller
 
     public function destroy(Request $request, string $uuid)
     {
-        return (new AdminVcardsStorageController)->destroy($request, $request->user()->id, $uuid);
+        return (new AdminVcardsStorageController)->destroy($request->user()->id, $uuid);
     }
 }

flexiapi/app/Http/Controllers/Api/Account/VoicemailController.php

@@ -1,30 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Api\Account;
-
-use App\Http\Controllers\Controller;
-use App\Http\Controllers\Api\Admin\Account\VoicemailController as AdminVoicemailController;
-use Illuminate\Http\Request;
-
-class VoicemailController extends Controller
-{
-    public function index(Request $request)
-    {
-        return (new AdminVoicemailController)->index($request, $request->user()->id);
-    }
-
-    public function store(Request $request)
-    {
-        return (new AdminVoicemailController)->store($request, $request->user()->id);
-    }
-
-    public function show(Request $request, string $uuid)
-    {
-        return (new AdminVoicemailController)->show($request, $request->user()->id, $uuid);
-    }
-
-    public function destroy(Request $request, string $uuid)
-    {
-        return (new AdminVoicemailController)->destroy($request, $request->user()->id, $uuid);
-    }
-}

flexiapi/app/Http/Controllers/Api/Admin/Account/CardDavCredentialsController.php

@@ -1,78 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Api\Admin\Account;
-
-use App\Http\Controllers\Controller;
-use Illuminate\Http\Request;
-
-use App\Account;
-use App\Space;
-use App\AccountCardDavCredentials;
-use App\SpaceCardDavServer;
-use App\Http\Requests\Account\CardDavCredentials;
-
-class CardDavCredentialsController extends Controller
-{
-    public function index(Request $request, int $accountId)
-    {
-        $account = $request->space->accounts()->findOrFail($accountId);
-        $cardDavServers = $account->carddavServers;
-
-        if ($cardDavServers->isEmpty()) return new \stdClass;
-
-        return $cardDavServers->map(function ($cardDavServer) {
-            return $this->extractCardDavServer($cardDavServer);
-        })->keyBy('carddav_id');
-    }
-
-    public function show(Request $request, int $accountId, int $cardDavServerId)
-    {
-        $account = $request->space->accounts()->findOrFail($accountId);
-        $cardDavServer = $account->cardDavServers()->findOrFail($cardDavServerId);
-
-        return $this->extractCardDavServer($cardDavServer);
-    }
-
-    public function update(CardDavCredentials $request, int $accountId, int $cardDavServerId)
-    {
-        $account = $request->space->accounts()->findOrFail($accountId);
-        $cardDavServer = $request->space->cardDavServers()->findOrFail($cardDavServerId);
-
-        $accountCarddavCredentials = AccountCardDavCredentials::where('account_id', $account->id)
-            ->where('space_carddav_server_id', $cardDavServer->id)
-            ->delete();
-
-        $accountCarddavCredentials = new AccountCardDavCredentials;
-        $accountCarddavCredentials->space_carddav_server_id = $cardDavServer->id;
-        $accountCarddavCredentials->account_id = $account->id;
-        $accountCarddavCredentials->username = $request->get('username');
-        $accountCarddavCredentials->realm = $request->get('realm');
-        $accountCarddavCredentials->password = bchash(
-            $request->get('username'),
-            $request->get('realm'),
-            $request->get('password'),
-            $request->get('algorithm')
-        );
-        $accountCarddavCredentials->algorithm = $request->get('algorithm');
-        return $accountCarddavCredentials->save();
-    }
-
-    public function destroy(Request $request, int $accountId, int $cardDavServerId)
-    {
-        $account = $request->space->accounts()->findOrFail($accountId);
-        $cardDavServer = $account->cardDavServers()->findOrFail($cardDavServerId);
-
-        return $cardDavServer->delete();
-    }
-
-    private function extractCardDavServer(SpaceCardDavServer $cardDavServer)
-    {
-        return [
-            'carddav_id' => $cardDavServer->id,
-            'username' => $cardDavServer->pivot->username,
-            'realm' => $cardDavServer->pivot->realm,
-            'algorithm' => $cardDavServer->pivot->algorithm,
-            'password' => $cardDavServer->pivot->password,
-        ];
-    }
-}

flexiapi/app/Http/Controllers/Api/Admin/Account/VoicemailController.php

@@ -1,49 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Api\Admin\Account;
-
-use App\Account;
-use App\AccountFile;
-use App\Http\Controllers\Controller;
-use Illuminate\Http\Request;
-use Illuminate\Validation\Rule;
-
-class VoicemailController extends Controller
-{
-    public function index(Request $request, int $accountId)
-    {
-        return Account::findOrFail($accountId)->voicemails;
-    }
-
-    public function store(Request $request, int $accountId)
-    {
-        $account = Account::findOrFail($accountId);
-        $request->validate([
-            'sip_from' => 'nullable|starts_with:sip',
-            'content_type' => [
-                'required',
-                Rule::in(AccountFile::VOICEMAIL_CONTENTTYPES),
-            ]
-        ]);
-
-        $voicemail = new AccountFile;
-        $voicemail->account_id = $account->id;
-        $voicemail->sip_from = $request->get('sip_from');
-        $voicemail->content_type = $request->get('content_type');
-        $voicemail->save();
-
-        $voicemail->append(['upload_url', 'max_upload_size']);
-
-        return $voicemail;
-    }
-
-    public function show(Request $request, int $accountId, string $uuid)
-    {
-        return Account::findOrFail($accountId)->voicemails()->where('id', $uuid)->firstOrFail();
-    }
-
-    public function destroy(Request $request, int $accountId, string $uuid)
-    {
-        return Account::findOrFail($accountId)->voicemails()->where('id', $uuid)->delete();
-    }
-}

flexiapi/app/Http/Controllers/Api/Admin/AccountActionController.php

@@ -17,32 +17,33 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Api\Admin\Account;
+namespace App\Http\Controllers\Api\Admin;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
 
+use App\Account;
 use App\AccountAction;
 use App\Rules\NoUppercase;
 
-class ActionController extends Controller
+class AccountActionController extends Controller
 {
-    public function index(Request $request, int $accountId)
+    public function index(int $id)
     {
-        return $this->resolveAccount($request, $accountId)->actions;
+        return $this->resolveAccount($id)->actions;
     }
 
-    public function get(Request $request, int $accountId, int $actionId)
+    public function get(int $id, int $actionId)
     {
-        return $this->resolveAccount($request, $accountId)
+        return $this->resolveAccount($id)
                       ->actions()
                       ->where('id', $actionId)
                       ->firstOrFail();
     }
 
-    public function store(Request $request, int $accountId)
+    public function store(Request $request, int $id)
     {
-        $account = $this->resolveAccount($request, $accountId);
+        $account = $this->resolveAccount($id);
 
         $request->validate([
             'key' => ['required', 'alpha_dash', new NoUppercase],
@@ -58,9 +59,9 @@ class ActionController extends Controller
         return $accountAction;
     }
 
-    public function update(Request $request, int $accountId, int $actionId)
+    public function update(Request $request, int $id, int $actionId)
     {
-        $account = $this->resolveAccount($request, $accountId);
+        $account = $this->resolveAccount($id);
 
         $request->validate([
             'key' => ['alpha_dash', new NoUppercase],
@@ -78,17 +79,17 @@ class ActionController extends Controller
         return $accountAction;
     }
 
-    public function destroy(Request $request, int $accountId, int $actionId)
+    public function destroy(int $id, int $actionId)
     {
-        return $this->resolveAccount($request, $accountId)
+        return $this->resolveAccount($id)
                                  ->actions()
                                  ->where('id', $actionId)
                                  ->delete();
     }
 
-    private function resolveAccount(Request $request, int $accountId)
+    private function resolveAccount(int $id)
     {
-        $account = $request->space->accounts()->findOrFail($accountId);
+        $account = Account::findOrFail($id);
         if ($account->dtmf_protocol == null) abort(403, 'DTMF Protocol must be configured');
 
         return $account;

flexiapi/app/Http/Controllers/Api/Admin/AccountContactController.php

@@ -17,44 +17,44 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Api\Admin\Account;
+namespace App\Http\Controllers\Api\Admin;
 
 use App\Http\Controllers\Controller;
-use Illuminate\Http\Request;
 
-class ContactController extends Controller
+use App\Account;
+
+class AccountContactController extends Controller
 {
-    public function index(Request $request, int $accountId)
+    public function index(int $id)
     {
-        return $request->space->accounts()->findOrFail($accountId)->contacts;
+        return Account::findOrFail($id)->contacts;
     }
 
-    public function show(Request $request, int $accountId, int $contactId)
+    public function show(int $id, int $contactId)
     {
-        return $request->space->accounts()->findOrFail($accountId)
+        return Account::findOrFail($id)
                       ->contacts()
                       ->where('id', $contactId)
                       ->firstOrFail();
     }
 
-    public function add(Request $request, int $accountId, int $contactId)
+    public function add(int $id, int $contactId)
     {
-        $account = $request->space->accounts()->findOrFail($accountId);
-        $account->contacts()->detach($contactId);
+        if (Account::findOrFail($id)->contacts()->pluck('id')->contains($contactId)) {
+            abort(403);
+        }
 
-        if ($request->space->accounts()->findOrFail($contactId)) {
-            return $account->contacts()->attach($contactId);
+        if (Account::findOrFail($contactId)) {
+            return Account::findOrFail($id)->contacts()->attach($contactId);
         }
     }
 
-    public function remove(Request $request, int $accountId, int $contactId)
+    public function remove(int $id, int $contactId)
     {
-        $account = $request->space->accounts()->findOrFail($accountId);
-
-        if (!$account->contacts()->pluck('id')->contains($contactId)) {
-            abort(404);
+        if (!Account::findOrFail($id)->contacts()->pluck('id')->contains($contactId)) {
+            abort(403);
         }
 
-        return $account->contacts()->detach($contactId);
+        return Account::findOrFail($id)->contacts()->detach($contactId);
     }
 }

flexiapi/app/Http/Controllers/Api/Admin/AccountController.php

@@ -21,36 +21,27 @@ namespace App\Http\Controllers\Api\Admin;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
-use Illuminate\Support\Str;
 use Illuminate\Support\Facades\Log;
-use Illuminate\Support\Facades\Mail;
 
+use App\Account;
 use App\AccountTombstone;
 use App\AccountType;
 use App\ContactsList;
-use App\ResetPasswordEmailToken;
 use App\Http\Requests\Account\Create\Api\AsAdminRequest;
 use App\Http\Requests\Account\Update\Api\AsAdminRequest as ApiAsAdminRequest;
-use App\Mail\Provisioning;
-use App\Mail\ResetPassword;
 use App\Services\AccountService;
+use App\SipDomain;
 
 class AccountController extends Controller
 {
     public function index(Request $request)
     {
-        return $request->space->accounts()
-            ->without(['passwords', 'admin'])
-            ->with(['phoneChangeCode', 'emailChangeCode'])
-            ->paginate(20);
+        return Account::without(['passwords', 'admin'])->with(['phoneChangeCode', 'emailChangeCode'])->paginate(20);
     }
 
     public function show(Request $request, $accountId)
     {
-        $account = $request->space->accounts()
-            ->without(['passwords', 'admin'])
-            ->with(['phoneChangeCode', 'emailChangeCode'])
-            ->findOrFail($accountId);
+        $account = Account::without(['passwords', 'admin'])->with(['phoneChangeCode', 'emailChangeCode'])->findOrFail($accountId);
 
         if ($request->user()->admin) {
             if ($account->phoneChangeCode) {
@@ -65,29 +56,19 @@ class AccountController extends Controller
         return $account;
     }
 
-    public function search(Request $request, string $sip)
+    public function search(string $sip)
     {
-        $account = $request->space->accounts()->sip($sip)->first();
-
-        if (!$account)
-            abort(404, 'SIP address not found');
-
-        return $account;
+        return Account::sip($sip)->firstOrFail();
     }
 
-    public function searchByEmail(Request $request, string $email)
+    public function searchByEmail(string $email)
     {
-        $account = $request->space->accounts()->where('email', $email)->first();
-
-        if (!$account)
-            abort(404, 'Email address not found');
-
-        return $account;
+        return Account::where('email', $email)->firstOrFail();
     }
 
     public function destroy(Request $request, int $accountId)
     {
-        $account = $request->space->accounts()->findOrFail($accountId);
+        $account = Account::findOrFail($accountId);
 
         if (!$account->hasTombstone()) {
             $tombstone = new AccountTombstone();
@@ -101,9 +82,9 @@ class AccountController extends Controller
         Log::channel('events')->info('API Admin: Account destroyed', ['id' => $account->identifier]);
     }
 
-    public function activate(Request $request, int $accountId)
+    public function activate(int $accountId)
     {
-        $account = $request->space->accounts()->findOrFail($accountId);
+        $account = Account::findOrFail($accountId);
         $account->activated = true;
         $account->save();
 
@@ -112,9 +93,9 @@ class AccountController extends Controller
         return $account;
     }
 
-    public function deactivate(Request $request, int $accountId)
+    public function deactivate(int $accountId)
     {
-        $account = $request->space->accounts()->findOrFail($accountId);
+        $account = Account::findOrFail($accountId);
         $account->activated = false;
         $account->save();
 
@@ -123,9 +104,9 @@ class AccountController extends Controller
         return $account;
     }
 
-    public function block(Request $request, int $accountId)
+    public function block(int $accountId)
     {
-        $account = $request->space->accounts()->findOrFail($accountId);
+        $account = Account::findOrFail($accountId);
         $account->blocked = true;
         $account->save();
 
@@ -134,9 +115,9 @@ class AccountController extends Controller
         return $account;
     }
 
-    public function unblock(Request $request, int $accountId)
+    public function unblock(int $accountId)
     {
-        $account = $request->space->accounts()->findOrFail($accountId);
+        $account = Account::findOrFail($accountId);
         $account->blocked = false;
         $account->save();
 
@@ -145,9 +126,9 @@ class AccountController extends Controller
         return $account;
     }
 
-    public function provision(Request $request, int $accountId)
+    public function provision(int $accountId)
     {
-        $account = $request->space->accounts()->findOrFail($accountId);
+        $account = Account::findOrFail($accountId);
         $account->provision();
         $account->save();
 
@@ -158,6 +139,15 @@ class AccountController extends Controller
 
     public function store(AsAdminRequest $request)
     {
+        // Create the missing SipDomain
+        if ($request->user()->superAdmin
+            && $request->has('domain')
+            && !SipDomain::pluck('domain')->contains($request->get('domain'))) {
+            $sipDomain = new SipDomain();
+            $sipDomain->domain = $request->get('domain');
+            $sipDomain->save();
+        }
+
         return (new AccountService())->store($request)->makeVisible(['confirmation_key', 'provisioning_token']);
     }
 
@@ -167,80 +157,46 @@ class AccountController extends Controller
 
         Log::channel('events')->info('API Admin: Account updated', ['id' => $account->identifier]);
 
-        return $account->makeVisible(['provisioning_token']);
+        return $account->makeVisible(['confirmation_key', 'provisioning_token']);
     }
 
-    public function typeAdd(Request $request, int $accountId, int $typeId)
+    public function typeAdd(int $accountId, int $typeId)
     {
-        if ($request->space->accounts()->findOrFail($accountId)->types()->pluck('id')->contains($typeId)) {
+        if (Account::findOrFail($accountId)->types()->pluck('id')->contains($typeId)) {
             abort(403);
         }
 
         if (AccountType::findOrFail($typeId)) {
-            return $request->space->accounts()->findOrFail($accountId)->types()->attach($typeId);
+            return Account::findOrFail($accountId)->types()->attach($typeId);
         }
     }
 
-    public function typeRemove(Request $request, int $accountId, int $typeId)
+    public function typeRemove(int $accountId, int $typeId)
     {
-        if (!$request->space->accounts()->findOrFail($accountId)->types()->pluck('id')->contains($typeId)) {
+        if (!Account::findOrFail($accountId)->types()->pluck('id')->contains($typeId)) {
             abort(403);
         }
 
-        return $request->space->accounts()->findOrFail($accountId)->types()->detach($typeId);
+        return Account::findOrFail($accountId)->types()->detach($typeId);
     }
 
-    public function contactsListAdd(Request $request, int $accountId, int $contactsListId)
+    public function contactsListAdd(int $accountId, int $contactsListId)
     {
-        if ($request->space->accounts()->findOrFail($accountId)->contactsLists()->pluck('id')->contains($contactsListId)) {
+        if (Account::findOrFail($accountId)->contactsLists()->pluck('id')->contains($contactsListId)) {
             abort(403);
         }
 
         if (ContactsList::findOrFail($contactsListId)) {
-            return $request->space->accounts()->findOrFail($accountId)->contactsLists()->attach($contactsListId);
+            return Account::findOrFail($accountId)->contactsLists()->attach($contactsListId);
         }
     }
 
-    public function contactsListRemove(Request $request, int $accountId, int $contactsListId)
+    public function contactsListRemove(int $accountId, int $contactsListId)
     {
-        if (!$request->space->accounts()->findOrFail($accountId)->contactsLists()->pluck('id')->contains($contactsListId)) {
+        if (!Account::findOrFail($accountId)->contactsLists()->pluck('id')->contains($contactsListId)) {
             abort(403);
         }
 
-        return $request->space->accounts()->findOrFail($accountId)->contactsLists()->detach($contactsListId);
-    }
-
-    /**
-     * Emails
-     */
-
-    public function sendProvisioningEmail(Request $request, int $accountId)
-    {
-        $account = $request->space->accounts()->findOrFail($accountId);
-
-        if (!$account->email)
-            abort(403, 'No email configured');
-
-        $account->provision();
-
-        Mail::to($account)->send(new Provisioning($account));
-
-        Log::channel('events')->info('API: Sending provisioning email', ['id' => $account->identifier]);
-    }
-
-    public function sendResetPasswordEmail(Request $request, int $accountId)
-    {
-        $account = $request->space->accounts()->findOrFail($accountId);
-
-        if (!$account->email)
-            abort(403, 'No email configured');
-
-        $resetPasswordEmail = new ResetPasswordEmailToken;
-        $resetPasswordEmail->account_id = $account->id;
-        $resetPasswordEmail->token = Str::random(16);
-        $resetPasswordEmail->email = $account->email;
-        $resetPasswordEmail->save();
-
-        Mail::to($account)->send(new ResetPassword($account));
+        return Account::findOrFail($accountId)->contactsLists()->detach($contactsListId);
     }
 }

flexiapi/app/Http/Controllers/Api/Admin/AccountCreationTokenController.php

@@ -17,7 +17,7 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Api\Admin\Account;
+namespace App\Http\Controllers\Api\Admin;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
@@ -26,7 +26,7 @@ use Illuminate\Support\Str;
 use App\AccountCreationToken;
 use App\Http\Controllers\Account\AuthenticateController as WebAuthenticateController;
 
-class CreationTokenController extends Controller
+class AccountCreationTokenController extends Controller
 {
     public function create(Request $request)
     {

flexiapi/app/Http/Controllers/Api/Admin/AccountDictionaryController.php

@@ -17,23 +17,23 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Api\Admin\Account;
+namespace App\Http\Controllers\Api\Admin;
 
 use App\Http\Controllers\Controller;
+use App\Account;
 
 use Illuminate\Http\Request;
 
-class DictionaryController extends Controller
+class AccountDictionaryController extends Controller
 {
-    public function index(Request $request, int $accountId)
+    public function index(int $accountId)
     {
-        return $request->space->accounts()->findOrFail($accountId)->dictionary;
+        return Account::findOrFail($accountId)->dictionary;
     }
 
-    public function show(Request $request, int $accountId, string $key)
+    public function show(int $accountId, string $key)
     {
-        return $request->space->accounts()
-            ->findOrFail($accountId)->dictionaryEntries()->where('key', $key)->first();
+        return Account::findOrFail($accountId)->dictionaryEntries()->where('key', $key)->first();
     }
 
     public function set(Request $request, int $accountId, string $key)
@@ -42,7 +42,7 @@ class DictionaryController extends Controller
             'value' => 'required'
         ]);
 
-        $account = $request->space->accounts()->findOrFail($accountId);
+        $account = Account::findOrFail($accountId);
         $result = $account->setDictionaryEntry($key, $request->get('value'));
 
         if (function_exists('accountServiceAccountEditedHook')) {
@@ -53,15 +53,8 @@ class DictionaryController extends Controller
         return $result;
     }
 
-    public function destroy(Request $request, int $accountId, string $key)
+    public function destroy(int $accountId, string $key)
     {
-        return $request->space->accounts()
-            ->findOrFail($accountId)->dictionaryEntries()->where('key', $key)->delete();
-    }
-
-    public function clear(Request $request, int $accountId)
-    {
-        return $request->space->accounts()
-            ->findOrFail($accountId)->dictionaryEntries()->delete();
+        return Account::findOrFail($accountId)->dictionaryEntries()->where('key', $key)->delete();
     }
 }

flexiapi/app/Http/Controllers/Api/Admin/AccountTypeController.php

@@ -17,7 +17,7 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Api\Admin\Account;
+namespace App\Http\Controllers\Api\Admin;
 
 use App\Http\Controllers\Controller;
 use App\Rules\NoUppercase;
@@ -25,7 +25,7 @@ use Illuminate\Http\Request;
 
 use App\AccountType;
 
-class TypeController extends Controller
+class AccountTypeController extends Controller
 {
     public function index()
     {

flexiapi/app/Http/Controllers/Api/Admin/ContactsListController.php

@@ -17,8 +17,9 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-namespace App\Http\Controllers\Api\Admin\Space;
+namespace App\Http\Controllers\Api\Admin;
 
+use App\Account;
 use App\ContactsList;
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
@@ -27,12 +28,12 @@ class ContactsListController extends Controller
 {
     public function index(Request $request)
     {
-        return $request->space->contactsLists;
+        return ContactsList::all();
     }
 
-    public function get(Request $request, int $contactsListId)
+    public function get(int $contactsListId)
     {
-        return $request->space->contactsLists()->findOrFail($contactsListId);
+        return ContactsList::findOrFail($contactsListId);
     }
 
     public function store(Request $request)
@@ -43,7 +44,6 @@ class ContactsListController extends Controller
         ]);
 
         $contactsList = new ContactsList;
-        $contactsList->space_id = $request->space->id;
         $contactsList->title = $request->get('title');
         $contactsList->description = $request->get('description');
         $contactsList->save();
@@ -59,7 +59,6 @@ class ContactsListController extends Controller
         ]);
 
         $contactsList = ContactsList::findOrFail($contactsListId);
-        $contactsList->space_id = $request->space->id;
         $contactsList->title = $request->get('title');
         $contactsList->description = $request->get('description');
         $contactsList->save();
@@ -67,30 +66,29 @@ class ContactsListController extends Controller
         return $contactsList;
     }
 
-    public function destroy(Request $request, int $contactsListId)
+    public function destroy(int $contactsListId)
     {
-        return $request->space->contactsLists()->where('id', $contactsListId)
+        return ContactsList::where('id', $contactsListId)
             ->delete();
     }
 
-    public function contactAdd(Request $request, int $id, int $contactId)
+    public function contactAdd(int $id, int $contactId)
     {
-        $contactsList = $request->space->contactsLists()->findOrFail($id);
-        $contactsList->contacts()->detach($contactId);
+        if (ContactsList::findOrFail($id)->contacts()->pluck('id')->contains($contactId)) {
+            abort(403);
+        }
 
-        if ($request->space->accounts()->findOrFail($contactId)) {
-            return $contactsList->contacts()->attach($contactId);
+        if (Account::findOrFail($contactId)) {
+            return ContactsList::findOrFail($id)->contacts()->attach($contactId);
         }
     }
 
-    public function contactRemove(Request $request, int $id, int $contactId)
+    public function contactRemove(int $id, int $contactId)
     {
-        $contactsList = $request->space->contactsLists()->findOrFail($id);
-
-        if (!$contactsList->contacts()->pluck('id')->contains($contactId)) {
-            abort(404);
+        if (!ContactsList::findOrFail($id)->contacts()->pluck('id')->contains($contactId)) {
+            abort(403);
         }
 
-        return $contactsList->contacts()->detach($contactId);
+        return ContactsList::findOrFail($id)->contacts()->detach($contactId);
     }
 }

flexiapi/app/Http/Controllers/Api/Admin/DeviceController.php

@@ -20,29 +20,23 @@
 namespace App\Http\Controllers\Api\Admin;
 
 use App\Http\Controllers\Controller;
-use App\Libraries\FlexisipRedisConnector;
+use App\Libraries\FlexisipConnector;
 use App\Account;
-use Illuminate\Http\Request;
 use stdClass;
 
 class DeviceController extends Controller
 {
-    public function index(Request $request, int $accountId)
+    public function index(int $accountId)
     {
-        $devices = (new FlexisipRedisConnector)->getDevices(
-            $request->space->accounts()->findOrFail($accountId)->identifier
-        );
+        $devices = (new FlexisipConnector)->getDevices(Account::findOrFail($accountId)->identifier);
 
         return ($devices->isEmpty()) ? new stdClass : $devices;
     }
 
-    public function destroy(Request $request, int $accountId, string $uuid)
+    public function destroy(int $accountId, string $uuid)
     {
-        $connector = new FlexisipRedisConnector;
+        $connector = new FlexisipConnector;
 
-        return $connector->deleteDevice(
-            $request->space->accounts()->findOrFail($accountId)->identifier,
-            $uuid
-        );
+        return $connector->deleteDevice(Account::findOrFail($accountId)->identifier, $uuid);
     }
 }

flexiapi/app/Http/Controllers/Api/Admin/ExternalAccountController.php

@@ -1,43 +0,0 @@
-<?php
-/*
-    Flexisip Account Manager is a set of tools to manage SIP accounts.
-    Copyright (C) 2023 Belledonne Communications SARL, All rights reserved.
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Affero General Public License as
-    published by the Free Software Foundation, either version 3 of the
-    License, or (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU Affero General Public License for more details.
-
-    You should have received a copy of the GNU Affero General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-namespace App\Http\Controllers\Api\Admin;
-
-use App\Http\Controllers\Controller;
-use App\Http\Requests\ExternalAccount\CreateUpdate;
-use App\Services\AccountService;
-use Illuminate\Http\Request;
-
-class ExternalAccountController extends Controller
-{
-    public function show(Request $request, int $accountId)
-    {
-        return $request->space->accounts()->findOrFail($accountId)->external()->firstOrFail();
-    }
-
-    public function store(CreateUpdate $request, int $accountId)
-    {
-        return (new AccountService)->storeExternalAccount($request, $accountId);
-    }
-
-    public function destroy(int $accountId)
-    {
-        return (new AccountService)->deleteExternalAccount($accountId);
-    }
-}