diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2da6a127d..faa86ddf3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -33,6 +33,7 @@ Group changes to describe their impact on the project, as follows:
### Fixed
- Messages not marked as reply in basic chat room if sending more than 1 content
+- Chat message video attachment display when failing to get a preview picture
## [5.0.12] - 2023-05-23
diff --git a/app/src/main/java/org/linphone/utils/DataBindingUtils.kt b/app/src/main/java/org/linphone/utils/DataBindingUtils.kt
index 7fffb7b22..46d499e77 100644
--- a/app/src/main/java/org/linphone/utils/DataBindingUtils.kt
+++ b/app/src/main/java/org/linphone/utils/DataBindingUtils.kt
@@ -339,7 +339,7 @@ fun setImageViewScaleType(imageView: ImageView, scaleType: ImageView.ScaleType)
@BindingAdapter("coilRounded")
fun loadRoundImageWithCoil(imageView: ImageView, path: String?) {
- if (path != null && path.isNotEmpty() && FileUtils.isExtensionImage(path)) {
+ if (!path.isNullOrEmpty() && FileUtils.isExtensionImage(path)) {
imageView.load(path) {
transformations(CircleCropTransformation())
}
@@ -350,7 +350,7 @@ fun loadRoundImageWithCoil(imageView: ImageView, path: String?) {
@BindingAdapter("coil")
fun loadImageWithCoil(imageView: ImageView, path: String?) {
- if (path != null && path.isNotEmpty() && FileUtils.isExtensionImage(path)) {
+ if (!path.isNullOrEmpty() && FileUtils.isExtensionImage(path)) {
if (corePreferences.vfsEnabled && path.startsWith(corePreferences.vfsCachePath)) {
imageView.load(path) {
diskCachePolicy(CachePolicy.DISABLED)
@@ -547,9 +547,23 @@ fun loadAvatarWithCoil(imageView: ImageView, path: String?) {
@BindingAdapter("coilVideoPreview")
fun loadVideoPreview(imageView: ImageView, path: String?) {
- if (path != null && path.isNotEmpty() && FileUtils.isExtensionVideo(path)) {
+ if (!path.isNullOrEmpty() && FileUtils.isExtensionVideo(path)) {
imageView.load(path) {
videoFrameMillis(0)
+ listener(
+ onError = { _, result ->
+ Log.e(
+ "[Data Binding] [Coil] Error getting preview picture from video? [$path]: ${result.throwable}"
+ )
+ },
+ onSuccess = { _, _ ->
+ // Display "play" button above video preview
+ LayoutInflater.from(imageView.context).inflate(
+ R.layout.video_play_button,
+ imageView.parent as ViewGroup
+ )
+ }
+ )
}
}
}
diff --git a/app/src/main/res/layout/chat_message_attachment_cell.xml b/app/src/main/res/layout/chat_message_attachment_cell.xml
index 0ae6f964e..e56fd6740 100644
--- a/app/src/main/res/layout/chat_message_attachment_cell.xml
+++ b/app/src/main/res/layout/chat_message_attachment_cell.xml
@@ -14,8 +14,15 @@
android:layout_margin="5dp"
android:orientation="vertical">
+
+
+
+
-
-
-
-
-
-
-
+ android:textAlignment="center"
+ android:drawablePadding="5dp"
+ android:drawableTop="@{data.pdf ? @drawable/file_pdf : (data.audio ? @drawable/file_audio : @drawable/file), default=@drawable/file}"
+ android:visibility="@{data.image || data.video ? View.GONE : View.VISIBLE, default=gone}"
+ android:text="@{data.fileName, default=`test.txt`}"/>
+
+
-
-
+
+
-
-
-
+
@@ -19,7 +20,22 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:visibility="@{inflatedVisibility}"
- inflatedLifecycleOwner="@{true}">
+ inflatedLifecycleOwner="@{true}"
+ android:background="?attr/backgroundColor">
+
+
-
-
\ No newline at end of file
diff --git a/app/src/main/res/layout/video_play_button.xml b/app/src/main/res/layout/video_play_button.xml
new file mode 100644
index 000000000..5688963d8
--- /dev/null
+++ b/app/src/main/res/layout/video_play_button.xml
@@ -0,0 +1,9 @@
+
+
\ No newline at end of file