From 22795a52845bd606e790b1d2b0217199cfc3e637 Mon Sep 17 00:00:00 2001 From: Sylvain Berfini Date: Thu, 18 Jul 2024 14:21:02 +0200 Subject: [PATCH] Improved main screens' top bar --- .../contacts/fragment/ContactsListFragment.kt | 2 +- .../ui/main/fragment/AbstractMainFragment.kt | 4 +-- .../history/fragment/HistoryListFragment.kt | 2 +- app/src/main/res/drawable/funnel.xml | 6 ++-- .../res/drawable/shape_squircle_main1_500.xml | 5 ++++ .../res/layout-land/chat_list_fragment.xml | 6 ++-- .../layout-land/contacts_list_fragment.xml | 26 +++++------------ .../res/layout-land/history_list_fragment.xml | 26 +++++------------ .../layout-land/meetings_list_fragment.xml | 26 +++++------------ .../main/res/layout/chat_list_fragment.xml | 6 ++-- .../res/layout/contacts_list_fragment.xml | 26 +++++------------ .../main/res/layout/history_list_fragment.xml | 26 +++++------------ ...{top_bar.xml => main_activity_top_bar.xml} | 28 ++++++++++++++++++- .../res/layout/meetings_list_fragment.xml | 26 +++++------------ 14 files changed, 85 insertions(+), 130 deletions(-) create mode 100644 app/src/main/res/drawable/shape_squircle_main1_500.xml rename app/src/main/res/layout/{top_bar.xml => main_activity_top_bar.xml} (83%) diff --git a/app/src/main/java/org/linphone/ui/main/contacts/fragment/ContactsListFragment.kt b/app/src/main/java/org/linphone/ui/main/contacts/fragment/ContactsListFragment.kt index cd5035f40..4977e5b59 100644 --- a/app/src/main/java/org/linphone/ui/main/contacts/fragment/ContactsListFragment.kt +++ b/app/src/main/java/org/linphone/ui/main/contacts/fragment/ContactsListFragment.kt @@ -171,7 +171,7 @@ class ContactsListFragment : AbstractMainFragment() { } binding.setFilterClickListener { - showFilterPopupMenu(binding.filter) + showFilterPopupMenu(binding.topBar.extraAction) } sharedViewModel.showContactEvent.observe( diff --git a/app/src/main/java/org/linphone/ui/main/fragment/AbstractMainFragment.kt b/app/src/main/java/org/linphone/ui/main/fragment/AbstractMainFragment.kt index 827ce3322..6925360a2 100644 --- a/app/src/main/java/org/linphone/ui/main/fragment/AbstractMainFragment.kt +++ b/app/src/main/java/org/linphone/ui/main/fragment/AbstractMainFragment.kt @@ -33,7 +33,7 @@ import com.google.android.material.textfield.TextInputLayout import org.linphone.R import org.linphone.core.tools.Log import org.linphone.databinding.BottomNavBarBinding -import org.linphone.databinding.TopBarBinding +import org.linphone.databinding.MainActivityTopBarBinding import org.linphone.ui.main.MainActivity import org.linphone.ui.main.chat.fragment.ConversationsListFragmentDirections import org.linphone.ui.main.contacts.fragment.ContactsListFragmentDirections @@ -144,7 +144,7 @@ abstract class AbstractMainFragment : GenericMainFragment() { fun initViews( slidingPane: SlidingPaneLayout, - topBar: TopBarBinding, + topBar: MainActivityTopBarBinding, navBar: BottomNavBarBinding, @IdRes fragmentId: Int ) { diff --git a/app/src/main/java/org/linphone/ui/main/history/fragment/HistoryListFragment.kt b/app/src/main/java/org/linphone/ui/main/history/fragment/HistoryListFragment.kt index 0568b2de7..434118732 100644 --- a/app/src/main/java/org/linphone/ui/main/history/fragment/HistoryListFragment.kt +++ b/app/src/main/java/org/linphone/ui/main/history/fragment/HistoryListFragment.kt @@ -299,7 +299,7 @@ class HistoryListFragment : AbstractMainFragment() { // Elevation is for showing a shadow around the popup popupWindow.elevation = 20f - popupWindow.showAsDropDown(binding.menu, 0, 0, Gravity.BOTTOM) + popupWindow.showAsDropDown(binding.topBar.extraAction, 0, 0, Gravity.BOTTOM) } private fun showDeleteConfirmationDialog() { diff --git a/app/src/main/res/drawable/funnel.xml b/app/src/main/res/drawable/funnel.xml index 47df0eac8..db9790d4c 100644 --- a/app/src/main/res/drawable/funnel.xml +++ b/app/src/main/res/drawable/funnel.xml @@ -1,9 +1,9 @@ diff --git a/app/src/main/res/drawable/shape_squircle_main1_500.xml b/app/src/main/res/drawable/shape_squircle_main1_500.xml new file mode 100644 index 000000000..9c52de9ca --- /dev/null +++ b/app/src/main/res/drawable/shape_squircle_main1_500.xml @@ -0,0 +1,5 @@ + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout-land/chat_list_fragment.xml b/app/src/main/res/layout-land/chat_list_fragment.xml index c511aa369..230f5430f 100644 --- a/app/src/main/res/layout-land/chat_list_fragment.xml +++ b/app/src/main/res/layout-land/chat_list_fragment.xml @@ -27,8 +27,7 @@ + android:layout_height="match_parent"> diff --git a/app/src/main/res/layout-land/contacts_list_fragment.xml b/app/src/main/res/layout-land/contacts_list_fragment.xml index e8c921c36..9899bd000 100644 --- a/app/src/main/res/layout-land/contacts_list_fragment.xml +++ b/app/src/main/res/layout-land/contacts_list_fragment.xml @@ -27,8 +27,7 @@ + android:layout_height="match_parent"> - - + app:layout_constraintEnd_toEndOf="parent"/> + android:layout_height="match_parent"> - - + app:layout_constraintEnd_toEndOf="parent"/> + android:layout_height="match_parent"> - - + app:layout_constraintEnd_toEndOf="parent"/> + android:layout_height="match_parent"> diff --git a/app/src/main/res/layout/contacts_list_fragment.xml b/app/src/main/res/layout/contacts_list_fragment.xml index 6601efcbf..e5b2660c9 100644 --- a/app/src/main/res/layout/contacts_list_fragment.xml +++ b/app/src/main/res/layout/contacts_list_fragment.xml @@ -27,8 +27,7 @@ + android:layout_height="match_parent"> - - + app:layout_constraintEnd_toEndOf="parent"/> + android:layout_height="match_parent"> - - + app:layout_constraintEnd_toEndOf="parent"/> + + + + @@ -13,7 +25,7 @@ + android:background="@drawable/shape_squircle_main1_500"> + + diff --git a/app/src/main/res/layout/meetings_list_fragment.xml b/app/src/main/res/layout/meetings_list_fragment.xml index e10718a40..6591b77e8 100644 --- a/app/src/main/res/layout/meetings_list_fragment.xml +++ b/app/src/main/res/layout/meetings_list_fragment.xml @@ -30,8 +30,7 @@ + android:layout_height="match_parent"> - - + app:layout_constraintEnd_toEndOf="parent"/>