From 49059d6b3c89535adc7e014e91ca5fdc6de015b4 Mon Sep 17 00:00:00 2001 From: Sylvain Berfini Date: Wed, 11 Sep 2024 12:39:53 +0200 Subject: [PATCH] Added back round corners to main lists in portrait mode (keep round top bar in landscape) + increased space at the bottom of the avatar in top main bar --- .../fragment/ConversationsListFragment.kt | 1 + .../history/fragment/HistoryListFragment.kt | 1 + .../meetings/fragment/MeetingsListFragment.kt | 1 + ...> shape_squircle_main1_500_r10_bottom.xml} | 0 ...hape_squircle_white_r20_top_background.xml | 5 + .../res/layout-land/chat_list_fragment.xml | 6 +- .../res/layout-land/history_list_fragment.xml | 4 +- .../res/layout-land/main_activity_top_bar.xml | 170 ++++++++++++++++++ .../layout-land/meetings_list_fragment.xml | 29 +-- .../main/res/layout/chat_list_fragment.xml | 36 ++-- .../res/layout/contacts_list_fragment.xml | 5 +- .../main/res/layout/history_list_fragment.xml | 36 ++-- .../main/res/layout/main_activity_top_bar.xml | 6 +- .../res/layout/meetings_list_decoration.xml | 4 +- .../res/layout/meetings_list_fragment.xml | 40 +---- 15 files changed, 223 insertions(+), 121 deletions(-) rename app/src/main/res/drawable/{shape_squircle_main1_500.xml => shape_squircle_main1_500_r10_bottom.xml} (100%) create mode 100644 app/src/main/res/drawable/shape_squircle_white_r20_top_background.xml create mode 100644 app/src/main/res/layout-land/main_activity_top_bar.xml diff --git a/app/src/main/java/org/linphone/ui/main/chat/fragment/ConversationsListFragment.kt b/app/src/main/java/org/linphone/ui/main/chat/fragment/ConversationsListFragment.kt index 1d8c5bf27..54fe0f451 100644 --- a/app/src/main/java/org/linphone/ui/main/chat/fragment/ConversationsListFragment.kt +++ b/app/src/main/java/org/linphone/ui/main/chat/fragment/ConversationsListFragment.kt @@ -119,6 +119,7 @@ class ConversationsListFragment : AbstractMainFragment() { binding.conversationsList.setHasFixedSize(true) binding.conversationsList.layoutManager = LinearLayoutManager(requireContext()) + binding.conversationsList.clipToOutline = true adapter.conversationLongClickedEvent.observe(viewLifecycleOwner) { it.consume { model -> diff --git a/app/src/main/java/org/linphone/ui/main/history/fragment/HistoryListFragment.kt b/app/src/main/java/org/linphone/ui/main/history/fragment/HistoryListFragment.kt index 2d9599962..59b905552 100644 --- a/app/src/main/java/org/linphone/ui/main/history/fragment/HistoryListFragment.kt +++ b/app/src/main/java/org/linphone/ui/main/history/fragment/HistoryListFragment.kt @@ -106,6 +106,7 @@ class HistoryListFragment : AbstractMainFragment() { binding.historyList.setHasFixedSize(true) binding.historyList.layoutManager = LinearLayoutManager(requireContext()) + binding.historyList.clipToOutline = true adapter.callLogLongClickedEvent.observe(viewLifecycleOwner) { it.consume { model -> diff --git a/app/src/main/java/org/linphone/ui/main/meetings/fragment/MeetingsListFragment.kt b/app/src/main/java/org/linphone/ui/main/meetings/fragment/MeetingsListFragment.kt index 47a9e3f22..1cc206004 100644 --- a/app/src/main/java/org/linphone/ui/main/meetings/fragment/MeetingsListFragment.kt +++ b/app/src/main/java/org/linphone/ui/main/meetings/fragment/MeetingsListFragment.kt @@ -118,6 +118,7 @@ class MeetingsListFragment : AbstractMainFragment() { val headerItemDecoration = RecyclerViewHeaderDecoration(requireContext(), adapter) binding.meetingsList.addItemDecoration(headerItemDecoration) + binding.meetingsList.clipToOutline = true binding.setNewMeetingClicked { if (findNavController().currentDestination?.id == R.id.meetingsListFragment) { diff --git a/app/src/main/res/drawable/shape_squircle_main1_500.xml b/app/src/main/res/drawable/shape_squircle_main1_500_r10_bottom.xml similarity index 100% rename from app/src/main/res/drawable/shape_squircle_main1_500.xml rename to app/src/main/res/drawable/shape_squircle_main1_500_r10_bottom.xml diff --git a/app/src/main/res/drawable/shape_squircle_white_r20_top_background.xml b/app/src/main/res/drawable/shape_squircle_white_r20_top_background.xml new file mode 100644 index 000000000..cb88a6922 --- /dev/null +++ b/app/src/main/res/drawable/shape_squircle_white_r20_top_background.xml @@ -0,0 +1,5 @@ + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout-land/chat_list_fragment.xml b/app/src/main/res/layout-land/chat_list_fragment.xml index 2af0f6afe..164e0e38a 100644 --- a/app/src/main/res/layout-land/chat_list_fragment.xml +++ b/app/src/main/res/layout-land/chat_list_fragment.xml @@ -55,11 +55,11 @@ app:layout_constraintStart_toEndOf="@id/bottom_nav_bar" app:layout_constraintEnd_toEndOf="parent"/> - + android:layout_marginStart="@dimen/landscape_nav_bar_width"/> - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout-land/meetings_list_fragment.xml b/app/src/main/res/layout-land/meetings_list_fragment.xml index 0f02cd2fb..c303c48e5 100644 --- a/app/src/main/res/layout-land/meetings_list_fragment.xml +++ b/app/src/main/res/layout-land/meetings_list_fragment.xml @@ -62,42 +62,17 @@ app:layout_constraintStart_toEndOf="@id/bottom_nav_bar" app:layout_constraintEnd_toEndOf="parent"/> - - - - - + android:layout_height="match_parent" + android:background="?attr/color_main1_500"> - + android:layout_marginTop="@dimen/top_bar_height" + app:layout_constraintTop_toTopOf="parent" + app:layout_constraintBottom_toTopOf="@id/bottom_nav_bar" /> + app:layout_constraintTop_toTopOf="@id/conversations_list" + app:layout_constraintBottom_toTopOf="@id/no_conversation_label" /> - - + app:layout_constraintTop_toBottomOf="@id/no_conversation_image" + app:layout_constraintBottom_toBottomOf="@id/conversations_list"/> + android:layout_height="match_parent" + android:background="?attr/color_main1_500"> + android:layout_height="match_parent" + android:background="?attr/color_main1_500"> - + android:layout_marginTop="@dimen/top_bar_height" + app:layout_constraintTop_toTopOf="parent" + app:layout_constraintBottom_toTopOf="@id/bottom_nav_bar" /> + app:layout_constraintTop_toTopOf="@id/history_list" + app:layout_constraintBottom_toTopOf="@id/no_calls_label" /> - - + app:layout_constraintTop_toBottomOf="@id/no_calls_image" + app:layout_constraintBottom_toBottomOf="@id/history_list" /> + android:background="?attr/color_main1_500"> + app:layout_constraintTop_toTopOf="parent"/> + android:gravity="center_vertical" /> \ No newline at end of file diff --git a/app/src/main/res/layout/meetings_list_fragment.xml b/app/src/main/res/layout/meetings_list_fragment.xml index c930a881c..4c21bf51a 100644 --- a/app/src/main/res/layout/meetings_list_fragment.xml +++ b/app/src/main/res/layout/meetings_list_fragment.xml @@ -30,7 +30,8 @@ + android:layout_height="match_parent" + android:background="?attr/color_main1_500"> - - - - - -