From 62eea3fdb4c195d6e9773226877b2ccaae483044 Mon Sep 17 00:00:00 2001
From: Sylvain Berfini <sylvain.berfini@belledonne-communications.com>
Date: Tue, 29 Mar 2022 10:35:57 +0200
Subject: [PATCH] Trying to prevent dummy sync service to be run by system

---
 CHANGELOG.md                                               | 1 +
 app/src/main/AndroidManifest.xml                           | 4 ++--
 app/src/main/java/org/linphone/contact/DummySyncService.kt | 2 +-
 app/src/main/res/xml/sync_adapter.xml                      | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1c6e1302f..3844f8fb2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,7 @@ Group changes to describe their impact on the project, as follows:
 ### Fixed
 - Catching exceptions in new ContactsLoader reported on PlayStore
 - Missing phone numbers in contacts when label contains a space character (5.1.24 SDK fix) 
+- Prevent app from starting by itself due to DummySyncService
 - Hide chat rooms settings not working properly
 
 ## [4.6.5] - 2022-04-11
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 645d02e57..f970094c9 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -158,7 +158,7 @@
 
         <service
             android:name=".contact.DummySyncService"
-            android:exported="true">
+            android:exported="false">
             <intent-filter>
                 <action android:name="android.content.SyncAdapter" />
             </intent-filter>
@@ -172,7 +172,7 @@
         </service>
 
         <service android:name=".contact.DummyAuthenticationService"
-            android:exported="true">
+            android:exported="false">
             <intent-filter>
                 <action android:name="android.accounts.AccountAuthenticator" />
             </intent-filter>
diff --git a/app/src/main/java/org/linphone/contact/DummySyncService.kt b/app/src/main/java/org/linphone/contact/DummySyncService.kt
index a040dafca..d4c617868 100644
--- a/app/src/main/java/org/linphone/contact/DummySyncService.kt
+++ b/app/src/main/java/org/linphone/contact/DummySyncService.kt
@@ -47,7 +47,7 @@ class DummySyncService : Service() {
         synchronized(syncAdapterLock) {
             Log.i("[Dummy Sync Adapter] Sync Service created")
             if (syncAdapter == null) {
-                syncAdapter = DummySyncAdapter(applicationContext, true)
+                syncAdapter = DummySyncAdapter(applicationContext, false)
                 Log.i("[Dummy Sync Adapter] Sync Adapter created")
             }
         }
diff --git a/app/src/main/res/xml/sync_adapter.xml b/app/src/main/res/xml/sync_adapter.xml
index 2be6acf4d..b0b3caaf5 100644
--- a/app/src/main/res/xml/sync_adapter.xml
+++ b/app/src/main/res/xml/sync_adapter.xml
@@ -4,6 +4,6 @@
     android:accountType="@string/sync_account_type"
     android:contentAuthority="com.android.contacts"
     android:supportsUploading="false"
-    android:userVisible="true"
+    android:userVisible="false"
     android:allowParallelSyncs="false"
     android:isAlwaysSyncable="false" />