From 7ab7136a5b718022d74a1bbe7df573def313d534 Mon Sep 17 00:00:00 2001 From: Sylvain Berfini Date: Mon, 27 Oct 2025 14:13:32 +0100 Subject: [PATCH] Fixed contacts list cell clipping --- .../ui/main/contacts/fragment/ContactsListFragment.kt | 5 +++++ app/src/main/res/layout/contact_list_cell.xml | 4 ++-- app/src/main/res/layout/contacts_list_fragment.xml | 8 ++++---- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/org/linphone/ui/main/contacts/fragment/ContactsListFragment.kt b/app/src/main/java/org/linphone/ui/main/contacts/fragment/ContactsListFragment.kt index 0457543fa..0cea2cdf1 100644 --- a/app/src/main/java/org/linphone/ui/main/contacts/fragment/ContactsListFragment.kt +++ b/app/src/main/java/org/linphone/ui/main/contacts/fragment/ContactsListFragment.kt @@ -136,6 +136,7 @@ class ContactsListFragment : AbstractMainFragment() { binding.contactsList.setHasFixedSize(true) binding.contactsList.layoutManager = LinearLayoutManager(requireContext()) + binding.contactsList.outlineProvider = outlineProvider binding.favouritesContactsList.setHasFixedSize(true) val favouritesLayoutManager = LinearLayoutManager(requireContext()) @@ -145,6 +146,10 @@ class ContactsListFragment : AbstractMainFragment() { configureAdapter(adapter) configureAdapter(favouritesAdapter) + listViewModel.isListFiltered.observe(viewLifecycleOwner) { filtered -> + binding.contactsList.clipToOutline = filtered + } + listViewModel.contactsList.observe( viewLifecycleOwner ) { diff --git a/app/src/main/res/layout/contact_list_cell.xml b/app/src/main/res/layout/contact_list_cell.xml index e747776fe..89031a693 100644 --- a/app/src/main/res/layout/contact_list_cell.xml +++ b/app/src/main/res/layout/contact_list_cell.xml @@ -25,8 +25,8 @@ android:onContextClick="@{onLongClickListener}" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginStart="4dp" - android:layout_marginEnd="16dp" + android:paddingStart="4dp" + android:paddingEnd="16dp" android:paddingTop="5dp" android:paddingBottom="5dp" android:background="@drawable/primary_cell_background"> diff --git a/app/src/main/res/layout/contacts_list_fragment.xml b/app/src/main/res/layout/contacts_list_fragment.xml index 9d4717c01..201628e4c 100644 --- a/app/src/main/res/layout/contacts_list_fragment.xml +++ b/app/src/main/res/layout/contacts_list_fragment.xml @@ -81,6 +81,7 @@ android:layout_marginStart="16dp" android:layout_marginEnd="16dp" android:layout_marginTop="10dp" + android:layout_marginBottom="4dp" android:text="@string/contacts_list_favourites_title" android:drawableEnd="@{viewModel.showFavourites ? @drawable/caret_up : @drawable/caret_down, default=@drawable/caret_up}" android:drawableTint="?attr/color_main2_600" /> @@ -89,8 +90,7 @@ android:id="@+id/favourites_contacts_list" android:visibility="@{viewModel.showFavourites && !viewModel.isListFiltered && viewModel.favouritesList.size() > 0 ? View.VISIBLE : View.GONE}" android:layout_width="match_parent" - android:layout_height="wrap_content" - android:layout_marginTop="4dp" /> + android:layout_height="wrap_content" /> + android:layout_height="match_parent">