diff --git a/app/src/main/java/org/linphone/contacts/AvatarGenerator.kt b/app/src/main/java/org/linphone/contacts/AvatarGenerator.kt
index 6fb729ef3..c67069226 100644
--- a/app/src/main/java/org/linphone/contacts/AvatarGenerator.kt
+++ b/app/src/main/java/org/linphone/contacts/AvatarGenerator.kt
@@ -30,21 +30,11 @@ import org.linphone.R
import org.linphone.utils.AppUtils
class AvatarGenerator(private val context: Context) {
- private var textSize: Float
- private var textColor: Int
- private var avatarSize: Int
+ private var textSize: Float = AppUtils.getDimension(R.dimen.avatar_initials_text_size)
+ private var textColor: Int = ContextCompat.getColor(context, R.color.gray_main2_600)
+ private var avatarSize: Int = AppUtils.getDimension(R.dimen.avatar_list_cell_size).toInt()
private var initials = " "
- private var backgroundColor: Int
-
- init {
- backgroundColor = ContextCompat.getColor(context, R.color.gray_main2_200)
-
- textColor = ContextCompat.getColor(context, R.color.gray_main2_600)
-
- textSize = AppUtils.getDimension(R.dimen.avatar_initials_text_size)
-
- avatarSize = AppUtils.getDimension(R.dimen.avatar_list_cell_size).toInt()
- }
+ private var backgroundColor: Int = ContextCompat.getColor(context, R.color.gray_main2_200)
fun setTextSize(size: Float) = apply {
textSize = size
diff --git a/app/src/main/java/org/linphone/ui/assistant/fragment/RegisterFragment.kt b/app/src/main/java/org/linphone/ui/assistant/fragment/RegisterFragment.kt
index 3abb582dd..c89ec51cf 100644
--- a/app/src/main/java/org/linphone/ui/assistant/fragment/RegisterFragment.kt
+++ b/app/src/main/java/org/linphone/ui/assistant/fragment/RegisterFragment.kt
@@ -174,7 +174,7 @@ class RegisterFragment : Fragment() {
viewModel.dialPlansLabelList
) {
override fun getView(position: Int, convertView: View?, parent: ViewGroup): View {
- val view = convertView ?: super.getView(position, convertView, parent)
+ val view = convertView ?: super.getView(position, null, parent)
val label = viewModel.dialPlansShortLabelList[position]
(view as? AppCompatTextView)?.text = label
return view
diff --git a/app/src/main/java/org/linphone/ui/main/meetings/viewmodel/MeetingViewModel.kt b/app/src/main/java/org/linphone/ui/main/meetings/viewmodel/MeetingViewModel.kt
index e1acada39..aede6ba6b 100644
--- a/app/src/main/java/org/linphone/ui/main/meetings/viewmodel/MeetingViewModel.kt
+++ b/app/src/main/java/org/linphone/ui/main/meetings/viewmodel/MeetingViewModel.kt
@@ -72,9 +72,6 @@ class MeetingViewModel @UiThread constructor() : ViewModel() {
private lateinit var conferenceInfo: ConferenceInfo
- init {
- }
-
override fun onCleared() {
super.onCleared()
diff --git a/app/src/main/java/org/linphone/ui/main/meetings/viewmodel/MeetingsListViewModel.kt b/app/src/main/java/org/linphone/ui/main/meetings/viewmodel/MeetingsListViewModel.kt
index 15f5056c8..1974a86d9 100644
--- a/app/src/main/java/org/linphone/ui/main/meetings/viewmodel/MeetingsListViewModel.kt
+++ b/app/src/main/java/org/linphone/ui/main/meetings/viewmodel/MeetingsListViewModel.kt
@@ -125,9 +125,7 @@ class MeetingsListViewModel @UiThread constructor() : AbstractTopBarViewModel()
TimestampUtils.isAfterToday(it.timestamp)
}
Log.i("$TAG $firstMeetingAfterToday")
- if (firstMeetingAfterToday != null) {
- firstMeetingAfterToday.displayTodayIndicator.postValue(true)
- }
+ firstMeetingAfterToday?.displayTodayIndicator?.postValue(true)
}
meetings.postValue(list)
diff --git a/app/src/main/java/org/linphone/ui/main/settings/fragment/AccountSettingsFragment.kt b/app/src/main/java/org/linphone/ui/main/settings/fragment/AccountSettingsFragment.kt
index 93abe4509..0b8eb0c61 100644
--- a/app/src/main/java/org/linphone/ui/main/settings/fragment/AccountSettingsFragment.kt
+++ b/app/src/main/java/org/linphone/ui/main/settings/fragment/AccountSettingsFragment.kt
@@ -34,9 +34,9 @@ class AccountSettingsFragment : GenericFragment() {
private val dropdownListener = object : AdapterView.OnItemSelectedListener {
override fun onItemSelected(parent: AdapterView<*>?, view: View?, position: Int, id: Long) {
val transport = viewModel.availableTransports[position]
- val transportType = when {
- transport == TransportType.Tcp.name.uppercase(Locale.getDefault()) -> TransportType.Tcp
- transport == TransportType.Tls.name.uppercase(Locale.getDefault()) -> TransportType.Tls
+ val transportType = when (transport) {
+ TransportType.Tcp.name.uppercase(Locale.getDefault()) -> TransportType.Tcp
+ TransportType.Tls.name.uppercase(Locale.getDefault()) -> TransportType.Tls
else -> TransportType.Udp
}
Log.i("$TAG Selected transport updated [$transport] -> [${transportType.name}]")
diff --git a/app/src/main/java/org/linphone/ui/main/settings/viewmodel/AccountProfileViewModel.kt b/app/src/main/java/org/linphone/ui/main/settings/viewmodel/AccountProfileViewModel.kt
index 64f995c6b..3705b3238 100644
--- a/app/src/main/java/org/linphone/ui/main/settings/viewmodel/AccountProfileViewModel.kt
+++ b/app/src/main/java/org/linphone/ui/main/settings/viewmodel/AccountProfileViewModel.kt
@@ -115,7 +115,7 @@ class AccountProfileViewModel @UiThread constructor() : ViewModel() {
val prefix = account.params.internationalPrefix
if (!prefix.isNullOrEmpty()) {
Log.i(
- "$TAG Account [${account.params?.identityAddress?.asStringUriOnly()}] prefix is [$prefix]"
+ "$TAG Account [${account.params.identityAddress?.asStringUriOnly()}] prefix is [$prefix]"
)
val dialPlan = Factory.instance().dialPlans.find {
it.countryCallingCode == prefix
diff --git a/app/src/main/res/color/list_cell_background_color.xml b/app/src/main/res/color/list_cell_background_color.xml
deleted file mode 100644
index 1221b511e..000000000
--- a/app/src/main/res/color/list_cell_background_color.xml
+++ /dev/null
@@ -1,9 +0,0 @@
-
-
-
-
-
-
diff --git a/app/src/main/res/drawable/shape_remote_recording_background.xml b/app/src/main/res/drawable/shape_remote_recording_background.xml
deleted file mode 100644
index 1fd7a73de..000000000
--- a/app/src/main/res/drawable/shape_remote_recording_background.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-
-
-
-
-
\ No newline at end of file
diff --git a/app/src/main/res/layout-land/chat_list_fragment.xml b/app/src/main/res/layout-land/chat_list_fragment.xml
index 1f9861d41..328fab6d2 100644
--- a/app/src/main/res/layout-land/chat_list_fragment.xml
+++ b/app/src/main/res/layout-land/chat_list_fragment.xml
@@ -41,7 +41,7 @@
android:layout_width="@dimen/landscape_nav_bar_width"
android:layout_height="match_parent"
layout="@layout/bottom_nav_bar"
- viewModel="@{viewModel}"
+ bind:viewModel="@{viewModel}"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBottom_toBottomOf="parent" />
diff --git a/app/src/main/res/layout-land/contacts_list_fragment.xml b/app/src/main/res/layout-land/contacts_list_fragment.xml
index e0a4e98b7..2e348dfdc 100644
--- a/app/src/main/res/layout-land/contacts_list_fragment.xml
+++ b/app/src/main/res/layout-land/contacts_list_fragment.xml
@@ -41,7 +41,7 @@
android:layout_width="@dimen/landscape_nav_bar_width"
android:layout_height="match_parent"
layout="@layout/bottom_nav_bar"
- viewModel="@{viewModel}"
+ bind:viewModel="@{viewModel}"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBottom_toBottomOf="parent" />
diff --git a/app/src/main/res/layout-land/history_list_fragment.xml b/app/src/main/res/layout-land/history_list_fragment.xml
index 410e0cbb9..3beb72f1f 100644
--- a/app/src/main/res/layout-land/history_list_fragment.xml
+++ b/app/src/main/res/layout-land/history_list_fragment.xml
@@ -47,7 +47,7 @@
android:layout_width="@dimen/landscape_nav_bar_width"
android:layout_height="match_parent"
layout="@layout/bottom_nav_bar"
- viewModel="@{viewModel}"
+ bind:viewModel="@{viewModel}"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBottom_toBottomOf="parent" />
diff --git a/app/src/main/res/layout-land/meetings_list_fragment.xml b/app/src/main/res/layout-land/meetings_list_fragment.xml
index 985569c2c..975e22e89 100644
--- a/app/src/main/res/layout-land/meetings_list_fragment.xml
+++ b/app/src/main/res/layout-land/meetings_list_fragment.xml
@@ -44,7 +44,7 @@
android:layout_width="@dimen/landscape_nav_bar_width"
android:layout_height="match_parent"
layout="@layout/bottom_nav_bar"
- viewModel="@{viewModel}"
+ bind:viewModel="@{viewModel}"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBottom_toBottomOf="parent" />
diff --git a/app/src/main/res/layout/assistant_country_picker_dropdown_cell.xml b/app/src/main/res/layout/assistant_country_picker_dropdown_cell.xml
index 737fff4e2..ec42e5957 100644
--- a/app/src/main/res/layout/assistant_country_picker_dropdown_cell.xml
+++ b/app/src/main/res/layout/assistant_country_picker_dropdown_cell.xml
@@ -1,11 +1,12 @@
\ No newline at end of file
+ android:paddingEnd="20dp"
+ tools:ignore="HardcodedText" />
\ No newline at end of file
diff --git a/app/src/main/res/layout/call_numpad_bottom_sheet.xml b/app/src/main/res/layout/call_numpad_bottom_sheet.xml
index 3b06f4eae..a86deb752 100644
--- a/app/src/main/res/layout/call_numpad_bottom_sheet.xml
+++ b/app/src/main/res/layout/call_numpad_bottom_sheet.xml
@@ -1,6 +1,7 @@
+ xmlns:app="http://schemas.android.com/apk/res-auto"
+ xmlns:tools="http://schemas.android.com/tools">
@@ -20,7 +21,8 @@
android:focusable="true"
app:behavior_hideable="true"
app:behavior_peekHeight="0dp"
- app:layout_behavior="com.google.android.material.bottomsheet.BottomSheetBehavior">
+ app:layout_behavior="com.google.android.material.bottomsheet.BottomSheetBehavior"
+ tools:ignore="HardcodedText">
-
+
@@ -174,7 +174,7 @@
android:layout_height="wrap_content"
android:visibility="@{model.meetingFound ? View.VISIBLE : View.GONE, default=gone}"
android:layout="@layout/chat_bubble_meeting_invite_content"
- model="@{model}"/>
+ bind:model="@{model}"/>
+ bind:model="@{model}" />
+ xmlns:app="http://schemas.android.com/apk/res-auto"
+ xmlns:bind="http://schemas.android.com/tools">
@@ -164,7 +165,7 @@
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBottom_toTopOf="@id/bottom_barrier"
- model="@{model}"
+ bind:model="@{model}"
layout="@layout/chat_bubble_outgoing"/>
+ bind:model="@{model}"/>
diff --git a/app/src/main/res/layout/chat_bubble_outgoing.xml b/app/src/main/res/layout/chat_bubble_outgoing.xml
index 79c675eb1..54c61036c 100644
--- a/app/src/main/res/layout/chat_bubble_outgoing.xml
+++ b/app/src/main/res/layout/chat_bubble_outgoing.xml
@@ -1,7 +1,7 @@
-
+
@@ -136,7 +136,7 @@
android:layout_height="wrap_content"
android:visibility="@{model.meetingFound ? View.VISIBLE : View.GONE, default=gone}"
android:layout="@layout/chat_bubble_meeting_invite_content"
- model="@{model}"/>
+ bind:model="@{model}"/>
+ bind:model="@{model}" />
+ xmlns:app="http://schemas.android.com/apk/res-auto"
+ xmlns:bind="http://schemas.android.com/tools">
@@ -233,8 +234,8 @@
diff --git a/app/src/main/res/layout/chat_conversation_send_area_bottom_sheet.xml b/app/src/main/res/layout/chat_conversation_send_area_bottom_sheet.xml
index 97724818a..b86478b3d 100644
--- a/app/src/main/res/layout/chat_conversation_send_area_bottom_sheet.xml
+++ b/app/src/main/res/layout/chat_conversation_send_area_bottom_sheet.xml
@@ -1,7 +1,7 @@
+ xmlns:bind="http://schemas.android.com/tools">
@@ -30,14 +30,14 @@
diff --git a/app/src/main/res/layout/chat_event.xml b/app/src/main/res/layout/chat_event.xml
index 9fbbf998e..cc55cc1b4 100644
--- a/app/src/main/res/layout/chat_event.xml
+++ b/app/src/main/res/layout/chat_event.xml
@@ -1,7 +1,6 @@
+ xmlns:android="http://schemas.android.com/apk/res/android">
diff --git a/app/src/main/res/layout/chat_list_fragment.xml b/app/src/main/res/layout/chat_list_fragment.xml
index 7cf159e8f..a854d7d93 100644
--- a/app/src/main/res/layout/chat_list_fragment.xml
+++ b/app/src/main/res/layout/chat_list_fragment.xml
@@ -94,7 +94,7 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
layout="@layout/bottom_nav_bar"
- viewModel="@{viewModel}"
+ bind:viewModel="@{viewModel}"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintBottom_toBottomOf="parent" />
diff --git a/app/src/main/res/layout/contacts_list_fragment.xml b/app/src/main/res/layout/contacts_list_fragment.xml
index 2a3bde1fa..fb6472c58 100644
--- a/app/src/main/res/layout/contacts_list_fragment.xml
+++ b/app/src/main/res/layout/contacts_list_fragment.xml
@@ -148,7 +148,7 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
layout="@layout/bottom_nav_bar"
- viewModel="@{viewModel}"
+ bind:viewModel="@{viewModel}"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintBottom_toBottomOf="parent" />
diff --git a/app/src/main/res/layout/generic_add_participants_fragment.xml b/app/src/main/res/layout/generic_add_participants_fragment.xml
index cffb930af..e7f2530e9 100644
--- a/app/src/main/res/layout/generic_add_participants_fragment.xml
+++ b/app/src/main/res/layout/generic_add_participants_fragment.xml
@@ -1,7 +1,6 @@
+ xmlns:app="http://schemas.android.com/apk/res-auto">
diff --git a/app/src/main/res/layout/generic_dropdown_cell.xml b/app/src/main/res/layout/generic_dropdown_cell.xml
index 91b59eeb6..3dce72423 100644
--- a/app/src/main/res/layout/generic_dropdown_cell.xml
+++ b/app/src/main/res/layout/generic_dropdown_cell.xml
@@ -1,11 +1,12 @@
\ No newline at end of file
+ android:paddingEnd="20dp"
+ tools:ignore="HardcodedText" />
\ No newline at end of file
diff --git a/app/src/main/res/layout/history_list_fragment.xml b/app/src/main/res/layout/history_list_fragment.xml
index dc990e7dd..b834725a5 100644
--- a/app/src/main/res/layout/history_list_fragment.xml
+++ b/app/src/main/res/layout/history_list_fragment.xml
@@ -113,7 +113,7 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
layout="@layout/bottom_nav_bar"
- viewModel="@{viewModel}"
+ bind:viewModel="@{viewModel}"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintBottom_toBottomOf="parent" />
diff --git a/app/src/main/res/layout/meeting_schedule_fragment.xml b/app/src/main/res/layout/meeting_schedule_fragment.xml
index 8a9697afd..1af49e443 100644
--- a/app/src/main/res/layout/meeting_schedule_fragment.xml
+++ b/app/src/main/res/layout/meeting_schedule_fragment.xml
@@ -1,6 +1,7 @@
+ xmlns:app="http://schemas.android.com/apk/res-auto"
+ xmlns:bind="http://schemas.android.com/tools">
diff --git a/app/src/main/res/layout/meetings_list_decoration.xml b/app/src/main/res/layout/meetings_list_decoration.xml
index d290c00f3..015af597d 100644
--- a/app/src/main/res/layout/meetings_list_decoration.xml
+++ b/app/src/main/res/layout/meetings_list_decoration.xml
@@ -1,5 +1,5 @@
-
@@ -15,9 +15,11 @@
android:paddingTop="16dp"
android:paddingBottom="16dp"
android:paddingStart="16dp"
+ android:paddingEnd="16dp"
android:text="October"
android:textSize="20sp"
android:textColor="@color/gray_main2_600"
- android:gravity="center_vertical"/>
+ android:gravity="center_vertical"
+ tools:ignore="HardcodedText" />
\ No newline at end of file
diff --git a/app/src/main/res/layout/meetings_list_fragment.xml b/app/src/main/res/layout/meetings_list_fragment.xml
index 699639e01..463fb98fb 100644
--- a/app/src/main/res/layout/meetings_list_fragment.xml
+++ b/app/src/main/res/layout/meetings_list_fragment.xml
@@ -110,7 +110,7 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
layout="@layout/bottom_nav_bar"
- viewModel="@{viewModel}"
+ bind:viewModel="@{viewModel}"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintBottom_toBottomOf="parent" />
diff --git a/app/src/main/res/layout/start_call_numpad_bottom_sheet.xml b/app/src/main/res/layout/start_call_numpad_bottom_sheet.xml
index 8082d462a..67df69354 100644
--- a/app/src/main/res/layout/start_call_numpad_bottom_sheet.xml
+++ b/app/src/main/res/layout/start_call_numpad_bottom_sheet.xml
@@ -1,6 +1,7 @@
+ xmlns:app="http://schemas.android.com/apk/res-auto"
+ xmlns:tools="http://schemas.android.com/tools">
@@ -20,7 +21,8 @@
android:focusable="true"
app:behavior_hideable="true"
app:behavior_peekHeight="0dp"
- app:layout_behavior="com.google.android.material.bottomsheet.BottomSheetBehavior">
+ app:layout_behavior="com.google.android.material.bottomsheet.BottomSheetBehavior"
+ tools:ignore="HardcodedText">
450dp
110dp
- 125dp
235dp
\ No newline at end of file
diff --git a/app/src/main/res/values/dimen.xml b/app/src/main/res/values/dimen.xml
index 01f81727f..4c668c963 100644
--- a/app/src/main/res/values/dimen.xml
+++ b/app/src/main/res/values/dimen.xml
@@ -43,7 +43,6 @@
28dp
48dp
110dp
- 235dp
345dp
120dp
20dp
@@ -63,9 +62,6 @@
4dp
16dp
- 110dp
- 12dp
- 5dp
30sp
88dp
150dp
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 130f16842..a4099e3ca 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -39,7 +39,6 @@
SIP address
Display name
Domain
- Cancel
Username
Password
Phone number
@@ -139,8 +138,7 @@
Login
Scan QR code
- Configuration successfully applied
- Remote configuration failed!
+ Configuration successfully applied+
Use a third party SIP account
Single sign on
No account yet?