From a81973e4cffc843731fc1cbba9777b4a2fae157e Mon Sep 17 00:00:00 2001 From: Sylvain Berfini Date: Mon, 16 Jun 2025 14:28:00 +0200 Subject: [PATCH] Using style to factorize popup menus attributes, added hover effect (same as pressed) & improved some layouts --- CHANGELOG.md | 2 + .../main/res/color/icon_color_selector.xml | 1 + .../res/color/icon_primary_color_selector.xml | 1 + .../in_call_button_background_tint_color.xml | 1 + .../main/res/color/in_call_button_color.xml | 2 + .../res/color/in_call_button_tint_color.xml | 1 + .../res/color/primary_button_label_color.xml | 2 + .../color/secondary_button_label_color.xml | 2 + .../res/color/tertiary_button_label_color.xml | 1 + .../res/drawable/action_background_bottom.xml | 2 + .../res/drawable/action_background_full.xml | 2 + .../res/drawable/action_background_middle.xml | 2 + .../res/drawable/action_background_top.xml | 2 + .../circle_light_blue_button_background.xml | 2 + .../circle_white_button_background.xml | 2 + .../in_call_button_background_green.xml | 2 + .../in_call_button_background_red.xml | 2 + .../in_call_button_background_transparent.xml | 13 ++++ .../res/drawable/menu_item_background.xml | 2 + .../drawable/popup_menu_button_background.xml | 9 +++ .../drawable/primary_button_background.xml | 2 + .../res/drawable/primary_cell_background.xml | 2 + .../drawable/primary_cell_background_alt.xml | 2 + .../drawable/primary_cell_r10_background.xml | 2 + .../drawable/secondary_button_background.xml | 2 + .../drawable/secondary_cell_background.xml | 2 + ...pe_round_popup_menu_pressed_background.xml | 5 ++ .../shape_round_transparent_background.xml | 5 ++ .../squircle_green_button_background.xml | 2 + .../squircle_red_button_background.xml | 2 + .../drawable/tertiary_button_background.xml | 2 + .../main/res/layout/account_popup_menu.xml | 10 ++- .../main/res/layout/call_actions_generic.xml | 43 ++++-------- ...onference_participants_list_popup_menu.xml | 11 +--- app/src/main/res/layout/call_numpad_digit.xml | 14 +--- .../layout/call_numpad_digit_with_letters.xml | 14 +--- .../layout/call_numpad_digit_with_plus.xml | 14 +--- .../call_numpad_digit_with_voicemail.xml | 14 +--- .../layout/chat_bubble_long_press_menu.xml | 25 ++++--- .../layout/chat_conversation_popup_menu.xml | 65 +++---------------- .../chat_participant_admin_popup_menu.xml | 56 +++------------- app/src/main/res/layout/contact_list_cell.xml | 17 +---- .../contacts_list_filter_popup_menu.xml | 20 ++---- ...neric_address_picker_contact_list_cell.xml | 15 +---- ..._address_picker_conversation_list_cell.xml | 15 +---- .../res/layout/history_list_popup_menu.xml | 8 +-- .../main/res/layout/history_popup_menu.xml | 42 +++--------- .../main/res/layout/meeting_popup_menu.xml | 36 +++++----- .../layout/start_call_numpad_bottom_sheet.xml | 24 +++---- app/src/main/res/values/dimen.xml | 3 +- app/src/main/res/values/styles.xml | 31 +++++---- 51 files changed, 208 insertions(+), 350 deletions(-) create mode 100644 app/src/main/res/drawable/in_call_button_background_transparent.xml create mode 100644 app/src/main/res/drawable/popup_menu_button_background.xml create mode 100644 app/src/main/res/drawable/shape_round_popup_menu_pressed_background.xml create mode 100644 app/src/main/res/drawable/shape_round_transparent_background.xml diff --git a/CHANGELOG.md b/CHANGELOG.md index b06d2ba23..2389e5133 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,9 @@ Group changes to describe their impact on the project, as follows: ## [6.1.0] - Unreleased ### Added +- Added hover effect when using a mouse (useful for tablets or devices with desktop mode) - Added toggle speaker action in active call notification +- Added back increased text size for chat messages that only contains emoji(s) - Added a vu meter for recording & playback volumes (disabled by default, must be enabled in CorePreferences) - Added a setting for user to choose whether to sort contacts by first name or last name - Added a setting to hide contacts that have neither a SIP address nor a phone number diff --git a/app/src/main/res/color/icon_color_selector.xml b/app/src/main/res/color/icon_color_selector.xml index 93c5547b1..4e8e23e2a 100644 --- a/app/src/main/res/color/icon_color_selector.xml +++ b/app/src/main/res/color/icon_color_selector.xml @@ -2,5 +2,6 @@ + \ No newline at end of file diff --git a/app/src/main/res/color/icon_primary_color_selector.xml b/app/src/main/res/color/icon_primary_color_selector.xml index f05cdbb0e..c13e2e2b2 100644 --- a/app/src/main/res/color/icon_primary_color_selector.xml +++ b/app/src/main/res/color/icon_primary_color_selector.xml @@ -2,5 +2,6 @@ + \ No newline at end of file diff --git a/app/src/main/res/color/in_call_button_background_tint_color.xml b/app/src/main/res/color/in_call_button_background_tint_color.xml index 67e4952cb..0becb21f8 100644 --- a/app/src/main/res/color/in_call_button_background_tint_color.xml +++ b/app/src/main/res/color/in_call_button_background_tint_color.xml @@ -2,5 +2,6 @@ + diff --git a/app/src/main/res/color/in_call_button_color.xml b/app/src/main/res/color/in_call_button_color.xml index 4fa2d9bb3..92cd270cf 100644 --- a/app/src/main/res/color/in_call_button_color.xml +++ b/app/src/main/res/color/in_call_button_color.xml @@ -2,6 +2,8 @@ + diff --git a/app/src/main/res/color/in_call_button_tint_color.xml b/app/src/main/res/color/in_call_button_tint_color.xml index 3c8402d0a..898f65ef2 100644 --- a/app/src/main/res/color/in_call_button_tint_color.xml +++ b/app/src/main/res/color/in_call_button_tint_color.xml @@ -2,5 +2,6 @@ + diff --git a/app/src/main/res/color/primary_button_label_color.xml b/app/src/main/res/color/primary_button_label_color.xml index 31aa017d9..0a60ac460 100644 --- a/app/src/main/res/color/primary_button_label_color.xml +++ b/app/src/main/res/color/primary_button_label_color.xml @@ -4,6 +4,8 @@ android:color="?attr/color_on_main" /> + diff --git a/app/src/main/res/color/secondary_button_label_color.xml b/app/src/main/res/color/secondary_button_label_color.xml index 4788ca05b..beeab10b4 100644 --- a/app/src/main/res/color/secondary_button_label_color.xml +++ b/app/src/main/res/color/secondary_button_label_color.xml @@ -4,6 +4,8 @@ android:color="?attr/color_main1_500" /> + diff --git a/app/src/main/res/color/tertiary_button_label_color.xml b/app/src/main/res/color/tertiary_button_label_color.xml index 0dfdda8ab..5bf48c62c 100644 --- a/app/src/main/res/color/tertiary_button_label_color.xml +++ b/app/src/main/res/color/tertiary_button_label_color.xml @@ -2,5 +2,6 @@ + diff --git a/app/src/main/res/drawable/action_background_bottom.xml b/app/src/main/res/drawable/action_background_bottom.xml index f044482aa..1d7579047 100644 --- a/app/src/main/res/drawable/action_background_bottom.xml +++ b/app/src/main/res/drawable/action_background_bottom.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_squircle_main2_100_background_bottom" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/action_background_full.xml b/app/src/main/res/drawable/action_background_full.xml index 25ac4f240..45b708991 100644 --- a/app/src/main/res/drawable/action_background_full.xml +++ b/app/src/main/res/drawable/action_background_full.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_squircle_main2_100_r15_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/action_background_middle.xml b/app/src/main/res/drawable/action_background_middle.xml index fbc9e3cc0..af86707b1 100644 --- a/app/src/main/res/drawable/action_background_middle.xml +++ b/app/src/main/res/drawable/action_background_middle.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_rectangle_gray_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/action_background_top.xml b/app/src/main/res/drawable/action_background_top.xml index 0c2549c10..7aa7926d3 100644 --- a/app/src/main/res/drawable/action_background_top.xml +++ b/app/src/main/res/drawable/action_background_top.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_squircle_main2_100_background_top" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/circle_light_blue_button_background.xml b/app/src/main/res/drawable/circle_light_blue_button_background.xml index 88b35c53a..88d1b1574 100644 --- a/app/src/main/res/drawable/circle_light_blue_button_background.xml +++ b/app/src/main/res/drawable/circle_light_blue_button_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_circle_light_blue_disabled_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/circle_white_button_background.xml b/app/src/main/res/drawable/circle_white_button_background.xml index 83326874b..5e3a9d11d 100644 --- a/app/src/main/res/drawable/circle_white_button_background.xml +++ b/app/src/main/res/drawable/circle_white_button_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_primary_button_disabled_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/in_call_button_background_green.xml b/app/src/main/res/drawable/in_call_button_background_green.xml index 4f8efb4b0..10f619917 100644 --- a/app/src/main/res/drawable/in_call_button_background_green.xml +++ b/app/src/main/res/drawable/in_call_button_background_green.xml @@ -6,6 +6,8 @@ android:drawable="@drawable/shape_round_in_call_selected_green_button_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/in_call_button_background_red.xml b/app/src/main/res/drawable/in_call_button_background_red.xml index ae3b842f9..d6bf319d1 100644 --- a/app/src/main/res/drawable/in_call_button_background_red.xml +++ b/app/src/main/res/drawable/in_call_button_background_red.xml @@ -6,6 +6,8 @@ android:drawable="@drawable/shape_round_in_call_selected_red_button_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/in_call_button_background_transparent.xml b/app/src/main/res/drawable/in_call_button_background_transparent.xml new file mode 100644 index 000000000..1096ed16d --- /dev/null +++ b/app/src/main/res/drawable/in_call_button_background_transparent.xml @@ -0,0 +1,13 @@ + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/drawable/menu_item_background.xml b/app/src/main/res/drawable/menu_item_background.xml index 72c6a78a2..46c287b5c 100644 --- a/app/src/main/res/drawable/menu_item_background.xml +++ b/app/src/main/res/drawable/menu_item_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_rectangle_gray_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/popup_menu_button_background.xml b/app/src/main/res/drawable/popup_menu_button_background.xml new file mode 100644 index 000000000..3d60bd9aa --- /dev/null +++ b/app/src/main/res/drawable/popup_menu_button_background.xml @@ -0,0 +1,9 @@ + + + + + + \ No newline at end of file diff --git a/app/src/main/res/drawable/primary_button_background.xml b/app/src/main/res/drawable/primary_button_background.xml index 69ae79fba..fffc810d2 100644 --- a/app/src/main/res/drawable/primary_button_background.xml +++ b/app/src/main/res/drawable/primary_button_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_primary_button_disabled_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/primary_cell_background.xml b/app/src/main/res/drawable/primary_cell_background.xml index 2f9a9ca58..45386dfcb 100644 --- a/app/src/main/res/drawable/primary_cell_background.xml +++ b/app/src/main/res/drawable/primary_cell_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/color_main2_100" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/primary_cell_background_alt.xml b/app/src/main/res/drawable/primary_cell_background_alt.xml index 0625945d0..f012c7c4c 100644 --- a/app/src/main/res/drawable/primary_cell_background_alt.xml +++ b/app/src/main/res/drawable/primary_cell_background_alt.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/color_main2_100" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/primary_cell_r10_background.xml b/app/src/main/res/drawable/primary_cell_r10_background.xml index e3a99d27e..7b96644e5 100644 --- a/app/src/main/res/drawable/primary_cell_r10_background.xml +++ b/app/src/main/res/drawable/primary_cell_r10_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_squircle_gray_main2_100_r10_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/secondary_button_background.xml b/app/src/main/res/drawable/secondary_button_background.xml index d002e4e5c..10ac3e62b 100644 --- a/app/src/main/res/drawable/secondary_button_background.xml +++ b/app/src/main/res/drawable/secondary_button_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_secondary_button_disabled_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/secondary_cell_background.xml b/app/src/main/res/drawable/secondary_cell_background.xml index 8d2657fce..ea60a6ac2 100644 --- a/app/src/main/res/drawable/secondary_cell_background.xml +++ b/app/src/main/res/drawable/secondary_cell_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/color_main2_100" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/shape_round_popup_menu_pressed_background.xml b/app/src/main/res/drawable/shape_round_popup_menu_pressed_background.xml new file mode 100644 index 000000000..6a04a3d9f --- /dev/null +++ b/app/src/main/res/drawable/shape_round_popup_menu_pressed_background.xml @@ -0,0 +1,5 @@ + + + + + \ No newline at end of file diff --git a/app/src/main/res/drawable/shape_round_transparent_background.xml b/app/src/main/res/drawable/shape_round_transparent_background.xml new file mode 100644 index 000000000..b9942d93e --- /dev/null +++ b/app/src/main/res/drawable/shape_round_transparent_background.xml @@ -0,0 +1,5 @@ + + + + + \ No newline at end of file diff --git a/app/src/main/res/drawable/squircle_green_button_background.xml b/app/src/main/res/drawable/squircle_green_button_background.xml index 34552986e..d002cf8dc 100644 --- a/app/src/main/res/drawable/squircle_green_button_background.xml +++ b/app/src/main/res/drawable/squircle_green_button_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_squircle_green_disabled_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/squircle_red_button_background.xml b/app/src/main/res/drawable/squircle_red_button_background.xml index 0669a1a3e..a7a250075 100644 --- a/app/src/main/res/drawable/squircle_red_button_background.xml +++ b/app/src/main/res/drawable/squircle_red_button_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_squircle_red_disabled_background" /> + \ No newline at end of file diff --git a/app/src/main/res/drawable/tertiary_button_background.xml b/app/src/main/res/drawable/tertiary_button_background.xml index 2c40a0d99..9f96c0943 100644 --- a/app/src/main/res/drawable/tertiary_button_background.xml +++ b/app/src/main/res/drawable/tertiary_button_background.xml @@ -4,6 +4,8 @@ android:drawable="@drawable/shape_tertiary_button_disabled_background" /> + \ No newline at end of file diff --git a/app/src/main/res/layout/account_popup_menu.xml b/app/src/main/res/layout/account_popup_menu.xml index 7892928b0..e5aef5e2e 100644 --- a/app/src/main/res/layout/account_popup_menu.xml +++ b/app/src/main/res/layout/account_popup_menu.xml @@ -16,18 +16,16 @@ android:background="@drawable/shape_round_popup_menu_background"> - - + app:layout_constraintTop_toTopOf="@id/toggle_mute_mic" + app:layout_constraintBottom_toBottomOf="@id/toggle_mute_mic" + app:layout_constraintStart_toStartOf="@id/toggle_mute_mic" + app:layout_constraintEnd_toEndOf="@id/toggle_mute_mic" /> - - + app:layout_constraintTop_toTopOf="@id/change_audio_output" + app:layout_constraintBottom_toBottomOf="@id/change_audio_output" + app:layout_constraintStart_toStartOf="@id/change_audio_output" + app:layout_constraintEnd_toEndOf="@id/change_audio_output" /> - - + android:layout_height="@dimen/call_dtmf_button_size" + android:background="@drawable/in_call_button_background_red"> - - + android:layout_height="@dimen/call_dtmf_button_size" + android:background="@drawable/in_call_button_background_red"> - - + android:layout_height="@dimen/call_dtmf_button_size" + android:background="@drawable/in_call_button_background_red"> - - + android:layout_height="@dimen/call_dtmf_button_size" + android:background="@drawable/in_call_button_background_red"> @@ -113,13 +113,14 @@ android:visibility="@{viewModel.isMessageInError && viewModel.isMessageOutgoing ? View.VISIBLE : View.GONE, default=gone}"/> + android:background="@{viewModel.isMessageInError && viewModel.isMessageOutgoing ? @drawable/action_background_middle : @drawable/action_background_top, default=@drawable/action_background_top}" + android:drawableEnd="@drawable/info"/> @@ -143,12 +145,13 @@ android:visibility="@{viewModel.isChatRoomReadOnly ? View.GONE : View.VISIBLE}" /> @@ -159,12 +162,13 @@ android:visibility="@{viewModel.hideCopyTextToClipboard ? View.GONE : View.VISIBLE}"/> @@ -175,13 +179,16 @@ android:visibility="@{viewModel.hideForward ? View.GONE : View.VISIBLE}" /> + android:textColor="?attr/color_danger_500" + android:background="@drawable/action_background_bottom" + android:drawableEnd="@drawable/trash_simple" + app:drawableTint="?attr/color_danger_500"/> diff --git a/app/src/main/res/layout/chat_conversation_popup_menu.xml b/app/src/main/res/layout/chat_conversation_popup_menu.xml index 47276a09b..45c9f5f72 100644 --- a/app/src/main/res/layout/chat_conversation_popup_menu.xml +++ b/app/src/main/res/layout/chat_conversation_popup_menu.xml @@ -45,143 +45,94 @@ android:background="@drawable/shape_round_popup_menu_background"> - - + android:background="@drawable/primary_cell_background"> - - + android:paddingBottom="5dp" + android:background="@drawable/primary_cell_background"> - - + android:paddingBottom="5dp" + android:background="@drawable/primary_cell_background"> + app:layout_constraintBottom_toTopOf="@id/bottom_anchor"/> + app:layout_constraintBottom_toTopOf="@id/bottom_anchor"/> + + diff --git a/app/src/main/res/layout/start_call_numpad_bottom_sheet.xml b/app/src/main/res/layout/start_call_numpad_bottom_sheet.xml index dc7b51ec7..cbfb75447 100644 --- a/app/src/main/res/layout/start_call_numpad_bottom_sheet.xml +++ b/app/src/main/res/layout/start_call_numpad_bottom_sheet.xml @@ -61,7 +61,7 @@ 400dp 400dp 250dp - 15dp - 20dp + 10dp 70dp 110dp diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index c57fecce3..fd4c25142 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -99,7 +99,7 @@ - + - -