From ae7c35c75da2961380f9cdf11bd82679a4ab601e Mon Sep 17 00:00:00 2001
From: Sylvain Berfini <sylvain.berfini@belledonne-communications.com>
Date: Sun, 10 Sep 2023 09:13:26 +0200
Subject: [PATCH] Fixed suggestions list not scrollable

---
 .../main/res/layout/call_start_fragment.xml   | 28 ++++++++++++++-----
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/app/src/main/res/layout/call_start_fragment.xml b/app/src/main/res/layout/call_start_fragment.xml
index 016d9f47f..027a1266b 100644
--- a/app/src/main/res/layout/call_start_fragment.xml
+++ b/app/src/main/res/layout/call_start_fragment.xml
@@ -209,14 +209,22 @@
             <androidx.recyclerview.widget.RecyclerView
                 android:id="@+id/contacts_list"
                 android:layout_width="0dp"
-                android:layout_height="0dp"
+                android:layout_height="wrap_content"
                 android:layout_marginTop="8dp"
                 android:visibility="@{viewModel.emptyContactsList ? View.GONE : View.VISIBLE}"
+                app:layout_constrainedHeight="true"
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintTop_toBottomOf="@id/all_contacts_label"
                 app:layout_constraintBottom_toTopOf="@id/suggestions_label" />
 
+            <androidx.constraintlayout.widget.Barrier
+                android:id="@+id/suggestions_top_barrier"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                app:barrierDirection="bottom"
+                app:constraint_referenced_ids="contacts_list, all_contacts_label, group_call_icon" />
+
             <androidx.appcompat.widget.AppCompatTextView
                 android:id="@+id/suggestions_label"
                 style="@style/default_text_style_800"
@@ -231,21 +239,27 @@
                 android:visibility="@{viewModel.suggestionsList.size() == 0 ? View.GONE : View.VISIBLE}"
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintEnd_toEndOf="parent"
-                app:layout_constraintTop_toBottomOf="@id/contacts_list"
+                app:layout_constraintTop_toBottomOf="@id/suggestions_top_barrier"
                 app:layout_constraintBottom_toTopOf="@id/suggestions_list"/>
 
-            <LinearLayout
+            <ScrollView
                 android:id="@+id/suggestions_list"
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
-                android:orientation="vertical"
-                entries="@{viewModel.suggestionsList}"
-                layout="@{@layout/call_suggestion_list_cell}"
                 app:layout_constrainedHeight="true"
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintTop_toBottomOf="@id/suggestions_label"
-                app:layout_constraintBottom_toBottomOf="parent" />
+                app:layout_constraintBottom_toBottomOf="parent">
+
+                <LinearLayout
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:orientation="vertical"
+                    entries="@{viewModel.suggestionsList}"
+                    layout="@{@layout/call_suggestion_list_cell}" />
+
+            </ScrollView>
 
         </androidx.constraintlayout.widget.ConstraintLayout>