From e012d45c10c60747b15acf064ce651c201eab065 Mon Sep 17 00:00:00 2001
From: Sylvain Berfini <sylvain.berfini@belledonne-communications.com>
Date: Thu, 11 Jul 2024 15:46:12 +0200
Subject: [PATCH] Disable action buttons & hide numbers & SIP addresses fields
 if contact doesn't contains any

---
 app/src/main/assets/linphonerc_default                 |  3 +++
 app/src/main/java/org/linphone/core/CoreContext.kt     |  3 +++
 .../ui/main/contacts/viewmodel/ContactViewModel.kt     |  8 ++++++++
 app/src/main/res/layout/contact_fragment.xml           | 10 +++++++++-
 4 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/app/src/main/assets/linphonerc_default b/app/src/main/assets/linphonerc_default
index 13cfb6207..fb1fcee9d 100644
--- a/app/src/main/assets/linphonerc_default
+++ b/app/src/main/assets/linphonerc_default
@@ -44,4 +44,7 @@ hide_empty_chat_rooms=0
 [fec]
 fec_enabled=1
 
+[magic_search]
+return_empty_friends=1
+
 ## End of default rc
diff --git a/app/src/main/java/org/linphone/core/CoreContext.kt b/app/src/main/java/org/linphone/core/CoreContext.kt
index 71b7f9321..afe4ebc6a 100644
--- a/app/src/main/java/org/linphone/core/CoreContext.kt
+++ b/app/src/main/java/org/linphone/core/CoreContext.kt
@@ -447,6 +447,9 @@ class CoreContext @UiThread constructor(val context: Context) : HandlerThread("C
 
                 core.isFecEnabled = true
                 Log.i("$TAG Video FEC has been enabled")
+
+                core.config.setBool("magic_search", "return_empty_friends", true)
+                Log.i("$TAG Showing 'empty' friends enabled")
             }
 
             corePreferences.linphoneConfigurationVersion = currentVersion
diff --git a/app/src/main/java/org/linphone/ui/main/contacts/viewmodel/ContactViewModel.kt b/app/src/main/java/org/linphone/ui/main/contacts/viewmodel/ContactViewModel.kt
index 8d9a9d91b..a611f079c 100644
--- a/app/src/main/java/org/linphone/ui/main/contacts/viewmodel/ContactViewModel.kt
+++ b/app/src/main/java/org/linphone/ui/main/contacts/viewmodel/ContactViewModel.kt
@@ -21,6 +21,7 @@ package org.linphone.ui.main.contacts.viewmodel
 
 import androidx.annotation.UiThread
 import androidx.annotation.WorkerThread
+import androidx.lifecycle.MediatorLiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.viewModelScope
 import java.io.File
@@ -64,6 +65,7 @@ class ContactViewModel @UiThread constructor() : GenericViewModel() {
     val contact = MutableLiveData<ContactAvatarModel>()
 
     val sipAddressesAndPhoneNumbers = MutableLiveData<ArrayList<ContactNumberOrAddressModel>>()
+    val atLeastOneSipAddressOrPhoneNumber = MediatorLiveData<Boolean>()
 
     val devices = MutableLiveData<ArrayList<ContactDeviceModel>>()
 
@@ -236,9 +238,15 @@ class ContactViewModel @UiThread constructor() : GenericViewModel() {
 
     init {
         isStored.value = false
+
         expandNumbersAndAddresses.value = true
         trustedDevicesPercentage.value = 0
 
+        atLeastOneSipAddressOrPhoneNumber.value = false
+        atLeastOneSipAddressOrPhoneNumber.addSource(sipAddressesAndPhoneNumbers) {
+            atLeastOneSipAddressOrPhoneNumber.value = it.isNotEmpty()
+        }
+
         coreContext.postOnCoreThread { core ->
             core.addListener(coreListener)
             chatDisabled.postValue(corePreferences.disableChat)
diff --git a/app/src/main/res/layout/contact_fragment.xml b/app/src/main/res/layout/contact_fragment.xml
index cdbd97b36..cb35caef1 100644
--- a/app/src/main/res/layout/contact_fragment.xml
+++ b/app/src/main/res/layout/contact_fragment.xml
@@ -144,6 +144,7 @@
                     <ImageView
                         android:id="@+id/call"
                         android:onClick="@{() -> viewModel.startAudioCall()}"
+                        android:enabled="@{viewModel.atLeastOneSipAddressOrPhoneNumber}"
                         android:layout_width="56dp"
                         android:layout_height="56dp"
                         android:layout_marginTop="20dp"
@@ -160,6 +161,7 @@
                         style="@style/default_text_style"
                         android:id="@+id/call_label"
                         android:onClick="@{() -> viewModel.startAudioCall()}"
+                        android:enabled="@{viewModel.atLeastOneSipAddressOrPhoneNumber}"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:layout_marginTop="8dp"
@@ -173,6 +175,7 @@
                         android:id="@+id/chat"
                         android:onClick="@{() -> viewModel.goToConversation()}"
                         android:visibility="@{viewModel.chatDisabled ? View.GONE : View.VISIBLE}"
+                        android:enabled="@{viewModel.atLeastOneSipAddressOrPhoneNumber}"
                         android:layout_width="56dp"
                         android:layout_height="56dp"
                         android:layout_marginTop="20dp"
@@ -190,6 +193,7 @@
                         android:id="@+id/chat_label"
                         android:onClick="@{() -> viewModel.goToConversation()}"
                         android:visibility="@{viewModel.chatDisabled ? View.GONE : View.VISIBLE}"
+                        android:enabled="@{viewModel.atLeastOneSipAddressOrPhoneNumber}"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:layout_marginTop="8dp"
@@ -203,6 +207,7 @@
                         android:id="@+id/video_call"
                         android:onClick="@{() -> viewModel.startVideoCall()}"
                         android:visibility="@{viewModel.videoCallDisabled ? View.GONE : View.VISIBLE}"
+                        android:enabled="@{viewModel.atLeastOneSipAddressOrPhoneNumber}"
                         android:layout_width="56dp"
                         android:layout_height="56dp"
                         android:layout_marginTop="20dp"
@@ -220,6 +225,7 @@
                         android:id="@+id/video_call_label"
                         android:onClick="@{() -> viewModel.startVideoCall()}"
                         android:visibility="@{viewModel.videoCallDisabled ? View.GONE : View.VISIBLE}"
+                        android:enabled="@{viewModel.atLeastOneSipAddressOrPhoneNumber}"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:layout_marginTop="8dp"
@@ -242,13 +248,14 @@
                         android:text="@string/contact_details_numbers_and_addresses_title"
                         android:drawableEnd="@{viewModel.expandNumbersAndAddresses ? @drawable/caret_up : @drawable/caret_down, default=@drawable/caret_up}"
                         android:drawableTint="?attr/color_main2_600"
+                        android:visibility="@{viewModel.atLeastOneSipAddressOrPhoneNumber ? View.VISIBLE : View.GONE}"
                         app:layout_constraintStart_toStartOf="parent"
                         app:layout_constraintEnd_toEndOf="parent"
                         app:layout_constraintTop_toBottomOf="@id/call_label"/>
 
                     <LinearLayout
                         android:id="@+id/numbers_and_addresses"
-                        android:visibility="@{viewModel.expandNumbersAndAddresses ? View.VISIBLE : View.GONE}"
+                        android:visibility="@{viewModel.atLeastOneSipAddressOrPhoneNumber &amp;&amp; viewModel.expandNumbersAndAddresses ? View.VISIBLE : View.GONE}"
                         android:layout_width="0dp"
                         android:layout_height="wrap_content"
                         android:orientation="vertical"
@@ -488,6 +495,7 @@
                         android:paddingBottom="8dp"
                         android:paddingTop="8dp"
                         android:background="@drawable/shape_squircle_white_background"
+                        app:layout_constraintVertical_bias="0"
                         app:layout_constraintStart_toStartOf="parent"
                         app:layout_constraintEnd_toEndOf="parent"
                         app:layout_constraintTop_toBottomOf="@id/actions"