diff --git a/app/src/main/java/org/linphone/LinphoneApplication.kt b/app/src/main/java/org/linphone/LinphoneApplication.kt
index ad105ceec..f6c2c486f 100644
--- a/app/src/main/java/org/linphone/LinphoneApplication.kt
+++ b/app/src/main/java/org/linphone/LinphoneApplication.kt
@@ -67,10 +67,8 @@ class LinphoneApplication : Application(), ImageLoaderFactory {
val appName = context.getString(R.string.app_name)
Factory.instance().setLoggerDomain(appName)
- Factory.instance().enableLogcatLogs(true)
- if (corePreferences.debugLogs) {
- Factory.instance().loggingService.setLogLevel(LogLevel.Message)
- }
+ Factory.instance().loggingService.setLogLevel(LogLevel.Message)
+ Factory.instance().enableLogcatLogs(corePreferences.printLogsInLogcat)
Log.i("[Linphone Application] Report Core preferences initialized")
diff --git a/app/src/main/java/org/linphone/core/CorePreferences.kt b/app/src/main/java/org/linphone/core/CorePreferences.kt
index 5a765ea9a..07ff3c064 100644
--- a/app/src/main/java/org/linphone/core/CorePreferences.kt
+++ b/app/src/main/java/org/linphone/core/CorePreferences.kt
@@ -42,7 +42,7 @@ class CorePreferences @UiThread constructor(private val context: Context) {
}
@get:WorkerThread @set:WorkerThread
- var debugLogs: Boolean
+ var printLogsInLogcat: Boolean
get() = config.getBool("app", "debug", org.linphone.BuildConfig.DEBUG)
set(value) {
config.setBool("app", "debug", value)
diff --git a/app/src/main/java/org/linphone/ui/main/help/viewmodel/HelpViewModel.kt b/app/src/main/java/org/linphone/ui/main/help/viewmodel/HelpViewModel.kt
index b59fe2928..790284215 100644
--- a/app/src/main/java/org/linphone/ui/main/help/viewmodel/HelpViewModel.kt
+++ b/app/src/main/java/org/linphone/ui/main/help/viewmodel/HelpViewModel.kt
@@ -30,7 +30,6 @@ import org.linphone.R
import org.linphone.core.Core
import org.linphone.core.CoreListenerStub
import org.linphone.core.Factory
-import org.linphone.core.LogLevel
import org.linphone.core.VersionUpdateCheckResult
import org.linphone.core.tools.Log
import org.linphone.utils.AppUtils
@@ -47,7 +46,7 @@ class HelpViewModel @UiThread constructor() : ViewModel() {
val sdkVersion = MutableLiveData()
- val debugModeEnabled = MutableLiveData()
+ val printLogInLogcatEnabled = MutableLiveData()
val newVersionAvailableEvent: MutableLiveData>> by lazy {
MutableLiveData>>()
@@ -124,7 +123,7 @@ class HelpViewModel @UiThread constructor() : ViewModel() {
coreContext.postOnCoreThread { core ->
core.addListener(coreListener)
- debugModeEnabled.postValue(corePreferences.debugLogs)
+ printLogInLogcatEnabled.postValue(corePreferences.printLogsInLogcat)
}
}
@@ -138,19 +137,13 @@ class HelpViewModel @UiThread constructor() : ViewModel() {
}
@UiThread
- fun toggleDebugMode() {
- val enabled = debugModeEnabled.value == false
- debugModeEnabled.value = enabled
-
- if (!enabled) {
- cleanLogs()
- }
+ fun togglePrintLogsInLogcat() {
+ val enabled = printLogInLogcatEnabled.value == false
+ printLogInLogcatEnabled.value = enabled
coreContext.postOnCoreThread {
- corePreferences.debugLogs = enabled
- val logLevel = if (enabled) LogLevel.Message else LogLevel.Error
- Factory.instance().loggingService.setLogLevel(logLevel)
- Log.i("$TAG Debug logs have been ${if (enabled) "enabled" else "disabled"}")
+ corePreferences.printLogsInLogcat = enabled
+ Factory.instance().enableLogcatLogs(corePreferences.printLogsInLogcat)
}
}
diff --git a/app/src/main/res/layout/help_debug_fragment.xml b/app/src/main/res/layout/help_debug_fragment.xml
index a51d4af5f..f8ec06ca0 100644
--- a/app/src/main/res/layout/help_debug_fragment.xml
+++ b/app/src/main/res/layout/help_debug_fragment.xml
@@ -46,7 +46,7 @@
+ app:layout_constraintEnd_toStartOf="@id/print_logs_in_logcat_switch"/>
+ app:layout_constraintEnd_toStartOf="@id/print_logs_in_logcat_switch" />
+ app:layout_constraintTop_toTopOf="@id/print_logs_in_logcat_title"
+ app:layout_constraintBottom_toBottomOf="@id/print_logs_in_logcat_subtitle" />
+ app:layout_constraintTop_toBottomOf="@id/print_logs_in_logcat_subtitle"/>
+ app:layout_constraintTop_toBottomOf="@id/print_logs_in_logcat_subtitle"/>
Your version is up-to-date
An error occurred while checking for update
Troubleshooting
- Enable/disable debug logs
- Blah
+ Enable/disable printing logs in ADB
+ Blah blah blah?
Clean logs
Share logs
Linphone app version