From f4b6deb06a8ccc8ca5d855f8b1b62eb8754da252 Mon Sep 17 00:00:00 2001 From: Sylvain Berfini Date: Fri, 8 Sep 2023 10:31:56 +0200 Subject: [PATCH] Layout changes for tablet --- .../org/linphone/utils/DataBindingUtils.kt | 5 +- .../main/res/layout-land/welcome_page_1.xml | 71 +++++++++++++++++++ .../main/res/layout-land/welcome_page_2.xml | 71 +++++++++++++++++++ .../main/res/layout-land/welcome_page_3.xml | 71 +++++++++++++++++++ .../res/layout/account_profile_fragment.xml | 24 +++---- .../res/layout/assistant_login_fragment.xml | 12 ++-- .../layout/assistant_register_fragment.xml | 21 +++--- ...third_party_sip_account_login_fragment.xml | 16 +++-- ...ird_party_sip_account_warning_fragment.xml | 3 + .../main/res/layout/call_start_fragment.xml | 1 + .../res/layout/contact_new_or_edit_cell.xml | 12 ++-- .../layout/contact_new_or_edit_fragment.xml | 34 ++++----- ...assistant_accept_conditions_and_policy.xml | 7 +- ...nt_create_account_confirm_phone_number.xml | 1 + .../layout/dialog_cancel_contact_changes.xml | 1 + .../res/layout/dialog_confirm_zrtp_sas.xml | 1 + .../dialog_contact_confirm_trust_call.xml | 1 + .../layout/dialog_contact_trust_process.xml | 1 + .../layout/dialog_pick_number_or_address.xml | 1 + .../layout/dialog_remove_all_call_logs.xml | 1 + app/src/main/res/layout/drawer_menu.xml | 11 ++- app/src/main/res/layout/welcome_activity.xml | 1 + app/src/main/res/values/dimen.xml | 9 ++- 23 files changed, 310 insertions(+), 66 deletions(-) create mode 100644 app/src/main/res/layout-land/welcome_page_1.xml create mode 100644 app/src/main/res/layout-land/welcome_page_2.xml create mode 100644 app/src/main/res/layout-land/welcome_page_3.xml diff --git a/app/src/main/java/org/linphone/utils/DataBindingUtils.kt b/app/src/main/java/org/linphone/utils/DataBindingUtils.kt index c2abadc88..f33dae9a2 100644 --- a/app/src/main/java/org/linphone/utils/DataBindingUtils.kt +++ b/app/src/main/java/org/linphone/utils/DataBindingUtils.kt @@ -68,9 +68,8 @@ fun setEntries( entries: List?, layoutId: Int ) { - viewGroup.removeAllViews() - - if (entries != null) { + if (!entries.isNullOrEmpty()) { + viewGroup.removeAllViews() val inflater = viewGroup.context.getSystemService(Context.LAYOUT_INFLATER_SERVICE) as LayoutInflater for (entry in entries) { val binding = DataBindingUtil.inflate( diff --git a/app/src/main/res/layout-land/welcome_page_1.xml b/app/src/main/res/layout-land/welcome_page_1.xml new file mode 100644 index 000000000..57cf422f5 --- /dev/null +++ b/app/src/main/res/layout-land/welcome_page_1.xml @@ -0,0 +1,71 @@ + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout-land/welcome_page_2.xml b/app/src/main/res/layout-land/welcome_page_2.xml new file mode 100644 index 000000000..6362376c9 --- /dev/null +++ b/app/src/main/res/layout-land/welcome_page_2.xml @@ -0,0 +1,71 @@ + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout-land/welcome_page_3.xml b/app/src/main/res/layout-land/welcome_page_3.xml new file mode 100644 index 000000000..bdb535213 --- /dev/null +++ b/app/src/main/res/layout-land/welcome_page_3.xml @@ -0,0 +1,71 @@ + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout/account_profile_fragment.xml b/app/src/main/res/layout/account_profile_fragment.xml index 4a33fae8f..3ed0d612b 100644 --- a/app/src/main/res/layout/account_profile_fragment.xml +++ b/app/src/main/res/layout/account_profile_fragment.xml @@ -88,15 +88,14 @@ @@ -123,15 +123,14 @@ @@ -157,15 +157,14 @@ diff --git a/app/src/main/res/layout/assistant_login_fragment.xml b/app/src/main/res/layout/assistant_login_fragment.xml index 7a5687552..9e1bf59d4 100644 --- a/app/src/main/res/layout/assistant_login_fragment.xml +++ b/app/src/main/res/layout/assistant_login_fragment.xml @@ -79,13 +79,12 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginTop="18dp" - android:layout_marginStart="16dp" android:layout_marginEnd="16dp" android:text="Username*" android:textSize="13sp" android:textColor="@color/gray_9" app:layout_constraintTop_toBottomOf="@id/title" - app:layout_constraintStart_toStartOf="parent"/> + app:layout_constraintStart_toStartOf="@id/username"/> @@ -111,14 +111,14 @@ style="@style/default_text_style_700" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginStart="16dp" android:layout_marginEnd="16dp" android:layout_marginTop="16dp" android:text="Password*" android:textSize="13sp" android:textColor="@color/gray_9" + app:layout_constraintWidth_max="@dimen/text_input_max_width" app:layout_constraintTop_toBottomOf="@id/username" - app:layout_constraintStart_toStartOf="parent"/> + app:layout_constraintStart_toStartOf="@id/password"/> @@ -249,6 +251,7 @@ android:drawableStart="@drawable/qr_code" android:drawablePadding="8dp" app:drawableTint="@color/secondary_button_label_color" + app:layout_constraintWidth_max="@dimen/button_max_width" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toBottomOf="@id/or" /> @@ -271,6 +274,7 @@ android:textColor="@color/secondary_button_label_color" android:gravity="center" android:background="@drawable/secondary_button_background" + app:layout_constraintWidth_max="@dimen/button_max_width" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toBottomOf="@id/scan_qr_code" /> diff --git a/app/src/main/res/layout/assistant_register_fragment.xml b/app/src/main/res/layout/assistant_register_fragment.xml index 99ad26ad2..d7cc8e631 100644 --- a/app/src/main/res/layout/assistant_register_fragment.xml +++ b/app/src/main/res/layout/assistant_register_fragment.xml @@ -79,13 +79,12 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginTop="48dp" - android:layout_marginStart="16dp" android:layout_marginEnd="16dp" android:text="Username*" android:textSize="13sp" android:textColor="@color/gray_9" app:layout_constraintTop_toBottomOf="@id/title" - app:layout_constraintStart_toStartOf="parent"/> + app:layout_constraintStart_toStartOf="@id/username"/> @@ -124,21 +124,19 @@ style="@style/default_text_style_700" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginStart="16dp" android:layout_marginEnd="16dp" android:layout_marginTop="16dp" android:text="Phone Number*" android:textSize="13sp" android:textColor="@color/gray_9" app:layout_constraintTop_toBottomOf="@id/username_error" - app:layout_constraintStart_toStartOf="parent"/> + app:layout_constraintStart_toStartOf="@id/prefix"/> + app:layout_constraintStart_toStartOf="@id/username" + app:layout_constraintEnd_toEndOf="@id/username"/> + app:layout_constraintStart_toStartOf="@id/username" /> + app:layout_constraintStart_toStartOf="@id/password"/> @@ -247,6 +245,7 @@ android:textColor="@color/primary_button_label_color" android:gravity="center" android:background="@drawable/primary_button_background" + app:layout_constraintWidth_max="@dimen/button_max_width" app:layout_constraintTop_toBottomOf="@id/password" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent" /> diff --git a/app/src/main/res/layout/assistant_third_party_sip_account_login_fragment.xml b/app/src/main/res/layout/assistant_third_party_sip_account_login_fragment.xml index 2044c157e..37f1454c3 100644 --- a/app/src/main/res/layout/assistant_third_party_sip_account_login_fragment.xml +++ b/app/src/main/res/layout/assistant_third_party_sip_account_login_fragment.xml @@ -60,7 +60,7 @@ android:textSize="13sp" android:textColor="@color/gray_9" app:layout_constraintTop_toBottomOf="@id/title" - app:layout_constraintStart_toStartOf="parent"/> + app:layout_constraintStart_toStartOf="@id/username"/> @@ -93,7 +94,7 @@ android:textSize="13sp" android:textColor="@color/gray_9" app:layout_constraintTop_toBottomOf="@id/username" - app:layout_constraintStart_toStartOf="parent"/> + app:layout_constraintStart_toStartOf="@id/password"/> @@ -139,7 +141,7 @@ android:textSize="13sp" android:textColor="@color/gray_9" app:layout_constraintTop_toBottomOf="@id/password" - app:layout_constraintStart_toStartOf="parent"/> + app:layout_constraintStart_toStartOf="@id/domain"/> @@ -172,7 +175,7 @@ android:textSize="13sp" android:textColor="@color/gray_9" app:layout_constraintTop_toBottomOf="@id/domain" - app:layout_constraintStart_toStartOf="parent"/> + app:layout_constraintStart_toStartOf="@id/display_name"/> @@ -205,7 +209,7 @@ android:textSize="13sp" android:textColor="@color/gray_9" app:layout_constraintTop_toBottomOf="@id/display_name" - app:layout_constraintStart_toStartOf="parent"/> + app:layout_constraintStart_toStartOf="@id/transport"/> @@ -249,6 +254,7 @@ android:textColor="@color/primary_button_label_color" android:gravity="center" android:background="@drawable/primary_button_background" + app:layout_constraintWidth_max="@dimen/button_max_width" app:layout_constraintTop_toBottomOf="@id/transport" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent" /> diff --git a/app/src/main/res/layout/assistant_third_party_sip_account_warning_fragment.xml b/app/src/main/res/layout/assistant_third_party_sip_account_warning_fragment.xml index e6c6db747..b8777245d 100644 --- a/app/src/main/res/layout/assistant_third_party_sip_account_warning_fragment.xml +++ b/app/src/main/res/layout/assistant_third_party_sip_account_warning_fragment.xml @@ -89,6 +89,7 @@ android:text="Some features require a Linphone account, such as group messaging, video conferences...\n\nThese features are hidden when you register with a third party SIP account.\n\nTo enable it in a commercial projet, please contact us. " android:textSize="14sp" android:gravity="center" + app:layout_constraintWidth_max="@dimen/text_input_max_width" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toBottomOf="@id/no_chat"/> @@ -132,6 +133,7 @@ android:textColor="@color/secondary_button_label_color" android:gravity="center" android:background="@drawable/secondary_button_background" + app:layout_constraintWidth_max="@dimen/button_max_width" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintBottom_toTopOf="@id/continue_third_party_account_login" /> @@ -155,6 +157,7 @@ android:textColor="@color/primary_button_label_color" android:gravity="center" android:background="@drawable/primary_button_background" + app:layout_constraintWidth_max="@dimen/button_max_width" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent" /> diff --git a/app/src/main/res/layout/call_start_fragment.xml b/app/src/main/res/layout/call_start_fragment.xml index 7efe61090..016d9f47f 100644 --- a/app/src/main/res/layout/call_start_fragment.xml +++ b/app/src/main/res/layout/call_start_fragment.xml @@ -181,6 +181,7 @@ android:layout_height="wrap_content" android:text="No suggestion and no contact for the moment..." android:textSize="16sp" + android:gravity="center" android:visibility="@{viewModel.emptyContactsList && viewModel.suggestionsList.size() == 0 ? View.VISIBLE : View.GONE}" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/app/src/main/res/layout/contact_new_or_edit_cell.xml b/app/src/main/res/layout/contact_new_or_edit_cell.xml index 87b67a0f6..e46aeef2b 100644 --- a/app/src/main/res/layout/contact_new_or_edit_cell.xml +++ b/app/src/main/res/layout/contact_new_or_edit_cell.xml @@ -19,15 +19,12 @@ @@ -57,7 +53,7 @@ android:visibility="@{model.showRemoveButton ? View.VISIBLE : View.INVISIBLE, default=invisible}" android:layout_width="@dimen/icon_size" android:layout_height="@dimen/icon_size" - android:layout_marginEnd="16dp" + android:layout_marginStart="10dp" android:src="@drawable/x" app:tint="@color/gray_8" app:layout_constraintStart_toEndOf="@id/field" diff --git a/app/src/main/res/layout/contact_new_or_edit_fragment.xml b/app/src/main/res/layout/contact_new_or_edit_fragment.xml index f05bd52ec..f9c5dc5e9 100644 --- a/app/src/main/res/layout/contact_new_or_edit_fragment.xml +++ b/app/src/main/res/layout/contact_new_or_edit_fragment.xml @@ -116,15 +116,13 @@ @@ -150,15 +149,13 @@ @@ -186,7 +184,10 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginTop="30dp" + android:layout_marginStart="16dp" + android:layout_marginEnd="16dp" android:orientation="vertical" + app:layout_constraintWidth_max="@dimen/text_input_max_width" app:layout_constraintTop_toBottomOf="@id/last_name" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent"/> @@ -196,7 +197,10 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginTop="30dp" + android:layout_marginStart="16dp" + android:layout_marginEnd="16dp" android:orientation="vertical" + app:layout_constraintWidth_max="@dimen/text_input_max_width" app:layout_constraintTop_toBottomOf="@id/sip_addresses" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent"/> @@ -204,15 +208,13 @@ @@ -238,15 +241,13 @@ + app:layout_constraintTop_toTopOf="@id/title" /> diff --git a/app/src/main/res/layout/dialog_contact_confirm_trust_call.xml b/app/src/main/res/layout/dialog_contact_confirm_trust_call.xml index a853d6be4..252605b87 100644 --- a/app/src/main/res/layout/dialog_contact_confirm_trust_call.xml +++ b/app/src/main/res/layout/dialog_contact_confirm_trust_call.xml @@ -33,6 +33,7 @@ android:layout_marginEnd="12dp" android:layout_marginBottom="2dp" android:src="@drawable/shape_dialog_background" + app:layout_constraintWidth_max="@dimen/dialog_max_width" app:layout_constraintBottom_toBottomOf="@id/anchor" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/app/src/main/res/layout/dialog_contact_trust_process.xml b/app/src/main/res/layout/dialog_contact_trust_process.xml index c45731792..2acdc75d5 100644 --- a/app/src/main/res/layout/dialog_contact_trust_process.xml +++ b/app/src/main/res/layout/dialog_contact_trust_process.xml @@ -33,6 +33,7 @@ android:layout_marginEnd="12dp" android:layout_marginBottom="2dp" android:src="@drawable/shape_dialog_background" + app:layout_constraintWidth_max="@dimen/dialog_max_width" app:layout_constraintBottom_toBottomOf="@id/anchor" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/app/src/main/res/layout/dialog_pick_number_or_address.xml b/app/src/main/res/layout/dialog_pick_number_or_address.xml index cda4e3550..ec531041a 100644 --- a/app/src/main/res/layout/dialog_pick_number_or_address.xml +++ b/app/src/main/res/layout/dialog_pick_number_or_address.xml @@ -34,6 +34,7 @@ android:layout_marginEnd="12dp" android:layout_marginBottom="2dp" android:src="@drawable/shape_dialog_background" + app:layout_constraintWidth_max="@dimen/dialog_max_width" app:layout_constraintBottom_toBottomOf="@id/anchor" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/app/src/main/res/layout/dialog_remove_all_call_logs.xml b/app/src/main/res/layout/dialog_remove_all_call_logs.xml index ce0955270..4c3c8c2d6 100644 --- a/app/src/main/res/layout/dialog_remove_all_call_logs.xml +++ b/app/src/main/res/layout/dialog_remove_all_call_logs.xml @@ -34,6 +34,7 @@ android:layout_marginEnd="12dp" android:layout_marginBottom="2dp" android:src="@drawable/shape_dialog_background" + app:layout_constraintWidth_max="@dimen/dialog_max_width" app:layout_constraintBottom_toBottomOf="@id/anchor" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/app/src/main/res/layout/drawer_menu.xml b/app/src/main/res/layout/drawer_menu.xml index 9c5c96966..243b0c794 100644 --- a/app/src/main/res/layout/drawer_menu.xml +++ b/app/src/main/res/layout/drawer_menu.xml @@ -74,7 +74,15 @@ android:layout_marginEnd="5dp" android:orientation="vertical" entries="@{viewModel.accounts}" - layout="@{@layout/account_list_cell}"/> + layout="@{@layout/account_list_cell}"> + + + + @@ -99,6 +107,7 @@ android:drawablePadding="8dp" app:drawableTint="@color/secondary_button_label_color" android:background="@drawable/secondary_button_background" + app:layout_constraintWidth_max="@dimen/button_max_width" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintBottom_toTopOf="@id/separator" /> diff --git a/app/src/main/res/layout/welcome_activity.xml b/app/src/main/res/layout/welcome_activity.xml index f2bf6772b..a540ad1c3 100644 --- a/app/src/main/res/layout/welcome_activity.xml +++ b/app/src/main/res/layout/welcome_activity.xml @@ -84,6 +84,7 @@ android:textColor="@color/primary_button_label_color" android:gravity="center" android:background="@drawable/primary_button_background" + app:layout_constraintWidth_max="@dimen/button_max_width" app:layout_constraintTop_toBottomOf="@id/dots_indicator" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/app/src/main/res/values/dimen.xml b/app/src/main/res/values/dimen.xml index 612d669be..f441fe437 100644 --- a/app/src/main/res/values/dimen.xml +++ b/app/src/main/res/values/dimen.xml @@ -3,9 +3,9 @@ 0dp 75dp - 280dp + 400dp - 355dp + 475dp 300dp 24dp @@ -34,7 +34,10 @@ 345dp 20dp - 360dp + 400dp + 400dp + 400dp + 400dp 55dp 15dp