From 0c1d6929cd5d49cca7285b5df21a1e672bd7bbbf Mon Sep 17 00:00:00 2001
From: Ronan Abhamon <ronan.abhamon@belledonne-communications.com>
Date: Mon, 20 Feb 2017 11:56:31 +0100
Subject: [PATCH] feat(ui/modules/Linphone/Timeline): use `Connections`
 component

---
 .../ui/modules/Linphone/Timeline.qml          | 76 ++++++++++---------
 1 file changed, 40 insertions(+), 36 deletions(-)

diff --git a/linphone-desktop/ui/modules/Linphone/Timeline.qml b/linphone-desktop/ui/modules/Linphone/Timeline.qml
index 6b462a123..c9c56f0ad 100644
--- a/linphone-desktop/ui/modules/Linphone/Timeline.qml
+++ b/linphone-desktop/ui/modules/Linphone/Timeline.qml
@@ -45,47 +45,51 @@ ColumnLayout {
 
   spacing: 0
 
+  // ---------------------------------------------------------------------------
+
+  Connections {
+    target: model
+
+    // Handle if current entry was moved in timeline.
+    onDataChanged: {
+      var index = view.currentIndex
+      if (
+        index !== -1 &&
+        _selectedSipAddress !== model.data(model.index(index, 0)).sipAddress
+      ) {
+        setSelectedEntry(_selectedSipAddress)
+      }
+    }
+
+    // A timeline entry is removed from timeline if there is no history entry.
+    onRowsAboutToBeRemoved: {
+      var index = view.currentIndex
+      if (index >= first && index <= last) {
+        view.currentIndex = -1
+      }
+    }
+
+    // A entry is added when history is created.
+    onRowsInserted: {
+      if (_selectedSipAddress.length === 0) {
+        return
+      }
+
+      for (var i = first; i <= last; i++) {
+        if (_selectedSipAddress === model.data(model.index(i, 0)).sipAddress) {
+          view.currentIndex = i
+        }
+      }
+    }
+  }
+
+  // ---------------------------------------------------------------------------
+
   Rectangle {
     anchors.fill: parent
     color: TimelineStyle.color
   }
 
-  SmartConnect {
-    Component.onCompleted: {
-      // Handle if current entry was moved in timeline.
-      this.connect(model, 'dataChanged', function () {
-        var index = view.currentIndex
-        if (
-          index !== -1 &&
-          _selectedSipAddress !== model.data(model.index(index, 0)).sipAddress
-        ) {
-          setSelectedEntry(_selectedSipAddress)
-        }
-      })
-
-      // A timeline entry is removed from timeline if there is no history entry.
-      this.connect(model, 'rowsAboutToBeRemoved', function (_, first, last) {
-        var index = view.currentIndex
-        if (index >= first && index <= last) {
-          view.currentIndex = -1
-        }
-      })
-
-      // A entry is added when history is created.
-      this.connect(model, 'rowsInserted', function (_, first, last) {
-        if (_selectedSipAddress.length === 0) {
-          return
-        }
-
-        for (var i = first; i <= last; i++) {
-          if (_selectedSipAddress === model.data(model.index(i, 0)).sipAddress) {
-            view.currentIndex = i
-          }
-        }
-      })
-    }
-  }
-
   // ---------------------------------------------------------------------------
   // Legend.
   // ---------------------------------------------------------------------------