From 0d00704e442615cca1c49b71594eb8ed8b8b8bcd Mon Sep 17 00:00:00 2001 From: Julien Wadel Date: Tue, 4 Apr 2023 15:43:13 +0200 Subject: [PATCH] Fix factor computation to detect non-standard size for a thumbnail. --- CHANGELOG.md | 1 + linphone-app/src/components/content/ContentModel.cpp | 4 ++-- linphone-app/ui/views/App/Main/Conversation.qml | 1 - 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e1917f3c..755c01610 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - Fix using only username in URI handlers. - Chat flickering on load. +- Portait thumbnails. - Color of busy indicator when the chat is loading. - Incoming ephemerals weren't removed without reloading chat rooms. - Update SDK to 5.2.42 diff --git a/linphone-app/src/components/content/ContentModel.cpp b/linphone-app/src/components/content/ContentModel.cpp index 1431ab769..5a592359d 100644 --- a/linphone-app/src/components/content/ContentModel.cpp +++ b/linphone-app/src/components/content/ContentModel.cpp @@ -184,9 +184,9 @@ void ContentModel::createThumbnail (const bool& force) { QPainter painter(&image); painter.drawImage(0, 0, originalImage); //-------------------- - double factor = image.width() / image.height(); + double factor = image.width() / (double)image.height(); if(factor < 0.2 || factor > 5){ - qInfo() << QStringLiteral("Cannot create thumbnails because size factor is too low/much of: `%1`.").arg(path); + qInfo() << QStringLiteral("Cannot create thumbnails because size factor (%1) is too low/much of: `%2`.").arg(factor).arg(path); }else { QImage thumbnail = image.scaled( Constants::ThumbnailImageFileWidth, Constants::ThumbnailImageFileHeight, diff --git a/linphone-app/ui/views/App/Main/Conversation.qml b/linphone-app/ui/views/App/Main/Conversation.qml index 6089cd13d..1e8bcb539 100644 --- a/linphone-app/ui/views/App/Main/Conversation.qml +++ b/linphone-app/ui/views/App/Main/Conversation.qml @@ -651,7 +651,6 @@ ColumnLayout { } } chatRoomModel: conversation.chatRoomModel - peerAddress: conversation.peerAddress fullPeerAddress: conversation.fullPeerAddress fullLocalAddress: conversation.fullLocalAddress localAddress: conversation.localAddress// Reload is done on localAddress. Use this order