mirrors/linphone-desktop
1
0
Fork 0
mirror of https://gitlab.linphone.org/BC/public/linphone-desktop.git synced 2026-01-31 10:59:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(app): coding style & log app startup

Browse source
This commit is contained in:
Ronan Abhamon 2016-12-19 14:18:34 +01:00
parent 59c0154f3a
commit 265965dae2
5 changed files with 17 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/src/app/App.cpp
View file

@ -61,6 +61,8 @@ App::App (int &argc, char **argv) : QApplication(argc, argv) {
// -------------------------------------------------------------------
void App::initContentApp () {
qInfo() << "Initializing core manager...";
// Init core.
CoreManager::init();
@ -69,6 +71,7 @@ void App::initContentApp () {
addContextProperties();
// Load main view.
qInfo() << "Loading main view...";
m_engine.load(QUrl(QML_VIEW_MAIN_WINDOW));
if (m_engine.rootObjects().isEmpty())
qFatal("Unable to open main window.");
@ -81,6 +84,8 @@ void App::initContentApp () {
}
void App::registerTypes () {
qInfo() << "Registering types...";
// Register meta types.
qmlRegisterUncreatableType<Presence>(
"Linphone", 1, 0, "Presence", "Presence is uncreatable"
@ -143,14 +148,16 @@ void App::registerTypes () {
}
void App::addContextProperties () {
qInfo() << "Adding context properties...";
QQmlContext *context = m_engine.rootContext();
QQmlComponent component(&m_engine, QUrl(QML_VIEW_CALL_WINDOW));
// Windows.
if (component.isError())
QQmlComponent component(&m_engine, QUrl(QML_VIEW_CALL_WINDOW));
if (component.isError()) {
qWarning() << component.errors();
else
context->setContextProperty("CallsWindow", component.create());
abort();
}
context->setContextProperty("CallsWindow", component.create());
m_notifier = new Notifier();
context->setContextProperty("Notifier", m_notifier);

4
tests/src/components/chat/ChatModel.cpp
View file

@ -20,7 +20,7 @@ QHash<int, QByteArray> ChatModel::roleNames () const {
return roles;
}
int ChatModel::rowCount (const QModelIndex&) const {
int ChatModel::rowCount (const QModelIndex &) const {
return m_entries.count();
}
@ -40,7 +40,7 @@ QVariant ChatModel::data (const QModelIndex &index, int role) const {
return QVariant();
}
bool ChatModel::removeRow (int row, const QModelIndex&) {
bool ChatModel::removeRow (int row, const QModelIndex &) {
return removeRows(row, 1);
}

2
tests/src/components/contacts/ContactsListProxyModel.hpp
View file

@ -49,7 +49,7 @@ private:
// and reused by `lessThan`.
mutable QHash<const ContactModel *, unsigned int> m_weights;
bool m_use_connected_filter;
bool m_use_connected_filter = false;
static const QRegExp m_search_separators;

4
tests/ui/modules/Common/Form/ListForm.qml
View file

@ -132,12 +132,12 @@ RowLayout {
}
padding: ListFormStyle.value.text.padding
visible: values.model.count === 0 // TODO: placeholder click machin
visible: values.model.count === 0
verticalAlignment: Text.AlignVCenter
MouseArea {
anchors.fill: parent
onClicked: _addValue('')
onClicked: !listForm.readOnly && _addValue('')
}
}

1
tests/ui/modules/Linphone/Chat/Chat.qml
View file

@ -5,7 +5,6 @@ import QtQuick.Layouts 1.3
import Common 1.0
import Linphone 1.0
import Linphone.Styles 1.0
import Utils 1.0
// ===================================================================