From 3881bcacd16b4fdeb5bf56eb3152e3cd3bb97b44 Mon Sep 17 00:00:00 2001
From: Ronan Abhamon <ronan.abhamon@belledonne-communications.com>
Date: Tue, 27 Jun 2017 10:24:13 +0200
Subject: [PATCH] feat(Incall): add tooltips on recording and screenshot
 buttons

---
 assets/languages/en.ts                        | 27 +++++++++++++++++++
 assets/languages/fr.ts                        | 27 +++++++++++++++++++
 ui/views/App/Calls/Incall.qml                 | 12 +++++++++
 ui/views/App/Calls/IncallFullscreenWindow.qml | 16 ++++++++++-
 4 files changed, 81 insertions(+), 1 deletion(-)

diff --git a/assets/languages/en.ts b/assets/languages/en.ts
index 0d7db03b3..6b7d385cc 100644
--- a/assets/languages/en.ts
+++ b/assets/languages/en.ts
@@ -829,6 +829,33 @@ Server url not configured.</translation>
         <source>callNotSecured</source>
         <translation>Call not encrypted.</translation>
     </message>
+    <message>
+        <source>takeSnapshotLabel</source>
+        <translation>Take a snapshot.</translation>
+    </message>
+    <message>
+        <source>startRecordingLabel</source>
+        <translation>Start recording.</translation>
+    </message>
+    <message>
+        <source>stopRecordingLabel</source>
+        <translation>Stop recording.</translation>
+    </message>
+</context>
+<context>
+    <name>IncallFullscreenWindow</name>
+    <message>
+        <source>takeSnapshotLabel</source>
+        <translation>Take a snapshot.</translation>
+    </message>
+    <message>
+        <source>startRecordingLabel</source>
+        <translation>Start recording.</translation>
+    </message>
+    <message>
+        <source>stopRecordingLabel</source>
+        <translation>Stop recording.</translation>
+    </message>
 </context>
 <context>
     <name>InviteFriends</name>
diff --git a/assets/languages/fr.ts b/assets/languages/fr.ts
index 0e277fafc..350620590 100644
--- a/assets/languages/fr.ts
+++ b/assets/languages/fr.ts
@@ -829,6 +829,33 @@ Url du serveur non configurée.</translation>
         <source>callNotSecured</source>
         <translation>Appel non chiffré.</translation>
     </message>
+    <message>
+        <source>takeSnapshotLabel</source>
+        <translation>Prendre une capture d&apos;écran.</translation>
+    </message>
+    <message>
+        <source>startRecordingLabel</source>
+        <translation>Commencer un enregistrement.</translation>
+    </message>
+    <message>
+        <source>stopRecordingLabel</source>
+        <translation>Stopper un enregistrement.</translation>
+    </message>
+</context>
+<context>
+    <name>IncallFullscreenWindow</name>
+    <message>
+        <source>takeSnapshotLabel</source>
+        <translation>Prendre une capture d&apos;écran.</translation>
+    </message>
+    <message>
+        <source>startRecordingLabel</source>
+        <translation>Commencer un enregistrement.</translation>
+    </message>
+    <message>
+        <source>stopRecordingLabel</source>
+        <translation>Stopper un enregistrement.</translation>
+    </message>
 </context>
 <context>
     <name>InviteFriends</name>
diff --git a/ui/views/App/Calls/Incall.qml b/ui/views/App/Calls/Incall.qml
index f509ea5ef..21cf93395 100644
--- a/ui/views/App/Calls/Incall.qml
+++ b/ui/views/App/Calls/Incall.qml
@@ -165,9 +165,15 @@ Rectangle {
           visible: incall.call.videoEnabled
 
           onClicked: incall.call.takeSnapshot()
+
+          TooltipArea {
+            text: qsTr('takeSnapshotLabel')
+          }
         }
 
         ActionSwitch {
+          id: recordingSwitch
+
           enabled: incall.call.recording
           icon: 'record'
           useStates: false
@@ -178,6 +184,12 @@ Rectangle {
               ? call.startRecording()
               : call.stopRecording()
           }
+
+          TooltipArea {
+            text: !recordingSwitch.enabled
+              ? qsTr('startRecordingLabel')
+              : qsTr('stopRecordingLabel')
+          }
         }
 
         ActionButton {
diff --git a/ui/views/App/Calls/IncallFullscreenWindow.qml b/ui/views/App/Calls/IncallFullscreenWindow.qml
index 7b472ad42..50a791760 100644
--- a/ui/views/App/Calls/IncallFullscreenWindow.qml
+++ b/ui/views/App/Calls/IncallFullscreenWindow.qml
@@ -216,14 +216,28 @@ Window {
             icon: 'screenshot'
 
             onClicked: call.takeSnapshot()
+
+            TooltipArea {
+              text: qsTr('takeSnapshotLabel')
+            }
           }
 
           ActionSwitch {
+            id: recordingSwitch
+
             enabled: call.recording
             icon: 'record'
             useStates: false
 
-            onClicked: !enabled ? call.startRecording() : call.stopRecording()
+            onClicked: !enabled
+              ? call.startRecording()
+              : call.stopRecording()
+
+            TooltipArea {
+              text: !recordingSwitch.enabled
+                ? qsTr('startRecordingLabel')
+                : qsTr('stopRecordingLabel')
+            }
           }
 
           ActionButton {