feat(app): QString("") is more efficient than QStringLiteral("")

This commit is contained in:
Ronan Abhamon 2017-06-12 14:25:39 +02:00
parent 271f771c49
commit 3dd474111c
7 changed files with 9 additions and 9 deletions

View file

@ -113,13 +113,13 @@ const QString Cli::parseFunctionName (const QString &command) noexcept {
const QStringList &texts = mRegExpFunctionName.capturedTexts();
if (texts.size() < 2) {
qWarning() << QStringLiteral("Unable to parse function name of command: `%1`.").arg(command);
return QStringLiteral("");
return QString("");
}
const QString functionName = texts[1];
if (!mCommands.contains(functionName)) {
qWarning() << QStringLiteral("This command doesn't exist: `%1`.").arg(functionName);
return QStringLiteral("");
return QString("");
}
return functionName;

View file

@ -58,7 +58,7 @@ QString DefaultTranslator::translate (
int n
) const {
if (!context)
return QStringLiteral("");
return QString("");
QString translation = QTranslator::translate(context, sourceText, disambiguation, n);

View file

@ -527,7 +527,7 @@ QString CallModel::getSecuredString () const {
break;
}
return QStringLiteral("");
return QString("");
}
// -----------------------------------------------------------------------------

View file

@ -136,7 +136,7 @@ QString VcardModel::getAvatar () const {
// No path found.
if (!photo)
return QStringLiteral("");
return QString("");
// Returns right path.
return QStringLiteral("image://%1/%2").arg(AvatarProvider::PROVIDER_ID).arg(

View file

@ -68,5 +68,5 @@ QString Presence::getPresenceLevelIconName (const PresenceLevel &level) {
return QStringLiteral("led_white");
}
return QStringLiteral("");
return QString("");
}

View file

@ -154,7 +154,7 @@ QString SipAddressesModel::getTransportFromSipAddress (const QString &sipAddress
);
if (!address)
return QStringLiteral("");
return QString("");
switch (address->getTransport()) {
case linphone::TransportTypeUdp:
@ -167,7 +167,7 @@ QString SipAddressesModel::getTransportFromSipAddress (const QString &sipAddress
return QStringLiteral("DTLS");
}
return QStringLiteral("");
return QString("");
}
QString SipAddressesModel::addTransportToSipAddress (const QString &sipAddress, const QString &transport) const {

View file

@ -65,7 +65,7 @@ QString Utils::getSafeFilePath (const QString &filePath, bool *soFarSoGood) {
if (soFarSoGood)
*soFarSoGood = false;
return QStringLiteral("");
return QString("");
}
#undef SAFE_FILE_PATH_LIMIT