From 42e00a1817a396ce1db5b7c3eb27a45da3d65133 Mon Sep 17 00:00:00 2001
From: nicolas <nicolas.follet@belledonne-communications.com>
Date: Wed, 9 Aug 2017 17:41:00 +0200
Subject: [PATCH] fix(Cli): better test when passing uri as cli, and an
 argument is missing

---
 src/app/cli/Cli.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/app/cli/Cli.cpp b/src/app/cli/Cli.cpp
index 8b03aa0db..d96c87bb0 100644
--- a/src/app/cli/Cli.cpp
+++ b/src/app/cli/Cli.cpp
@@ -123,7 +123,7 @@ void Cli::Command::execute (QHash<QString, QString> &args) const {
 
   // Check missing arguments.
   for (const auto &argName : mArgsScheme.keys()) {
-    if (!args.contains(argName) && !mArgsScheme[argName].isOptional) {
+    if (!mArgsScheme[argName].isOptional && (!args.contains(argName) || args[argName].isEmpty())) {
       qWarning() << QStringLiteral("Missing argument for command: `%1 (%2)`.")
         .arg(mFunctionName).arg(argName);
       return;
@@ -220,6 +220,7 @@ void Cli::executeCommand (const QString &command, CommandFormat *format) const {
     return;
   }
 
+  //TODO: check if there is any header when the `method` header is missing.
   const QString functionName = ::Utils::coreStringToAppString(address->getHeader("method")).isEmpty()
     ? QStringLiteral("call")
     : ::Utils::coreStringToAppString(address->getHeader("method"));