mirrors/linphone-desktop
1
0
Fork 0
mirror of https://gitlab.linphone.org/BC/public/linphone-desktop.git synced 2026-01-24 07:08:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(app): remove all slots, use Q_INVOKABLE instead.

Browse source
This commit is contained in:
Ronan Abhamon 2016-12-30 16:57:22 +01:00
parent 9813baf1d6
commit 555bf66047
12 changed files with 55 additions and 64 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/src/app/App.hpp
View file

@ -33,8 +33,7 @@ public:
return &m_engine;
}
public slots:
QString locale () const {
Q_INVOKABLE QString locale () const {
return m_locale;
}

5
tests/src/components/chat/ChatModel.hpp
View file

@ -56,9 +56,8 @@ public:
QString getSipAddress () const;
void setSipAddress (const QString &sip_address);
public slots:
void removeEntry (int id);
void removeAllEntries ();
Q_INVOKABLE void removeEntry (int id);
Q_INVOKABLE void removeAllEntries ();
signals:
void sipAddressChanged (const QString &sip_address);

9
tests/src/components/chat/ChatProxyModel.hpp
View file

@ -43,12 +43,11 @@ class ChatProxyModel : public QSortFilterProxyModel {
public:
ChatProxyModel (QObject *parent = Q_NULLPTR);
public slots:
void loadMoreEntries ();
void setEntryTypeFilter (ChatModel::EntryType type);
void removeEntry (int id);
Q_INVOKABLE void loadMoreEntries ();
Q_INVOKABLE void setEntryTypeFilter (ChatModel::EntryType type);
Q_INVOKABLE void removeEntry (int id);
void removeAllEntries () {
Q_INVOKABLE void removeAllEntries () {
static_cast<ChatModel *>(m_chat_model_filter.sourceModel())->removeAllEntries();
}

7
tests/src/components/contact/ContactModel.hpp
View file

@ -26,10 +26,9 @@ public:
return m_vcard;
}
public slots:
void startEdit ();
void endEdit ();
void abortEdit ();
Q_INVOKABLE void startEdit ();
Q_INVOKABLE void endEdit ();
Q_INVOKABLE void abortEdit ();
signals:
void contactUpdated ();

33
tests/src/components/contact/VcardModel.hpp
View file

@ -27,27 +27,26 @@ public:
QString getUsername () const;
QVariantList getSipAddresses () const;
public slots:
bool addSipAddress (const QString &sip_address);
void removeSipAddress (const QString &sip_address);
bool updateSipAddress (const QString &old_sip_address, const QString &sip_address);
Q_INVOKABLE bool addSipAddress (const QString &sip_address);
Q_INVOKABLE void removeSipAddress (const QString &sip_address);
Q_INVOKABLE bool updateSipAddress (const QString &old_sip_address, const QString &sip_address);
bool addCompany (const QString &company);
void removeCompany (const QString &company);
bool updateCompany (const QString &old_company, const QString &company);
Q_INVOKABLE bool addCompany (const QString &company);
Q_INVOKABLE void removeCompany (const QString &company);
Q_INVOKABLE bool updateCompany (const QString &old_company, const QString &company);
bool addEmail (const QString &email);
void removeEmail (const QString &email);
bool updateEmail (const QString &old_email, const QString &email);
Q_INVOKABLE bool addEmail (const QString &email);
Q_INVOKABLE void removeEmail (const QString &email);
Q_INVOKABLE bool updateEmail (const QString &old_email, const QString &email);
bool addUrl (const QString &url);
void removeUrl (const QString &url);
bool updateUrl (const QString &old_url, const QString &url);
Q_INVOKABLE bool addUrl (const QString &url);
Q_INVOKABLE void removeUrl (const QString &url);
Q_INVOKABLE bool updateUrl (const QString &old_url, const QString &url);
void setStreet (const QString &street);
void setLocality (const QString &locality);
void setPostalCode (const QString &postal_code);
void setCountry (const QString &country);
Q_INVOKABLE void setStreet (const QString &street);
Q_INVOKABLE void setLocality (const QString &locality);
Q_INVOKABLE void setPostalCode (const QString &postal_code);
Q_INVOKABLE void setCountry (const QString &country);
signals:
void vcardUpdated ();

5
tests/src/components/contacts/ContactsListModel.hpp
View file

@ -25,9 +25,8 @@ public:
bool removeRow (int row, const QModelIndex &parent = QModelIndex());
bool removeRows (int row, int count, const QModelIndex &parent = QModelIndex()) override;
public slots:
ContactModel *addContact (VcardModel *vcard);
void removeContact (ContactModel *contact);
Q_INVOKABLE ContactModel *addContact (VcardModel *vcard);
Q_INVOKABLE void removeContact (ContactModel *contact);
signals:
void contactAdded (ContactModel *contact);

3
tests/src/components/contacts/ContactsListProxyModel.hpp
View file

@ -22,8 +22,7 @@ public:
ContactsListProxyModel (QObject *parent = Q_NULLPTR);
~ContactsListProxyModel () = default;
public slots:
void setFilter (const QString &pattern);
Q_INVOKABLE void setFilter (const QString &pattern);
protected:
bool filterAcceptsRow (int source_row, const QModelIndex &source_parent) const override;

3
tests/src/components/core/CoreManager.hpp
View file

@ -34,10 +34,9 @@ public:
return m_instance;
}
public slots:
// Must be used in a qml scene.
// Warning: The ownership of `VcardModel` is `QQmlEngine::JavaScriptOwnership` by default.
VcardModel *createDetachedVcardModel ();
Q_INVOKABLE VcardModel *createDetachedVcardModel ();
private:
CoreManager (QObject *parent = Q_NULLPTR);

3
tests/src/components/notifier/Notifier.hpp
View file

@ -20,8 +20,7 @@ public:
MaxNbTypes
};
public slots:
void showCallMessage (int timeout, const QString &sip_address);
Q_INVOKABLE void showCallMessage (int timeout, const QString &sip_address);
private:
QObject *createNotification (NotificationType type);

38
tests/src/components/sip-addresses/SipAddressesModel.cpp
View file

@ -83,6 +83,26 @@ ContactModel *SipAddressesModel::mapSipAddressToContact (const QString &sip_addr
return it->value("contact").value<ContactModel *>();
}
// -----------------------------------------------------------------------------
ContactObserver *SipAddressesModel::getContactObserver (const QString &sip_address) {
ContactObserver *model = new ContactObserver(sip_address);
model->setContact(mapSipAddressToContact(sip_address));
m_observers.insert(sip_address, model);
QObject::connect(
model, &ContactObserver::destroyed, this, [this, model]() {
const QString &sip_address = model->getSipAddress();
if (m_observers.remove(sip_address, model) == 0)
qWarning() << QStringLiteral("Unable to remove sip address `%1` from observers.").arg(sip_address);
}
);
return model;
}
// -----------------------------------------------------------------------------
void SipAddressesModel::handleAllHistoryEntriesRemoved () {
QObject *sender = QObject::sender();
if (!sender)
@ -115,24 +135,6 @@ void SipAddressesModel::handleAllHistoryEntriesRemoved () {
// -----------------------------------------------------------------------------
ContactObserver *SipAddressesModel::getContactObserver (const QString &sip_address) {
ContactObserver *model = new ContactObserver(sip_address);
model->setContact(mapSipAddressToContact(sip_address));
m_observers.insert(sip_address, model);
QObject::connect(
model, &ContactObserver::destroyed, this, [this, model]() {
const QString &sip_address = model->getSipAddress();
if (m_observers.remove(sip_address, model) == 0)
qWarning() << QStringLiteral("Unable to remove sip address `%1` from observers.").arg(sip_address);
}
);
return model;
}
// -----------------------------------------------------------------------------
bool SipAddressesModel::removeRow (int row, const QModelIndex &parent) {
return removeRows(row, 1, parent);
}

7
tests/src/components/sip-addresses/SipAddressesModel.hpp
View file

@ -20,11 +20,10 @@ public:
QHash<int, QByteArray> roleNames () const override;
QVariant data (const QModelIndex &index, int role) const override;
public slots:
ContactModel *mapSipAddressToContact (const QString &sip_address) const;
void handleAllHistoryEntriesRemoved ();
Q_INVOKABLE ContactModel *mapSipAddressToContact (const QString &sip_address) const;
Q_INVOKABLE ContactObserver *getContactObserver (const QString &sip_address);
ContactObserver *getContactObserver (const QString &sip_address);
Q_INVOKABLE void handleAllHistoryEntriesRemoved ();
private:
bool removeRow (int row, const QModelIndex &parent = QModelIndex());

3
tests/src/components/smart-search-bar/SmartSearchBarModel.hpp
View file

@ -16,8 +16,7 @@ public:
QHash<int, QByteArray> roleNames () const override;
public slots:
void setFilter (const QString &pattern);
Q_INVOKABLE void setFilter (const QString &pattern);
protected:
bool filterAcceptsRow (int source_row, const QModelIndex &source_parent) const override;