mirrors/linphone-desktop
1
0
Fork 0
mirror of https://gitlab.linphone.org/BC/public/linphone-desktop.git synced 2026-02-01 19:59:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(app): force the usage of override keyword

Browse source
This commit is contained in:
Ronan Abhamon 2016-12-01 11:26:55 +01:00
parent 989bbc4edf
commit 7bcc90c38f
7 changed files with 18 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/CMakeLists.txt
View file

@ -25,6 +25,8 @@ set(CUSTOM_FLAGS "\
-Wpointer-arith \
-Wuninitialized \
-Wunused \
-Wsuggest-override \
-Werror=suggest-override \
")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CUSTOM_FLAGS}")

8
tests/src/components/chat/ChatModel.hpp
View file

@ -47,13 +47,13 @@ public:
ChatModel (QObject *parent = Q_NULLPTR) : QAbstractListModel(parent) {}
int rowCount (const QModelIndex &index = QModelIndex()) const;
int rowCount (const QModelIndex &index = QModelIndex()) const override;
QHash<int, QByteArray> roleNames () const;
QVariant data (const QModelIndex &index, int role) const;
QHash<int, QByteArray> roleNames () const override;
QVariant data (const QModelIndex &index, int role) const override;
bool removeRow (int row, const QModelIndex &parent = QModelIndex());
bool removeRows (int row, int count, const QModelIndex &parent = QModelIndex());
bool removeRows (int row, int count, const QModelIndex &parent = QModelIndex()) override;
public slots:
void removeEntry (int id);

4
tests/src/components/chat/ChatProxyModel.hpp
View file

@ -19,7 +19,7 @@ public:
ChatModelFilter (QObject *parent = Q_NULLPTR);
protected:
bool filterAcceptsRow (int source_row, const QModelIndex &parent) const;
bool filterAcceptsRow (int source_row, const QModelIndex &parent) const override;
private:
void setEntryTypeFilter (ChatModel::EntryType type);
@ -60,7 +60,7 @@ public slots:
}
protected:
bool filterAcceptsRow (int source_row, const QModelIndex &source_parent) const;
bool filterAcceptsRow (int source_row, const QModelIndex &source_parent) const override;
private:
QString getSipAddress () const {

8
tests/src/components/contacts/ContactsListModel.hpp
View file

@ -16,13 +16,13 @@ class ContactsListModel : public QAbstractListModel {
public:
ContactsListModel (QObject *parent = Q_NULLPTR);
int rowCount (const QModelIndex &index = QModelIndex()) const;
int rowCount (const QModelIndex &index = QModelIndex()) const override;
QHash<int, QByteArray> roleNames () const;
QVariant data (const QModelIndex &index, int role) const;
QHash<int, QByteArray> roleNames () const override;
QVariant data (const QModelIndex &index, int role) const override;
bool removeRow (int row, const QModelIndex &parent = QModelIndex());
bool removeRows (int row, int count, const QModelIndex &parent = QModelIndex());
bool removeRows (int row, int count, const QModelIndex &parent = QModelIndex()) override;
public slots:
// See: http://doc.qt.io/qt-5/qtqml-cppintegration-data.html#data-ownership

4
tests/src/components/contacts/ContactsListProxyModel.hpp
View file

@ -30,8 +30,8 @@ public slots:
}
protected:
bool filterAcceptsRow (int source_row, const QModelIndex &source_parent) const;
bool lessThan (const QModelIndex &left, const QModelIndex &right) const;
bool filterAcceptsRow (int source_row, const QModelIndex &source_parent) const override;
bool lessThan (const QModelIndex &left, const QModelIndex &right) const override;
private:
float computeStringWeight (const QString &string, float percentage) const;

6
tests/src/components/timeline/TimelineModel.hpp
View file

@ -13,9 +13,9 @@ class TimelineModel : public QAbstractListModel {
public:
TimelineModel (const ContactsListModel *contacts_list);
int rowCount (const QModelIndex &) const;
QHash<int, QByteArray> roleNames () const;
QVariant data (const QModelIndex &index, int role) const;
int rowCount (const QModelIndex &) const override;
QHash<int, QByteArray> roleNames () const override;
QVariant data (const QModelIndex &index, int role) const override;
private:
void init_entries ();

1
tests/ui/views/App/Calls/Calls.qml
View file

@ -86,6 +86,7 @@ Window {
childA: AbstractCall {
anchors.fill: parent
callTypeLabel: 'INCOMING VIDEO CALL'
sipAddress: 'sip:erwan.croze@sip.linphone.org'
}
childB: Rectangle {