From aa660534bad51310ff87c2a9963692e363747bdd Mon Sep 17 00:00:00 2001 From: Julien Wadel Date: Mon, 9 Jan 2023 18:07:49 +0100 Subject: [PATCH] Update lime url on migration for Linphone. Set old core url before migrating account parameters. Fix OpenSSL deployment on Windows. Update SDK to 5.2.10 --- CHANGELOG.md | 3 ++- CMakeLists.txt | 7 ++++++- .../components/chat-room/ChatRoomModel.cpp | 12 ++++++----- .../src/components/core/CoreManager.cpp | 21 ++++++++++--------- linphone-sdk | 2 +- 5 files changed, 27 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2275d584c..f82d3e52f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - Crash at startup -- Update SDK to 5.2.8 +- Deploy missing OpenSSL libraries on Windows (fix blank message on image url) +- Update SDK to 5.2.10 ## 5.0.4 - 2022-12-28 diff --git a/CMakeLists.txt b/CMakeLists.txt index 31db8a82b..369320f3e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -121,9 +121,13 @@ option(LINPHONE_SDK_MAKE_RELEASE_FILE_URL "Make a RELEASE file that work along c -if(WIN32 OR APPLE) +if(WIN32) + option(ENABLE_OPENSSL_EXPORT "Enable OpenSSL deployment" YES) +elseif(APPLE) + option(ENABLE_OPENSSL_EXPORT "Enable OpenSSL deployment" NO) else() option(ENABLE_V4L "Ability to capture and display video using libv4l2 or libv4l." YES) + option(ENABLE_OPENSSL_EXPORT "Enable OpenSSL deployment" NO) endif() option(ENABLE_RELATIVE_PREFIX "Set Internal packages relative to the binary" YES) @@ -142,6 +146,7 @@ list(APPEND APP_OPTIONS "-DENABLE_FLEXIAPI=${ENABLE_QRCODE}") list(APPEND APP_OPTIONS "-DENABLE_LDAP=${ENABLE_LDAP}") list(APPEND APP_OPTIONS "-DENABLE_NON_FREE_CODECS=${ENABLE_NON_FREE_CODECS}") list(APPEND APP_OPTIONS "-DENABLE_OPENH264=${ENABLE_OPENH264}") +list(APPEND APP_OPTIONS "-DENABLE_OPENSSL_EXPORT=${ENABLE_OPENSSL_EXPORT}") list(APPEND APP_OPTIONS "-DENABLE_QRCODE=${ENABLE_QRCODE}") list(APPEND APP_OPTIONS "-DENABLE_SANITIZER=${ENABLE_SANITIZER}") diff --git a/linphone-app/src/components/chat-room/ChatRoomModel.cpp b/linphone-app/src/components/chat-room/ChatRoomModel.cpp index 45de74dbe..096093168 100644 --- a/linphone-app/src/components/chat-room/ChatRoomModel.cpp +++ b/linphone-app/src/components/chat-room/ChatRoomModel.cpp @@ -1253,12 +1253,14 @@ void ChatRoomModel::onMessagesReceived(const std::shared_ptr void ChatRoomModel::onNewEvent(const std::shared_ptr & chatRoom, const std::shared_ptr & eventLog){ - if( eventLog->getType() == linphone::EventLog::Type::ConferenceCallEnded ){ - setMissedCallsCount(mMissedCallsCount+1); - }else if( eventLog->getType() == linphone::EventLog::Type::ConferenceCreated ){ - emit fullPeerAddressChanged(); + if(eventLog){ + if( eventLog->getType() == linphone::EventLog::Type::ConferenceCallEnded ){ + setMissedCallsCount(mMissedCallsCount+1); + }else if( eventLog->getType() == linphone::EventLog::Type::ConferenceCreated ){ + emit fullPeerAddressChanged(); + } + updateLastUpdateTime(); } - updateLastUpdateTime(); } void ChatRoomModel::onChatMessageReceived(const std::shared_ptr & chatRoom, const std::shared_ptr & eventLog) { diff --git a/linphone-app/src/components/core/CoreManager.cpp b/linphone-app/src/components/core/CoreManager.cpp index b04f30113..73db430d4 100644 --- a/linphone-app/src/components/core/CoreManager.cpp +++ b/linphone-app/src/components/core/CoreManager.cpp @@ -324,7 +324,10 @@ void CoreManager::migrate () { qInfo() << QStringLiteral("Migrate from old rc file (%1 to %2).") .arg(rcVersion).arg(Constants::RcVersionCurrent); - + if( !oldLimeServerUrl.empty()) { + mCore->setLimeX3DhServerUrl(""); + mCore->enableLimeX3Dh(true); + } bool setLimeServerUrl = false; for(const auto &account : getAccountList()){ auto params = account->getParams(); @@ -360,19 +363,17 @@ void CoreManager::migrate () { qInfo() << "Migrating" << accountIdentity << "for version 5. Video conference factory URI" << (exists ? std::string("unchanged") : std::string("= ") +Constants::DefaultVideoConferenceURI).c_str(); // note: using std::string.c_str() to avoid having double quotes in qInfo() } - - if(!oldLimeServerUrl.empty()) - newParams->setLimeServerUrl(oldLimeServerUrl); - else if( setLimeServerUrl) - newParams->setLimeServerUrl(Constants::DefaultLimeServerURL); + if(newParams->getLimeServerUrl().empty()){ + if(!oldLimeServerUrl.empty()) + newParams->setLimeServerUrl(oldLimeServerUrl); + else if( setLimeServerUrl) + newParams->setLimeServerUrl(Constants::DefaultLimeServerURL); + } account->setParams(newParams); } } - if( !oldLimeServerUrl.empty()) { - mCore->setLimeX3DhServerUrl(""); - mCore->enableLimeX3Dh(true); - }else if(setLimeServerUrl) { + if( oldLimeServerUrl.empty() && setLimeServerUrl) { mCore->enableLimeX3Dh(true); } diff --git a/linphone-sdk b/linphone-sdk index c50ef2612..e57d22dca 160000 --- a/linphone-sdk +++ b/linphone-sdk @@ -1 +1 @@ -Subproject commit c50ef261270294c2b87d5abdfdfe5dc0cb841726 +Subproject commit e57d22dca56af8ecd9b0ee5b8e072dbdd65d2266