From b650e35a2beb902572d263a814e8d8b0d18d3c0d Mon Sep 17 00:00:00 2001 From: Ronan Abhamon Date: Fri, 23 Sep 2016 15:50:46 +0200 Subject: [PATCH] feat(Collapse): use coding conventions --- tests/linphone.pro | 1 - tests/ui/components/collapse/Collapse.qml | 12 +++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/linphone.pro b/tests/linphone.pro index 6fb09055a..5bb80b85b 100644 --- a/tests/linphone.pro +++ b/tests/linphone.pro @@ -33,7 +33,6 @@ lupdate_only{ ui/components/scrollBar/*.qml \ ui/components/select/*.qml \ ui/components/timeline/*.qml \ - ui/style/collapse/*.qml \ ui/views/*.qml \ ui/views/mainWindow/*.qml } diff --git a/tests/ui/components/collapse/Collapse.qml b/tests/ui/components/collapse/Collapse.qml index b65bb2f42..0dc023236 100644 --- a/tests/ui/components/collapse/Collapse.qml +++ b/tests/ui/components/collapse/Collapse.qml @@ -3,16 +3,18 @@ import QtQuick 2.7 import 'qrc:/ui/components/form' import 'qrc:/ui/style' +// =================================================================== +// A simple component to build collapsed item. // =================================================================== Item { - property bool isCollapsed: false + property bool _isCollapsed: false signal collapsed (bool collapsed) function collapse () { - isCollapsed = !isCollapsed - collapsed(isCollapsed) + _isCollapsed = !_isCollapsed + collapsed(_isCollapsed) rotate.start() } @@ -32,9 +34,9 @@ Item { direction: RotationAnimation.Clockwise duration: CollapseStyle.animationDuration - from: isCollapsed ? 0 : 180 + from: _isCollapsed ? 0 : 180 property: 'rotation' target: button - to: isCollapsed ? 180 : 0 + to: _isCollapsed ? 180 : 0 } }