From c515eec4811d688453885018f437aeca20caa7d2 Mon Sep 17 00:00:00 2001
From: Ronan Abhamon <ronan.abhamon@belledonne-communications.com>
Date: Wed, 9 Aug 2017 12:48:44 +0200
Subject: [PATCH] fix(app): test correctly valid sip addresses at many points

---
 src/app/cli/Cli.cpp                     | 2 +-
 src/components/calls/CallsListModel.cpp | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/app/cli/Cli.cpp b/src/app/cli/Cli.cpp
index 3384b10df..0468e6114 100644
--- a/src/app/cli/Cli.cpp
+++ b/src/app/cli/Cli.cpp
@@ -53,7 +53,7 @@ static void cliInitiateConference (QHash<QString, QString> &args) {
   // Check identity.
   {
     shared_ptr<linphone::Address> address = core->interpretUrl(::Utils::appStringToCoreString(args["sip-address"]));
-    if (!address) {
+    if (!address || address->getUsername().empty()) {
       qWarning() << QStringLiteral("Unable to parse invalid sip address.");
       return;
     }
diff --git a/src/components/calls/CallsListModel.cpp b/src/components/calls/CallsListModel.cpp
index 1cf43dba0..ee2148251 100644
--- a/src/components/calls/CallsListModel.cpp
+++ b/src/components/calls/CallsListModel.cpp
@@ -95,7 +95,7 @@ void CallsListModel::launchAudioCall (const QString &sipAddress, const QHash<QSt
   shared_ptr<linphone::Core> core = CoreManager::getInstance()->getCore();
 
   shared_ptr<linphone::Address> address = core->interpretUrl(::Utils::appStringToCoreString(sipAddress));
-  if (!address)
+  if (!address || address->getUsername().empty())
     return;
 
   shared_ptr<linphone::CallParams> params = core->createCallParams(nullptr);
@@ -120,7 +120,7 @@ void CallsListModel::launchVideoCall (const QString &sipAddress) const {
   }
 
   shared_ptr<linphone::Address> address = core->interpretUrl(::Utils::appStringToCoreString(sipAddress));
-  if (!address)
+  if (!address || address->getUsername().empty())
     return;
 
   shared_ptr<linphone::CallParams> params = core->createCallParams(nullptr);