From ca73193f6c15b49ea23082edb6080b022f5b88ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandre=20J=C3=B6rgensen?= Date: Fri, 7 Nov 2025 16:28:37 +0100 Subject: [PATCH] Fix accessibility screen reader: * Error on login page not sayed #LINQT-2095 * Incorect translation of close button in french #LINQT-2094 --- Linphone/data/languages/ca.ts | 2 +- Linphone/data/languages/cs.ts | 2 +- Linphone/data/languages/de.ts | 2 +- Linphone/data/languages/en.ts | 2 +- Linphone/data/languages/es.ts | 2 +- Linphone/data/languages/eu.ts | 2 +- Linphone/data/languages/fi.ts | 2 +- Linphone/data/languages/fr.ts | 4 ++-- Linphone/data/languages/hu.ts | 2 +- Linphone/data/languages/mk.ts | 2 +- Linphone/data/languages/nl.ts | 2 +- Linphone/data/languages/pt.ts | 2 +- Linphone/data/languages/pt_BR.ts | 2 +- Linphone/data/languages/ru.ts | 2 +- Linphone/data/languages/sk.ts | 2 +- Linphone/data/languages/uk.ts | 2 +- Linphone/data/languages/zh_Hans.ts | 2 +- Linphone/model/account/AccountManager.cpp | 2 ++ Linphone/view/Page/Form/Contact/ContactEdition.qml | 2 +- 19 files changed, 21 insertions(+), 19 deletions(-) diff --git a/Linphone/data/languages/ca.ts b/Linphone/data/languages/ca.ts index 3f628b379..4efecfa43 100644 --- a/Linphone/data/languages/ca.ts +++ b/Linphone/data/languages/ca.ts @@ -2599,7 +2599,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/cs.ts b/Linphone/data/languages/cs.ts index be8063b26..0452638e6 100644 --- a/Linphone/data/languages/cs.ts +++ b/Linphone/data/languages/cs.ts @@ -2610,7 +2610,7 @@ proto nezveřejňujte žádné citlivé informace! close_accessible_name - Close %n + Close %1 Zavřít %1 diff --git a/Linphone/data/languages/de.ts b/Linphone/data/languages/de.ts index 6f0f67d73..84eaddf33 100644 --- a/Linphone/data/languages/de.ts +++ b/Linphone/data/languages/de.ts @@ -2740,7 +2740,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/en.ts b/Linphone/data/languages/en.ts index ccf93ae5d..f3cf2fa28 100644 --- a/Linphone/data/languages/en.ts +++ b/Linphone/data/languages/en.ts @@ -2684,7 +2684,7 @@ Only your correspondent can decrypt them. close_accessible_name - Close %n + Close %1 Close %1 diff --git a/Linphone/data/languages/es.ts b/Linphone/data/languages/es.ts index 6c283131d..ddd4efe3b 100644 --- a/Linphone/data/languages/es.ts +++ b/Linphone/data/languages/es.ts @@ -2594,7 +2594,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/eu.ts b/Linphone/data/languages/eu.ts index f9f6fed2c..ece0dfa03 100644 --- a/Linphone/data/languages/eu.ts +++ b/Linphone/data/languages/eu.ts @@ -2599,7 +2599,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/fi.ts b/Linphone/data/languages/fi.ts index ab539d18b..68d861f00 100644 --- a/Linphone/data/languages/fi.ts +++ b/Linphone/data/languages/fi.ts @@ -2594,7 +2594,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/fr.ts b/Linphone/data/languages/fr.ts index 5bf22ecfa..f8dacfd43 100644 --- a/Linphone/data/languages/fr.ts +++ b/Linphone/data/languages/fr.ts @@ -2684,8 +2684,8 @@ en bout. Seul votre correspondant peut les déchiffrer. close_accessible_name - Close %n - Fermer %n + Close %1 + Fermer %1 diff --git a/Linphone/data/languages/hu.ts b/Linphone/data/languages/hu.ts index 52635c2ff..9233ba8af 100644 --- a/Linphone/data/languages/hu.ts +++ b/Linphone/data/languages/hu.ts @@ -2594,7 +2594,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/mk.ts b/Linphone/data/languages/mk.ts index 90b2b22e0..19c3d4189 100644 --- a/Linphone/data/languages/mk.ts +++ b/Linphone/data/languages/mk.ts @@ -2594,7 +2594,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/nl.ts b/Linphone/data/languages/nl.ts index 8fe09f544..38c5c9c28 100644 --- a/Linphone/data/languages/nl.ts +++ b/Linphone/data/languages/nl.ts @@ -2594,7 +2594,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/pt.ts b/Linphone/data/languages/pt.ts index 8bbbbd0f2..65de2cf2a 100644 --- a/Linphone/data/languages/pt.ts +++ b/Linphone/data/languages/pt.ts @@ -2599,7 +2599,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/pt_BR.ts b/Linphone/data/languages/pt_BR.ts index 6177ea99a..aebcd953f 100644 --- a/Linphone/data/languages/pt_BR.ts +++ b/Linphone/data/languages/pt_BR.ts @@ -2601,7 +2601,7 @@ Apenas seu correspondente pode descriptografá-las. close_accessible_name - Close %n + Close %1 Fechar %1 diff --git a/Linphone/data/languages/ru.ts b/Linphone/data/languages/ru.ts index adef95db8..245f37034 100644 --- a/Linphone/data/languages/ru.ts +++ b/Linphone/data/languages/ru.ts @@ -2603,7 +2603,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/sk.ts b/Linphone/data/languages/sk.ts index b00d4959b..558c38d6d 100644 --- a/Linphone/data/languages/sk.ts +++ b/Linphone/data/languages/sk.ts @@ -2598,7 +2598,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/uk.ts b/Linphone/data/languages/uk.ts index 057eed2a3..dc540ce80 100644 --- a/Linphone/data/languages/uk.ts +++ b/Linphone/data/languages/uk.ts @@ -2603,7 +2603,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/data/languages/zh_Hans.ts b/Linphone/data/languages/zh_Hans.ts index f2b52559d..7e4f33e58 100644 --- a/Linphone/data/languages/zh_Hans.ts +++ b/Linphone/data/languages/zh_Hans.ts @@ -2600,7 +2600,7 @@ Error close_accessible_name - Close %n + Close %1 diff --git a/Linphone/model/account/AccountManager.cpp b/Linphone/model/account/AccountManager.cpp index 10532bbd3..4d8911e3f 100644 --- a/Linphone/model/account/AccountManager.cpp +++ b/Linphone/model/account/AccountManager.cpp @@ -19,6 +19,7 @@ */ #include "AccountManager.hpp" +#include "tool/accessibility/AccessibilityHelper.hpp" #include #include @@ -153,6 +154,7 @@ bool AccountManager::login(QString username, errorMessage = tr("assistant_account_login_forbidden_error"); //: "Error during connection, please verify your parameters" else errorMessage = tr("assistant_account_login_error"); + AccessibilityHelper::announceMessage(errorMessage); mAccountModel->removeAccount(); } else if (state == linphone::RegistrationState::Ok) { core->setDefaultAccount(account); diff --git a/Linphone/view/Page/Form/Contact/ContactEdition.qml b/Linphone/view/Page/Form/Contact/ContactEdition.qml index 994c69ce6..902058eed 100644 --- a/Linphone/view/Page/Form/Contact/ContactEdition.qml +++ b/Linphone/view/Page/Form/Contact/ContactEdition.qml @@ -58,7 +58,7 @@ MainRightPanel { icon.source: AppIcons.closeX icon.width: Utils.getSizeWithScreenRatio(24) icon.height: Utils.getSizeWithScreenRatio(24) - //: Close %n + //: Close %1 Accessible.name: qsTr("close_accessible_name").arg(mainItem.title) onClicked: { if (contact.core.isSaved) mainItem.closeEdition('')