From d7be2afbb7bb145a42ad99f44673b2ab02e839e6 Mon Sep 17 00:00:00 2001 From: Ronan Abhamon Date: Wed, 9 Aug 2017 13:50:07 +0200 Subject: [PATCH] fix(ConferenceAddMOdel): check valid sip address in `addToConference` --- src/components/conference/ConferenceAddModel.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/components/conference/ConferenceAddModel.cpp b/src/components/conference/ConferenceAddModel.cpp index b1de6639a..9519016b1 100644 --- a/src/components/conference/ConferenceAddModel.cpp +++ b/src/components/conference/ConferenceAddModel.cpp @@ -90,15 +90,17 @@ bool ConferenceHelperModel::ConferenceAddModel::addToConference (const QString & if (mSipAddresses.contains(sipAddress)) return false; - int row = rowCount(); + shared_ptr address = CoreManager::getInstance()->getCore()->interpretUrl( + ::Utils::appStringToCoreString(sipAddress) + ); + if (!address || address->getUsername().empty()) + return false; + int row = rowCount(); beginInsertRows(QModelIndex(), row, row); qInfo() << QStringLiteral("Add sip address to conference: `%1`.").arg(sipAddress); - shared_ptr linphoneAddress = CoreManager::getInstance()->getCore()->interpretUrl( - ::Utils::appStringToCoreString(sipAddress) - ); - addToConferencePrivate(linphoneAddress); + addToConferencePrivate(address); endInsertRows();