From e09911d8fbb2eb354cb550de15bbc0fbd90dfbbc Mon Sep 17 00:00:00 2001 From: Ronan Abhamon Date: Wed, 7 Jun 2017 14:56:48 +0200 Subject: [PATCH] fix(ui/views/App/Calls/CallsWindow): do not show closing virtual window in conference mode --- linphone-desktop/ui/views/App/Calls/CallsWindow.js | 8 ++------ linphone-desktop/ui/views/App/Calls/CallsWindow.qml | 6 +++--- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/linphone-desktop/ui/views/App/Calls/CallsWindow.js b/linphone-desktop/ui/views/App/Calls/CallsWindow.js index f0c37d978..bdf2d5368 100644 --- a/linphone-desktop/ui/views/App/Calls/CallsWindow.js +++ b/linphone-desktop/ui/views/App/Calls/CallsWindow.js @@ -81,15 +81,11 @@ function handleCallTransferAsked (call) { }) } -function handleDetachedVirtualWindow () { - handleCountChanged(calls.count) -} - function windowMustBeClosed () { - return calls.count === 0 && !window.virtualWindowVisible + return Linphone.CallsListModel.rowCount() === 0 && !window.virtualWindowVisible } -function handleCountChanged () { +function tryToCloseWindow () { if (windowMustBeClosed()) { // Workaround, it's necessary to use a timeout because at last call termination // a segfault is emit in `QOpenGLContext::functions() const ()`. diff --git a/linphone-desktop/ui/views/App/Calls/CallsWindow.qml b/linphone-desktop/ui/views/App/Calls/CallsWindow.qml index c511a3998..9ced3eb7d 100644 --- a/linphone-desktop/ui/views/App/Calls/CallsWindow.qml +++ b/linphone-desktop/ui/views/App/Calls/CallsWindow.qml @@ -55,7 +55,7 @@ Window { // --------------------------------------------------------------------------- onClosing: Logic.handleClosing(close) - onDetachedVirtualWindow: Logic.handleDetachedVirtualWindow() + onDetachedVirtualWindow: Logic.tryToCloseWindow() // --------------------------------------------------------------------------- @@ -124,8 +124,6 @@ Window { conferenceModel: ConferenceModel {} model: CallsListProxyModel {} - - onCountChanged: Logic.handleCountChanged(count) } } } @@ -212,10 +210,12 @@ Window { // --------------------------------------------------------------------------- // Handle transfer. + // Handle count changed. Not on proxy model!!! // --------------------------------------------------------------------------- Connections { target: CallsListModel onCallTransferAsked: Logic.handleCallTransferAsked(callModel) + onRowsRemoved: Logic.tryToCloseWindow() } }