From e292ed1b42a13d10ceb93c93f2a00fee1ef33071 Mon Sep 17 00:00:00 2001 From: Julien Wadel Date: Mon, 4 Apr 2022 13:22:18 +0200 Subject: [PATCH] - Set LDAP as an optional feature. - Fix qml error on ChatContent. - Participant devices : click on participant will show devices instead of calling him. - Set SDK to 5.1.19 with fix on crash at exit, 'm' device security level, leak on aborted call. --- CHANGELOG.md | 15 +++++++++++++-- CMakeLists.txt | 3 ++- .../src/components/settings/SettingsModel.cpp | 4 ++++ .../src/components/settings/SettingsModel.hpp | 2 ++ .../ui/modules/Linphone/Chat/ChatContent.qml | 4 ++-- .../App/Main/Dialogs/ParticipantsDevices.qml | 5 ++++- .../ui/views/App/Settings/SettingsAdvanced.qml | 1 + linphone-sdk | 2 +- 8 files changed, 29 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9228f4020..30561b3ee 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,22 +15,33 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Device name can be changed from settings. - New event on new messages in chat and a shortcut to go to the end of chat if last message is not shown. - Shortcut in Reply to message's origin. -- Based on Linphone SDK 5.1 +- Allow redirected downloads (bzip2/OpenH264) +- Auto-download message files, editable in settings (10Mb as default) - 64bits application on Windows +- Based on Linphone SDK 5.1 ### Fixed - Simplify filtering timelines with 2 modes (minimal or exhaustive) and on 3 kind of search : security level, simple/group chats, ephemerals. - Sort timelines by taken account of unread events in chat rooms. - Fix systemTrayIcon that could be cloned on each restart. +- Fix thumbnails display in notification. - Fix errors on Action-Buttons on restart. - Enable G729 on public builds. -- Take account of return key on Numpad +- Take account of return key on Numpad. - Huge messages are better shown and with less flickering. +- High CPU consumption on idle state. +- Hide deleted/terminated chat rooms. - Adapt UserAgent with device name. - Video freeze on network change. +- Support OpenGL 4.1 and GLSL 4.10. +- Fix some glitches on Apple M1. +- Audio errors in settings when using different audio format between input and output. - Set default log size to 50MB +- Reduce ICE candidates on Windows. +- Show logs in console on Windows. - Crash on the smart search bar. + ## 4.3.2 ### Fixed diff --git a/CMakeLists.txt b/CMakeLists.txt index 2cf1928b7..5d2a1b936 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -104,6 +104,7 @@ option(ENABLE_NON_FREE_CODECS "Enable the use of non free codecs" YES) option(ENABLE_BUILD_APP_PLUGINS "Enable the build of plugins" YES) option(ENABLE_BUILD_EXAMPLES "Enable the build of examples" NO) option(ENABLE_VIDEO "Enable Video support." YES) +option(ENABLE_LDAP "Enable LDAP support." YES) option(ENABLE_DAEMON "Enable the linphone daemon interface." NO) option(ENABLE_CONSOLE_UI "Turn on or off compilation of console interface." NO) @@ -138,7 +139,7 @@ list(APPEND APP_OPTIONS "-DENABLE_DAEMON=${ENABLE_DAEMON}") list(APPEND APP_OPTIONS "-DENABLE_CONSOLE_UI=${ENABLE_CONSOLE_UI}") list(APPEND APP_OPTIONS "-DENABLE_VIDEO=${ENABLE_VIDEO}") list(APPEND APP_OPTIONS "-DENABLE_APP_LICENSE=${ENABLE_APP_LICENSE}") -list(APPEND APP_OPTIONS "-DENABLE_LDAP=YES") +list(APPEND APP_OPTIONS "-DENABLE_LDAP=${ENABLE_LDAP}") list(APPEND APP_OPTIONS "-DENABLE_APP_WEBVIEW=${ENABLE_APP_WEBVIEW}") diff --git a/linphone-app/src/components/settings/SettingsModel.cpp b/linphone-app/src/components/settings/SettingsModel.cpp index 82d8c463d..8384f8ff6 100644 --- a/linphone-app/src/components/settings/SettingsModel.cpp +++ b/linphone-app/src/components/settings/SettingsModel.cpp @@ -1471,6 +1471,10 @@ void SettingsModel::setLogsEmail (const QString &email) { emit logsEmailChanged(email); } +bool SettingsModel::isLdapAvailable(){ + return CoreManager::getInstance()->getCore()->ldapAvailable(); +} + // --------------------------------------------------------------------------- QString SettingsModel::getLogsFolder (const shared_ptr &config) { diff --git a/linphone-app/src/components/settings/SettingsModel.hpp b/linphone-app/src/components/settings/SettingsModel.hpp index 7e6bd83c2..4f1ed9c5a 100644 --- a/linphone-app/src/components/settings/SettingsModel.hpp +++ b/linphone-app/src/components/settings/SettingsModel.hpp @@ -536,6 +536,8 @@ public: QString getLogsEmail () const; void setLogsEmail (const QString &email); + Q_INVOKABLE bool isLdapAvailable(); + // --------------------------------------------------------------------------- static QString getLogsFolder (const std::shared_ptr &config); diff --git a/linphone-app/ui/modules/Linphone/Chat/ChatContent.qml b/linphone-app/ui/modules/Linphone/Chat/ChatContent.qml index 5b1ba13ff..c1bfe93bc 100644 --- a/linphone-app/ui/modules/Linphone/Chat/ChatContent.qml +++ b/linphone-app/ui/modules/Linphone/Chat/ChatContent.qml @@ -30,8 +30,8 @@ Column{ signal rightClicked() height: fitHeight - anchors.left: parent.left - anchors.right: parent.right + anchors.left: parent ? parent.left : undefined + anchors.right: parent ? parent.right : undefined spacing: 0 diff --git a/linphone-app/ui/views/App/Main/Dialogs/ParticipantsDevices.qml b/linphone-app/ui/views/App/Main/Dialogs/ParticipantsDevices.qml index 943e950f1..dff4d0fa1 100644 --- a/linphone-app/ui/views/App/Main/Dialogs/ParticipantsDevices.qml +++ b/linphone-app/ui/views/App/Main/Dialogs/ParticipantsDevices.qml @@ -97,10 +97,13 @@ DialogPlus { MouseArea{ anchors.fill:contactDescription onClicked: { - mainHeader.window.attachVirtualWindow(Qt.resolvedUrl('InfoEncryption.qml') + if(participantDevices.count == 0 ) + mainHeader.window.attachVirtualWindow(Qt.resolvedUrl('InfoEncryption.qml') ,{securityLevel : mainHeader.securityLevel , addressToCall : mainHeader.addressToCall} ) + else + participantDevices.visible = !participantDevices.visible } } } diff --git a/linphone-app/ui/views/App/Settings/SettingsAdvanced.qml b/linphone-app/ui/views/App/Settings/SettingsAdvanced.qml index 8771933a2..564053b5d 100644 --- a/linphone-app/ui/views/App/Settings/SettingsAdvanced.qml +++ b/linphone-app/ui/views/App/Settings/SettingsAdvanced.qml @@ -111,6 +111,7 @@ TabContainer { width: parent.width addButton:true onAddButtonClicked:ldapSection.add() + visible: SettingsModel.isLdapAvailable() || SettingsModel.developerSettingsEnabled SettingsLdap{ id:ldapSection width: parent.width diff --git a/linphone-sdk b/linphone-sdk index f3daa534e..fdfb9a2c8 160000 --- a/linphone-sdk +++ b/linphone-sdk @@ -1 +1 @@ -Subproject commit f3daa534e402049c95b300d2bbdab485fdab2f3e +Subproject commit fdfb9a2c8de008c4fedc9bd2a9f08459bfa7ec2d