From ebf1d8da844842d1875a4bc64902a48516b0dfcc Mon Sep 17 00:00:00 2001 From: Ronan Abhamon Date: Thu, 23 Aug 2018 10:31:00 +0200 Subject: [PATCH] feat(CoreManager): add a assert in getChatModel to check if a chat room was correctly removed --- src/components/core/CoreManager.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/core/CoreManager.cpp b/src/components/core/CoreManager.cpp index 604b708fd..03a7ca8d2 100644 --- a/src/components/core/CoreManager.cpp +++ b/src/components/core/CoreManager.cpp @@ -120,7 +120,8 @@ shared_ptr CoreManager::getChatModel (const QString &peerAddress, con Q_ASSERT(mCore->createAddress(Utils::appStringToCoreString(localAddress))); auto deleter = [this, chatModelId](ChatModel *chatModel) { - mChatModels.remove(chatModelId); + bool removed = mChatModels.remove(chatModelId); + Q_ASSERT(removed); delete chatModel; }; @@ -134,7 +135,7 @@ shared_ptr CoreManager::getChatModel (const QString &peerAddress, con // Returns an existing chat model. shared_ptr chatModel = mChatModels[chatModelId].lock(); - Q_CHECK_PTR(chatModel.get()); + Q_CHECK_PTR(chatModel); return chatModel; }