From 013be9e292a933bb79961dbd6fe4b9e7457a3863 Mon Sep 17 00:00:00 2001 From: Ronan Abhamon Date: Wed, 11 Oct 2017 15:06:32 +0200 Subject: [PATCH] fix(ChatModifier): use `const std::shared_ptr &message` instead of `std::shared_ptr message` --- src/chat/modifier/chat-message-modifier.h | 4 ++-- src/chat/modifier/cpim-chat-message-modifier.cpp | 4 ++-- src/chat/modifier/cpim-chat-message-modifier.h | 4 ++-- src/chat/modifier/encryption-chat-message-modifier.cpp | 4 ++-- src/chat/modifier/encryption-chat-message-modifier.h | 4 ++-- src/chat/modifier/multipart-chat-message-modifier.cpp | 4 ++-- src/chat/modifier/multipart-chat-message-modifier.h | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/chat/modifier/chat-message-modifier.h b/src/chat/modifier/chat-message-modifier.h index 02b671b7a..8e448063c 100644 --- a/src/chat/modifier/chat-message-modifier.h +++ b/src/chat/modifier/chat-message-modifier.h @@ -46,13 +46,13 @@ public: * It should check first if the internalContent is filled. * If so, it should apply it's changes to it, otherwise it should use the contentsList. */ - virtual Result encode (std::shared_ptr message, int *errorCode) = 0; + virtual Result encode (const std::shared_ptr &message, int *errorCode) = 0; /** * This method will be called when the message is about to be received. * It should apply it's changes to the internal content, the last modifier will take care of filling the contentsList. */ - virtual Result decode (std::shared_ptr message, int *errorCode) = 0; + virtual Result decode (const std::shared_ptr &message, int *errorCode) = 0; }; LINPHONE_END_NAMESPACE diff --git a/src/chat/modifier/cpim-chat-message-modifier.cpp b/src/chat/modifier/cpim-chat-message-modifier.cpp index c556c0d25..04934aead 100644 --- a/src/chat/modifier/cpim-chat-message-modifier.cpp +++ b/src/chat/modifier/cpim-chat-message-modifier.cpp @@ -32,7 +32,7 @@ using namespace std; LINPHONE_BEGIN_NAMESPACE -ChatMessageModifier::Result CpimChatMessageModifier::encode (shared_ptr message, int *errorCode) { +ChatMessageModifier::Result CpimChatMessageModifier::encode (const shared_ptr &message, int *errorCode) { Cpim::Message cpimMessage; Cpim::GenericHeader cpimContentTypeHeader; cpimContentTypeHeader.setName("Content-Type"); @@ -75,7 +75,7 @@ ChatMessageModifier::Result CpimChatMessageModifier::encode (shared_ptr message, int *errorCode) { +ChatMessageModifier::Result CpimChatMessageModifier::decode (const shared_ptr &message, int *errorCode) { Content content; if (!message->getInternalContent().isEmpty()) { content = message->getInternalContent(); diff --git a/src/chat/modifier/cpim-chat-message-modifier.h b/src/chat/modifier/cpim-chat-message-modifier.h index df6a4578c..4e26091b2 100644 --- a/src/chat/modifier/cpim-chat-message-modifier.h +++ b/src/chat/modifier/cpim-chat-message-modifier.h @@ -30,8 +30,8 @@ class CpimChatMessageModifier : public ChatMessageModifier { public: CpimChatMessageModifier () = default; - Result encode (std::shared_ptr message, int *errorCode) override; - Result decode (std::shared_ptr message, int *errorCode) override; + Result encode (const std::shared_ptr &message, int *errorCode) override; + Result decode (const std::shared_ptr &message, int *errorCode) override; }; LINPHONE_END_NAMESPACE diff --git a/src/chat/modifier/encryption-chat-message-modifier.cpp b/src/chat/modifier/encryption-chat-message-modifier.cpp index cad20317a..156b7350e 100644 --- a/src/chat/modifier/encryption-chat-message-modifier.cpp +++ b/src/chat/modifier/encryption-chat-message-modifier.cpp @@ -34,7 +34,7 @@ using namespace std; LINPHONE_BEGIN_NAMESPACE -ChatMessageModifier::Result EncryptionChatMessageModifier::encode (shared_ptr message, int *errorCode) { +ChatMessageModifier::Result EncryptionChatMessageModifier::encode (const shared_ptr &message, int *errorCode) { int retval = -1; shared_ptr chatRoom = message->getChatRoom(); LinphoneImEncryptionEngine *imee = chatRoom->getCore()->im_encryption_engine; @@ -59,7 +59,7 @@ ChatMessageModifier::Result EncryptionChatMessageModifier::encode (shared_ptr message, int *errorCode) { +ChatMessageModifier::Result EncryptionChatMessageModifier::decode (const shared_ptr &message, int *errorCode) { int retval = -1; shared_ptr chatRoom = message->getChatRoom(); LinphoneImEncryptionEngine *imee = chatRoom->getCore()->im_encryption_engine; diff --git a/src/chat/modifier/encryption-chat-message-modifier.h b/src/chat/modifier/encryption-chat-message-modifier.h index 8b9ce52dc..6bd8833f2 100644 --- a/src/chat/modifier/encryption-chat-message-modifier.h +++ b/src/chat/modifier/encryption-chat-message-modifier.h @@ -30,8 +30,8 @@ class EncryptionChatMessageModifier : public ChatMessageModifier { public: EncryptionChatMessageModifier () = default; - Result encode (std::shared_ptr message, int *errorCode) override; - Result decode (std::shared_ptr message, int *errorCode) override; + Result encode (const std::shared_ptr &message, int *errorCode) override; + Result decode (const std::shared_ptr &message, int *errorCode) override; }; LINPHONE_END_NAMESPACE diff --git a/src/chat/modifier/multipart-chat-message-modifier.cpp b/src/chat/modifier/multipart-chat-message-modifier.cpp index 895a1a6d9..72f1064ca 100644 --- a/src/chat/modifier/multipart-chat-message-modifier.cpp +++ b/src/chat/modifier/multipart-chat-message-modifier.cpp @@ -30,7 +30,7 @@ using namespace std; LINPHONE_BEGIN_NAMESPACE -ChatMessageModifier::Result MultipartChatMessageModifier::encode (shared_ptr message, int *errorCode) { +ChatMessageModifier::Result MultipartChatMessageModifier::encode (const shared_ptr &message, int *errorCode) { if (message->getContents().size() > 1) { LinphoneCore *lc = message->getChatRoom()->getCore(); char tmp[64]; @@ -59,7 +59,7 @@ ChatMessageModifier::Result MultipartChatMessageModifier::encode (shared_ptr message, int *errorCode) { +ChatMessageModifier::Result MultipartChatMessageModifier::decode (const shared_ptr &message, int *errorCode) { if (message->getInternalContent().getContentType().getType() == "multipart") { string boundary = message->getInternalContent().getContentType().getParameter(); if (boundary.empty()) { diff --git a/src/chat/modifier/multipart-chat-message-modifier.h b/src/chat/modifier/multipart-chat-message-modifier.h index fd7b747ca..4336af26c 100644 --- a/src/chat/modifier/multipart-chat-message-modifier.h +++ b/src/chat/modifier/multipart-chat-message-modifier.h @@ -30,8 +30,8 @@ class MultipartChatMessageModifier : public ChatMessageModifier { public: MultipartChatMessageModifier () = default; - Result encode (std::shared_ptr message, int *errorCode) override; - Result decode (std::shared_ptr message, int *errorCode) override; + Result encode (const std::shared_ptr &message, int *errorCode) override; + Result decode (const std::shared_ptr &message, int *errorCode) override; }; LINPHONE_END_NAMESPACE