mirrors/linphone-iphone
1
0
Fork 1
mirror of https://gitlab.linphone.org/BC/public/linphone-iphone.git synced 2026-01-20 20:48:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Reworking of Liblinphone's API around payload types

Browse source
This commit is contained in:
François Grisez 2017-03-31 15:23:36 +02:00
parent 5e02b53ee6
commit 351bb97027
20 changed files with 718 additions and 241 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
coreapi/CMakeLists.txt
View file

@ -102,6 +102,7 @@ set(LINPHONE_SOURCE_FILES_C
misc.c
nat_policy.c
offeranswer.c
payload_type.c
player.c
presence.c
proxy.c

18
coreapi/call_params.c
View file

@ -213,15 +213,27 @@ const char *linphone_call_params_get_session_name(const LinphoneCallParams *cp){
return cp->session_name;
}
const LinphonePayloadType* linphone_call_params_get_used_audio_codec(const LinphoneCallParams *cp) {
LinphonePayloadType *linphone_call_params_get_used_audio_payload_type(const LinphoneCallParams *cp) {
return cp->audio_codec ? linphone_payload_type_new(NULL, cp->audio_codec) : NULL;
}
LinphonePayloadType *linphone_call_params_get_used_video_payload_type(const LinphoneCallParams *cp) {
return cp->video_codec ? linphone_payload_type_new(NULL, cp->video_codec) : NULL;
}
LinphonePayloadType *linphone_call_params_get_used_text_payload_type(const LinphoneCallParams *cp) {
return cp->text_codec ? linphone_payload_type_new(NULL, cp->text_codec) : NULL;
}
const OrtpPayloadType *linphone_call_params_get_used_audio_codec(const LinphoneCallParams *cp) {
return cp->audio_codec;
}
const LinphonePayloadType* linphone_call_params_get_used_video_codec(const LinphoneCallParams *cp) {
const OrtpPayloadType *linphone_call_params_get_used_video_codec(const LinphoneCallParams *cp) {
return cp->video_codec;
}
const LinphonePayloadType* linphone_call_params_get_used_text_codec(const LinphoneCallParams *cp) {
const OrtpPayloadType *linphone_call_params_get_used_text_codec(const LinphoneCallParams *cp) {
return cp->text_codec;
}

6
coreapi/help/CMakeLists.txt
View file

@ -27,14 +27,14 @@ if (ENABLE_DOC OR CXX_WRAPPER)
set(top_srcdir "${CMAKE_CURRENT_LIST_DIR}/../../")
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/Doxyfile.in ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile)
set(DOC_INPUT_FILES ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile
${LINPHONE_HEADER_FILES}
${CMAKE_CURRENT_SOURCE_DIR}/doxygen.dox
${LINPHONE_HEADER_FILES}
)
add_custom_command(OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/doc/html/index.html"
add_custom_command(OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/doc/html/index.html" "${CMAKE_CURRENT_BINARY_DIR}/doc/xml/index.xml"
COMMAND ${DOXYGEN_EXECUTABLE} ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile
DEPENDS ${DOC_INPUT_FILES}
)
add_custom_target(linphone-doc ALL DEPENDS "${CMAKE_CURRENT_BINARY_DIR}/doc/html/index.html")
add_custom_target(linphone-doc ALL DEPENDS "${CMAKE_CURRENT_BINARY_DIR}/doc/html/index.html" "${CMAKE_CURRENT_BINARY_DIR}/doc/xml/index.xml")
install(DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/doc/html" "${CMAKE_CURRENT_BINARY_DIR}/doc/xml"
DESTINATION "${CMAKE_INSTALL_DATADIR}/doc/linphone-${LINPHONE_VERSION}")
else()

2
coreapi/linphonecall.c
View file

@ -513,7 +513,7 @@ static bctbx_list_t *make_codec_list(LinphoneCore *lc, CodecConstraints * hints,
pt->mime_type,pt->clock_rate,hints->bandwidth_limit);
continue;
}
if (!linphone_core_check_payload_type_usability(lc,pt)){
if (!_linphone_core_check_payload_type_usability(lc, pt)) {
continue;
}
pt=payload_type_clone(pt);

82
coreapi/linphonecore.c
View file

@ -2220,6 +2220,53 @@ void linphone_core_unref(LinphoneCore *lc) {
belle_sip_object_unref(BELLE_SIP_OBJECT(lc));
}
static bctbx_list_t *ortp_payloads_to_linphone_payloads(const bctbx_list_t *ortp_payloads, LinphoneCore *lc) {
bctbx_list_t *linphone_payloads = NULL;
for (; ortp_payloads!=NULL; ortp_payloads=bctbx_list_next(ortp_payloads)) {
LinphonePayloadType *pt = linphone_payload_type_new(lc, (OrtpPayloadType *)ortp_payloads->data);
linphone_payloads = bctbx_list_append(linphone_payloads, pt);
}
return linphone_payloads;
}
static void sort_ortp_pt_list(bctbx_list_t **ortp_pt_list, const bctbx_list_t *linphone_pt_list) {
bctbx_list_t *new_list = NULL;
const bctbx_list_t *it;
for (it=bctbx_list_first_elem(linphone_pt_list); it; it=bctbx_list_next(it)) {
OrtpPayloadType *ortp_pt = linphone_payload_type_get_ortp_pt((LinphonePayloadType *)it->data);
bctbx_list_t *elem = bctbx_list_find(*ortp_pt_list, ortp_pt);
if (elem) {
*ortp_pt_list = bctbx_list_unlink(*ortp_pt_list, elem);
new_list = bctbx_list_append_link(new_list, elem);
}
}
*ortp_pt_list = bctbx_list_prepend_link(*ortp_pt_list, new_list);
}
bctbx_list_t *linphone_core_get_audio_payload_types(LinphoneCore *lc) {
return ortp_payloads_to_linphone_payloads(lc->codecs_conf.audio_codecs, lc);
}
void linphone_core_set_audio_payload_types(LinphoneCore *lc, const bctbx_list_t *payload_types) {
sort_ortp_pt_list(&lc->codecs_conf.audio_codecs, payload_types);
}
bctbx_list_t *linphone_core_get_video_payload_types(LinphoneCore *lc) {
return ortp_payloads_to_linphone_payloads(lc->codecs_conf.video_codecs, lc);
}
void linphone_core_set_video_payload_types(LinphoneCore *lc, const bctbx_list_t *payload_types) {
sort_ortp_pt_list(&lc->codecs_conf.video_codecs, payload_types);
}
bctbx_list_t *linphone_core_get_text_payload_types(LinphoneCore *lc) {
return ortp_payloads_to_linphone_payloads(lc->codecs_conf.text_codecs, lc);
}
void linphone_core_set_text_payload_types(LinphoneCore *lc, const bctbx_list_t *payload_types) {
sort_ortp_pt_list(&lc->codecs_conf.text_codecs, payload_types);
}
const bctbx_list_t *linphone_core_get_audio_codecs(const LinphoneCore *lc) {
return lc->codecs_conf.audio_codecs;
}
@ -4193,7 +4240,7 @@ void linphone_core_enable_echo_cancellation(LinphoneCore *lc, bool_t val){
lp_config_set_int(lc->config,"sound","echocancellation",val);
}
bool_t linphone_core_echo_cancellation_enabled(LinphoneCore *lc){
bool_t linphone_core_echo_cancellation_enabled(const LinphoneCore *lc){
return lc->sound_conf.ec;
}
@ -5616,7 +5663,7 @@ void _linphone_core_codec_config_write(LinphoneCore *lc){
lp_config_set_string(lc->config,key,"mime",pt->mime_type);
lp_config_set_int(lc->config,key,"rate",pt->clock_rate);
lp_config_set_int(lc->config,key,"channels",pt->channels);
lp_config_set_int(lc->config,key,"enabled",linphone_core_payload_type_enabled(lc,pt));
lp_config_set_int(lc->config,key,"enabled",payload_type_enabled(pt));
index++;
}
sprintf(key,"audio_codec_%i",index);
@ -5628,7 +5675,7 @@ void _linphone_core_codec_config_write(LinphoneCore *lc){
sprintf(key,"video_codec_%i",index);
lp_config_set_string(lc->config,key,"mime",pt->mime_type);
lp_config_set_int(lc->config,key,"rate",pt->clock_rate);
lp_config_set_int(lc->config,key,"enabled",linphone_core_payload_type_enabled(lc,pt));
lp_config_set_int(lc->config,key,"enabled",payload_type_enabled(pt));
lp_config_set_string(lc->config,key,"recv_fmtp",pt->recv_fmtp);
index++;
}
@ -6003,8 +6050,8 @@ bool_t linphone_core_get_ring_during_incoming_early_media(const LinphoneCore *lc
return (bool_t)lp_config_get_int(lc->config, "sound", "ring_during_incoming_early_media", 0);
}
LinphonePayloadType* linphone_core_find_payload_type(LinphoneCore* lc, const char* type, int rate, int channels) {
LinphonePayloadType* result = find_payload_type_from_list(type, rate, channels, linphone_core_get_audio_codecs(lc));
static OrtpPayloadType* _linphone_core_find_payload_type(LinphoneCore* lc, const char* type, int rate, int channels) {
OrtpPayloadType* result = find_payload_type_from_list(type, rate, channels, linphone_core_get_audio_codecs(lc));
if (result) {
return result;
} else {
@ -6022,6 +6069,15 @@ LinphonePayloadType* linphone_core_find_payload_type(LinphoneCore* lc, const cha
return NULL;
}
OrtpPayloadType* linphone_core_find_payload_type(LinphoneCore* lc, const char* type, int rate, int channels) {
return _linphone_core_find_payload_type(lc, type, rate, channels);
}
LinphonePayloadType *linphone_core_get_payload_type(LinphoneCore *lc, const char *type, int rate, int channels) {
OrtpPayloadType *pt = _linphone_core_find_payload_type(lc, type, rate, channels);
return pt ? linphone_payload_type_new(lc, pt) : NULL;
}
const char* linphone_configuring_state_to_string(LinphoneConfiguringState cs){
switch(cs){
case LinphoneConfiguringSuccessful:
@ -6444,22 +6500,6 @@ void linphone_core_set_avpf_rr_interval(LinphoneCore *lc, int interval){
lp_config_set_int(lc->config,"rtp","avpf_rr_interval",interval);
}
int linphone_payload_type_get_type(const LinphonePayloadType *pt) {
return pt->type;
}
int linphone_payload_type_get_normal_bitrate(const LinphonePayloadType *pt) {
return pt->normal_bitrate;
}
const char * linphone_payload_type_get_mime_type(const LinphonePayloadType *pt) {
return pt->mime_type;
}
int linphone_payload_type_get_channels(const LinphonePayloadType *pt) {
return pt->channels;
}
int linphone_core_set_audio_multicast_addr(LinphoneCore *lc, const char* ip) {
char* new_value;
if (ip && !ms_is_multicast(ip)) {

114
coreapi/misc.c
View file

@ -24,6 +24,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#include "mediastreamer2/mediastream.h"
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#ifdef HAVE_SIGHANDLER_T
#include <signal.h>
#endif /*HAVE_SIGHANDLER_T*/
@ -62,78 +63,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
static void clear_ice_check_list(LinphoneCall *call, IceCheckList *removed);
bool_t linphone_core_payload_type_enabled(LinphoneCore *lc, const LinphonePayloadType *pt){
if (bctbx_list_find(lc->codecs_conf.audio_codecs, (PayloadType*) pt) || bctbx_list_find(lc->codecs_conf.video_codecs, (PayloadType*)pt) || bctbx_list_find(lc->codecs_conf.text_codecs, (PayloadType*)pt)){
return payload_type_enabled(pt);
}
ms_error("Getting enablement status of codec not in audio or video list of PayloadType !");
return FALSE;
}
bool_t linphone_core_payload_type_is_vbr(LinphoneCore *lc, const LinphonePayloadType *pt) {
return linphone_payload_type_is_vbr(pt);
}
bool_t linphone_payload_type_is_vbr(const LinphonePayloadType *pt) {
if (pt->type == PAYLOAD_VIDEO) return TRUE;
return !!(pt->flags & PAYLOAD_TYPE_IS_VBR);
}
int linphone_core_enable_payload_type(LinphoneCore *lc, LinphonePayloadType *pt, bool_t enabled){
if (bctbx_list_find(lc->codecs_conf.audio_codecs,pt) || bctbx_list_find(lc->codecs_conf.video_codecs,pt) || bctbx_list_find(lc->codecs_conf.text_codecs,pt)){
payload_type_set_enable(pt,enabled);
_linphone_core_codec_config_write(lc);
linphone_core_update_allocated_audio_bandwidth(lc);
return 0;
}
ms_error("Enabling codec not in audio or video list of PayloadType !");
return -1;
}
int linphone_core_get_payload_type_number(LinphoneCore *lc, const PayloadType *pt) {
return linphone_payload_type_get_number(pt);
}
int linphone_payload_type_get_number(const LinphonePayloadType *pt) {
return payload_type_get_number(pt);
}
void linphone_core_set_payload_type_number(LinphoneCore *lc, PayloadType *pt, int number) {
linphone_payload_type_set_number(pt, number);
}
void linphone_payload_type_set_number(LinphonePayloadType *pt, int number) {
payload_type_set_number(pt, number);
}
const char *linphone_core_get_payload_type_description(LinphoneCore *lc, PayloadType *pt){
//if (ms_filter_codec_supported(pt->mime_type)){
if (ms_factory_codec_supported(lc->factory, pt->mime_type)){
MSFilterDesc *desc=ms_factory_get_encoder(lc->factory, pt->mime_type);
#ifdef ENABLE_NLS
return dgettext("mediastreamer",desc->text);
#else
return desc->text;
#endif
}
return NULL;
}
void linphone_core_set_payload_type_bitrate(LinphoneCore *lc, LinphonePayloadType *pt, int bitrate){
if (bctbx_list_find(lc->codecs_conf.audio_codecs, (PayloadType*) pt) || bctbx_list_find(lc->codecs_conf.video_codecs, (PayloadType*)pt) || bctbx_list_find(lc->codecs_conf.text_codecs, (PayloadType*)pt)){
if (pt->type==PAYLOAD_VIDEO || pt->flags & PAYLOAD_TYPE_IS_VBR){
pt->normal_bitrate=bitrate*1000;
pt->flags|=PAYLOAD_TYPE_BITRATE_OVERRIDE;
linphone_core_update_allocated_audio_bandwidth(lc);
}else{
ms_error("Cannot set an explicit bitrate for codec %s/%i, because it is not VBR.",pt->mime_type,pt->clock_rate);
return;
}
} else {
ms_error("linphone_core_set_payload_type_bitrate() payload type not in audio or video list !");
}
}
/*
*((codec-birate*ptime/8) + RTP header + UDP header + IP header)*8/ptime;
@ -184,8 +113,8 @@ static int lookup_vbr_typical_bitrate(int maxbw, int clock_rate){
return 32;
}
static int get_audio_payload_bandwidth(LinphoneCore *lc, const PayloadType *pt, int maxbw){
if (linphone_payload_type_is_vbr(pt)){
int get_audio_payload_bandwidth(const LinphoneCore *lc, const PayloadType *pt, int maxbw) {
if (payload_type_is_vbr(pt)) {
if (pt->flags & PAYLOAD_TYPE_BITRATE_OVERRIDE){
ms_debug("PayloadType %s/%i has bitrate override",pt->mime_type,pt->clock_rate);
return pt->normal_bitrate/1000;
@ -194,23 +123,6 @@ static int get_audio_payload_bandwidth(LinphoneCore *lc, const PayloadType *pt,
}else return (int)ceil(get_audio_payload_bandwidth_from_codec_bitrate(pt)/1000.0);/*rounding codec bandwidth should be avoid, specially for AMR*/
}
int linphone_core_get_payload_type_bitrate(LinphoneCore *lc, const LinphonePayloadType *pt){
int maxbw=get_min_bandwidth(linphone_core_get_download_bandwidth(lc),
linphone_core_get_upload_bandwidth(lc));
if (pt->type==PAYLOAD_AUDIO_CONTINUOUS || pt->type==PAYLOAD_AUDIO_PACKETIZED){
return get_audio_payload_bandwidth(lc,pt,maxbw);
}else if (pt->type==PAYLOAD_VIDEO){
int video_bw;
if (maxbw<=0) {
video_bw=1500; /*default bitrate for video stream when no bandwidth limit is set, around 1.5 Mbit/s*/
}else{
video_bw=get_remaining_bandwidth_for_video(maxbw,lc->audio_bw);
}
return video_bw;
}
return 0;
}
void linphone_core_update_allocated_audio_bandwidth_in_call(LinphoneCall *call, const PayloadType *pt, int maxbw){
call->audio_bw=get_audio_payload_bandwidth(call->core,pt,maxbw);
ms_message("Audio bandwidth for this call is %i",call->audio_bw);
@ -238,7 +150,7 @@ void linphone_core_update_allocated_audio_bandwidth(LinphoneCore *lc){
}
}
bool_t linphone_core_is_payload_type_usable_for_bandwidth(LinphoneCore *lc, const PayloadType *pt, int bandwidth_limit){
bool_t linphone_core_is_payload_type_usable_for_bandwidth(const LinphoneCore *lc, const PayloadType *pt, int bandwidth_limit){
double codec_band;
const int video_enablement_limit = 99;
bool_t ret=FALSE;
@ -263,24 +175,6 @@ bool_t linphone_core_is_payload_type_usable_for_bandwidth(LinphoneCore *lc, cons
return ret;
}
bool_t linphone_core_check_payload_type_usability(LinphoneCore *lc, const PayloadType *pt){
int maxbw=get_min_bandwidth(linphone_core_get_download_bandwidth(lc),
linphone_core_get_upload_bandwidth(lc));
bool_t ret=linphone_core_is_payload_type_usable_for_bandwidth(lc, pt, maxbw);
if ((pt->type==PAYLOAD_AUDIO_CONTINUOUS || pt->type==PAYLOAD_AUDIO_PACKETIZED)
&& lc->sound_conf.capt_sndcard
&& !(ms_snd_card_get_capabilities(lc->sound_conf.capt_sndcard) & MS_SND_CARD_CAP_BUILTIN_ECHO_CANCELLER)
&& linphone_core_echo_cancellation_enabled(lc)
&& (pt->clock_rate!=16000 && pt->clock_rate!=8000)
&& strcasecmp(pt->mime_type,"opus")!=0
&& ms_factory_lookup_filter_by_name(lc->factory, "MSWebRTCAEC")!=NULL){
ms_warning("Payload type %s/%i cannot be used because software echo cancellation is required but is unable to operate at this rate.",
pt->mime_type,pt->clock_rate);
ret=FALSE;
}
return ret;
}
bool_t lp_spawn_command_line_sync(const char *command, char **result,int *command_ret){
#if !defined(_WIN32_WCE) && !defined(LINPHONE_WINDOWS_UNIVERSAL)
FILE *f=popen(command,"r");

307
coreapi/payload_type.c Normal file
View file

@ -0,0 +1,307 @@
/*
payload_type.c
Copyright (C) 2017 Belledonne Communications SARL
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2
of the License, or (at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
#include <string.h>
#include <ortp/payloadtype.h>
#include "linphone/payload_type.h"
#include "private.h"
struct _LinphonePayloadType {
belle_sip_object_t base;
OrtpPayloadType *pt;
LinphoneCore *lc;
};
BELLE_SIP_DECLARE_NO_IMPLEMENTED_INTERFACES(LinphonePayloadType);
BELLE_SIP_DECLARE_VPTR(LinphonePayloadType);
LinphonePayloadType *linphone_payload_type_new(LinphoneCore *lc, OrtpPayloadType *ortp_pt) {
LinphonePayloadType *pt;
if (ortp_pt == NULL) return NULL;
pt = belle_sip_object_new(LinphonePayloadType);
pt->pt = ortp_pt;
pt->lc = lc;
return pt;
}
LinphonePayloadType *linphone_payload_type_ref(LinphonePayloadType *pt) {
return (LinphonePayloadType *)belle_sip_object_ref(pt);
}
void linphone_payload_type_unref(LinphonePayloadType *pt) {
belle_sip_object_unref(pt);
}
int linphone_payload_type_get_type(const LinphonePayloadType *pt) {
return pt->pt->type;
}
static bool_t _payload_type_is_in_core(const OrtpPayloadType *pt, const LinphoneCore *lc) {
return (bctbx_list_find(lc->codecs_conf.audio_codecs, pt) != NULL)
|| (bctbx_list_find(lc->codecs_conf.video_codecs, pt) != NULL)
|| (bctbx_list_find(lc->codecs_conf.text_codecs, pt) != NULL);
}
static char *_payload_type_get_description(const OrtpPayloadType *pt) {
return bctbx_strdup_printf("%s/%d/%d", pt->mime_type, pt->clock_rate, pt->channels);
}
static int _linphone_core_enable_payload_type(LinphoneCore *lc, OrtpPayloadType *pt, bool_t enabled) {
payload_type_set_enable(pt,enabled);
_linphone_core_codec_config_write(lc);
linphone_core_update_allocated_audio_bandwidth(lc);
return 0;
}
int linphone_core_enable_payload_type(LinphoneCore *lc, OrtpPayloadType *pt, bool_t enabled){
if (!_payload_type_is_in_core(pt, lc)) {
char *desc = _payload_type_get_description(pt);
ms_error("cannot enable '%s' payload type: not in the core", desc);
bctbx_free(desc);
return -1;
}
return _linphone_core_enable_payload_type(lc, pt, enabled);
}
int linphone_payload_type_enable(LinphonePayloadType *pt, bool_t enabled) {
if (pt->lc == NULL) {
char *desc = linphone_payload_type_get_description(pt);
ms_error("cannot enable '%s' payload type: no core associated", desc);
bctbx_free(desc);
return -1;
}
return _linphone_core_enable_payload_type(pt->lc, pt->pt, enabled);
}
bool_t linphone_core_payload_type_enabled(const LinphoneCore *lc, const OrtpPayloadType *pt){
return payload_type_enabled(pt);
}
bool_t linphone_payload_type_enabled(const LinphonePayloadType *pt) {
return payload_type_enabled(pt->pt);
}
char *linphone_payload_type_get_description(const LinphonePayloadType *pt) {
return _payload_type_get_description(pt->pt);
}
static const char *_linphone_core_get_payload_type_codec_description(const LinphoneCore *lc, const OrtpPayloadType *pt) {
if (ms_factory_codec_supported(lc->factory, pt->mime_type)){
MSFilterDesc *desc=ms_factory_get_encoder(lc->factory, pt->mime_type);
#ifdef ENABLE_NLS
return dgettext("mediastreamer",desc->text);
#else
return desc->text;
#endif
}
return NULL;
}
const char *linphone_core_get_payload_type_description(LinphoneCore *lc, const OrtpPayloadType *pt){
if (!_payload_type_is_in_core(pt, lc)) {
char *desc = _payload_type_get_description(pt);
ms_error("cannot get codec description for '%s' payload type: not in the core", desc);
bctbx_free(desc);
return NULL;
}
return _linphone_core_get_payload_type_codec_description(lc, pt);
}
const char *linphone_payload_type_get_encoder_description(const LinphonePayloadType *pt) {
if (pt->lc == NULL) {
char *desc = linphone_payload_type_get_description(pt);
ms_error("cannot get codec description for '%s' payload type: no associated core", desc);
bctbx_free(desc);
return NULL;
}
return _linphone_core_get_payload_type_codec_description(pt->lc, pt->pt);
}
static int _linphone_core_get_payload_type_normal_bitrate(const LinphoneCore *lc, const OrtpPayloadType *pt) {
int maxbw = get_min_bandwidth(linphone_core_get_download_bandwidth(lc),
linphone_core_get_upload_bandwidth(lc));
if (pt->type==PAYLOAD_AUDIO_CONTINUOUS || pt->type==PAYLOAD_AUDIO_PACKETIZED){
return get_audio_payload_bandwidth(lc, pt, maxbw);
}else if (pt->type==PAYLOAD_VIDEO){
int video_bw;
if (maxbw<=0) {
video_bw=1500; /*default bitrate for video stream when no bandwidth limit is set, around 1.5 Mbit/s*/
}else{
video_bw=get_remaining_bandwidth_for_video(maxbw,lc->audio_bw);
}
return video_bw;
}
return 0;
}
int linphone_core_get_payload_type_bitrate(LinphoneCore *lc, const OrtpPayloadType *pt){
if (_payload_type_is_in_core(pt, lc)) {
return _linphone_core_get_payload_type_normal_bitrate(lc, pt);
} else {
char *desc = _payload_type_get_description(pt);
ms_error("cannot get normal bitrate of payload type '%s': not in the core", desc);
bctbx_free(desc);
return -1;
}
}
int linphone_payload_type_get_normal_bitrate(const LinphonePayloadType *pt) {
if (pt->lc == NULL) {
char *desc = linphone_payload_type_get_description(pt);
ms_error("cannot get normal bitrate of codec '%s': no associated core", desc);
bctbx_free(desc);
return -1;
}
return _linphone_core_get_payload_type_normal_bitrate(pt->lc, pt->pt);
}
static void _linphone_core_set_payload_type_normal_bitrate(LinphoneCore *lc, OrtpPayloadType *pt, int bitrate) {
if (pt->type==PAYLOAD_VIDEO || pt->flags & PAYLOAD_TYPE_IS_VBR){
pt->normal_bitrate=bitrate*1000;
pt->flags|=PAYLOAD_TYPE_BITRATE_OVERRIDE;
linphone_core_update_allocated_audio_bandwidth(lc);
}else{
char *desc = _payload_type_get_description(pt);
ms_error("Cannot set an explicit bitrate for codec '%s', because it is not VBR.",desc);
bctbx_free(desc);
}
}
void linphone_core_set_payload_type_bitrate(LinphoneCore *lc, OrtpPayloadType *pt, int bitrate) {
if (_payload_type_is_in_core(pt, lc)) {
_linphone_core_set_payload_type_normal_bitrate(lc, pt, bitrate);
} else {
char *desc = _payload_type_get_description(pt);
ms_error("cannot set normal bitrate of codec '%s': not in the core", desc);
bctbx_free(desc);
}
}
void linphone_payload_type_set_normal_bitrate(LinphonePayloadType *pt, int bitrate) {
if (pt->lc == NULL) {
ms_error("cannot set bitrate of codec %s/%d: no associated core", pt->pt->mime_type, pt->pt->clock_rate);
return;
}
_linphone_core_set_payload_type_normal_bitrate(pt->lc, pt->pt, bitrate);
}
const char *linphone_payload_type_get_mime_type(const LinphonePayloadType *pt) {
return pt->pt->mime_type;
}
int linphone_payload_type_get_channels(const LinphonePayloadType *pt) {
return pt->pt->channels;
}
int linphone_core_get_payload_type_number(LinphoneCore *lc, const OrtpPayloadType *pt) {
return payload_type_get_number(pt);
}
int linphone_payload_type_get_number(const LinphonePayloadType *pt) {
return payload_type_get_number(pt->pt);
}
void linphone_core_set_payload_type_number(LinphoneCore *lc, OrtpPayloadType *pt, int number) {
payload_type_set_number(pt, number);
}
void linphone_payload_type_set_number(LinphonePayloadType *pt, int number) {
payload_type_set_number(pt->pt, number);
}
const char *linphone_payload_type_get_recv_fmtp(const LinphonePayloadType *pt) {
return pt->pt->recv_fmtp;
}
void linphone_payload_type_set_recv_fmtp(LinphonePayloadType *pt, const char *recv_fmtp) {
if (pt->pt->recv_fmtp != NULL) bctbx_free(pt->pt->recv_fmtp);
if (recv_fmtp != NULL) pt->pt->recv_fmtp = bctbx_strdup(recv_fmtp);
else recv_fmtp = NULL;
}
const char *linphone_payload_type_get_send_fmtp(const LinphonePayloadType *pt) {
return pt->pt->send_fmtp;
}
void linphone_payload_type_set_send_fmtp(LinphonePayloadType *pt, const char *send_fmtp) {
if (pt->pt->send_fmtp != NULL) bctbx_free(pt->pt->send_fmtp);
if (send_fmtp != NULL) pt->pt->recv_fmtp = bctbx_strdup(send_fmtp);
else send_fmtp = NULL;
}
int linphone_payload_type_get_clock_rate(const LinphonePayloadType *pt) {
return pt->pt->clock_rate;
}
bool_t linphone_core_payload_type_is_vbr(const LinphoneCore *lc, const OrtpPayloadType *pt) {
return payload_type_is_vbr(pt);
}
bool_t linphone_payload_type_is_vbr(const LinphonePayloadType *pt) {
return payload_type_is_vbr(pt->pt);
}
bool_t _linphone_core_check_payload_type_usability(const LinphoneCore *lc, const OrtpPayloadType *pt) {
int maxbw=get_min_bandwidth(linphone_core_get_download_bandwidth(lc),
linphone_core_get_upload_bandwidth(lc));
bool_t ret=linphone_core_is_payload_type_usable_for_bandwidth(lc, pt, maxbw);
if ((pt->type==PAYLOAD_AUDIO_CONTINUOUS || pt->type==PAYLOAD_AUDIO_PACKETIZED)
&& lc->sound_conf.capt_sndcard
&& !(ms_snd_card_get_capabilities(lc->sound_conf.capt_sndcard) & MS_SND_CARD_CAP_BUILTIN_ECHO_CANCELLER)
&& linphone_core_echo_cancellation_enabled(lc)
&& (pt->clock_rate!=16000 && pt->clock_rate!=8000)
&& strcasecmp(pt->mime_type,"opus")!=0
&& ms_factory_lookup_filter_by_name(lc->factory, "MSWebRTCAEC")!=NULL){
ms_warning("Payload type %s/%i cannot be used because software echo cancellation is required but is unable to operate at this rate.",
pt->mime_type,pt->clock_rate);
ret=FALSE;
}
return ret;
}
bool_t linphone_core_check_payload_type_usability(LinphoneCore *lc, const OrtpPayloadType *pt) {
if (!_payload_type_is_in_core(pt, lc)) {
char *desc = _payload_type_get_description(pt);
ms_error("cannot check usability of '%s' payload type: not in the core", desc);
bctbx_free(desc);
return FALSE;
}
return _linphone_core_check_payload_type_usability(lc, pt);
}
bool_t linphone_payload_type_is_usable(const LinphonePayloadType *pt) {
if (pt->lc == NULL) {
char *desc = linphone_payload_type_get_description(pt);
ms_error("cannot check usability of '%s' payload type: no associated core", desc);
bctbx_free(desc);
return FALSE;
}
return _linphone_core_check_payload_type_usability(pt->lc, pt->pt);
}
OrtpPayloadType *linphone_payload_type_get_ortp_pt(const LinphonePayloadType *pt) {
return pt->pt;
}
BELLE_SIP_INSTANCIATE_VPTR(LinphonePayloadType, belle_sip_object_t,
NULL, // uninit
NULL, // clone
NULL, // marshale
TRUE // unown
);

16
coreapi/private.h
View file

@ -1176,7 +1176,7 @@ void linphone_call_increment_local_media_description(LinphoneCall *call);
void linphone_call_fill_media_multicast_addr(LinphoneCall *call);
void linphone_call_update_streams(LinphoneCall *call, SalMediaDescription *new_md, LinphoneCallState target_state);
bool_t linphone_core_is_payload_type_usable_for_bandwidth(LinphoneCore *lc, const PayloadType *pt, int bandwidth_limit);
bool_t linphone_core_is_payload_type_usable_for_bandwidth(const LinphoneCore *lc, const PayloadType *pt, int bandwidth_limit);
#define linphone_core_ready(lc) ((lc)->state==LinphoneGlobalOn || (lc)->state==LinphoneGlobalShutdown)
void _linphone_core_configure_resolver(void);
@ -1667,17 +1667,22 @@ char * linphone_timestamp_to_rfc3339_string(time_t timestamp);
void linphone_error_info_from_sal_op(LinphoneErrorInfo *ei, const SalOp *op);
static MS2_INLINE void payload_type_set_enable(PayloadType *pt,int value)
static MS2_INLINE void payload_type_set_enable(OrtpPayloadType *pt,int value)
{
if ((value)!=0) payload_type_set_flag(pt,PAYLOAD_TYPE_ENABLED); \
else payload_type_unset_flag(pt,PAYLOAD_TYPE_ENABLED);
}
static MS2_INLINE bool_t payload_type_enabled(const PayloadType *pt) {
static MS2_INLINE bool_t payload_type_enabled(const OrtpPayloadType *pt) {
return (((pt)->flags & PAYLOAD_TYPE_ENABLED)!=0);
}
bool_t is_payload_type_number_available(const MSList *l, int number, const PayloadType *ignore);
bool_t is_payload_type_number_available(const MSList *l, int number, const OrtpPayloadType *ignore);
int get_audio_payload_bandwidth(const LinphoneCore *lc, const PayloadType *pt, int maxbw);
LinphonePayloadType *linphone_payload_type_new(LinphoneCore *lc, OrtpPayloadType *ortp_pt);
bool_t _linphone_core_check_payload_type_usability(const LinphoneCore *lc, const OrtpPayloadType *pt);
OrtpPayloadType *linphone_payload_type_get_ortp_pt(const LinphonePayloadType *pt);
const MSCryptoSuite * linphone_core_get_srtp_crypto_suites(LinphoneCore *lc);
MsZrtpCryptoTypesCount linphone_core_get_zrtp_key_agreement_suites(LinphoneCore *lc, MSZrtpKeyAgreement keyAgreements[MS_MAX_ZRTP_CRYPTO_TYPES]);
@ -1759,7 +1764,8 @@ BELLE_SIP_TYPE_ID(LinphonePresenceNote),
BELLE_SIP_TYPE_ID(LinphoneErrorInfo),
BELLE_SIP_TYPE_ID(LinphoneConferenceParams),
BELLE_SIP_TYPE_ID(LinphoneConference),
BELLE_SIP_TYPE_ID(LinphoneInfoMessage)
BELLE_SIP_TYPE_ID(LinphoneInfoMessage),
BELLE_SIP_TYPE_ID(LinphonePayloadType)
BELLE_SIP_DECLARE_TYPES_END

6
coreapi/quality_reporting.c
View file

@ -539,15 +539,15 @@ void linphone_reporting_update_media_info(LinphoneCall * call, int stats_type) {
/*yet we use the same payload config for local and remote, since this is the largest use case*/
if (stats_type == LINPHONE_CALL_STATS_AUDIO && call->audiostream != NULL) {
stream = &call->audiostream->ms;
local_payload = linphone_call_params_get_used_audio_codec(current_params);
local_payload = current_params->audio_codec;
remote_payload = local_payload;
} else if (stats_type == LINPHONE_CALL_STATS_VIDEO && call->videostream != NULL) {
stream = &call->videostream->ms;
local_payload = linphone_call_params_get_used_video_codec(current_params);
local_payload = current_params->video_codec;
remote_payload = local_payload;
} else if (stats_type == LINPHONE_CALL_STATS_TEXT && call->textstream != NULL) {
stream = &call->textstream->ms;
local_payload = linphone_call_params_get_used_text_codec(current_params);
local_payload = current_params->text_codec;
remote_payload = local_payload;
}

4
daemon/commands/audio-codec-set.cc
View file

@ -71,7 +71,7 @@ static PayloadType *findPayload(LinphoneCore *lc, int payload_type, int *index){
for (const bctbx_list_t *node = linphone_core_get_audio_codecs(lc); node != NULL; node = bctbx_list_next(node)) {
PayloadType *payload = reinterpret_cast<PayloadType*>(node->data);
if (index) (*index)++;
if (payload_type == linphone_payload_type_get_number(payload)) {
if (payload_type == payload_type_get_number(payload)) {
return payload;
}
}
@ -127,7 +127,7 @@ void AudioCodecSetCommand::exec(Daemon *app, const string& args) {
if (conflict) {
app->sendResponse(Response("New payload type number is already used.", Response::Error));
} else {
linphone_payload_type_set_number(payload, idx);
payload_type_set_number(payload, idx);
app->sendResponse(PayloadTypeResponse(app->getCore(), payload, parser.getPosition()));
}
return;

2
daemon/commands/audio-stream-start.cc
View file

@ -33,7 +33,7 @@ static PayloadType *getPayloadType(LinphoneCore *lc, const MSList *codecs, int n
const MSList *elem;
for (elem = codecs; elem != NULL; elem = elem->next) {
PayloadType *pt = (PayloadType*)elem->data;
if (linphone_payload_type_get_number(pt) == number)
if (payload_type_get_number(pt) == number)
return pt;
}
return NULL;

4
daemon/daemon.cc
View file

@ -219,7 +219,7 @@ PayloadTypeResponse::PayloadTypeResponse(LinphoneCore *core, const PayloadType *
if (payloadType != NULL) {
if (index >= 0)
ostr << prefix << "Index: " << index << "\n";
ostr << prefix << "Payload-type-number: " << linphone_payload_type_get_number(payloadType) << "\n";
ostr << prefix << "Payload-type-number: " << payload_type_get_number(payloadType) << "\n";
ostr << prefix << "Clock-rate: " << payloadType->clock_rate << "\n";
ostr << prefix << "Bitrate: " << payloadType->normal_bitrate << "\n";
ostr << prefix << "Mime: " << payloadType->mime_type << "\n";
@ -252,7 +252,7 @@ PayloadTypeParser::PayloadTypeParser(LinphoneCore *core, const string &mime_type
}else if (number!=-1){
const bctbx_list_t *elem;
for(elem=linphone_core_get_audio_codecs(core);elem!=NULL;elem=elem->next){
if (number==linphone_payload_type_get_number((PayloadType*)elem->data)){
if (number==payload_type_get_number((PayloadType*)elem->data)){
mPayloadType=(PayloadType*)elem->data;
break;
}

4
gtk/propertybox.c
View file

@ -647,7 +647,7 @@ static void linphone_gtk_init_codec_list(GtkTreeView *listview){
}
const char *get_codec_color(LinphoneCore *lc, PayloadType *pt){
const char *get_codec_color(LinphoneCore *lc, OrtpPayloadType *pt){
const gchar *color;
if (linphone_core_check_payload_type_usability(lc,pt)) color="blue";
else color="red";
@ -673,7 +673,7 @@ static void linphone_gtk_show_codecs(GtkTreeView *listview, const bctbx_list_t *
const gchar *color;
const char *params="";
struct _PayloadType *pt=(struct _PayloadType *)elem->data;
OrtpPayloadType *pt=(OrtpPayloadType *)elem->data;
color=get_codec_color(linphone_gtk_get_core(),pt);
if (linphone_core_payload_type_enabled(linphone_gtk_get_core(),pt)) status=_("Enabled");

55
include/linphone/call_params.h
View file

@ -23,6 +23,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#include "linphone/types.h"
#include "linphone/payload_type.h"
#ifdef __cplusplus
@ -175,25 +176,55 @@ LINPHONE_PUBLIC MSVideoSize linphone_call_params_get_sent_video_size(const Linph
LINPHONE_PUBLIC const char *linphone_call_params_get_session_name(const LinphoneCallParams *cp);
/**
* Get the audio codec used in the call, described as a LinphonePayloadType object.
* @param[in] cp LinphoneCallParams object
* @return The LinphonePayloadType object corresponding to the audio codec being used in the call.
* Get the audio payload type that has been selected by a call.
* @param[in] cp The call.
* @return The selected payload type. NULL is returned if no audio payload type has been seleced
* by the call. If a payload type is returned, it must be released with linphone_payload_type_unref() after use.
**/
LINPHONE_PUBLIC const LinphonePayloadType* linphone_call_params_get_used_audio_codec(const LinphoneCallParams *cp);
LINPHONE_PUBLIC LinphonePayloadType *linphone_call_params_get_used_audio_payload_type(const LinphoneCallParams *cp);
/**
* Get the video codec used in the call, described as a LinphonePayloadType structure.
* @param[in] cp LinphoneCallParams object
* @return The LinphonePayloadType object corresponding to the video codec being used in the call.
* Get the video payload type that has been selected by a call.
* @param[in] cp The call.
* @return The selected payload type. NULL is returned if no video payload type has been seleced
* by the call. If a payload type is returned, it must be released with linphone_payload_type_unref() after use.
**/
LINPHONE_PUBLIC const LinphonePayloadType* linphone_call_params_get_used_video_codec(const LinphoneCallParams *cp);
LINPHONE_PUBLIC LinphonePayloadType *linphone_call_params_get_used_video_payload_type(const LinphoneCallParams *cp);
/**
* Get the text codec used in the call, described as a LinphonePayloadType structure.
* @param[in] cp LinphoneCallParams object
* @return The LinphonePayloadType object corresponding to the text codec being used in the call.
* Get the text payload type that has been selected by a call.
* @param[in] cp The call.
* @return The selected payload type. NULL is returned if no text payload type has been seleced
* by the call. If a payload type is returned, it must be released with linphone_payload_type_unref() after use.
**/
LINPHONE_PUBLIC const LinphonePayloadType* linphone_call_params_get_used_text_codec(const LinphoneCallParams *cp);
LINPHONE_PUBLIC LinphonePayloadType *linphone_call_params_get_used_text_payload_type(const LinphoneCallParams *cp);
/**
* Get the audio payload type that has been selected by a call.
* @param[in] cp The call.
* @return The selected payload type. NULL is returned if no audio payload type has been seleced by the call.
* @deprecated Use linphone_call_params_get_used_audio_payload_type() instead.
* @donotwrap
**/
LINPHONE_PUBLIC LINPHONE_DEPRECATED const OrtpPayloadType *linphone_call_params_get_used_audio_codec(const LinphoneCallParams *cp);
/**
* Get the video payload type that has been selected by a call.
* @param[in] cp The call.
* @return The selected payload type. NULL is returned if no video payload type has been seleced by the call.
* @deprecated Use linphone_call_params_get_used_video_payload_type() instead.
* @donotwrap
**/
LINPHONE_PUBLIC LINPHONE_DEPRECATED const OrtpPayloadType *linphone_call_params_get_used_video_codec(const LinphoneCallParams *cp);
/**
* Get the text payload type that has been selected by a call.
* @param[in] cp The call.
* @return The selected payload type. NULL is returned if no text payload type has been seleced by the call.
* @deprecated Use linphone_call_params_get_used_text_payload_type() instead.
* @donotwrap
**/
LINPHONE_PUBLIC LINPHONE_DEPRECATED const OrtpPayloadType *linphone_call_params_get_used_text_codec(const LinphoneCallParams *cp);
/**
* Tell whether the call has been configured in low bandwidth mode or not.

157
include/linphone/core.h
View file

@ -1570,67 +1570,131 @@ LINPHONE_PUBLIC bool_t linphone_core_dns_search_enabled(const LinphoneCore *lc);
*/
LINPHONE_PUBLIC void linphone_core_set_dns_servers(LinphoneCore *lc, const bctbx_list_t *servers);
/**
* Return the list of the available audio payload types.
* @param[in] lc The core.
* @return \bctbx_list{LinphonePayloadType} A freshly allocated list of the available payload types. It must be released
* with bctbx_list_free_with_data() calling linphone_payload_type_unref() on each element.
* @ingroup media_parameters
*/
LINPHONE_PUBLIC bctbx_list_t *linphone_core_get_audio_payload_types(LinphoneCore *lc);
/**
* Redefine the list of the available payload types.
* @param[in] lc The core.
* @param[in] payload_types \bctbx_list{LinphonePayloadType} The new list of payload types. The core does not take
* ownership on it.
* @ingroup media_paremeters
*/
LINPHONE_PUBLIC void linphone_core_set_audio_payload_types(LinphoneCore *lc, const bctbx_list_t *payload_types);
/**
* Returns the list of available audio codecs.
* @param[in] lc The LinphoneCore object
* @return \bctbx_list{LinphonePayloadType}
* @return \bctbx_list{OrtpPayloadType}
*
* This list is unmodifiable. The ->data field of the bctbx_list_t points a PayloadType
* structure holding the codec information.
* It is possible to make copy of the list with bctbx_list_copy() in order to modify it
* (such as the order of codecs).
* @ingroup media_parameters
* @deprecated Use linphone_core_get_audio_payload_types() instead.
* @donotwrap
**/
LINPHONE_PUBLIC const bctbx_list_t *linphone_core_get_audio_codecs(const LinphoneCore *lc);
LINPHONE_PUBLIC LINPHONE_DEPRECATED const bctbx_list_t *linphone_core_get_audio_codecs(const LinphoneCore *lc);
/**
* Sets the list of audio codecs.
* @param[in] lc The LinphoneCore object
* @param[in] codecs \bctbx_list{LinphonePayloadType}
* @param[in] codecs \bctbx_list{OrtpPayloadType}
* @return 0
* The list is taken by the LinphoneCore thus the application should not free it.
* This list is made of struct PayloadType describing the codec parameters.
* @ingroup media_parameters
* @deprecated Use linphone_core_set_audio_payload_types() instead.
* @donotwrap
**/
LINPHONE_PUBLIC int linphone_core_set_audio_codecs(LinphoneCore *lc, bctbx_list_t *codecs);
LINPHONE_PUBLIC LINPHONE_DEPRECATED int linphone_core_set_audio_codecs(LinphoneCore *lc, bctbx_list_t *codecs);
/**
* Return the list of the available video payload types.
* @param[in] lc The core.
* @return \bctbx_list{LinphonePayloadType} A freshly allocated list of the available payload types. It must be released
* with bctbx_list_free_with_data() calling linphone_payload_type_unref() on each element.
* @ingroup media_parameters
*/
LINPHONE_PUBLIC bctbx_list_t *linphone_core_get_video_payload_types(LinphoneCore *lc);
/**
* Redefine the list of the available video payload types.
* @param[in] lc The core.
* @param[in] payload_types \bctbx_list{LinphonePayloadType} The new list of codecs. The core does not take
* ownership on it.
* @ingroup media_parameters
*/
LINPHONE_PUBLIC void linphone_core_set_video_payload_types(LinphoneCore *lc, const bctbx_list_t *payload_types);
/**
* Returns the list of available video codecs.
* @param[in] lc The LinphoneCore object
* @return \bctbx_list{LinphonePayloadType}
* @return \bctbx_list{OrtpPayloadType}
*
* This list is unmodifiable. The ->data field of the bctbx_list_t points a PayloadType
* structure holding the codec information.
* It is possible to make copy of the list with bctbx_list_copy() in order to modify it
* (such as the order of codecs).
* @ingroup media_parameters
* @deprecated Use linphone_core_get_video_payload_types() instead.
* @donotwrap
**/
LINPHONE_PUBLIC const bctbx_list_t *linphone_core_get_video_codecs(const LinphoneCore *lc);
LINPHONE_PUBLIC LINPHONE_DEPRECATED const bctbx_list_t *linphone_core_get_video_codecs(const LinphoneCore *lc);
/**
* Sets the list of video codecs.
* @param[in] lc The LinphoneCore object
* @param[in] codecs \bctbx_list{LinphonePayloadType}
* @param[in] codecs \bctbx_list{OrtpPayloadType}
* @return 0
*
* The list is taken by the LinphoneCore thus the application should not free it.
* This list is made of struct PayloadType describing the codec parameters.
* @ingroup media_parameters
* @deprecated Use linphone_core_set_video_payload_types() instead.
* @donotwrap
**/
LINPHONE_PUBLIC int linphone_core_set_video_codecs(LinphoneCore *lc, bctbx_list_t *codecs);
LINPHONE_PUBLIC LINPHONE_DEPRECATED int linphone_core_set_video_codecs(LinphoneCore *lc, bctbx_list_t *codecs);
/**
* Return the list of the available text payload types.
* @param[in] lc The core.
* @return \bctbx_list{LinphonePayloadType} A freshly allocated list of the available payload types. It must be released
* with bctbx_list_free_with_data() calling linphone_payload_type_unref() on each element.
* @ingroup media_parameters
*/
LINPHONE_PUBLIC bctbx_list_t *linphone_core_get_text_payload_types(LinphoneCore *lc);
/**
* Redefine the list of the available payload types.
* @param[in] lc The core.
* @param[in] payload_types \bctbx_list{LinphonePayloadType} The new list of payload types. The core does not take
* ownership on it.
* @ingroup media_parameters
*/
LINPHONE_PUBLIC void linphone_core_set_text_payload_types(LinphoneCore *lc, const bctbx_list_t *payload_types);
/**
* Returns the list of available text codecs.
* @param[in] lc The LinphoneCore object
* @return \bctbx_list{LinphonePayloadType}
* @return \bctbx_list{OrtpPayloadType}
*
* This list is unmodifiable. The ->data field of the bctbx_list_t points a PayloadType
* structure holding the codec information.
* It is possible to make copy of the list with bctbx_list_copy() in order to modify it
* (such as the order of codecs).
* @ingroup media_parameters
* @deprecated Use linphone_core_get_text_payload_types() instead.
* @donotwrap
**/
LINPHONE_PUBLIC const bctbx_list_t *linphone_core_get_text_codecs(const LinphoneCore *lc);
LINPHONE_PUBLIC LINPHONE_DEPRECATED const bctbx_list_t *linphone_core_get_text_codecs(const LinphoneCore *lc);
/**
* Sets the list of text codecs.
@ -1641,8 +1705,10 @@ LINPHONE_PUBLIC const bctbx_list_t *linphone_core_get_text_codecs(const Linphone
* The list is taken by the LinphoneCore thus the application should not free it.
* This list is made of struct PayloadType describing the codec parameters.
* @ingroup media_parameters
* @deprecated Use linphone_core_set_text_payload_types() instead.
* @donotwrap
**/
LINPHONE_PUBLIC int linphone_core_set_text_codecs(LinphoneCore *lc, bctbx_list_t *codecs);
LINPHONE_PUBLIC LINPHONE_DEPRECATED int linphone_core_set_text_codecs(LinphoneCore *lc, bctbx_list_t *codecs);
/**
* Enable RFC3389 generic comfort noise algorithm (CN payload type).
@ -1679,50 +1745,58 @@ LINPHONE_PUBLIC bool_t linphone_core_generic_comfort_noise_enabled(const Linphon
/**
* Tells whether the specified payload type is enabled.
* @param[in] lc #LinphoneCore object.
* @param[in] pt The #LinphonePayloadType we want to know is enabled or not.
* @param[in] pt The payload type to check.
* @return TRUE if the payload type is enabled, FALSE if disabled.
* @ingroup media_parameters
* @deprecated Use linphone_payload_type_enabled() instead.
* @donotwrap
*/
LINPHONE_PUBLIC bool_t linphone_core_payload_type_enabled(LinphoneCore *lc, const LinphonePayloadType *pt);
LINPHONE_PUBLIC LINPHONE_DEPRECATED bool_t linphone_core_payload_type_enabled(const LinphoneCore *lc, const OrtpPayloadType *pt);
/**
* Tells whether the specified payload type represents a variable bitrate codec.
* @param[in] lc #LinphoneCore object.
* @param[in] pt The #LinphonePayloadType we want to know
* @param[in] pt The payload type to check.
* @return TRUE if the payload type represents a VBR codec, FALSE if disabled.
* @ingroup media_parameters
* @deprecated Use linphone_payload_type_is_vbr() instead
* @deprecated Use linphone_payload_type_is_vbr() instead.
* @donotwrap
*/
LINPHONE_PUBLIC LINPHONE_DEPRECATED bool_t linphone_core_payload_type_is_vbr(LinphoneCore *lc, const LinphonePayloadType *pt);
LINPHONE_PUBLIC LINPHONE_DEPRECATED bool_t linphone_core_payload_type_is_vbr(const LinphoneCore *lc, const OrtpPayloadType *pt);
/**
* Set an explicit bitrate (IP bitrate, not codec bitrate) for a given codec, in kbit/s.
* @param[in] lc the #LinphoneCore object
* @param[in] pt the #LinphonePayloadType to modify.
* @param[in] pt the payload type to modify.
* @param[in] bitrate the IP bitrate in kbit/s.
* @ingroup media_parameters
* @deprecated Use linphone_payload_type_set_normal_bitrate() instead.
* @donotwrap
**/
LINPHONE_PUBLIC void linphone_core_set_payload_type_bitrate(LinphoneCore *lc, LinphonePayloadType *pt, int bitrate);
LINPHONE_PUBLIC LINPHONE_DEPRECATED void linphone_core_set_payload_type_bitrate(LinphoneCore *lc, OrtpPayloadType *pt, int bitrate);
/**
* Get the bitrate explicitely set with linphone_core_set_payload_type_bitrate().
* @param[in] lc the #LinphoneCore object
* @param[in] pt the #LinphonePayloadType to modify.
* @param[in] pt the payload type to modify.
* @return bitrate the IP bitrate in kbit/s, or -1 if an error occured.
* @ingroup media_parameters
* @deprecated Use linphone_payload_type_get_bitrate().
* @donotwrap
**/
LINPHONE_PUBLIC int linphone_core_get_payload_type_bitrate(LinphoneCore *lc, const LinphonePayloadType *pt);
LINPHONE_PUBLIC LINPHONE_DEPRECATED int linphone_core_get_payload_type_bitrate(LinphoneCore *lc, const OrtpPayloadType *pt);
/**
* Enable or disable the use of the specified payload type.
* @param[in] lc #LinphoneCore object.
* @param[in] pt The #LinphonePayloadType to enable or disable. It can be retrieved using #linphone_core_find_payload_type
* @param[in] pt The payload type to enable or disable. It can be retrieved using #linphone_core_find_payload_type
* @param[in] enable TRUE to enable the payload type, FALSE to disable it.
* @return 0 if successful, any other value otherwise.
* @ingroup media_parameters
* @deprecated Use linphone_payload_type_enable().
* @donotwrap
*/
LINPHONE_PUBLIC int linphone_core_enable_payload_type(LinphoneCore *lc, LinphonePayloadType *pt, bool_t enable);
LINPHONE_PUBLIC LINPHONE_DEPRECATED int linphone_core_enable_payload_type(LinphoneCore *lc, OrtpPayloadType *pt, bool_t enable);
/**
* Wildcard value used by #linphone_core_find_payload_type to ignore rate in search algorithm
@ -1737,7 +1811,7 @@ LINPHONE_PUBLIC int linphone_core_enable_payload_type(LinphoneCore *lc, Linphone
#define LINPHONE_FIND_PAYLOAD_IGNORE_CHANNELS -1
/**
* Get payload type from mime type and clock rate
* Get payload type from mime type and clock rate.
* @ingroup media_parameters
* This function searches in audio and video codecs for the given payload type name and clockrate.
* @param lc #LinphoneCore object
@ -1745,8 +1819,23 @@ LINPHONE_PUBLIC int linphone_core_enable_payload_type(LinphoneCore *lc, Linphone
* @param rate can be #LINPHONE_FIND_PAYLOAD_IGNORE_RATE
* @param channels number of channels, can be #LINPHONE_FIND_PAYLOAD_IGNORE_CHANNELS
* @return Returns NULL if not found.
* @deprecated Use linphone_core_get_payload_type() instead.
* @donotwrap
*/
LINPHONE_PUBLIC LinphonePayloadType* linphone_core_find_payload_type(LinphoneCore* lc, const char* type, int rate, int channels);
LINPHONE_PUBLIC LINPHONE_DEPRECATED OrtpPayloadType *linphone_core_find_payload_type(LinphoneCore* lc, const char* type, int rate, int channels);
/**
* Get payload type from mime type and clock rate.
* @ingroup media_parameters
* This function searches in audio and video codecs for the given payload type name and clockrate.
* @param lc #LinphoneCore object
* @param type payload mime type (I.E SPEEX, PCMU, VP8)
* @param rate can be #LINPHONE_FIND_PAYLOAD_IGNORE_RATE
* @param channels number of channels, can be #LINPHONE_FIND_PAYLOAD_IGNORE_CHANNELS
* @return Returns NULL if not found. If a #LinphonePayloadType is returned, it must be released with
* linphone_payload_type_unref() after using it.
*/
LINPHONE_PUBLIC LinphonePayloadType *linphone_core_get_payload_type(LinphoneCore *lc, const char *type, int rate, int channels);
/**
* Returns the payload type number assigned for this codec.
@ -1754,7 +1843,7 @@ LINPHONE_PUBLIC LinphonePayloadType* linphone_core_find_payload_type(LinphoneCor
* @deprecated Use linphone_payload_type_get_number() instead
* @donotwrap
**/
LINPHONE_PUBLIC LINPHONE_DEPRECATED int linphone_core_get_payload_type_number(LinphoneCore *lc, const PayloadType *pt);
LINPHONE_PUBLIC LINPHONE_DEPRECATED int linphone_core_get_payload_type_number(LinphoneCore *lc, const OrtpPayloadType *pt);
/**
* Force a number for a payload type. The LinphoneCore does payload type number assignment automatically. THis function is to be used mainly for tests, in order
@ -1763,15 +1852,25 @@ LINPHONE_PUBLIC LINPHONE_DEPRECATED int linphone_core_get_payload_type_number(Li
* @deprecated Use linphone_payload_type_set_number() instead
* @donotwrap
**/
LINPHONE_PUBLIC LINPHONE_DEPRECATED void linphone_core_set_payload_type_number(LinphoneCore *lc, PayloadType *pt, int number);
LINPHONE_PUBLIC LINPHONE_DEPRECATED void linphone_core_set_payload_type_number(LinphoneCore *lc, OrtpPayloadType *pt, int number);
LINPHONE_PUBLIC const char *linphone_core_get_payload_type_description(LinphoneCore *lc, PayloadType *pt);
/**
* Get a description of the encoder used to supply a payload type.
* @param[in] lc The core.
* @param[in] pt The payload type.
* @return The description of the encoder. Can be NULL if the format is not supported by Mediastreamer2.
* @deprecated Use linphone_payload_type_get_encoder_description() instead.
* @donotwrap
*/
LINPHONE_PUBLIC LINPHONE_DEPRECATED const char *linphone_core_get_payload_type_description(LinphoneCore *lc, const OrtpPayloadType *pt);
/**
* Return TRUE if codec can be used with bandwidth, FALSE else
* @ingroup media_parameters
* @deprecated Use linphone_payload_type_is_usable() instead.
* @donotwrap
*/
LINPHONE_PUBLIC bool_t linphone_core_check_payload_type_usability(LinphoneCore *lc, const PayloadType *pt);
LINPHONE_PUBLIC LINPHONE_DEPRECATED bool_t linphone_core_check_payload_type_usability(LinphoneCore *lc, const OrtpPayloadType *pt);
/**
* @addtogroup proxies
@ -2729,7 +2828,7 @@ LINPHONE_PUBLIC void linphone_core_enable_echo_cancellation(LinphoneCore *lc, bo
* @return A boolean value telling whether echo cancellation is enabled or disabled
* @ingroup media_parameters
**/
LINPHONE_PUBLIC bool_t linphone_core_echo_cancellation_enabled(LinphoneCore *lc);
LINPHONE_PUBLIC bool_t linphone_core_echo_cancellation_enabled(const LinphoneCore *lc);
/**
* Enables or disable echo limiter.

134
include/linphone/payload_type.h
View file

@ -20,77 +20,163 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#ifndef LINPHONE_PAYLOAD_TYPE_H_
#define LINPHONE_PAYLOAD_TYPE_H_
#include "linphone/types.h"
#ifdef __cplusplus
extern "C" {
#endif
/**
* @addtogroup media_parameters
* @{
**/
#ifdef __cplusplus
extern "C" {
#endif
/**
* Get the type of payload.
* @param[in] pt LinphonePayloadType object
* @return The type of payload.
* Take a reference on a #LinphonePayloadType.
*/
LINPHONE_PUBLIC LinphonePayloadType *linphone_payload_type_ref(LinphonePayloadType *pt);
/**
* Release a reference on a #LinphonePayloadType.
*/
LINPHONE_PUBLIC void linphone_payload_type_unref(LinphonePayloadType *pt);
/**
* Get the type of a payload type.
* @param[in] pt The payload type.
* @return The type of the payload e.g. PAYLOAD_AUDIO_CONTINUOUS or PAYLOAD_VIDEO.
*/
LINPHONE_PUBLIC int linphone_payload_type_get_type(const LinphonePayloadType *pt);
/**
* Enable/disable a payload type.
* @param[in] pt The payload type to enable/disable.
* @param[in] enabled Set TRUE for enabling and FALSE for disabling.
* @return 0 for success, -1 for failure.
*/
LINPHONE_PUBLIC int linphone_payload_type_enable(LinphonePayloadType *pt, bool_t enabled);
/**
* Check whether a palyoad type is enabled.
* @return TRUE if enabled, FALSE if disabled.
*/
LINPHONE_PUBLIC bool_t linphone_payload_type_enabled(const LinphonePayloadType *pt);
/**
* Return a string describing a payload type. The format of the string is
* &lt;mime_type&gt;/&lt;clock_rate&gt;/&lt;channels&gt;.
* @param[in] pt The payload type.
* @return The description of the payload type. Must be release after use.
*/
LINPHONE_PUBLIC char *linphone_payload_type_get_description(const LinphonePayloadType *pt);
/**
* Get a description of the encoder used to provide a payload type.
* @param[in] pt The payload type.
* @return The description of the encoder. Can be NULL if the payload type is not supported by Mediastreamer2.
*/
LINPHONE_PUBLIC const char *linphone_payload_type_get_encoder_description(const LinphonePayloadType *pt);
/**
* Get the normal bitrate in bits/s.
* @param[in] pt LinphonePayloadType object
* @return The normal bitrate in bits/s.
* @param[in] pt The payload type.
* @return The normal bitrate in bits/s or -1 if an error has occured.
*/
LINPHONE_PUBLIC int linphone_payload_type_get_normal_bitrate(const LinphonePayloadType *pt);
/**
* Change the normal bitrate of a payload type..
* @param[in] pt The payload type to change.
* @param[in] bitrate The new bitrate in bits/s.
*/
LINPHONE_PUBLIC void linphone_payload_type_set_normal_bitrate(LinphonePayloadType *pt, int bitrate);
/**
* Get the mime type.
* @param[in] pt LinphonePayloadType object
* @param[in] pt The payload type.
* @return The mime type.
*/
LINPHONE_PUBLIC const char * linphone_payload_type_get_mime_type(const LinphonePayloadType *pt);
/**
* Get the number of channels.
* @param[in] pt LinphonePayloadType object
* @param[in] pt The payload type.
* @return The number of channels.
*/
LINPHONE_PUBLIC int linphone_payload_type_get_channels(const LinphonePayloadType *pt);
/**
* Returns the payload type number assigned for this codec.
* @param[in] pt LinphonePayloadType object
* @return The number of the payload type
* @param[in] pt The payload type.
* @return The number of the payload type.
**/
LINPHONE_PUBLIC int linphone_payload_type_get_number(const LinphonePayloadType *pt);
/**
* Force a number for a payload type. The LinphoneCore does payload type number assignment automatically. THis function is to be used mainly for tests, in order
* to override the automatic assignment mechanism.
* @param[in] pt LinphonePayloadType object
* @param[in] number The number to assign to the payload type
* Force a number for a payload type. The LinphoneCore does payload type number assignment automatically.
* This function is mainly to be used for tests, in order to override the automatic assignment mechanism.
* @param[in] pt The payload type.
* @param[in] number The number to assign to the payload type.
**/
LINPHONE_PUBLIC void linphone_payload_type_set_number(LinphonePayloadType *pt, int number);
/**
* Get the format parameters for incoming streams.
* @param[in] pt The payload type.
* @return The format parameters as string.
*/
LINPHONE_PUBLIC const char *linphone_payload_type_get_recv_fmtp(const LinphonePayloadType *pt);
/**
* Set the format parameters for incoming streams.
* @param[in] pt The payload type.
* @param[in] recv_fmtp The new format parameters as string. The string will be copied.
*/
LINPHONE_PUBLIC void linphone_payload_type_set_recv_fmtp(LinphonePayloadType *pt, const char *recv_fmtp);
/**
* Get the format parameters for outgoing streams.
* @param[in] pt The payload type.
* @return The format parameters as string.
*/
LINPHONE_PUBLIC const char *linphone_payload_type_get_send_fmtp(const LinphonePayloadType *pt);
/**
* Set the format parameters for outgoing streams.
* @param[in] pt The payload type.
* @param[in] send_fmtp The new format parameters as string. The string will be copied.
*/
LINPHONE_PUBLIC void linphone_payload_type_set_send_fmtp(LinphonePayloadType *pt, const char *send_fmtp);
/**
* Get the clock rate of a payload type.
* @param[in] pt The payload type.
* @return[in] The clock rate in Hz.
*/
LINPHONE_PUBLIC int linphone_payload_type_get_clock_rate(const LinphonePayloadType *pt);
/**
* Tells whether the specified payload type represents a variable bitrate codec.
* @param[in] pt LinphonePayloadType object
* @return TRUE if the payload type represents a VBR codec, FALSE if disabled.
* @param[in] pt The payload type.
* @return TRUE if the payload type represents a VBR codec, FALSE instead.
*/
LINPHONE_PUBLIC bool_t linphone_payload_type_is_vbr(const LinphonePayloadType *pt);
/**
* @}
**/
* Check whether the payload is usable according the bandwidth targets set in the core.
* @param[in] pt The payload type to test.
* @return TRUE if the payload type is usable.
*/
LINPHONE_PUBLIC bool_t linphone_payload_type_is_usable(const LinphonePayloadType *pt);
#ifdef __cplusplus
}
#endif
/**
* @}
**/
#endif /* LINPHONE_PAYLOAD_TYPE_H_ */

12
include/linphone/types.h
View file

@ -685,12 +685,6 @@ typedef enum _LinphoneOnlineStatus{
LinphoneStatusEnd
} LinphoneOnlineStatus;
/**
* Object representing an RTP payload type.
* @ingroup media_parameters
*/
typedef PayloadType LinphonePayloadType;
/**
* Player interface.
* @ingroup call_control
@ -1177,6 +1171,12 @@ typedef enum _LinphoneXmlRpcStatus {
typedef struct _LsdPlayer LsdPlayer;
/**
* Object representing an RTP payload type.
* @ingroup media_parameters
*/
typedef struct _LinphonePayloadType LinphonePayloadType;
/**
* Structure describing a range of integers

2
tester/call_single_tester.c
View file

@ -3189,7 +3189,7 @@ static void call_with_in_dialog_codec_change_base(bool_t no_sdp) {
BC_ASSERT_TRUE(wait_for(marie->lc,pauline->lc,&marie->stat.number_of_LinphoneCallStreamsRunning,2));
BC_ASSERT_TRUE(wait_for(marie->lc,pauline->lc,&pauline->stat.number_of_LinphoneCallUpdatedByRemote,1));
BC_ASSERT_TRUE(wait_for(marie->lc,pauline->lc,&pauline->stat.number_of_LinphoneCallStreamsRunning,2));
BC_ASSERT_STRING_EQUAL("PCMA",linphone_payload_type_get_mime_type(linphone_call_params_get_used_audio_codec(linphone_call_get_current_params(linphone_core_get_current_call(marie->lc)))));
BC_ASSERT_STRING_EQUAL("PCMA",payload_type_get_mime(linphone_call_params_get_used_audio_codec(linphone_call_get_current_params(linphone_core_get_current_call(marie->lc)))));
wait_for_until(marie->lc, pauline->lc, &dummy, 1, 5000);
BC_ASSERT_GREATER(linphone_core_manager_get_max_audio_down_bw(marie),70,int,"%i");
BC_ASSERT_GREATER(linphone_core_manager_get_max_audio_down_bw(pauline),70,int,"%i");

32
tester/offeranswer_tester.c
View file

@ -58,13 +58,13 @@ static void check_payload_type_numbers(LinphoneCall *call1, LinphoneCall *call2,
const PayloadType *pt=linphone_call_params_get_used_audio_codec(params);
BC_ASSERT_PTR_NOT_NULL(pt);
if (pt){
BC_ASSERT_EQUAL(linphone_payload_type_get_number(pt),expected_number, int, "%d");
BC_ASSERT_EQUAL(payload_type_get_number(pt),expected_number, int, "%d");
}
params=linphone_call_get_current_params(call2);
pt=linphone_call_params_get_used_audio_codec(params);
BC_ASSERT_PTR_NOT_NULL(pt);
if (pt){
BC_ASSERT_EQUAL(linphone_payload_type_get_number(pt),expected_number, int, "%d");
BC_ASSERT_EQUAL(payload_type_get_number(pt),expected_number, int, "%d");
}
}
@ -80,7 +80,7 @@ static void simple_call_with_different_codec_mappings(void) {
disable_all_audio_codecs_except_one(pauline->lc,"pcmu",-1);
/*marie set a fantasy number to PCMU*/
linphone_payload_type_set_number(linphone_core_find_payload_type(marie->lc, "PCMU", 8000, -1), 104);
payload_type_set_number(linphone_core_find_payload_type(marie->lc, "PCMU", 8000, -1), 104);
BC_ASSERT_TRUE(call(marie,pauline));
pauline_call=linphone_core_get_current_call(pauline->lc);
@ -398,9 +398,9 @@ static void savpf_dtls_to_avpf_video_call(void) {
#endif
#ifdef VIDEO_ENABLED
static LinphonePayloadType * configure_core_for_avpf_and_video(LinphoneCore *lc) {
static OrtpPayloadType * configure_core_for_avpf_and_video(LinphoneCore *lc) {
LinphoneProxyConfig *lpc;
LinphonePayloadType *lpt;
OrtpPayloadType *pt;
LinphoneVideoPolicy policy = { 0 };
policy.automatically_initiate = TRUE;
@ -412,13 +412,13 @@ static LinphonePayloadType * configure_core_for_avpf_and_video(LinphoneCore *lc)
linphone_core_enable_video_capture(lc, TRUE);
linphone_core_enable_video_display(lc, TRUE);
linphone_core_set_video_policy(lc, &policy);
lpt = linphone_core_find_payload_type(lc, "VP8", 90000, -1);
if (lpt == NULL) {
pt = linphone_core_find_payload_type(lc, "VP8", 90000, -1);
if (pt == NULL) {
ms_warning("VP8 codec not available.");
} else {
disable_all_video_codecs_except_one(lc, "VP8");
}
return lpt;
return pt;
}
static void check_avpf_features(LinphoneCore *lc, unsigned char expected_features) {
@ -441,19 +441,20 @@ static void check_avpf_features(LinphoneCore *lc, unsigned char expected_feature
static void compatible_avpf_features(void) {
LinphoneCoreManager *marie = linphone_core_manager_new("marie_rc");
LinphoneCoreManager *pauline = linphone_core_manager_new("pauline_tcp_rc");
LinphonePayloadType *lpt;
OrtpPayloadType *pt;
bool_t call_ok;
if (configure_core_for_avpf_and_video(marie->lc) == NULL) goto end;
lpt = configure_core_for_avpf_and_video(pauline->lc);
pt = configure_core_for_avpf_and_video(pauline->lc);
BC_ASSERT_TRUE((call_ok=call(marie, pauline)));
if (!call_ok) goto end;
BC_ASSERT_TRUE(wait_for(marie->lc, pauline->lc, &marie->stat.number_of_LinphoneCallStreamsRunning, 1));
BC_ASSERT_TRUE(wait_for(marie->lc, pauline->lc, &pauline->stat.number_of_LinphoneCallStreamsRunning, 1));
check_avpf_features(marie->lc, lpt->avpf.features);
check_avpf_features(pauline->lc, lpt->avpf.features);
check_avpf_features(marie->lc, pt->avpf.features);
check_avpf_features(pauline->lc, pt->avpf.features);
end_call(marie,pauline);
end:
@ -464,12 +465,13 @@ end:
static void incompatible_avpf_features(void) {
LinphoneCoreManager *marie = linphone_core_manager_new("marie_rc");
LinphoneCoreManager *pauline = linphone_core_manager_new("pauline_tcp_rc");
LinphonePayloadType *lpt;
OrtpPayloadType *pt;
bool_t call_ok;
if (configure_core_for_avpf_and_video(marie->lc) == NULL) goto end;
lpt = configure_core_for_avpf_and_video(pauline->lc);
lpt->avpf.features = PAYLOAD_TYPE_AVPF_NONE;
pt = configure_core_for_avpf_and_video(pauline->lc);
pt->avpf.features = PAYLOAD_TYPE_AVPF_NONE;
BC_ASSERT_TRUE(call_ok=call(marie, pauline));
if (!call_ok) goto end;

1
wrappers/cpp/abstractapi.py
View file

@ -440,7 +440,6 @@ class CParser(object):
'linphone_vcard_get_belcard'] # manualy wrapped
self.classBl = ['LpConfig',
'LinphonePayloadType',
'LinphonePlayer'] # temporarly blacklisted
# list of classes that must be concidered as refcountable even if