mirrors/linphone-iphone
1
0
Fork 1
mirror of https://gitlab.linphone.org/BC/public/linphone-iphone.git synced 2026-01-20 04:28:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Handle From and To headers in CPIM messages.

Browse source
This commit is contained in:
Ghislain MARY 2017-10-13 11:20:20 +02:00
parent 8ab95782bb
commit 3d50e6e9e2
6 changed files with 99 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/chat/chat-message/chat-message-p.h
View file

@ -55,6 +55,11 @@ public:
// -----------------------------------------------------------------------------
void setApplyModifiers (bool value) { applyModifiers = value; }
const Address &getCpimFromAddress () const { return cpimFrom; }
void setCpimFromAddress (const Address &addr);
void setDirection (ChatMessage::Direction dir);
void setState(ChatMessage::State state);
@ -124,6 +129,7 @@ private:
unsigned int storageId = 0;
Address from;
Address to;
Address cpimFrom;
time_t time = 0;
std::string id;
std::string appData;
@ -143,6 +149,7 @@ private:
SalCustomHeader *salCustomHeaders = NULL;
unsigned long backgroundTaskId;
unsigned char currentSendStep = Step::None;
bool applyModifiers = true;
// Cache for returned values, used for compatibility with previous C API
ContentType cContentType;
std::string cText;

65
src/chat/chat-message/chat-message.cpp
View file

@ -60,6 +60,11 @@ void ChatMessagePrivate::setChatRoom (shared_ptr<ChatRoom> cr) {
chatRoom = cr;
}
void ChatMessagePrivate::setCpimFromAddress (const Address &addr) {
cpimFrom = addr;
cpimFrom.clean();
}
void ChatMessagePrivate::setDirection (ChatMessage::Direction dir) {
direction = dir;
}
@ -1132,41 +1137,43 @@ void ChatMessagePrivate::send() {
}
//End of TODO Remove
if ((currentSendStep & ChatMessagePrivate::Step::Multipart) == ChatMessagePrivate::Step::Multipart) {
lInfo() << "Multipart step already done, skipping";
} else {
if (contents.size() > 1) {
MultipartChatMessageModifier mcmm;
mcmm.encode(q->getSharedFromThis(), errorCode);
if (applyModifiers) {
if ((currentSendStep & ChatMessagePrivate::Step::Multipart) == ChatMessagePrivate::Step::Multipart) {
lInfo() << "Multipart step already done, skipping";
} else {
if (contents.size() > 1) {
MultipartChatMessageModifier mcmm;
mcmm.encode(q->getSharedFromThis(), errorCode);
}
currentSendStep |= ChatMessagePrivate::Step::Multipart;
}
currentSendStep |= ChatMessagePrivate::Step::Multipart;
}
if ((currentSendStep & ChatMessagePrivate::Step::Encryption) == ChatMessagePrivate::Step::Encryption) {
lInfo() << "Encryption step already done, skipping";
} else {
EncryptionChatMessageModifier ecmm;
ChatMessageModifier::Result result = ecmm.encode(q->getSharedFromThis(), errorCode);
if (result == ChatMessageModifier::Result::Error) {
sal_error_info_set((SalErrorInfo *)op->get_error_info(), SalReasonNotAcceptable, "SIP", errorCode, "Unable to encrypt IM", nullptr);
q->updateState(ChatMessage::State::NotDelivered);
q->store();
return;
} else if (result == ChatMessageModifier::Result::Suspended) {
if ((currentSendStep & ChatMessagePrivate::Step::Encryption) == ChatMessagePrivate::Step::Encryption) {
lInfo() << "Encryption step already done, skipping";
} else {
EncryptionChatMessageModifier ecmm;
ChatMessageModifier::Result result = ecmm.encode(q->getSharedFromThis(), errorCode);
if (result == ChatMessageModifier::Result::Error) {
sal_error_info_set((SalErrorInfo *)op->get_error_info(), SalReasonNotAcceptable, "SIP", errorCode, "Unable to encrypt IM", nullptr);
q->updateState(ChatMessage::State::NotDelivered);
q->store();
return;
} else if (result == ChatMessageModifier::Result::Suspended) {
currentSendStep |= ChatMessagePrivate::Step::Encryption;
return;
}
currentSendStep |= ChatMessagePrivate::Step::Encryption;
return;
}
currentSendStep |= ChatMessagePrivate::Step::Encryption;
}
if ((currentSendStep & ChatMessagePrivate::Step::Cpim) == ChatMessagePrivate::Step::Cpim) {
lInfo() << "Cpim step already done, skipping";
} else {
if (lp_config_get_int(chatRoom->getCore()->config, "sip", "use_cpim", 0) == 1) {
CpimChatMessageModifier ccmm;
ccmm.encode(q->getSharedFromThis(), errorCode);
if ((currentSendStep & ChatMessagePrivate::Step::Cpim) == ChatMessagePrivate::Step::Cpim) {
lInfo() << "Cpim step already done, skipping";
} else {
if (lp_config_get_int(chatRoom->getCore()->config, "sip", "use_cpim", 0) == 1) {
CpimChatMessageModifier ccmm;
ccmm.encode(q->getSharedFromThis(), errorCode);
}
currentSendStep |= ChatMessagePrivate::Step::Cpim;
}
currentSendStep |= ChatMessagePrivate::Step::Cpim;
}
// ---------------------------------------

1
src/chat/chat-message/chat-message.h
View file

@ -39,6 +39,7 @@ class ChatMessagePrivate;
class LINPHONE_PUBLIC ChatMessage : public Object {
friend class ChatRoom;
friend class ChatRoomPrivate;
friend class CpimChatMessageModifier;
friend class RealTimeTextChatRoomPrivate;
public:

1
src/chat/chat-room/chat-room.cpp
View file

@ -557,6 +557,7 @@ shared_ptr<ChatMessage> ChatRoom::createMessage () {
shared_ptr<ChatMessage> chatMessage = ObjectFactory::create<ChatMessage>(getSharedFromThis());
chatMessage->setToAddress(d->peerAddress);
chatMessage->setFromAddress(Address(linphone_core_get_identity(d->core)));
chatMessage->getPrivate()->setCpimFromAddress(chatMessage->getFromAddress());
chatMessage->getPrivate()->setTime(ms_time(0));
return chatMessage;
}

54
src/chat/modifier/cpim-chat-message-modifier.cpp
View file

@ -18,7 +18,7 @@
*/
#include "address/address.h"
#include "chat/chat-message/chat-message.h"
#include "chat/chat-message/chat-message-p.h"
#include "chat/cpim/cpim.h"
#include "content/content-type.h"
#include "content/content.h"
@ -36,9 +36,16 @@ ChatMessageModifier::Result CpimChatMessageModifier::encode (const shared_ptr<Ch
Cpim::Message cpimMessage;
Cpim::GenericHeader cpimContentTypeHeader;
cpimContentTypeHeader.setName("Content-Type");
cpimContentTypeHeader.setValue("Message/CPIM");
cpimContentTypeHeader.setValue(ContentType::Cpim.asString());
cpimMessage.addCpimHeader(cpimContentTypeHeader);
Cpim::FromHeader cpimFromHeader;
cpimFromHeader.setValue(cpimAddressAsString(message->getPrivate()->getCpimFromAddress()));
cpimMessage.addMessageHeader(cpimFromHeader);
Cpim::ToHeader cpimToHeader;
cpimToHeader.setValue(cpimAddressAsString(message->getToAddress()));
cpimMessage.addMessageHeader(cpimToHeader);
Content content;
if (!message->getInternalContent().isEmpty()) {
// Another ChatMessageModifier was called before this one, we apply our changes on the private content
@ -93,11 +100,52 @@ ChatMessageModifier::Result CpimChatMessageModifier::decode (const shared_ptr<Ch
}
Content newContent;
newContent.setContentType(ContentType(cpimMessage->getContentHeaders()->front()->getValue()));
bool contentTypeFound = false;
Cpim::Message::HeaderList l = cpimMessage->getContentHeaders();
if (l) {
for (const auto &header : *l.get()) {
if (header->getName() == "Content-Type") {
contentTypeFound = true;
newContent.setContentType(ContentType(header->getValue()));
break;
}
}
}
if (!contentTypeFound) {
lError() << "[CPIM] No Content-type for the content of the message";
errorCode = 500;
return ChatMessageModifier::Result::Error;
}
newContent.setBody(cpimMessage->getContent());
Address cpimFromAddress;
Address cpimToAddress;
l = cpimMessage->getMessageHeaders();
if (l) {
for (const auto &header : *l.get()) {
if (header->getName() == "From")
cpimFromAddress = Address(header->getValue());
else if (header->getName() == "To")
cpimToAddress = Address(header->getValue());
}
}
// Modify the initial message since there was no error
message->setInternalContent(newContent);
if (cpimFromAddress.isValid())
message->getPrivate()->setCpimFromAddress(cpimFromAddress);
if (cpimToAddress.isValid())
message->setToAddress(cpimToAddress);
return ChatMessageModifier::Result::Done;
}
string CpimChatMessageModifier::cpimAddressAsString (const Address &addr) const {
ostringstream os;
if (!addr.getDisplayName().empty())
os << addr.getDisplayName() << " ";
os << "<" << addr.asStringUriOnly() << ">";
return os.str();
}
LINPHONE_END_NAMESPACE

3
src/chat/modifier/cpim-chat-message-modifier.h
View file

@ -32,6 +32,9 @@ public:
Result encode (const std::shared_ptr<ChatMessage> &message, int &errorCode) override;
Result decode (const std::shared_ptr<ChatMessage> &message, int &errorCode) override;
private:
std::string cpimAddressAsString (const Address &addr) const;
};
LINPHONE_END_NAMESPACE