From 4ae532b61a1fbbd76aa3992be180994943ee1a05 Mon Sep 17 00:00:00 2001 From: Yann Diorcet Date: Thu, 23 Aug 2012 15:45:18 +0200 Subject: [PATCH] History details view: Create only one time the date formatter --- Classes/HistoryDetailsViewController.h | 1 + Classes/HistoryDetailsViewController.m | 20 ++++++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/Classes/HistoryDetailsViewController.h b/Classes/HistoryDetailsViewController.h index df6ffac34..a9140badd 100644 --- a/Classes/HistoryDetailsViewController.h +++ b/Classes/HistoryDetailsViewController.h @@ -26,6 +26,7 @@ @interface HistoryDetailsViewController : UIViewController { @private ABRecordRef contact; + NSDateFormatter *dateFormatter; } @property (nonatomic, retain) IBOutlet UIImageView *avatarImage; @property (nonatomic, retain) IBOutlet UILabel *addressLabel; diff --git a/Classes/HistoryDetailsViewController.m b/Classes/HistoryDetailsViewController.m index f0af8e22e..8b5f2a169 100644 --- a/Classes/HistoryDetailsViewController.m +++ b/Classes/HistoryDetailsViewController.m @@ -38,9 +38,23 @@ #pragma mark - LifeCycle Functions +- (id)init { + self = [super initWithNibName:@"HistoryDetailsViewController" bundle:[NSBundle mainBundle]]; + if(self != nil) { + dateFormatter = [[NSDateFormatter alloc] init]; + [dateFormatter setTimeStyle:NSDateFormatterMediumStyle]; + [dateFormatter setDateStyle:NSDateFormatterMediumStyle]; + NSLocale *locale = [NSLocale currentLocale]; + [dateFormatter setLocale:locale]; + } + return self; +} + - (void)dealloc { [[NSNotificationCenter defaultCenter] removeObserver:self]; + [dateFormatter release]; + [avatarImage release]; [addressLabel release]; [dateLabel release]; @@ -221,13 +235,7 @@ static UICompositeViewDescription *compositeDescription = nil; // Date NSDate *startData = [NSDate dateWithTimeIntervalSince1970:callLog->start_date_time]; - NSDateFormatter *dateFormatter = [[NSDateFormatter alloc] init]; - [dateFormatter setTimeStyle:NSDateFormatterMediumStyle]; - [dateFormatter setDateStyle:NSDateFormatterMediumStyle]; - NSLocale *locale = [NSLocale currentLocale]; - [dateFormatter setLocale:locale]; [dateLabel setText:[dateFormatter stringFromDate:startData]]; - [dateFormatter release]; // Duration int duration = callLog->duration;