From 8367c0fef2688095699cc1d570be91c69b333a83 Mon Sep 17 00:00:00 2001 From: Guillaume Beraudo Date: Wed, 12 Feb 2014 14:11:12 +0100 Subject: [PATCH] More builder-like interface for LinphoneProxyConfig --- java/common/org/linphone/core/LinphoneProxyConfig.java | 5 ++--- java/impl/org/linphone/core/LinphoneProxyConfigImpl.java | 6 ++++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/java/common/org/linphone/core/LinphoneProxyConfig.java b/java/common/org/linphone/core/LinphoneProxyConfig.java index 90d91e73a..e613fd194 100644 --- a/java/common/org/linphone/core/LinphoneProxyConfig.java +++ b/java/common/org/linphone/core/LinphoneProxyConfig.java @@ -30,7 +30,7 @@ public interface LinphoneProxyConfig { *Because proxy configuration must be consistent, applications MUST call {@link #edit()} before doing any attempts to modify proxy configuration (such as identity, proxy address and so on). *Once the modifications are done, then the application must call {@link #done()} to commit the changes. */ - public void edit(); + public LinphoneProxyConfig edit(); /** * Commits modification made to the proxy configuration. */ @@ -65,9 +65,8 @@ public interface LinphoneProxyConfig { * Enable register for this proxy config. * Register message is issued after call to {@link #done()} * @param value - * @throws LinphoneCoreException */ - public void enableRegister(boolean value) throws LinphoneCoreException; + public LinphoneProxyConfig enableRegister(boolean value); /** * @return true if registration to the proxy is enabled. */ diff --git a/java/impl/org/linphone/core/LinphoneProxyConfigImpl.java b/java/impl/org/linphone/core/LinphoneProxyConfigImpl.java index 9f24dcbe8..2fe08ad91 100644 --- a/java/impl/org/linphone/core/LinphoneProxyConfigImpl.java +++ b/java/impl/org/linphone/core/LinphoneProxyConfigImpl.java @@ -84,16 +84,18 @@ class LinphoneProxyConfigImpl implements LinphoneProxyConfig { private native int lookupCCCFromIso(long nativePtr, String iso); private native int lookupCCCFromE164(long nativePtr, String e164); - public void enableRegister(boolean value) { + public LinphoneProxyConfig enableRegister(boolean value) { enableRegister(nativePtr,value); + return this; } public void done() { done(nativePtr); } - public void edit() { + public LinphoneProxyConfig edit() { edit(nativePtr); + return this; } public void setIdentity(String identity) throws LinphoneCoreException {