mirrors/linphone-iphone
1
0
Fork 1
mirror of https://gitlab.linphone.org/BC/public/linphone-iphone.git synced 2026-01-30 01:39:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Prevent invalid reads in C code because of addresses internal cache variables being uselessly reallocated.

Browse source
This commit is contained in:
Ghislain MARY 2018-01-16 10:58:47 +01:00
parent dcc3bc6e59
commit c57570a979
1 changed files with 18 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/address/address.cpp
View file

@ -116,7 +116,9 @@ const string &Address::getScheme () const {
if (!d->internalAddress)
return Utils::getEmptyConstRefObject<string>();
d->cache.scheme = L_C_TO_STRING(sal_address_get_scheme(d->internalAddress));
string scheme(L_C_TO_STRING(sal_address_get_scheme(d->internalAddress)));
if (scheme != d->cache.scheme)
d->cache.scheme = scheme;
return d->cache.scheme;
}
@ -126,7 +128,9 @@ const string &Address::getDisplayName () const {
if (!d->internalAddress)
return Utils::getEmptyConstRefObject<string>();
d->cache.displayName = L_C_TO_STRING(sal_address_get_display_name(d->internalAddress));
string displayName(L_C_TO_STRING(sal_address_get_display_name(d->internalAddress)));
if (displayName != d->cache.displayName)
d->cache.displayName = displayName;
return d->cache.displayName;
}
@ -146,7 +150,9 @@ const string &Address::getUsername () const {
if (!d->internalAddress)
return Utils::getEmptyConstRefObject<string>();
d->cache.username = L_C_TO_STRING(sal_address_get_username(d->internalAddress));
string username(L_C_TO_STRING(sal_address_get_username(d->internalAddress)));
if (username != d->cache.username)
d->cache.username = username;
return d->cache.username;
}
@ -166,7 +172,9 @@ const string &Address::getDomain () const {
if (!d->internalAddress)
return Utils::getEmptyConstRefObject<string>();
d->cache.domain = L_C_TO_STRING(sal_address_get_domain(d->internalAddress));
string domain(L_C_TO_STRING(sal_address_get_domain(d->internalAddress)));
if (domain != d->cache.domain)
d->cache.domain = domain;
return d->cache.domain;
}
@ -236,7 +244,9 @@ const string &Address::getMethodParam () const {
if (!d->internalAddress)
return Utils::getEmptyConstRefObject<string>();
d->cache.methodParam = L_C_TO_STRING(sal_address_get_method_param(d->internalAddress));
string methodParam(L_C_TO_STRING(sal_address_get_method_param(d->internalAddress)));
if (methodParam != d->cache.methodParam)
d->cache.methodParam = methodParam;
return d->cache.methodParam;
}
@ -256,7 +266,9 @@ const string &Address::getPassword () const {
if (!d->internalAddress)
return Utils::getEmptyConstRefObject<string>();
d->cache.password = L_C_TO_STRING(sal_address_get_password(d->internalAddress));
string password(L_C_TO_STRING(sal_address_get_password(d->internalAddress)));
if (password != d->cache.password)
d->cache.password = password;
return d->cache.password;
}