fix(Object): little fixes, remove useless friend and add assert and getSharedFromThis

src/object/app-data-container.cpp

@@ -27,6 +27,8 @@ using namespace std;
 
 LINPHONE_BEGIN_NAMESPACE
 
+// -----------------------------------------------------------------------------
+
 class AppDataContainerPrivate {
 public:
 	shared_ptr<unordered_map<string, string>> appData;

src/object/base-object-p.h

@@ -17,8 +17,8 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  */
 
- #ifndef _BASE_OBJECT_P_H_
- #define _BASE_OBJECT_P_H_
+#ifndef _BASE_OBJECT_P_H_
+#define _BASE_OBJECT_P_H_
 
 #include "linphone/utils/general.h"
 

src/object/object.cpp

@@ -26,6 +26,8 @@ using namespace std;
 
 LINPHONE_BEGIN_NAMESPACE
 
+// -----------------------------------------------------------------------------
+
 Object::Object (ObjectPrivate &p) : BaseObject(p) {}
 
 shared_ptr<Object> Object::getSharedFromThis () {
@@ -39,6 +41,8 @@ shared_ptr<const Object> Object::getSharedFromThis () const {
 		lFatal() << "Object " << this << " was not created with make_shared.";
 	}
 
+	// Unable to reach this point.
+	L_ASSERT(false);
 	return nullptr;
 }
 

src/object/object.h

@@ -38,7 +38,6 @@ class LINPHONE_PUBLIC Object :
 	public std::enable_shared_from_this<Object>,
 	public BaseObject,
 	public PropertyContainer {
-	friend class ObjectFactory;
 
 public:
 	std::shared_ptr<Object> getSharedFromThis ();

src/object/property-container.cpp

@@ -27,6 +27,8 @@ using namespace std;
 
 LINPHONE_BEGIN_NAMESPACE
 
+// -----------------------------------------------------------------------------
+
 class PropertyContainerPrivate {
 public:
 	unordered_map<string, Variant> properties;

src/utils/utils.cpp

@@ -31,6 +31,8 @@ using namespace std;
 
 LINPHONE_BEGIN_NAMESPACE
 
+// -----------------------------------------------------------------------------
+
 bool Utils::iequals (const string &a, const string &b) {
 	size_t size = a.size();
 	if (b.size() != size)

src/variant/variant.cpp

@@ -27,6 +27,8 @@ using namespace std;
 
 LINPHONE_BEGIN_NAMESPACE
 
+// -----------------------------------------------------------------------------
+
 class VariantPrivate {
 public:
 	union Value {