mirrors/linphone-iphone
1
0
Fork 1
mirror of https://gitlab.linphone.org/BC/public/linphone-iphone.git synced 2026-04-29 06:36:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

srtp: fix crypto line tag handling

Browse source 
We were answering with the local tag index matching the remote crypto
algo; instead of using the remote tag
This commit is contained in:
Pierre-Eric Pelloux-Prayer 2012-03-01 10:46:22 +01:00
parent 3b4c6de52b
commit f40bd13c63
3 changed files with 37 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
coreapi/linphonecall.c
View file

@ -1181,15 +1181,23 @@ static void linphone_call_start_audio_stream(LinphoneCall *call, const char *cna
} }
audio_stream_set_rtcp_information(call->audiostream, cname, LINPHONE_RTCP_SDES_TOOL); audio_stream_set_rtcp_information(call->audiostream, cname, LINPHONE_RTCP_SDES_TOOL);
/* valid local tags are > 0 */
if (stream->proto == SalProtoRtpSavp) { if (stream->proto == SalProtoRtpSavp) {
const SalStreamDescription *local_st_desc=sal_media_description_find_stream(call->localdesc, const SalStreamDescription *local_st_desc=sal_media_description_find_stream(call->localdesc,
SalProtoRtpSavp,SalAudio); SalProtoRtpSavp,SalAudio);
int crypto_idx = find_crypto_index_from_tag(local_st_desc->crypto, stream->crypto_local_tag);
if (crypto_idx >= 0) {
audio_stream_enable_strp( audio_stream_enable_strp(
call->audiostream, call->audiostream,
stream->crypto[0].algo, stream->crypto[0].algo,
local_st_desc->crypto[find_crypto_index_from_tag(local_st_desc->crypto,stream->crypto[0].tag)].master_key, local_st_desc->crypto[crypto_idx].master_key,
stream->crypto[0].master_key); stream->crypto[0].master_key);
call->audiostream_encrypted=TRUE; call->audiostream_encrypted=TRUE;
} else {
ms_warning("Failed to find local crypto algo with tag: %d", stream->crypto_local_tag);
call->audiostream_encrypted=FALSE;
}
}else call->audiostream_encrypted=FALSE; }else call->audiostream_encrypted=FALSE;
if (call->params.in_conference){ if (call->params.in_conference){
/*transform the graph to connect it to the conference filter */ /*transform the graph to connect it to the conference filter */

18
coreapi/offeranswer.c
View file

@ -129,21 +129,27 @@ static MSList *match_payloads(const MSList *local, const MSList *remote, bool_t
} }
static bool_t match_crypto_algo(const SalSrtpCryptoAlgo* local, const SalSrtpCryptoAlgo* remote, static bool_t match_crypto_algo(const SalSrtpCryptoAlgo* local, const SalSrtpCryptoAlgo* remote,
SalSrtpCryptoAlgo* result, bool_t use_local_key) { SalSrtpCryptoAlgo* result, unsigned int* choosen_local_tag, bool_t use_local_key) {
int i,j; int i,j;
for(i=0; i<SAL_CRYPTO_ALGO_MAX; i++) { for(i=0; i<SAL_CRYPTO_ALGO_MAX; i++) {
if (remote[i].algo == 0) if (remote[i].algo == 0)
break; break;
/* Look for a local enabled crypto algo that matches one of the proposed by remote */
for(j=0; j<SAL_CRYPTO_ALGO_MAX; j++) { for(j=0; j<SAL_CRYPTO_ALGO_MAX; j++) {
if (remote[i].algo == local[j].algo) { if (remote[i].algo == local[j].algo) {
result->algo = remote[i].algo; result->algo = remote[i].algo;
/* We're answering an SDP offer. Supply our master key, associated with the remote supplied tag */
if (use_local_key) { if (use_local_key) {
strncpy(result->master_key, local[j].master_key, 41); strncpy(result->master_key, local[j].master_key, 41);
result->tag = local[j].tag;
} else {
strncpy(result->master_key, remote[i].master_key, 41);
result->tag = remote[i].tag; result->tag = remote[i].tag;
*choosen_local_tag = local[j].tag;
}
/* We received an answer to our SDP crypto proposal. Copy matching algo remote master key to result, and memorize local tag */
else {
strncpy(result->master_key, remote[i].master_key, 41);
result->tag = local[j].tag;
*choosen_local_tag = local[j].tag;
} }
result->master_key[40] = '\0'; result->master_key[40] = '\0';
return TRUE; return TRUE;
@ -214,7 +220,7 @@ static void initiate_outgoing(const SalStreamDescription *local_offer,
if (result->proto == SalProtoRtpSavp) { if (result->proto == SalProtoRtpSavp) {
/* verify crypto algo */ /* verify crypto algo */
memset(result->crypto, 0, sizeof(result->crypto)); memset(result->crypto, 0, sizeof(result->crypto));
if (!match_crypto_algo(local_offer->crypto, remote_answer->crypto, &result->crypto[0], FALSE)) if (!match_crypto_algo(local_offer->crypto, remote_answer->crypto, &result->crypto[0], &result->crypto_local_tag, FALSE))
result->port = 0; result->port = 0;
} }
} }
@ -239,7 +245,7 @@ static void initiate_incoming(const SalStreamDescription *local_cap,
if (result->proto == SalProtoRtpSavp) { if (result->proto == SalProtoRtpSavp) {
/* select crypto algo */ /* select crypto algo */
memset(result->crypto, 0, sizeof(result->crypto)); memset(result->crypto, 0, sizeof(result->crypto));
if (!match_crypto_algo(local_cap->crypto, remote_offer->crypto, &result->crypto[0], TRUE)) if (!match_crypto_algo(local_cap->crypto, remote_offer->crypto, &result->crypto[0], &result->crypto_local_tag, TRUE))
result->port = 0; result->port = 0;
} }

1
coreapi/sal.h
View file

@ -133,6 +133,7 @@ typedef struct SalStreamDescription{
SalEndpointCandidate candidates[SAL_ENDPOINT_CANDIDATE_MAX]; SalEndpointCandidate candidates[SAL_ENDPOINT_CANDIDATE_MAX];
SalStreamDir dir; SalStreamDir dir;
SalSrtpCryptoAlgo crypto[SAL_CRYPTO_ALGO_MAX]; SalSrtpCryptoAlgo crypto[SAL_CRYPTO_ALGO_MAX];
unsigned int crypto_local_tag;
} SalStreamDescription; } SalStreamDescription;
#define SAL_MEDIA_DESCRIPTION_MAX_STREAMS 4 #define SAL_MEDIA_DESCRIPTION_MAX_STREAMS 4