From ffb03f9c359bbf59cf5a2ff5d047fea438397dba Mon Sep 17 00:00:00 2001 From: Sylvain Berfini Date: Mon, 2 Jan 2012 15:30:05 +0100 Subject: [PATCH] Call quality indicator on all video views --- Classes/VideoViewController.h | 2 + Classes/VideoViewController.m | 16 ++++ Classes/VideoViewController.xib | 139 +++++++++++++++++++++++--------- 3 files changed, 119 insertions(+), 38 deletions(-) diff --git a/Classes/VideoViewController.h b/Classes/VideoViewController.h index a8958ff9d..1cad26a13 100644 --- a/Classes/VideoViewController.h +++ b/Classes/VideoViewController.h @@ -59,6 +59,7 @@ @property (nonatomic, retain) IBOutlet UIMuteButton* mMuteLandRight; @property (nonatomic, retain) IBOutlet UIHangUpButton* mHangUpLandRight; @property (nonatomic, retain) IBOutlet UICamSwitch* mCamSwitchLandRight; +@property (nonatomic, retain) IBOutlet UIImageView *mCallQualityLandRight; @property (nonatomic, retain) IBOutlet UIView* mLandscapeLeft; @property (nonatomic, retain) IBOutlet UIView* mDisplayLandLeft; @@ -66,6 +67,7 @@ @property (nonatomic, retain) IBOutlet UIMuteButton* mMuteLandLeft; @property (nonatomic, retain) IBOutlet UIHangUpButton* mHangUpLandLeft; @property (nonatomic, retain) IBOutlet UICamSwitch* mCamSwitchLandLeft; +@property (retain, nonatomic) IBOutlet UIImageView *mCallQualityLandLeft; - (void) updateCallQualityIndicator; diff --git a/Classes/VideoViewController.m b/Classes/VideoViewController.m index 5fbcd648b..424f0d118 100644 --- a/Classes/VideoViewController.m +++ b/Classes/VideoViewController.m @@ -36,6 +36,7 @@ @synthesize mMuteLandRight; @synthesize mHangUpLandRight; @synthesize mCamSwitchLandRight; +@synthesize mCallQualityLandRight; @synthesize mLandscapeLeft; @synthesize mDisplayLandLeft; @@ -43,6 +44,7 @@ @synthesize mMuteLandLeft; @synthesize mHangUpLandLeft; @synthesize mCamSwitchLandLeft; +@synthesize mCallQualityLandLeft; NSTimer *callQualityRefresher; @@ -58,6 +60,8 @@ NSTimer *callQualityRefresher; - (void)dealloc { [mCallQuality release]; + [mCallQualityLandRight release]; + [mCallQualityLandLeft release]; [super dealloc]; } @@ -90,18 +94,28 @@ NSTimer *callQualityRefresher; if (linphone_call_get_average_quality(call) >= 4) { [mCallQuality setImage: [UIImage imageNamed:@"stat_sys_signal_4.png"]]; + [mCallQualityLandRight setImage: [UIImage imageNamed:@"stat_sys_signal_4.png"]]; + [mCallQualityLandLeft setImage: [UIImage imageNamed:@"stat_sys_signal_4.png"]]; } else if (linphone_call_get_average_quality(call) >= 3) { [mCallQuality setImage: [UIImage imageNamed:@"stat_sys_signal_3.png"]]; + [mCallQualityLandRight setImage: [UIImage imageNamed:@"stat_sys_signal_3.png"]]; + [mCallQualityLandLeft setImage: [UIImage imageNamed:@"stat_sys_signal_3.png"]]; } else if (linphone_call_get_average_quality(call) >= 2) { [mCallQuality setImage: [UIImage imageNamed:@"stat_sys_signal_2.png"]]; + [mCallQualityLandRight setImage: [UIImage imageNamed:@"stat_sys_signal_2.png"]]; + [mCallQualityLandLeft setImage: [UIImage imageNamed:@"stat_sys_signal_2.png"]]; } else if (linphone_call_get_average_quality(call) >= 1) { [mCallQuality setImage: [UIImage imageNamed:@"stat_sys_signal_1.png"]]; + [mCallQualityLandRight setImage: [UIImage imageNamed:@"stat_sys_signal_1.png"]]; + [mCallQualityLandLeft setImage: [UIImage imageNamed:@"stat_sys_signal_1.png"]]; } else { [mCallQuality setImage: [UIImage imageNamed:@"stat_sys_signal_0.png"]]; + [mCallQualityLandRight setImage: [UIImage imageNamed:@"stat_sys_signal_0.png"]]; + [mCallQualityLandLeft setImage: [UIImage imageNamed:@"stat_sys_signal_0.png"]]; } } @@ -141,6 +155,8 @@ NSTimer *callQualityRefresher; { [mCallQuality release]; mCallQuality = nil; + [self setMCallQualityLandRight:nil]; + [self setMCallQualityLandLeft:nil]; [super viewDidUnload]; // Release any retained subviews of the main view. diff --git a/Classes/VideoViewController.xib b/Classes/VideoViewController.xib index 0ba0cefe2..cd1e2025e 100644 --- a/Classes/VideoViewController.xib +++ b/Classes/VideoViewController.xib @@ -36,9 +36,11 @@ IBCocoaTouchFramework - + 292 {320, 460} + + 1 MCAwIDAAA @@ -46,7 +48,7 @@ IBCocoaTouchFramework - + 274 YES @@ -127,6 +129,7 @@ 292 {{211, 418}, {108, 62}} + NO IBCocoaTouchFramework 0 @@ -170,6 +173,7 @@ {320, 480} + 3 @@ -178,7 +182,7 @@ IBCocoaTouchFramework - + 292 YES @@ -227,7 +231,7 @@ 292 {{420, 107}, {60, 106}} - + NO IBCocoaTouchFramework 0 @@ -248,6 +252,7 @@ 292 {{420, 212}, {60, 108}} + NO IBCocoaTouchFramework 0 @@ -276,8 +281,19 @@ IBCocoaTouchFramework + + + 292 + {{8, 285}, {28, 28}} + + + _NS:567 + NO + IBCocoaTouchFramework + {480, 320} + 3 @@ -291,7 +307,7 @@ IBCocoaTouchFramework - + 292 YES @@ -300,7 +316,7 @@ 274 {{60, 0}, {420, 320}} - + 3 MQA @@ -376,6 +392,7 @@ 274 {{360, 233}, {106, 80}} + 3 MQA @@ -383,8 +400,19 @@ IBCocoaTouchFramework + + + 292 + {{68, 285}, {28, 28}} + + + _NS:567 + NO + IBCocoaTouchFramework + {480, 320} + 3 @@ -489,14 +517,6 @@ 43 - - - mDisplayLandRight - - - - 44 - mPreviewLandRight @@ -505,14 +525,6 @@ 45 - - - mDisplayLandLeft - - - - 46 - mMuteLandLeft @@ -561,6 +573,38 @@ 54 + + + mDisplayLandRight + + + + 44 + + + + mCallQualityLandRight + + + + 58 + + + + mDisplayLandLeft + + + + 46 + + + + mCallQualityLandLeft + + + + 60 + @@ -617,6 +661,9 @@ 9 + + YES + preview @@ -641,11 +688,12 @@ YES - + + landscape-right @@ -668,15 +716,6 @@ Mute - - 15 - - - YES - - - display - 16 @@ -692,6 +731,7 @@ + @@ -700,6 +740,9 @@ 35 + + YES + preview @@ -721,17 +764,33 @@ Mute + + 52 + + + + + 56 + + + + + 15 + + + display + + + 59 + + + 39 display - - 52 - - - @@ -764,6 +823,8 @@ 39.IBPluginDependency 5.IBPluginDependency 52.IBPluginDependency + 56.IBPluginDependency + 59.IBPluginDependency 6.CustomClassName 6.IBPluginDependency 7.CustomClassName @@ -800,6 +861,8 @@ com.apple.InterfaceBuilder.IBCocoaTouchPlugin com.apple.InterfaceBuilder.IBCocoaTouchPlugin com.apple.InterfaceBuilder.IBCocoaTouchPlugin + com.apple.InterfaceBuilder.IBCocoaTouchPlugin + com.apple.InterfaceBuilder.IBCocoaTouchPlugin UIMuteButton com.apple.InterfaceBuilder.IBCocoaTouchPlugin UIHangUpButton @@ -821,7 +884,7 @@ - 54 + 60 0