From cbaf1020150894c8f167584e21555f033258cd30 Mon Sep 17 00:00:00 2001 From: thatmattlove Date: Sat, 17 Feb 2024 15:59:22 -0500 Subject: [PATCH] fix issue where if greeting is disabled, the page reloads --- hyperglass/ui/components/greeting.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hyperglass/ui/components/greeting.tsx b/hyperglass/ui/components/greeting.tsx index ca9c004..7ee576a 100644 --- a/hyperglass/ui/components/greeting.tsx +++ b/hyperglass/ui/components/greeting.tsx @@ -24,10 +24,13 @@ export const Greeting = (props: ModalContentProps): JSX.Element => { const color = useOpposingColor(bg); useEffect(() => { + if (!web.greeting.enable && !web.greeting.required) { + ack(true, false); + } if (!isAck && web.greeting.enable) { open(); } - }, [isAck, open, web.greeting.enable]); + }, [isAck, open, web.greeting.enable, web.greeting.required, ack]); return (