diff --git a/Classes/Base.lproj/CallView.xib b/Classes/Base.lproj/CallView.xib
index dec08d1d5..cca6a6d11 100644
--- a/Classes/Base.lproj/CallView.xib
+++ b/Classes/Base.lproj/CallView.xib
@@ -77,7 +77,7 @@
-
+
-
+
@@ -101,25 +101,25 @@
-
+
-
+
@@ -127,16 +127,16 @@
-
+
-
+
-
+
@@ -144,12 +144,12 @@
-
+
-
+
-
-
+
+
-
+
-
+
@@ -231,7 +231,7 @@
-
+
-
+
@@ -420,7 +420,7 @@
-
+
@@ -475,11 +475,11 @@
-
+
-
+
@@ -487,7 +487,7 @@
-
-
+
+
-
+
@@ -579,8 +579,8 @@
-
-
+
+
@@ -588,7 +588,7 @@
-
+
diff --git a/Classes/Base.lproj/SettingsView.xib b/Classes/Base.lproj/SettingsView.xib
index a44424f28..c5e91a649 100644
--- a/Classes/Base.lproj/SettingsView.xib
+++ b/Classes/Base.lproj/SettingsView.xib
@@ -1,6 +1,7 @@
-
+
+
@@ -19,7 +20,7 @@
-
+
diff --git a/Classes/LinphoneCoreSettingsStore.m b/Classes/LinphoneCoreSettingsStore.m
index e3098f418..4f893ad0a 100644
--- a/Classes/LinphoneCoreSettingsStore.m
+++ b/Classes/LinphoneCoreSettingsStore.m
@@ -426,7 +426,6 @@ extern void linphone_iphone_log_handler(int lev, const char *fmt, va_list args);
NSString *prefix = [self stringForKey:@"prefix_preference"];
NSString *proxyAddress = [self stringForKey:@"proxy_preference"];
- LinphoneAuthInfo *info = NULL;
const char *route = NULL;
if (isWifiOnly && [LinphoneManager instance].connectivity == wwan)
@@ -519,21 +518,15 @@ extern void linphone_iphone_log_handler(int lev, const char *fmt, va_list args);
LinphoneAddress *from = linphone_address_new(identity);
if (from) {
const char *userid_str = (userID != nil) ? [userID UTF8String] : NULL;
- info = linphone_auth_info_new(
+ LinphoneAuthInfo *info = linphone_auth_info_new(
linphone_address_get_username(from), userid_str, password ? password : NULL, password ? NULL : ha1,
linphone_proxy_config_get_realm(proxyCfg), linphone_proxy_config_get_domain(proxyCfg));
linphone_address_destroy(from);
+ linphone_core_add_auth_info(lc, info);
+ linphone_auth_info_destroy(info);
}
}
- // We reached here without hitting the goto: the new settings are correct, so replace the previous ones.
-
- // add auth info
- linphone_core_clear_all_auth_info(lc);
- if (info) {
- linphone_core_add_auth_info(lc, info);
- }
-
// setup new proxycfg
if (isEditing) {
linphone_proxy_config_done(proxyCfg);
@@ -548,8 +541,6 @@ extern void linphone_iphone_log_handler(int lev, const char *fmt, va_list args);
linphone_address_destroy(linphoneAddress);
if (proxy)
ms_free(proxy);
- if (info)
- linphone_auth_info_destroy(info);
// in case of error, show an alert to the user
if (error != nil) {
diff --git a/Classes/PhoneMainView.m b/Classes/PhoneMainView.m
index 4376c81ff..376a956bc 100644
--- a/Classes/PhoneMainView.m
+++ b/Classes/PhoneMainView.m
@@ -330,7 +330,7 @@ static RootViewManager *rootViewManagerInstance = nil;
case LinphoneCallPausedByRemote:
case LinphoneCallConnected:
case LinphoneCallStreamsRunning: {
- [self changeCurrentView:CallView.compositeViewDescription];
+ [self changeCurrentView:CallView.compositeViewDescription push:NO];
break;
}
case LinphoneCallUpdatedByRemote: {
@@ -543,7 +543,7 @@ static RootViewManager *rootViewManagerInstance = nil;
}
- (void)changeCurrentView:(UICompositeViewDescription *)view {
- [self changeCurrentView:view push:FALSE];
+ [self changeCurrentView:view push:TRUE];
}
- (void)changeCurrentView:(UICompositeViewDescription *)view push:(BOOL)push {
@@ -553,14 +553,11 @@ static RootViewManager *rootViewManagerInstance = nil;
}
- (void)changeCurrentView:(UICompositeViewDescription *)view push:(BOOL)push animated:(BOOL)animated {
- BOOL force = push;
NSMutableArray *viewStack = [RootViewManager instance].viewDescriptionStack;
- if (!push) {
- force = [viewStack count] > 1;
- [viewStack removeAllObjects];
+ if (push) {
+ [viewStack addObject:view];
}
- [viewStack addObject:view];
- [self _changeCurrentView:view transition:nil force:force animated:animated];
+ [self _changeCurrentView:view transition:nil force:push animated:animated];
}
- (UIViewController *)_changeCurrentView:(UICompositeViewDescription *)view
@@ -608,9 +605,9 @@ static RootViewManager *rootViewManagerInstance = nil;
}
- (UIViewController *)popCurrentView {
- LOGI(@"PhoneMainView: Pop view");
NSMutableArray *viewStack = [RootViewManager instance].viewDescriptionStack;
if ([viewStack count] > 1) {
+ LOGI(@"PhoneMainView: Pop view");
[viewStack removeLastObject];
[self _changeCurrentView:[viewStack lastObject]
transition:[PhoneMainView getBackwardTransition]
@@ -618,6 +615,7 @@ static RootViewManager *rootViewManagerInstance = nil;
animated:[[LinphoneManager instance] lpConfigBoolForKey:@"animations_preference"]];
return [mainViewController getCurrentViewController];
}
+ LOGW(@"PhoneMainView: Trying to pop view but none stacked!");
return nil;
}
diff --git a/Classes/SideMenuView.xib b/Classes/SideMenuView.xib
index 9fe911a1f..20169cff9 100644
--- a/Classes/SideMenuView.xib
+++ b/Classes/SideMenuView.xib
@@ -31,7 +31,7 @@
-
+
@@ -66,7 +66,7 @@
-
+