From f9a70fbd2f9fd996d0651e7dccfc1a3984a8f6c9 Mon Sep 17 00:00:00 2001 From: Gautier Pelloux-Prayer Date: Mon, 26 Oct 2015 17:30:24 +0100 Subject: [PATCH] UI: fix constraints for iPhone6+ and some crashes --- Classes/AssistantView.m | 17 +++++++++++---- Classes/Base.lproj/AssistantView.xib | 8 +++---- Classes/Base.lproj/ChatConversationView.xib | 10 ++++----- Classes/Base.lproj/ChatsListView.xib | 4 ++-- Classes/Base.lproj/ContactsListView.xib | 2 +- Classes/Base.lproj/HistoryListView.xib | 22 ++++++++++---------- Classes/LinphoneUI/Base.lproj/UIChatCell.xib | 10 ++++----- Classes/PhoneMainView.m | 3 +-- submodules/linphone | 2 +- 9 files changed, 43 insertions(+), 35 deletions(-) diff --git a/Classes/AssistantView.m b/Classes/AssistantView.m index 77978fc1a..94b98053e 100644 --- a/Classes/AssistantView.m +++ b/Classes/AssistantView.m @@ -418,6 +418,15 @@ static UICompositeViewDescription *compositeDescription = nil; return s != LinphoneAccountCreatorOk; }]; + UIAssistantTextField *domain = [self findTextField:ViewElement_Domain]; + [domain showError:[self errorForStatus:LinphoneAccountCreatorDomainInvalid] + when:^BOOL(NSString *inputEntry) { + LinphoneAccountCreatorStatus s = + linphone_account_creator_set_domain(account_creator, inputEntry.UTF8String); + domain.errorLabel.text = [self errorForStatus:s]; + return s != LinphoneAccountCreatorOk; + }]; + [self shouldEnableNextButton]; } @@ -545,7 +554,7 @@ void assistant_validation_tested(LinphoneAccountCreator *creator, LinphoneAccoun NSLocalizedString( @"Your account could not be checked yet. You can skip this validation or try again later.", nil)]; - [alert addCancelButtonWithTitle:NSLocalizedString(@"Cancel", nil) block:nil]; + [alert addCancelButtonWithTitle:NSLocalizedString(@"Back", nil) block:nil]; [alert addButtonWithTitle:NSLocalizedString(@"Skip verification", nil) block:^{ [thiz addProxyConfig:linphone_account_creator_configure(creator)]; @@ -605,13 +614,13 @@ void assistant_validation_tested(LinphoneAccountCreator *creator, LinphoneAccoun } - (IBAction)onCreateAccountClick:(id)sender { - linphone_account_creator_test_existence(account_creator); _waitView.hidden = NO; + linphone_account_creator_test_existence(account_creator); } - (IBAction)onCreateAccountActivationClick:(id)sender { - linphone_account_creator_create_account(account_creator); _waitView.hidden = NO; + linphone_account_creator_create_account(account_creator); } - (IBAction)onLinphoneLoginClick:(id)sender { @@ -621,7 +630,7 @@ void assistant_validation_tested(LinphoneAccountCreator *creator, LinphoneAccoun - (IBAction)onLoginClick:(id)sender { _waitView.hidden = NO; - linphone_account_creator_test_validation(account_creator); + [self addProxyConfig:linphone_account_creator_configure(account_creator)]; } - (IBAction)onRemoteProvisionningLoginClick:(id)sender { diff --git a/Classes/Base.lproj/AssistantView.xib b/Classes/Base.lproj/AssistantView.xib index 28fa2c850..8e4520658 100644 --- a/Classes/Base.lproj/AssistantView.xib +++ b/Classes/Base.lproj/AssistantView.xib @@ -1,5 +1,5 @@ - + @@ -70,7 +70,7 @@ - + - + - + @@ -183,7 +183,7 @@ - + @@ -130,7 +130,7 @@