mirrors/linphone-desktop
1
0
Fork 0
mirror of https://gitlab.linphone.org/BC/public/linphone-desktop.git synced 2026-01-18 03:48:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(Cli): better test when passing uri as cli, and an argument is missing

Browse source
This commit is contained in:
nicolas 2017-08-09 17:41:00 +02:00
parent bd0c9bdd43
commit 42e00a1817
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/app/cli/Cli.cpp
View file

@ -123,7 +123,7 @@ void Cli::Command::execute (QHash<QString, QString> &args) const {
// Check missing arguments.
for (const auto &argName : mArgsScheme.keys()) {
if (!args.contains(argName) && !mArgsScheme[argName].isOptional) {
if (!mArgsScheme[argName].isOptional && (!args.contains(argName) || args[argName].isEmpty())) {
qWarning() << QStringLiteral("Missing argument for command: `%1 (%2)`.")
.arg(mFunctionName).arg(argName);
return;
@ -220,6 +220,7 @@ void Cli::executeCommand (const QString &command, CommandFormat *format) const {
return;
}
//TODO: check if there is any header when the `method` header is missing.
const QString functionName = ::Utils::coreStringToAppString(address->getHeader("method")).isEmpty()
? QStringLiteral("call")
: ::Utils::coreStringToAppString(address->getHeader("method"));