mirrors/linphone-iphone
1
0
Fork 1
mirror of https://gitlab.linphone.org/BC/public/linphone-iphone.git synced 2026-02-07 14:18:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(ChatModifier): use const std::shared_ptr<ChatMessage> &message instead of std::shared_ptr<ChatMessage> message

Browse source
This commit is contained in:
Ronan Abhamon 2017-10-11 15:06:32 +02:00
parent ff688cd975
commit 013be9e292
7 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/chat/modifier/chat-message-modifier.h
View file

@ -46,13 +46,13 @@ public:
* It should check first if the internalContent is filled.
* If so, it should apply it's changes to it, otherwise it should use the contentsList.
*/
virtual Result encode (std::shared_ptr<ChatMessage> message, int *errorCode) = 0;
virtual Result encode (const std::shared_ptr<ChatMessage> &message, int *errorCode) = 0;
/**
* This method will be called when the message is about to be received.
* It should apply it's changes to the internal content, the last modifier will take care of filling the contentsList.
*/
virtual Result decode (std::shared_ptr<ChatMessage> message, int *errorCode) = 0;
virtual Result decode (const std::shared_ptr<ChatMessage> &message, int *errorCode) = 0;
};
LINPHONE_END_NAMESPACE

4
src/chat/modifier/cpim-chat-message-modifier.cpp
View file

@ -32,7 +32,7 @@ using namespace std;
LINPHONE_BEGIN_NAMESPACE
ChatMessageModifier::Result CpimChatMessageModifier::encode (shared_ptr<ChatMessage> message, int *errorCode) {
ChatMessageModifier::Result CpimChatMessageModifier::encode (const shared_ptr<ChatMessage> &message, int *errorCode) {
Cpim::Message cpimMessage;
Cpim::GenericHeader cpimContentTypeHeader;
cpimContentTypeHeader.setName("Content-Type");
@ -75,7 +75,7 @@ ChatMessageModifier::Result CpimChatMessageModifier::encode (shared_ptr<ChatMess
return ChatMessageModifier::Result::Done;
}
ChatMessageModifier::Result CpimChatMessageModifier::decode (shared_ptr<ChatMessage> message, int *errorCode) {
ChatMessageModifier::Result CpimChatMessageModifier::decode (const shared_ptr<ChatMessage> &message, int *errorCode) {
Content content;
if (!message->getInternalContent().isEmpty()) {
content = message->getInternalContent();

4
src/chat/modifier/cpim-chat-message-modifier.h
View file

@ -30,8 +30,8 @@ class CpimChatMessageModifier : public ChatMessageModifier {
public:
CpimChatMessageModifier () = default;
Result encode (std::shared_ptr<ChatMessage> message, int *errorCode) override;
Result decode (std::shared_ptr<ChatMessage> message, int *errorCode) override;
Result encode (const std::shared_ptr<ChatMessage> &message, int *errorCode) override;
Result decode (const std::shared_ptr<ChatMessage> &message, int *errorCode) override;
};
LINPHONE_END_NAMESPACE

4
src/chat/modifier/encryption-chat-message-modifier.cpp
View file

@ -34,7 +34,7 @@ using namespace std;
LINPHONE_BEGIN_NAMESPACE
ChatMessageModifier::Result EncryptionChatMessageModifier::encode (shared_ptr<ChatMessage> message, int *errorCode) {
ChatMessageModifier::Result EncryptionChatMessageModifier::encode (const shared_ptr<ChatMessage> &message, int *errorCode) {
int retval = -1;
shared_ptr<ChatRoom> chatRoom = message->getChatRoom();
LinphoneImEncryptionEngine *imee = chatRoom->getCore()->im_encryption_engine;
@ -59,7 +59,7 @@ ChatMessageModifier::Result EncryptionChatMessageModifier::encode (shared_ptr<Ch
return ChatMessageModifier::Result::Skipped;
}
ChatMessageModifier::Result EncryptionChatMessageModifier::decode (shared_ptr<ChatMessage> message, int *errorCode) {
ChatMessageModifier::Result EncryptionChatMessageModifier::decode (const shared_ptr<ChatMessage> &message, int *errorCode) {
int retval = -1;
shared_ptr<ChatRoom> chatRoom = message->getChatRoom();
LinphoneImEncryptionEngine *imee = chatRoom->getCore()->im_encryption_engine;

4
src/chat/modifier/encryption-chat-message-modifier.h
View file

@ -30,8 +30,8 @@ class EncryptionChatMessageModifier : public ChatMessageModifier {
public:
EncryptionChatMessageModifier () = default;
Result encode (std::shared_ptr<ChatMessage> message, int *errorCode) override;
Result decode (std::shared_ptr<ChatMessage> message, int *errorCode) override;
Result encode (const std::shared_ptr<ChatMessage> &message, int *errorCode) override;
Result decode (const std::shared_ptr<ChatMessage> &message, int *errorCode) override;
};
LINPHONE_END_NAMESPACE

4
src/chat/modifier/multipart-chat-message-modifier.cpp
View file

@ -30,7 +30,7 @@ using namespace std;
LINPHONE_BEGIN_NAMESPACE
ChatMessageModifier::Result MultipartChatMessageModifier::encode (shared_ptr<ChatMessage> message, int *errorCode) {
ChatMessageModifier::Result MultipartChatMessageModifier::encode (const shared_ptr<ChatMessage> &message, int *errorCode) {
if (message->getContents().size() > 1) {
LinphoneCore *lc = message->getChatRoom()->getCore();
char tmp[64];
@ -59,7 +59,7 @@ ChatMessageModifier::Result MultipartChatMessageModifier::encode (shared_ptr<Cha
return ChatMessageModifier::Result::Skipped;
}
ChatMessageModifier::Result MultipartChatMessageModifier::decode (shared_ptr<ChatMessage> message, int *errorCode) {
ChatMessageModifier::Result MultipartChatMessageModifier::decode (const shared_ptr<ChatMessage> &message, int *errorCode) {
if (message->getInternalContent().getContentType().getType() == "multipart") {
string boundary = message->getInternalContent().getContentType().getParameter();
if (boundary.empty()) {

4
src/chat/modifier/multipart-chat-message-modifier.h
View file

@ -30,8 +30,8 @@ class MultipartChatMessageModifier : public ChatMessageModifier {
public:
MultipartChatMessageModifier () = default;
Result encode (std::shared_ptr<ChatMessage> message, int *errorCode) override;
Result decode (std::shared_ptr<ChatMessage> message, int *errorCode) override;
Result encode (const std::shared_ptr<ChatMessage> &message, int *errorCode) override;
Result decode (const std::shared_ptr<ChatMessage> &message, int *errorCode) override;
};
LINPHONE_END_NAMESPACE